[Bug 26990] New: Playchess, pieces are not shown correctly
http://bugs.winehq.org/show_bug.cgi?id=26990 Summary: Playchess, pieces are not shown correctly Product: Wine Version: 1.3.19 Platform: x86 URL: http://www.fritzhelp.com/download/PlayChessV5Setup.exe OS/Version: Linux Status: UNCONFIRMED Severity: normal Priority: P2 Component: gdiplus AssignedTo: wine-bugs(a)winehq.org ReportedBy: ocean04(a)suomi24.fi Install.. Click "Enter As Guest". Click games tab and wait some time (Tab is changed, but nothing is drawn: bug 26989) Press enter-key (should open some games) Look like this: http://netikka.net/dev/pieces.jpg Terminal has lot of: fixme:gdiplus:GdipCreateBitmapFromHBITMAP don't know how to handle 16 bpp PS. winetricks gdiplus help -- Configure bugmail: http://bugs.winehq.org/userprefs.cgi?tab=email Do not reply to this email, post in Bugzilla using the above URL to reply. ------- You are receiving this mail because: ------- You are watching all bug changes.
http://bugs.winehq.org/show_bug.cgi?id=26990 Austin English <austinenglish(a)gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Keywords| |download -- Configure bugmail: http://bugs.winehq.org/userprefs.cgi?tab=email Do not reply to this email, post in Bugzilla using the above URL to reply. ------- You are receiving this mail because: ------- You are watching all bug changes.
http://bugs.winehq.org/show_bug.cgi?id=26990 --- Comment #1 from Vincent Povirk <madewokherd(a)gmail.com> 2011-05-11 10:48:00 CDT --- Created an attachment (id=34635) --> (http://bugs.winehq.org/attachment.cgi?id=34635) incorrect patch The pieces seem to scale correctly here, and I never see that message. But you can try this incorrect patch and see if it changes anything. -- Configure bugmail: http://bugs.winehq.org/userprefs.cgi?tab=email Do not reply to this email, post in Bugzilla using the above URL to reply. ------- You are receiving this mail because: ------- You are watching all bug changes.
http://bugs.winehq.org/show_bug.cgi?id=26990 Vincent Povirk <madewokherd(a)gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |madewokherd(a)gmail.com -- Configure bugmail: http://bugs.winehq.org/userprefs.cgi?tab=email Do not reply to this email, post in Bugzilla using the above URL to reply. ------- You are receiving this mail because: ------- You are watching all bug changes.
http://bugs.winehq.org/show_bug.cgi?id=26990 --- Comment #2 from ocean04(a)suomi24.fi 2011-05-11 13:02:30 CDT --- Created an attachment (id=34649) --> (http://bugs.winehq.org/attachment.cgi?id=34649) Board/pieces Pieces look okay after your patch. But board colors are wrong, and also some red dots, see attachment -- Configure bugmail: http://bugs.winehq.org/userprefs.cgi?tab=email Do not reply to this email, post in Bugzilla using the above URL to reply. ------- You are receiving this mail because: ------- You are watching all bug changes.
http://bugs.winehq.org/show_bug.cgi?id=26990 --- Comment #3 from Vincent Povirk <madewokherd(a)gmail.com> 2011-05-11 13:28:30 CDT --- Yeah, I was expecting the colors might be wrong. We need to determine whether the format of the bitmap is 555 or 565, and it wasn't obvious to me how to do it. This should still be straightforward to fix. -- Configure bugmail: http://bugs.winehq.org/userprefs.cgi?tab=email Do not reply to this email, post in Bugzilla using the above URL to reply. ------- You are receiving this mail because: ------- You are watching all bug changes.
http://bugs.winehq.org/show_bug.cgi?id=26990 --- Comment #4 from ocean04(a)suomi24.fi 2011-05-13 12:35:01 CDT --- Yes, if I change 555 to 565 then it's fine. -- Configure bugmail: http://bugs.winehq.org/userprefs.cgi?tab=email Do not reply to this email, post in Bugzilla using the above URL to reply. ------- You are receiving this mail because: ------- You are watching all bug changes.
http://bugs.winehq.org/show_bug.cgi?id=26990 Vincent Povirk <madewokherd(a)gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #34635|0 |1 is obsolete| | --- Comment #5 from Vincent Povirk <madewokherd(a)gmail.com> 2011-05-14 16:31:59 CDT --- Created an attachment (id=34708) --> (http://bugs.winehq.org/attachment.cgi?id=34708) patch using GetDIBits to detect bitmap format Try this one please. -- Configure bugmail: http://bugs.winehq.org/userprefs.cgi?tab=email Do not reply to this email, post in Bugzilla using the above URL to reply. ------- You are receiving this mail because: ------- You are watching all bug changes.
http://bugs.winehq.org/show_bug.cgi?id=26990 --- Comment #6 from ocean04(a)suomi24.fi 2011-05-15 07:30:03 CDT --- No, terminal was filled with: fixme:gdiplus:GdipCreateBitmapFromHBITMAP unknown bitfields format 16bpp 0/0/0/0 -- Configure bugmail: http://bugs.winehq.org/userprefs.cgi?tab=email Do not reply to this email, post in Bugzilla using the above URL to reply. ------- You are receiving this mail because: ------- You are watching all bug changes.
http://bugs.winehq.org/show_bug.cgi?id=26990 --- Comment #7 from ocean04(a)suomi24.fi 2012-01-13 11:24:56 CST --- I thought this might work now, but no. Message is different fixme:gdiplus:GdipCreateBitmapFromHBITMAP unimplemented for 16-bit ddb wine-1.3.36-361-g5eecdc8 -- Configure bugmail: http://bugs.winehq.org/userprefs.cgi?tab=email Do not reply to this email, post in Bugzilla using the above URL to reply. ------- You are receiving this mail because: ------- You are watching all bug changes.
http://bugs.winehq.org/show_bug.cgi?id=26990 --- Comment #8 from Vincent Povirk <madewokherd(a)gmail.com> 2012-03-01 15:21:13 CST --- Well, that's odd. I tested this on Windows, and it turns out that function doesn't actually work with ddb's. It returns Win32Error. -- Configure bugmail: http://bugs.winehq.org/userprefs.cgi?tab=email Do not reply to this email, post in Bugzilla using the above URL to reply. ------- You are receiving this mail because: ------- You are watching all bug changes.
http://bugs.winehq.org/show_bug.cgi?id=26990 --- Comment #9 from Vincent Povirk <madewokherd(a)gmail.com> 2012-03-01 15:53:19 CST --- Ah, it looks like the problem is I'm not using a 16-bit display. -- Configure bugmail: http://bugs.winehq.org/userprefs.cgi?tab=email Do not reply to this email, post in Bugzilla using the above URL to reply. ------- You are receiving this mail because: ------- You are watching all bug changes.
http://bugs.winehq.org/show_bug.cgi?id=26990 Vincent Povirk <madewokherd(a)gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #34708|0 |1 is obsolete| | --- Comment #10 from Vincent Povirk <madewokherd(a)gmail.com> 2012-03-01 15:57:45 CST --- Created attachment 39155 --> http://bugs.winehq.org/attachment.cgi?id=39155 patch for 16-bit ddbs Well, since I have no way to test this, here's a patch to try. -- Configure bugmail: http://bugs.winehq.org/userprefs.cgi?tab=email Do not reply to this email, post in Bugzilla using the above URL to reply. ------- You are receiving this mail because: ------- You are watching all bug changes.
http://bugs.winehq.org/show_bug.cgi?id=26990 --- Comment #11 from Dmitry Timoshkov <dmitry(a)baikal.ru> 2012-03-01 23:50:31 CST --- You should be able to detect 15/16 bpp with GetDIBits, if it returns biBitCount 16, biCompression BI_RGB indicates 555 mode, BI_BITFIELDS - 565. -- Configure bugmail: http://bugs.winehq.org/userprefs.cgi?tab=email Do not reply to this email, post in Bugzilla using the above URL to reply. ------- You are receiving this mail because: ------- You are watching all bug changes.
http://bugs.winehq.org/show_bug.cgi?id=26990 --- Comment #12 from Vincent Povirk <madewokherd(a)gmail.com> 2012-03-01 23:57:57 CST --- So, 16-bit with BI_BITFIELDS compression and no information in bmiColors indicates 565? Is this documented anywhere? -- Configure bugmail: http://bugs.winehq.org/userprefs.cgi?tab=email Do not reply to this email, post in Bugzilla using the above URL to reply. ------- You are receiving this mail because: ------- You are watching all bug changes.
http://bugs.winehq.org/show_bug.cgi?id=26990 --- Comment #13 from Dmitry Timoshkov <dmitry(a)baikal.ru> 2012-03-02 00:17:48 CST --- (In reply to comment #12)
So, 16-bit with BI_BITFIELDS compression and no information in bmiColors indicates 565? Is this documented anywhere?
Hmm, I may be mistaken here, see http://source.winehq.org/source/dlls/gdi32/tests/bitmap.c#L2163 -- Configure bugmail: http://bugs.winehq.org/userprefs.cgi?tab=email Do not reply to this email, post in Bugzilla using the above URL to reply. ------- You are receiving this mail because: ------- You are watching all bug changes.
http://bugs.winehq.org/show_bug.cgi?id=26990 --- Comment #14 from Alexandre Julliard <julliard(a)winehq.org> 2012-03-02 03:13:55 CST --- 16-bpp always returns bitfields. You have to call GetDIBits with the correct depth to retrieve them. But of course there's no guarantee that the fields are either 555 or 565, other values are possible. -- Configure bugmail: http://bugs.winehq.org/userprefs.cgi?tab=email Do not reply to this email, post in Bugzilla using the above URL to reply. ------- You are receiving this mail because: ------- You are watching all bug changes.
http://bugs.winehq.org/show_bug.cgi?id=26990 --- Comment #15 from ocean04(a)suomi24.fi 2012-03-03 12:14:46 CST --- Patch works -- Configure bugmail: http://bugs.winehq.org/userprefs.cgi?tab=email Do not reply to this email, post in Bugzilla using the above URL to reply. ------- You are receiving this mail because: ------- You are watching all bug changes.
http://bugs.winehq.org/show_bug.cgi?id=26990 Jerome Leclanche <adys.wh(a)gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Keywords| |patch Status|UNCONFIRMED |NEW CC| |adys.wh(a)gmail.com Ever Confirmed|0 |1 --- Comment #16 from Jerome Leclanche <adys.wh(a)gmail.com> 2012-03-29 13:28:40 CDT --- Patch was not committed yet. Was it sent? -- Configure bugmail: http://bugs.winehq.org/userprefs.cgi?tab=email Do not reply to this email, post in Bugzilla using the above URL to reply. ------- You are receiving this mail because: ------- You are watching all bug changes.
http://bugs.winehq.org/show_bug.cgi?id=26990 --- Comment #17 from Vincent Povirk <madewokherd(a)gmail.com> 2012-03-29 13:31:33 CDT --- No, I was going to try again with GetDIBits per Alexandre's advice. If it works, it will be less stupid than the approach I used. -- Configure bugmail: http://bugs.winehq.org/userprefs.cgi?tab=email Do not reply to this email, post in Bugzilla using the above URL to reply. ------- You are receiving this mail because: ------- You are watching all bug changes.
http://bugs.winehq.org/show_bug.cgi?id=26990 --- Comment #18 from Vincent Povirk <madewokherd(a)gmail.com> 2012-03-31 10:39:39 CDT --- Patch committed as 93a089766097338c88af511dd9bea5c512f2b575. Please retest. -- Configure bugmail: http://bugs.winehq.org/userprefs.cgi?tab=email Do not reply to this email, post in Bugzilla using the above URL to reply. ------- You are receiving this mail because: ------- You are watching all bug changes.
http://bugs.winehq.org/show_bug.cgi?id=26990 Jerome Leclanche <adys.wh(a)gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Fixed by SHA1| |93a089766097338c88af511dd9b | |ea5c512f2b575 Status|NEW |RESOLVED Resolution| |FIXED --- Comment #19 from Jerome Leclanche <adys.wh(a)gmail.com> 2012-04-01 12:13:23 CDT --- Assuming fixed. Please reopen if not. -- Configure bugmail: http://bugs.winehq.org/userprefs.cgi?tab=email Do not reply to this email, post in Bugzilla using the above URL to reply. ------- You are receiving this mail because: ------- You are watching all bug changes.
http://bugs.winehq.org/show_bug.cgi?id=26990 --- Comment #20 from Vincent Povirk <madewokherd(a)gmail.com> 2012-04-01 12:16:26 CDT --- Shouldn't we wait for confirmation before closing? The code that was committed hasn't actually been tested yet with ddb's. -- Configure bugmail: http://bugs.winehq.org/userprefs.cgi?tab=email Do not reply to this email, post in Bugzilla using the above URL to reply. ------- You are receiving this mail because: ------- You are watching all bug changes.
http://bugs.winehq.org/show_bug.cgi?id=26990 --- Comment #21 from Jerome Leclanche <adys.wh(a)gmail.com> 2012-04-01 12:39:04 CDT --- (In reply to comment #20) If there's no confirmation within a couple of days, I usually just assume fixed, otherwise the bugs tend to stay open for years. They can always be reopened otherwise. -- Configure bugmail: http://bugs.winehq.org/userprefs.cgi?tab=email Do not reply to this email, post in Bugzilla using the above URL to reply. ------- You are receiving this mail because: ------- You are watching all bug changes.
http://bugs.winehq.org/show_bug.cgi?id=26990 --- Comment #22 from Austin English <austinenglish(a)gmail.com> 2012-04-01 15:24:03 CDT --- (In reply to comment #21)
(In reply to comment #20) If there's no confirmation within a couple of days, I usually just assume fixed, otherwise the bugs tend to stay open for years. They can always be reopened otherwise.
There's a download, you could check yourself. -- Configure bugmail: http://bugs.winehq.org/userprefs.cgi?tab=email Do not reply to this email, post in Bugzilla using the above URL to reply. ------- You are receiving this mail because: ------- You are watching all bug changes.
http://bugs.winehq.org/show_bug.cgi?id=26990 --- Comment #23 from Jerome Leclanche <adys.wh(a)gmail.com> 2012-04-01 15:24:56 CDT --- (In reply to comment #22) Sorry, ubuntu completely broke compiling wine (multiarch). I'm in the process of moving over to Arch but it takes time. -- Configure bugmail: http://bugs.winehq.org/userprefs.cgi?tab=email Do not reply to this email, post in Bugzilla using the above URL to reply. ------- You are receiving this mail because: ------- You are watching all bug changes.
http://bugs.winehq.org/show_bug.cgi?id=26990 --- Comment #24 from Vincent Povirk <madewokherd(a)gmail.com> 2012-04-01 15:42:54 CDT --- The program only fails on the original reporter's setup (probably needs the X server to be 16 bit). -- Configure bugmail: http://bugs.winehq.org/userprefs.cgi?tab=email Do not reply to this email, post in Bugzilla using the above URL to reply. ------- You are receiving this mail because: ------- You are watching all bug changes.
http://bugs.winehq.org/show_bug.cgi?id=26990 --- Comment #25 from ocean04(a)suomi24.fi 2012-04-02 02:56:48 CDT --- Works now, wine-1.5.1 -- Configure bugmail: http://bugs.winehq.org/userprefs.cgi?tab=email Do not reply to this email, post in Bugzilla using the above URL to reply. ------- You are receiving this mail because: ------- You are watching all bug changes.
http://bugs.winehq.org/show_bug.cgi?id=26990 Alexandre Julliard <julliard(a)winehq.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|RESOLVED |CLOSED --- Comment #26 from Alexandre Julliard <julliard(a)winehq.org> 2012-04-13 13:29:02 CDT --- Closing bugs fixed in 1.5.2. -- Configure bugmail: http://bugs.winehq.org/userprefs.cgi?tab=email Do not reply to this email, post in Bugzilla using the above URL to reply. ------- You are receiving this mail because: ------- You are watching all bug changes.
http://bugs.winehq.org/show_bug.cgi?id=26990 Alexandre Julliard <julliard(a)winehq.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Target Milestone|--- |1.4.x -- Configure bugmail: http://bugs.winehq.org/userprefs.cgi?tab=email Do not reply to this email, post in Bugzilla using the above URL to reply. ------- You are receiving this mail because: ------- You are watching all bug changes.
http://bugs.winehq.org/show_bug.cgi?id=26990 Alexandre Julliard <julliard(a)winehq.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Target Milestone|1.4.x |--- -- Configure bugmail: http://bugs.winehq.org/userprefs.cgi?tab=email Do not reply to this email, post in Bugzilla using the above URL to reply. ------- You are receiving this mail because: ------- You are watching all bug changes.
participants (1)
-
wine-bugs＠winehq.org