[Bug 39614] New: Wine initialises a Critical Section for Mutexes by NULL instead of (void*)-1

https://bugs.winehq.org/show_bug.cgi?id=39614

            Bug ID: 39614
           Summary: Wine initialises a Critical Section for Mutexes by
                    NULL instead of (void*)-1
           Product: Wine
           Version: 1.7.55
          Hardware: x86
                OS: Linux
            Status: UNCONFIRMED
          Severity: normal
          Priority: P2
         Component: ntdll
          Assignee: wine-bugs(a)winehq.org
          Reporter: EoD(a)xmw.de
      Distribution: ---

After initialising a critical section for mutexes by using

static CRITICAL_SECTION Mutex = {(PCRITICAL_SECTION_DEBUG)-1, -1, 0, 0, 0, 0};

wine crashed in "RtlpWaitForCriticalSection()".

According to http://locklessinc.com/articles/pthreads_on_windows/ this is a
valid way of initialising the critical section. However, Wine seems to
initialize it by NULL instead of (void*)-1:
http://source.winehq.org/git/wine.git/blob/e8b9bda53ac39c913ddc93de0308f0c8b...


This is a re-reporting of an issue on github:
https://github.com/apitrace/apitrace/issues/397
with a backtrace in https://gist.github.com/EoD/cf759116a4af8744bdb7

-- 
Do not reply to this email, post in Bugzilla using the
above URL to reply.
You are receiving this mail because:
You are watching all bug changes.

[Bug 39614] Wine initialises a Critical Section for Mutexes by NULL instead of (void* )-1

https://bugs.winehq.org/show_bug.cgi?id=39614

Nikolay Sivov <bunglehead(a)gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|UNCONFIRMED                 |NEW
           Assignee|wine-bugs(a)winehq.org        |bunglehead(a)gmail.com
     Ever confirmed|0                           |1

--- Comment #1 from Nikolay Sivov <bunglehead(a)gmail.com> ---
Created attachment 64265
  --> https://bugs.winehq.org/attachment.cgi?id=64265
patch

Attaching here for now, will send next week.

-- 
Do not reply to this email, post in Bugzilla using the
above URL to reply.
You are receiving this mail because:
You are watching all bug changes.

[Bug 39614] Wine initialises a Critical Section for Mutexes by NULL instead of (void* )-1

https://bugs.winehq.org/show_bug.cgi?id=39614

pattietreutel <katyaberezyaka(a)gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |katyaberezyaka(a)gmail.com

-- 
Do not reply to this email, post in Bugzilla using the
above URL to reply.
You are receiving this mail because:
You are watching all bug changes.

[Bug 39614] Wine initialises a Critical Section for Mutexes by NULL instead of (void* )-1

https://bugs.winehq.org/show_bug.cgi?id=39614

Nikolay Sivov <bunglehead(a)gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
      Fixed by SHA1|                            |fe0f8a150fdaaf71052ab505972
                   |                            |07086cf5f4b4a
             Status|NEW                         |RESOLVED
         Resolution|---                         |FIXED

--- Comment #2 from Nikolay Sivov <bunglehead(a)gmail.com> ---
Marking fixed, fe0f8a150fdaaf71052ab50597207086cf5f4b4a.

-- 
Do not reply to this email, post in Bugzilla using the
above URL to reply.
You are receiving this mail because:
You are watching all bug changes.

[Bug 39614] Wine initialises a Critical Section for Mutexes by NULL instead of (void* )-1

https://bugs.winehq.org/show_bug.cgi?id=39614

Nikolay Sivov <bunglehead(a)gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
           Assignee|bunglehead(a)gmail.com        |wine-bugs(a)winehq.org

-- 
Do not reply to this email, post in Bugzilla using the
above URL to reply.
You are receiving this mail because:
You are watching all bug changes.

[Bug 39614] Wine initialises a Critical Section for Mutexes by NULL instead of (void* )-1

https://bugs.winehq.org/show_bug.cgi?id=39614

Alexandre Julliard <julliard(a)winehq.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|RESOLVED                    |CLOSED

--- Comment #3 from Alexandre Julliard <julliard(a)winehq.org> ---
Closing bugs fixed in 4.8.

-- 
Do not reply to this email, post in Bugzilla using the
above URL to reply.
You are receiving this mail because:
You are watching all bug changes.

[Bug 39614] Wine initialises a Critical Section for Mutexes by NULL instead of (void*)-1

[WineHQ Bugzilla]

https://bugs.winehq.org/show_bug.cgi?id=39614

Michael Stefaniuc <mstefani(a)winehq.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
   Target Milestone|---                         |4.0.x

-- 
Do not reply to this email, post in Bugzilla using the
above URL to reply.
You are receiving this mail because:
You are watching all bug changes.

[Bug 39614] Wine initialises a Critical Section for Mutexes by NULL instead of (void*)-1

[WineHQ Bugzilla]

https://bugs.winehq.org/show_bug.cgi?id=39614

Michael Stefaniuc <mstefani(a)winehq.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
   Target Milestone|4.0.x                       |---

--- Comment #4 from Michael Stefaniuc <mstefani(a)winehq.org> ---
Removing the 4.0.x milestone from bug fixes included in 4.0.3.

-- 
Do not reply to this email, post in Bugzilla using the
above URL to reply.
You are receiving this mail because:
You are watching all bug changes.