[Bug 48750] New: Few missing DirectSound3D Algorithms GUID Defs
https://bugs.winehq.org/show_bug.cgi?id=48750 Bug ID: 48750 Summary: Few missing DirectSound3D Algorithms GUID Defs Product: Wine Version: 5.4 Hardware: x86 OS: Linux Status: UNCONFIRMED Severity: normal Priority: P2 Component: directx-dsound Assignee: wine-bugs(a)winehq.org Reporter: byi5000(a)gmail.com Distribution: --- Created attachment 66653 --> https://bugs.winehq.org/attachment.cgi?id=66653 File with the missing GUIDs Grepping in https://source.winehq.org/git/wine.git/?a=search&h=HEAD&st=grep&s=DS3DALG_NO... shows missing GUIDs for "DS3DALG"s in dsound. They exist in the ReactOS Source Code tho: https://github.com/reactos/reactos/blob/893a3c9d030fd8b078cbd747eeefd3f6ce57... They seem also be missing in MinGW, so someone please forward this to Jacek Caban since he is a Wine and MinGW contributor. -- Do not reply to this email, post in Bugzilla using the above URL to reply. You are receiving this mail because: You are watching all bug changes.
https://bugs.winehq.org/show_bug.cgi?id=48750 --- Comment #1 from BieHDC <byi5000(a)gmail.com> --- Created attachment 66657 --> https://bugs.winehq.org/attachment.cgi?id=66657 Missing Struct in dplay Found a missing struct in dplay.h Also missing in MinGW. I might find more as i go on, should i collect them here or make a separate issue per module since the original report was about dsound while this is in dplay? -- Do not reply to this email, post in Bugzilla using the above URL to reply. You are receiving this mail because: You are watching all bug changes.
https://bugs.winehq.org/show_bug.cgi?id=48750 Vijay Kamuju <infyquest(a)gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |infyquest(a)gmail.com --- Comment #2 from Vijay Kamuju <infyquest(a)gmail.com> --- Is any application depending on this GUIDs? -- Do not reply to this email, post in Bugzilla using the above URL to reply. You are receiving this mail because: You are watching all bug changes.
https://bugs.winehq.org/show_bug.cgi?id=48750 --- Comment #3 from BieHDC <byi5000(a)gmail.com> --- (In reply to Vijay Kamuju from comment #2)
Is any application depending on this GUIDs?
The DirectX 7 sdk example programs do. I did (not yet) come across a real game depending on these. -- Do not reply to this email, post in Bugzilla using the above URL to reply. You are receiving this mail because: You are watching all bug changes.
https://bugs.winehq.org/show_bug.cgi?id=48750 Alistair Leslie-Hughes <leslie_alistair(a)hotmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Resolution|--- |FIXED Status|UNCONFIRMED |RESOLVED Fixed by SHA1| |90233748209bb9a5c0adfc41a10 | |0c83535a1b9b8 --- Comment #4 from Alistair Leslie-Hughes <leslie_alistair(a)hotmail.com> --- Fixed by https://source.winehq.org/git/wine.git/?a=commit;h=90233748209bb9a5c0adfc41a... -- Do not reply to this email, post in Bugzilla using the above URL to reply. You are receiving this mail because: You are watching all bug changes.
https://bugs.winehq.org/show_bug.cgi?id=48750 Alexandre Julliard <julliard(a)winehq.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|RESOLVED |CLOSED --- Comment #5 from Alexandre Julliard <julliard(a)winehq.org> --- Closing bugs fixed in 5.5. -- Do not reply to this email, post in Bugzilla using the above URL to reply. You are receiving this mail because: You are watching all bug changes.
https://bugs.winehq.org/show_bug.cgi?id=48750 Michael Stefaniuc <mstefani(a)winehq.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Target Milestone|--- |5.0.x -- Do not reply to this email, post in Bugzilla using the above URL to reply. You are receiving this mail because: You are watching all bug changes.
https://bugs.winehq.org/show_bug.cgi?id=48750 Ozkan Sezer <sezeroz(a)gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |sezeroz(a)gmail.com --- Comment #6 from Ozkan Sezer <sezeroz(a)gmail.com> --- Created attachment 67570 --> https://bugs.winehq.org/attachment.cgi?id=67570 DS3DALG_DEFAULT typo patch (In reply to Alistair Leslie-Hughes from comment #4)
Fixed by https://source.winehq.org/git/wine.git/?a=commit; h=90233748209bb9a5c0adfc41a100c83535a1b9b8
There is a typo in DS3DALG_DEFAULT definition. Trivial fix attached. -- Do not reply to this email, post in Bugzilla using the above URL to reply. You are receiving this mail because: You are watching all bug changes.
https://bugs.winehq.org/show_bug.cgi?id=48750 --- Comment #7 from Vijay Kamuju <infyquest(a)gmail.com> --- Please send the patch to wine-patches(a)winehq.org with your signoff. -- Do not reply to this email, post in Bugzilla using the above URL to reply. You are receiving this mail because: You are watching all bug changes.
https://bugs.winehq.org/show_bug.cgi?id=48750 --- Comment #8 from Ozkan Sezer <sezeroz(a)gmail.com> --- (In reply to Vijay Kamuju from comment #7)
Please send the patch to wine-patches(a)winehq.org with your signoff.
Not interested in subscribing to the list. The change is a trivial one-liner. Apply as you will, and I don't need being given credit. -- Do not reply to this email, post in Bugzilla using the above URL to reply. You are receiving this mail because: You are watching all bug changes.
https://bugs.winehq.org/show_bug.cgi?id=48750 Michael Stefaniuc <mstefani(a)winehq.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Target Milestone|5.0.x |--- --- Comment #9 from Michael Stefaniuc <mstefani(a)winehq.org> --- Removing the 5.0.x milestone from bug fixes included in 5.0.2. -- Do not reply to this email, post in Bugzilla using the above URL to reply. You are receiving this mail because: You are watching all bug changes.
participants (1)
-
WineHQ Bugzilla