[Bug 50381] New: AIMP (4.70 build 2236) window cannot be moved in Ubuntu MATE 20.04 and Linux Mint 20.0 Cinnamon/MATE
https://bugs.winehq.org/show_bug.cgi?id=50381 Bug ID: 50381 Summary: AIMP (4.70 build 2236) window cannot be moved in Ubuntu MATE 20.04 and Linux Mint 20.0 Cinnamon/MATE Product: Wine-staging Version: 6.0-rc3 Hardware: x86-64 OS: Linux Status: UNCONFIRMED Severity: normal Priority: P2 Component: -unknown Assignee: wine-bugs(a)winehq.org Reporter: 93.duke.xperia(a)gmail.com CC: leslie_alistair(a)hotmail.com, z.figura12(a)gmail.com Distribution: --- The AIMP (4.70 build 2236) window cannot be moved to Ubuntu MATE 20.04 and Linux Mint 20.0 Cinnamon / MATE. When you try to re-move by the window manager MATE, the window is moved but then returned to its previous position. Also, the window is in the mode - on top of all windows. Tested on Ubuntu 20.04 / Ubuntu MATE 20.04 / Linux Mint 20.0 Cinnamon/MATE/Xfce / KDE neon 5.20 distributions - this problem only occurs on Ubuntu MATE 20.04 and Linux Mint 20.0 Cinnamon / MATE on Xfce drag and drop works and other DEs too. AIMP v4.70 build 2236 --> https://www.aimp.ru/?do=download&os=windows -- Do not reply to this email, post in Bugzilla using the above URL to reply. You are receiving this mail because: You are watching all bug changes.
https://bugs.winehq.org/show_bug.cgi?id=50381 DUKE93 <93.duke.xperia(a)gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- URL| |https://www.aimp.ru/?do=dow | |nload&os=windows -- Do not reply to this email, post in Bugzilla using the above URL to reply. You are receiving this mail because: You are watching all bug changes.
https://bugs.winehq.org/show_bug.cgi?id=50381 --- Comment #1 from Zebediah Figura <z.figura12(a)gmail.com> --- Is this bug present in upstream (non-staging) wine? -- Do not reply to this email, post in Bugzilla using the above URL to reply. You are receiving this mail because: You are watching all bug changes.
https://bugs.winehq.org/show_bug.cgi?id=50381 --- Comment #2 from DUKE93 <93.duke.xperia(a)gmail.com> --- I have tested AIMP in Wine-devel (6.0-rc3) in Ubuntu MATE 20.04.1 and the error is present. The window also cannot be moved. I also tested Wine-stable (5.0.3) on the same distribution and there is no error. The window is being dragged. -- Do not reply to this email, post in Bugzilla using the above URL to reply. You are receiving this mail because: You are watching all bug changes.
https://bugs.winehq.org/show_bug.cgi?id=50381 Gijs Vermeulen <gijsvrm(a)gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Keywords| |download, regression Component|-unknown |-unknown Product|Wine-staging |Wine Distribution|--- |Ubuntu Summary|AIMP (4.70 build 2236) |AIMP (4.70 build 2236) |window cannot be moved in |window cannot be moved |Ubuntu MATE 20.04 and Linux | |Mint 20.0 Cinnamon/MATE | --- Comment #3 from Gijs Vermeulen <gijsvrm(a)gmail.com> --- Moving to the 'Wine' product, adding 'download' and 'regression' keywords. Could you do a regression test? See: <https://wiki.winehq.org/Regression_Testing> -- Do not reply to this email, post in Bugzilla using the above URL to reply. You are receiving this mail because: You are watching all bug changes.
https://bugs.winehq.org/show_bug.cgi?id=50381 --- Comment #4 from DUKE93 <93.duke.xperia(a)gmail.com> --- I have read the documentation for Regression Testing, but so far I have been able to figure out that the bug has appeared since version 5.16. As for the wine assembly from the source code, I have not done this yet, but I will try and I need some time to study the documentation. -- Do not reply to this email, post in Bugzilla using the above URL to reply. You are receiving this mail because: You are watching all bug changes.
https://bugs.winehq.org/show_bug.cgi?id=50381 Zebediah Figura <z.figura12(a)gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |zzhang(a)codeweavers.com Ever confirmed|0 |1 Status|UNCONFIRMED |NEW Component|-unknown |winex11.drv Regression SHA1| |c5ec1585f6e5211a2b63e343574 | |8210552250534 --- Comment #5 from Zebediah Figura <z.figura12(a)gmail.com> --- I can confirm this bug with Marco/MATE. A regression test yields: zeb(a)terabithia:/bridge/git/wine$ git bisect good c5ec1585f6e5211a2b63e3435748210552250534 is the first bad commit commit c5ec1585f6e5211a2b63e3435748210552250534 Author: Zhiyi Zhang <zzhang(a)codeweavers.com> Date: Tue Aug 25 15:20:39 2020 +0800 winex11.drv: Always update _NET_WM_STATE in update_net_wm_states(). KWin treats a window covering exactly the whole monitor as maximized when handling its first map request and expects applications to update maximized state later. Wine doesn't know about this added maximized state and expect it unchanged, making the window always maximized as far as KWin is concerned. So always send _NET_WM_STATE updates even if Wine doesn't expect changes to hint KWin that a window should not be maximized. Fix test failures when running the tests introduced by 36b720357bcaf0a1e625f488e0c981ce10e8affa with KWin. Signed-off-by: Zhiyi Zhang <zzhang(a)codeweavers.com> Signed-off-by: Alexandre Julliard <julliard(a)winehq.org> Zhiyi, would you mind taking a look at this? -- Do not reply to this email, post in Bugzilla using the above URL to reply. You are receiving this mail because: You are watching all bug changes.
https://bugs.winehq.org/show_bug.cgi?id=50381 Panard <panard(a)inzenet.org> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |panard(a)inzenet.org --- Comment #6 from Panard <panard(a)inzenet.org> --- This looks like a duplicate of https://bugs.winehq.org/show_bug.cgi?id=49779 I just tried with staging 6.0-rc6, the bug still occurs (window jumps to original position, or steal focus when maximized). Not sure if this is a bug in Cinnamon or in Wine. -- Do not reply to this email, post in Bugzilla using the above URL to reply. You are receiving this mail because: You are watching all bug changes.
https://bugs.winehq.org/show_bug.cgi?id=50381 Anastasius Focht <focht(a)gmx.net> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |focht(a)gmx.net URL|https://www.aimp.ru/?do=dow |https://web.archive.org/web |nload&os=windows |/20210206111555/https://www | |.videohelp.com/download-XBL | |cLvpm/aimp_4.70.2236.exe --- Comment #7 from Anastasius Focht <focht(a)gmx.net> --- Hello folks, adding stable download link via Internet Archive: https://web.archive.org/web/20210206111555/https://www.videohelp.com/downloa... https://web.archive.org/web/20210206111640/https://www.videohelp.com/downloa... https://www.videohelp.com/software/AIMP/old-versions $ sha1sum aimp_4.70.2236* 894059df301bcd6e9e74124dcf4b4e8f4599bf82 aimp_4.70.2236.exe fb72b4c0a034b397ff86ccee8c3c845791cacc06 aimp_4.70.2236_no-installer.zip $ du -sh aimp_4.70.2236* 12M aimp_4.70.2236.exe 15M aimp_4.70.2236_no-installer.zip Regards -- Do not reply to this email, post in Bugzilla using the above URL to reply. You are receiving this mail because: You are watching all bug changes.
https://bugs.winehq.org/show_bug.cgi?id=50381 Gabriel Ivăncescu <gabrielopcode(a)gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |gabrielopcode(a)gmail.com --- Comment #8 from Gabriel Ivăncescu <gabrielopcode(a)gmail.com> --- Users reported that Winamp is also affected by this bug on those WMs. http://web.archive.org/web/20180902190237/http://winamparchive.org/dl/winamp... -- Do not reply to this email, post in Bugzilla using the above URL to reply. You are receiving this mail because: You are watching all bug changes.
https://bugs.winehq.org/show_bug.cgi?id=50381 Rémi Bernon <rbernon(a)codeweavers.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |rbernon(a)codeweavers.com --- Comment #9 from Rémi Bernon <rbernon(a)codeweavers.com> --- The problem here is that MATE WM (https://github.com/mate-desktop/marco) restores some saved window position whenever the client requests a window to be "unmaximized" by changing _NET_WM_STATE. The saved position is only updated whenever the window gets maximized. With the _NET_WM_STATE updates being sent even when no change is actually done, marco restores the position to its saved position every time we update the state. This makes the window jump to its original position (where it was initially created or where it was on the last maximization). Then we usually move the window position too, and this makes it jump back to where it's now supposed to be, and again. We could on our side avoid requesting the maximize state change when it's not necessary but I think this is also a bug in marco, as it should either not unmaximize the window again if it's already unmaximized, or update its saved position after the window got unmaximized, as well as when the window is moved. -- Do not reply to this email, post in Bugzilla using the above URL to reply. You are receiving this mail because: You are watching all bug changes.
https://bugs.winehq.org/show_bug.cgi?id=50381 --- Comment #10 from Zhiyi Zhang <zzhang(a)codeweavers.com> --- Trying to fix this on the marco side. -- Do not reply to this email, post in Bugzilla using the above URL to reply. You are receiving this mail because: You are watching all bug changes.
https://bugs.winehq.org/show_bug.cgi?id=50381 --- Comment #11 from Zhiyi Zhang <zzhang(a)codeweavers.com> --- Thank you Rémi. I open a merge request for marco at https://github.com/mate-desktop/marco/pull/679 -- Do not reply to this email, post in Bugzilla using the above URL to reply. You are receiving this mail because: You are watching all bug changes.
https://bugs.winehq.org/show_bug.cgi?id=50381 Zhiyi Zhang <zzhang(a)codeweavers.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Summary|AIMP (4.70 build 2236) |Winamp and AIMP (4.70 build |window cannot be moved |2236) window cannot be | |moved -- Do not reply to this email, post in Bugzilla using the above URL to reply. You are receiving this mail because: You are watching all bug changes.
https://bugs.winehq.org/show_bug.cgi?id=50381 Zhiyi Zhang <zzhang(a)codeweavers.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |albertpool(a)solcon.nl --- Comment #12 from Zhiyi Zhang <zzhang(a)codeweavers.com> --- *** Bug 49779 has been marked as a duplicate of this bug. *** -- Do not reply to this email, post in Bugzilla using the above URL to reply. You are receiving this mail because: You are watching all bug changes.
https://bugs.winehq.org/show_bug.cgi?id=50381 Julian Rüger <jr98(a)gmx.net> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |jr98(a)gmx.net -- Do not reply to this email, post in Bugzilla using the above URL to reply. You are receiving this mail because: You are watching all bug changes.
https://bugs.winehq.org/show_bug.cgi?id=50381 --- Comment #13 from Panard <panard(a)inzenet.org> --- Should a similar fix be adapted for Cinnamon, which suffers from the same behavior as marco? Maybe it would be more robust to fix the issue directly in Wine? -- Do not reply to this email, post in Bugzilla using the above URL to reply. You are receiving this mail because: You are watching all bug changes.
https://bugs.winehq.org/show_bug.cgi?id=50381 --- Comment #14 from Zhiyi Zhang <zzhang(a)codeweavers.com> --- (In reply to Panard from comment #13)
Should a similar fix be adapted for Cinnamon, which suffers from the same behavior as marco? Maybe it would be more robust to fix the issue directly in Wine?
KWin needs _NET_WM_STATE to be updated. So it can't be fixed on the Wine side unless we use window manager specific hacks. -- Do not reply to this email, post in Bugzilla using the above URL to reply. You are receiving this mail because: You are watching all bug changes.
https://bugs.winehq.org/show_bug.cgi?id=50381 --- Comment #15 from Dmitry Timoshkov <dmitry(a)baikal.ru> --- (In reply to Zhiyi Zhang from comment #14)
(In reply to Panard from comment #13)
Should a similar fix be adapted for Cinnamon, which suffers from the same behavior as marco? Maybe it would be more robust to fix the issue directly in Wine?
KWin needs _NET_WM_STATE to be updated. So it can't be fixed on the Wine side unless we use window manager specific hacks.
Did you consider patching KWin instead? It seems reasonable, since you'd need to create less patches for fewer projects. -- Do not reply to this email, post in Bugzilla using the above URL to reply. You are receiving this mail because: You are watching all bug changes.
https://bugs.winehq.org/show_bug.cgi?id=50381 --- Comment #16 from Albert Pool <albertpool(a)solcon.nl> --- The source code of Muffin and Marco contains many similarities, so in this case I think it makes sense to fix both. Window managers should not make too many assumptions about the way a program behaves; that triggers all sorts of obscure bugs, mostly with programs that don't use a standard toolkit like Gtk or Qt. Looking at the source code of Muffin, I suspect the problem lies in the if-statement on lines 3994-3997 of src/core/window.c. -- Do not reply to this email, post in Bugzilla using the above URL to reply. You are receiving this mail because: You are watching all bug changes.
https://bugs.winehq.org/show_bug.cgi?id=50381 --- Comment #17 from Zhiyi Zhang <zzhang(a)codeweavers.com> --- Fix for Marco is merged in https://github.com/mate-desktop/marco/commit/60f49ae5a272b737a944065e4199c8b... -- Do not reply to this email, post in Bugzilla using the above URL to reply. You are receiving this mail because: You are watching all bug changes.
https://bugs.winehq.org/show_bug.cgi?id=50381 --- Comment #18 from Albert Pool <albertpool(a)solcon.nl> --- Fix for Cinnamon is merged in https://github.com/linuxmint/muffin/commit/45c631cfc34de5022e5cc8c42f8b7c049... As far as I see a fix has been merged in all affected window managers, could someone mark this bug as resolved? -- Do not reply to this email, post in Bugzilla using the above URL to reply. You are receiving this mail because: You are watching all bug changes.
https://bugs.winehq.org/show_bug.cgi?id=50381 Zhiyi Zhang <zzhang(a)codeweavers.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |RESOLVED Resolution|--- |FIXED --- Comment #19 from Zhiyi Zhang <zzhang(a)codeweavers.com> --- Thanks for the fix, Albert. Marking as resolved. -- Do not reply to this email, post in Bugzilla using the above URL to reply. You are receiving this mail because: You are watching all bug changes.
https://bugs.winehq.org/show_bug.cgi?id=50381 Anastasius Focht <focht(a)gmx.net> changed: What |Removed |Added ---------------------------------------------------------------------------- Summary|Winamp and AIMP (4.70 build |Winamp and AIMP (4.70 build |2236) window cannot be |2236) window cannot be |moved |moved since | |wine-5.15-183-gc5ec1585f6e | |when using Cinnamon and | |MATE Window Managers Resolution|FIXED |NOTOURBUG --- Comment #20 from Anastasius Focht <focht(a)gmx.net> --- Hello folks, --- quote --- Thanks for the fix, Albert. Marking as resolved. --- quote --- it was fixed in upstream projects hence 'NOTOURBUG' is more appropriate here. I've also refined the summary to highlight this happens only with specific window managers. Regards -- Do not reply to this email, post in Bugzilla using the above URL to reply. You are receiving this mail because: You are watching all bug changes.
https://bugs.winehq.org/show_bug.cgi?id=50381 --- Comment #21 from Albert Pool <albertpool(a)solcon.nl> --- For what it's worth, Muffin 5.0.0 has been released yesterday incorporating the fix for this bug for users of the Cinnamon desktop. -- Do not reply to this email, post in Bugzilla using the above URL to reply. You are receiving this mail because: You are watching all bug changes.
https://bugs.winehq.org/show_bug.cgi?id=50381 Ken Sharp <imwellcushtymelike(a)gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |imwellcushtymelike(a)gmail.co | |m --- Comment #22 from Ken Sharp <imwellcushtymelike(a)gmail.com> --- *** Bug 52125 has been marked as a duplicate of this bug. *** -- Do not reply to this email, post in Bugzilla using the above URL to reply. You are receiving this mail because: You are watching all bug changes.
https://bugs.winehq.org/show_bug.cgi?id=50381 Gijs Vermeulen <gijsvrm(a)gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|RESOLVED |CLOSED --- Comment #23 from Gijs Vermeulen <gijsvrm(a)gmail.com> --- As the fixes for Marco and Muffen have been in multiple releases, closing. -- Do not reply to this email, post in Bugzilla using the above URL to reply. You are receiving this mail because: You are watching all bug changes.
participants (1)
-
WineHQ Bugzilla