[Bug 16084] New: widl crash on vista x86
http://bugs.winehq.org/show_bug.cgi?id=16084 Summary: widl crash on vista x86 Product: Wine Version: CVS/GIT Platform: PC-x86-64 OS/Version: Windows Vista Status: UNCONFIRMED Severity: enhancement Priority: P2 Component: tools AssignedTo: wine-bugs(a)winehq.org ReportedBy: netzimme(a)aol.com in the function get_size_procformatstring() in tools/widl/typegen.c the line : else if (stmt->type != STMT_TYPE && stmt->u.type->type != RPC_FC_IP) should be : else if (stmt->type != STMT_TYPE || stmt->u.type->type != RPC_FC_IP) because both parameter must be the same not only one of them to call the function pred(iface) below. Greetings Daniel Zimmermann -- Configure bugmail: http://bugs.winehq.org/userprefs.cgi?tab=email Do not reply to this email, post in Bugzilla using the above URL to reply. ------- You are receiving this mail because: ------- You are watching all bug changes.
http://bugs.winehq.org/show_bug.cgi?id=16084 Austin English <austinenglish(a)gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Keywords| |patch --- Comment #1 from Austin English <austinenglish(a)gmail.com> 2008-11-16 15:15:28 --- Please send patches to wine-patches(a)winehq.org -- Configure bugmail: http://bugs.winehq.org/userprefs.cgi?tab=email Do not reply to this email, post in Bugzilla using the above URL to reply. ------- You are receiving this mail because: ------- You are watching all bug changes.
http://bugs.winehq.org/show_bug.cgi?id=16084 Dmitry Timoshkov <dmitry(a)codeweavers.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Version|CVS/GIT |1.1.8 -- Configure bugmail: http://bugs.winehq.org/userprefs.cgi?tab=email Do not reply to this email, post in Bugzilla using the above URL to reply. ------- You are receiving this mail because: ------- You are watching all bug changes.
http://bugs.winehq.org/show_bug.cgi?id=16084 --- Comment #2 from Daniel Zimmermann <netzimme(a)aol.com> 2008-11-17 14:10:09 --- Created an attachment (id=17329) --> (http://bugs.winehq.org/attachment.cgi?id=17329) Crash in WIDL on Vista x86 Here is the patch. I hove this is the right way for committing a patch. Perhapses my description from comment #1 is not so good. This issue/bug have i only discovered in Windows Vista x86. But i think it can also possible on other platforms! I think the list is sorted a little bit differenced on Vista but i cannot see how parser.c generated the list. I wand to say that pred() only should be called when stmt->type equals to STMT_TYPE and stmt->u.type->type equals to RPC_FC_IP and when not the for-statement should continued. A similar situation we can see in the function process_tfs_stmts() or write_procformatstring_stmts() Hope this will help you Greetings Daniel Zimmermann -- Configure bugmail: http://bugs.winehq.org/userprefs.cgi?tab=email Do not reply to this email, post in Bugzilla using the above URL to reply. ------- You are receiving this mail because: ------- You are watching all bug changes.
http://bugs.winehq.org/show_bug.cgi?id=16084 --- Comment #3 from Austin English <austinenglish(a)gmail.com> 2008-11-17 14:26:44 --- (In reply to comment #2)
Created an attachment (id=17329) --> (http://bugs.winehq.org/attachment.cgi?id=17329) [details] Crash in WIDL on Vista x86
Here is the patch. I hove this is the right way for committing a patch.
Thanks! But you need to e-mail it to wine-patches(a)winehq.org. Patches here aren't picked up for inclusion in the main tree. -- Configure bugmail: http://bugs.winehq.org/userprefs.cgi?tab=email Do not reply to this email, post in Bugzilla using the above URL to reply. ------- You are receiving this mail because: ------- You are watching all bug changes.
http://bugs.winehq.org/show_bug.cgi?id=16084 --- Comment #4 from Daniel Zimmermann <netzimme(a)aol.com> 2008-11-17 14:34:52 --- Thanks for the hint. I have send the E-Mail -- Configure bugmail: http://bugs.winehq.org/userprefs.cgi?tab=email Do not reply to this email, post in Bugzilla using the above URL to reply. ------- You are receiving this mail because: ------- You are watching all bug changes.
http://bugs.winehq.org/show_bug.cgi?id=16084 Austin English <austinenglish(a)gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|UNCONFIRMED |RESOLVED Resolution| |FIXED --- Comment #5 from Austin English <austinenglish(a)gmail.com> 2008-11-18 14:35:43 --- Patch was committed. -- Configure bugmail: http://bugs.winehq.org/userprefs.cgi?tab=email Do not reply to this email, post in Bugzilla using the above URL to reply. ------- You are receiving this mail because: ------- You are watching all bug changes.
http://bugs.winehq.org/show_bug.cgi?id=16084 Alexandre Julliard <julliard(a)winehq.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|RESOLVED |CLOSED --- Comment #6 from Alexandre Julliard <julliard(a)winehq.org> 2008-11-21 10:32:19 --- Closing bugs fixed in 1.1.9. -- Configure bugmail: http://bugs.winehq.org/userprefs.cgi?tab=email Do not reply to this email, post in Bugzilla using the above URL to reply. ------- You are receiving this mail because: ------- You are watching all bug changes.
http://bugs.winehq.org/show_bug.cgi?id=16084 Austin English <austinenglish(a)gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- OS/Version|Windows Vista |Windows -- Configure bugmail: http://bugs.winehq.org/userprefs.cgi?tab=email Do not reply to this email, post in Bugzilla using the above URL to reply. ------- You are receiving this mail because: ------- You are watching all bug changes.
participants (1)
-
wine-bugs＠winehq.org