[Bug 42512] New: A staging commit tanks performance
https://bugs.winehq.org/show_bug.cgi?id=42512 Bug ID: 42512 Summary: A staging commit tanks performance Product: Wine-staging Version: 2.2 Hardware: x86 OS: Linux Status: UNCONFIRMED Severity: normal Priority: P2 Component: -unknown Assignee: wine-bugs(a)winehq.org Reporter: noonetinone(a)gmail.com CC: erich.e.hoover(a)wine-staging.com, michael(a)fds-team.de, sebastian(a)fds-team.de Regression SHA1: 1cc5d04346f6fcf6d7b06e776b81b2a58b3d64f8 Distribution: Other A staging commit tanks performance in Hitman: Absolution. Other titles are affected as well. For 2.1(S) I would get 20-24 fps. But with 2.2(S) I get 6 or 7 fps. I did track down the offending commit. ****************************************************************************** commit 1cc5d04346f6fcf6d7b06e776b81b2a58b3d64f8 Author: Sebastian Lackner <sebastian(a)fds-team.de> Date: Sun Feb 12 05:21:10 2017 +0100 Added patch to create buffers on default pool in wined3d_buffer_create. ********************************************************************************** All staging commits prior to this one give good performance. Note: I did rebase again wine commit 9c72376c8cc03a4ea86dddaa6d18a93a1a33fc73 . -- Do not reply to this email, post in Bugzilla using the above URL to reply. You are receiving this mail because: You are watching all bug changes.
https://bugs.winehq.org/show_bug.cgi?id=42512 --- Comment #1 from Anthony Jagers <noonetinone(a)gmail.com> --- One more thing: I never did test these two commits in order. wined3d-DXTn: Remove reference to fixed bug. wined3d-CSMT_Main: Initialize critical sections with spincount. I don't know if they are good or bad. -- Do not reply to this email, post in Bugzilla using the above URL to reply. You are receiving this mail because: You are watching all bug changes.
https://bugs.winehq.org/show_bug.cgi?id=42512 --- Comment #2 from Sebastian Lackner <sebastian(a)fds-team.de> --- Thanks for the bug report. Actually, one of the main reasons for the commit was to improve performance, but since this doesn't seem to work out for all graphic cards / drivers, I have decided to disable it again. Please let me know if the issue is still present in current Wine Staging git. Also, it would be interesting to know which hardware / driver combination you are using. -- Do not reply to this email, post in Bugzilla using the above URL to reply. You are receiving this mail because: You are watching all bug changes.
https://bugs.winehq.org/show_bug.cgi?id=42512 --- Comment #3 from Anthony Jagers <noonetinone(a)gmail.com> --- I use a GTX 750 Ti with closed driver version 378.13. I'm currently on 4.10.0 kernel but the problem was present in 4.9 series as well. I you do upload a patch for this, I could use a wine commit tag in the comment to rebase against. -- Do not reply to this email, post in Bugzilla using the above URL to reply. You are receiving this mail because: You are watching all bug changes.
https://bugs.winehq.org/show_bug.cgi?id=42512 --- Comment #4 from Anthony Jagers <noonetinone(a)gmail.com> --- Checking the git repo... I see you have done that. Thanks! -- Do not reply to this email, post in Bugzilla using the above URL to reply. You are receiving this mail because: You are watching all bug changes.
https://bugs.winehq.org/show_bug.cgi?id=42512 --- Comment #5 from Sebastian Lackner <sebastian(a)fds-team.de> --- (In reply to Anthony Jagers from comment #3)
I you do upload a patch for this, I could use a wine commit tag in the comment to rebase against.
I recommend to test a clean Wine Staging git build (you can get the Wine commit via "patchinstall.sh --upstream-commit") to make sure the performance is back to the original value. There have also been other changes in the meantime, and just applying / reverting a separate change could give misleading results. If you encounter any crashes, try to apply http://source.winehq.org/patches/data/130627 (regression currently present in the dev branch). -- Do not reply to this email, post in Bugzilla using the above URL to reply. You are receiving this mail because: You are watching all bug changes.
https://bugs.winehq.org/show_bug.cgi?id=42512 --- Comment #6 from Anthony Jagers <noonetinone(a)gmail.com> --- You're right, there is a regression somewhere. Hitman:A doesn't start. The launcher starts and then black screen. I'll try to backtrack through the commits. I'll get back to you. -- Do not reply to this email, post in Bugzilla using the above URL to reply. You are receiving this mail because: You are watching all bug changes.
https://bugs.winehq.org/show_bug.cgi?id=42512 --- Comment #7 from Anthony Jagers <noonetinone(a)gmail.com> --- The problem occurs between these two commits. commit 2ae8a0be027c415c3a57406b74ea7c0055d5d015 bad commit dc52cbef3ce99ed539d673ebd712c646a05bb4cd good That starts after Jacek Caban committed to development after Feb 20th. His commit dc52* rebases to. That's all I know for now. -- Do not reply to this email, post in Bugzilla using the above URL to reply. You are receiving this mail because: You are watching all bug changes.
https://bugs.winehq.org/show_bug.cgi?id=42512 --- Comment #8 from Sebastian Lackner <sebastian(a)fds-team.de> --- (In reply to Anthony Jagers from comment #7)
The problem occurs between these two commits.
commit 2ae8a0be027c415c3a57406b74ea7c0055d5d015 bad commit dc52cbef3ce99ed539d673ebd712c646a05bb4cd good
That starts after Jacek Caban committed to development after Feb 20th. His commit dc52* rebases to.
That's all I know for now.
Have you checked that it is not fixed by http://source.winehq.org/patches/data/130627? -- Do not reply to this email, post in Bugzilla using the above URL to reply. You are receiving this mail because: You are watching all bug changes.
https://bugs.winehq.org/show_bug.cgi?id=42512 --- Comment #9 from Anthony Jagers <noonetinone(a)gmail.com> --- I'll try it out. -- Do not reply to this email, post in Bugzilla using the above URL to reply. You are receiving this mail because: You are watching all bug changes.
https://bugs.winehq.org/show_bug.cgi?id=42512 Robert Walker <bob.mt.wya(a)gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |bob.mt.wya(a)gmail.com -- Do not reply to this email, post in Bugzilla using the above URL to reply. You are receiving this mail because: You are watching all bug changes.
https://bugs.winehq.org/show_bug.cgi?id=42512 --- Comment #10 from Anthony Jagers <noonetinone(a)gmail.com> --- It worked. Things are as they were in 2.1(S). No regressions and no improvements in speed either. Will that patch 130627 be merged into wine? Closed. -- Do not reply to this email, post in Bugzilla using the above URL to reply. You are receiving this mail because: You are watching all bug changes.
https://bugs.winehq.org/show_bug.cgi?id=42512 Anthony Jagers <noonetinone(a)gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Resolution|--- |FIXED Status|UNCONFIRMED |RESOLVED --- Comment #11 from Anthony Jagers <noonetinone(a)gmail.com> --- FIXED with staging commit. -- Do not reply to this email, post in Bugzilla using the above URL to reply. You are receiving this mail because: You are watching all bug changes.
https://bugs.winehq.org/show_bug.cgi?id=42512 --- Comment #12 from Sebastian Lackner <sebastian(a)fds-team.de> --- (In reply to Anthony Jagers from comment #10)
It worked. Things are as they were in 2.1(S). No regressions and no improvements in speed either.
Thanks for testing. :)
Will that patch 130627 be merged into wine?
It was merged today: http://source.winehq.org/git/wine.git/commit/67007e010e83ac8c7c72eca196be8a6...
Closed.
-- Do not reply to this email, post in Bugzilla using the above URL to reply. You are receiving this mail because: You are watching all bug changes.
https://bugs.winehq.org/show_bug.cgi?id=42512 Sebastian Lackner <sebastian(a)fds-team.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Summary|A staging commit tanks |Performance regression in |performance |Hitman: Absolution and | |other titles Keywords| |regression -- Do not reply to this email, post in Bugzilla using the above URL to reply. You are receiving this mail because: You are watching all bug changes.
https://bugs.winehq.org/show_bug.cgi?id=42512 Alistair Leslie-Hughes <leslie_alistair(a)hotmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|RESOLVED |CLOSED --- Comment #13 from Alistair Leslie-Hughes <leslie_alistair(a)hotmail.com> --- Closing Fixed Staging 3.14 -- Do not reply to this email, post in Bugzilla using the above URL to reply. You are receiving this mail because: You are watching all bug changes.
participants (1)
-
wine-bugs＠winehq.org