[Bug 47433] New: Accel World vs. Sword Art Online needs WTSRegisterSessionNotificationEx() to return true.
https://bugs.winehq.org/show_bug.cgi?id=47433 Bug ID: 47433 Summary: Accel World vs. Sword Art Online needs WTSRegisterSessionNotificationEx() to return true. Product: Wine Version: unspecified Hardware: x86-64 OS: Linux Status: UNCONFIRMED Severity: normal Priority: P2 Component: wtsapi32 Assignee: wine-bugs(a)winehq.org Reporter: hibbsncc1701(a)gmail.com Distribution: --- The current stub for WTSRegisterSessionNotificationEx() returns false. Accel World vs. Sword Art Online calls it during start up and will exit immediately without displaying it's main window if it fails. If wine is patched to return true, the game runs. -- Do not reply to this email, post in Bugzilla using the above URL to reply. You are receiving this mail because: You are watching all bug changes.
https://bugs.winehq.org/show_bug.cgi?id=47433 --- Comment #1 from Patrick Hibbs <hibbsncc1701(a)gmail.com> --- Created attachment 64782 --> https://bugs.winehq.org/attachment.cgi?id=64782 Patch to make window registration struct. MSDN seems to indicate that each call to WTSRegisterSessionNotification[Ex]() is supposed to be paired with a call to WTSUnRegisterSessionNotification[Ex](). MSDN also indicates that calls to WTSRegisterSessionNotification[Ex]() for an already registered window should fail. I made a series of patches to enable this behavior in wine so that any DRM that decides to go looking will be satisfied. -- Do not reply to this email, post in Bugzilla using the above URL to reply. You are receiving this mail because: You are watching all bug changes.
https://bugs.winehq.org/show_bug.cgi?id=47433 --- Comment #2 from Patrick Hibbs <hibbsncc1701(a)gmail.com> --- Created attachment 64783 --> https://bugs.winehq.org/attachment.cgi?id=64783 Make WTSRegisterSessionNotificationEx() keep track of registrations. -- Do not reply to this email, post in Bugzilla using the above URL to reply. You are receiving this mail because: You are watching all bug changes.
https://bugs.winehq.org/show_bug.cgi?id=47433 --- Comment #3 from Patrick Hibbs <hibbsncc1701(a)gmail.com> --- Created attachment 64784 --> https://bugs.winehq.org/attachment.cgi?id=64784 Have WTSRegisterSessionNotification forward calls. -- Do not reply to this email, post in Bugzilla using the above URL to reply. You are receiving this mail because: You are watching all bug changes.
https://bugs.winehq.org/show_bug.cgi?id=47433 --- Comment #4 from Patrick Hibbs <hibbsncc1701(a)gmail.com> --- Created attachment 64785 --> https://bugs.winehq.org/attachment.cgi?id=64785 Allow deregistration with WTSUnRegisterSessionNotificationEx(). -- Do not reply to this email, post in Bugzilla using the above URL to reply. You are receiving this mail because: You are watching all bug changes.
https://bugs.winehq.org/show_bug.cgi?id=47433 --- Comment #5 from Patrick Hibbs <hibbsncc1701(a)gmail.com> --- Created attachment 64786 --> https://bugs.winehq.org/attachment.cgi?id=64786 Have WTSUnRegisterSessionNotification forward calls. -- Do not reply to this email, post in Bugzilla using the above URL to reply. You are receiving this mail because: You are watching all bug changes.
https://bugs.winehq.org/show_bug.cgi?id=47433 Patrick Hibbs <hibbsncc1701(a)gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #64782|0 |1 is obsolete| | --- Comment #6 from Patrick Hibbs <hibbsncc1701(a)gmail.com> --- Created attachment 64823 --> https://bugs.winehq.org/attachment.cgi?id=64823 Patch to make window registration struct. v2 v2 of Patch 1. Fix missing static variable declaration. -- Do not reply to this email, post in Bugzilla using the above URL to reply. You are receiving this mail because: You are watching all bug changes.
https://bugs.winehq.org/show_bug.cgi?id=47433 Patrick Hibbs <hibbsncc1701(a)gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #64823|0 |1 is obsolete| | --- Comment #7 from Patrick Hibbs <hibbsncc1701(a)gmail.com> --- Created attachment 64826 --> https://bugs.winehq.org/attachment.cgi?id=64826 Patch 1/5 v3: Create Struct Rebase patches to git 201d13a3c31131f204f89d61be37bf75d58dc6dd. v3: Fix missing include for 32bit. -- Do not reply to this email, post in Bugzilla using the above URL to reply. You are receiving this mail because: You are watching all bug changes.
https://bugs.winehq.org/show_bug.cgi?id=47433 Patrick Hibbs <hibbsncc1701(a)gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #64783|0 |1 is obsolete| | --- Comment #8 from Patrick Hibbs <hibbsncc1701(a)gmail.com> --- Created attachment 64827 --> https://bugs.winehq.org/attachment.cgi?id=64827 Patch 2/5: Fix RegisterSessionNotificationEx Rebase patches to git 201d13a3c31131f204f89d61be37bf75d58dc6dd. -- Do not reply to this email, post in Bugzilla using the above URL to reply. You are receiving this mail because: You are watching all bug changes.
https://bugs.winehq.org/show_bug.cgi?id=47433 Patrick Hibbs <hibbsncc1701(a)gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #64784|0 |1 is obsolete| | --- Comment #9 from Patrick Hibbs <hibbsncc1701(a)gmail.com> --- Created attachment 64828 --> https://bugs.winehq.org/attachment.cgi?id=64828 Patch 3/5: Forward calls WTSRegisterSessionNotification. Rebase patches to git 201d13a3c31131f204f89d61be37bf75d58dc6dd. -- Do not reply to this email, post in Bugzilla using the above URL to reply. You are receiving this mail because: You are watching all bug changes.
https://bugs.winehq.org/show_bug.cgi?id=47433 Patrick Hibbs <hibbsncc1701(a)gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #64785|0 |1 is obsolete| | --- Comment #10 from Patrick Hibbs <hibbsncc1701(a)gmail.com> --- Created attachment 64829 --> https://bugs.winehq.org/attachment.cgi?id=64829 Patch 4/5: Fix UnRegisterSessionNotificationEx. Rebase patches to git 201d13a3c31131f204f89d61be37bf75d58dc6dd. -- Do not reply to this email, post in Bugzilla using the above URL to reply. You are receiving this mail because: You are watching all bug changes.
https://bugs.winehq.org/show_bug.cgi?id=47433 Patrick Hibbs <hibbsncc1701(a)gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #64786|0 |1 is obsolete| | --- Comment #11 from Patrick Hibbs <hibbsncc1701(a)gmail.com> --- Created attachment 64830 --> https://bugs.winehq.org/attachment.cgi?id=64830 Patch 5/5: Forward calls WTSUnRegisterSessionNotification. Rebase patches to git 201d13a3c31131f204f89d61be37bf75d58dc6dd. -- Do not reply to this email, post in Bugzilla using the above URL to reply. You are receiving this mail because: You are watching all bug changes.
https://bugs.winehq.org/show_bug.cgi?id=47433 Zebediah Figura <z.figura12(a)gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |z.figura12(a)gmail.com --- Comment #12 from Zebediah Figura <z.figura12(a)gmail.com> --- Thanks for the patches. Ideally please submit them according to the process detailed in <https://wiki.winehq.org/Submitting_Patches>, since patches aren't automatically picked up from Bugzilla. That said, I suspect that it would be better just to return TRUE from WTSRegisterSessionNotificationEx(), and do nothing else. It's not really meaningful to track registrations if we're not going to actually do anything with them. -- Do not reply to this email, post in Bugzilla using the above URL to reply. You are receiving this mail because: You are watching all bug changes.
https://bugs.winehq.org/show_bug.cgi?id=47433 --- Comment #13 from Patrick Hibbs <hibbsncc1701(a)gmail.com> --- works in wine-5.0-rc1. -- Do not reply to this email, post in Bugzilla using the above URL to reply. You are receiving this mail because: You are watching all bug changes.
https://bugs.winehq.org/show_bug.cgi?id=47433 Zebediah Figura <z.figura12(a)gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Resolution|--- |FIXED Status|UNCONFIRMED |RESOLVED Fixed by SHA1| |f870aa4988fa8e980919c144682 | |da72865364ff0 Version|unspecified |4.11 --- Comment #14 from Zebediah Figura <z.figura12(a)gmail.com> --- Fixed by <https://source.winehq.org/git/wine.git/commitdiff/f870aa4988fa8e980919c144682da72865364ff0>. -- Do not reply to this email, post in Bugzilla using the above URL to reply. You are receiving this mail because: You are watching all bug changes.
https://bugs.winehq.org/show_bug.cgi?id=47433 Alexandre Julliard <julliard(a)winehq.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|RESOLVED |CLOSED --- Comment #15 from Alexandre Julliard <julliard(a)winehq.org> --- Closing bugs fixed in 5.0-rc6. -- Do not reply to this email, post in Bugzilla using the above URL to reply. You are receiving this mail because: You are watching all bug changes.
https://bugs.winehq.org/show_bug.cgi?id=47433 Michael Stefaniuc <mstefani(a)winehq.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Target Milestone|--- |4.0.x -- Do not reply to this email, post in Bugzilla using the above URL to reply. You are receiving this mail because: You are watching all bug changes.
https://bugs.winehq.org/show_bug.cgi?id=47433 Michael Stefaniuc <mstefani(a)winehq.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Target Milestone|4.0.x |--- --- Comment #16 from Michael Stefaniuc <mstefani(a)winehq.org> --- Removing the 4.0.x milestone from bug fixes included in 4.0.4. -- Do not reply to this email, post in Bugzilla using the above URL to reply. You are receiving this mail because: You are watching all bug changes.
participants (2)
-
wine-bugs＠winehq.org -
WineHQ Bugzilla