[Bug 12005] New: Regression in pressure sensitivity with wizardpen tablet driver and Photoshop 7
http://bugs.winehq.org/show_bug.cgi?id=12005 Summary: Regression in pressure sensitivity with wizardpen tablet driver and Photoshop 7 Product: Wine Version: 0.9.56. Platform: Other OS/Version: other Status: UNCONFIRMED Keywords: download Severity: normal Priority: P2 Component: wintab32 AssignedTo: wine-bugs(a)winehq.org ReportedBy: dank(a)kegel.com I haven't confirmed this myself, just relaying for a user. In http://www.winehq.org/pipermail/wine-users/2008-March/029938.html "blender" says: "I have a UC-LoGIC WP8060 tablet.I using wizardpen taplet driver. I using PS 7.0 with wine-0.9.33. My Pen worked perfectly with wine-0.9.33, but PS7.0 has some bugs. I update my wine "wine-0.9.56". PS 7.0 working perfectly but my pen has not got pressure sensitive. I turn back wine-0.9.33. I have too much problems PS 7.0. I want to use new version of wine." -- Configure bugmail: http://bugs.winehq.org/userprefs.cgi?tab=email Do not reply to this email, post in Bugzilla using the above URL to reply. ------- You are receiving this mail because: ------- You are watching all bug changes.
http://bugs.winehq.org/show_bug.cgi?id=12005 --- Comment #1 from Dan Kegel <dank(a)kegel.com> 2008-03-12 09:36:11 --- User log with wine-0.9.56 says: trace:wintab32:LoadTablet Initializing the tablet to hwnd 0x3034c trace:wintab32:X11DRV_LoadTabletInfo XListInputDevices reports 3 devices trace:wintab32:X11DRV_LoadTabletInfo Device 0: [id 0|name Keyboard0|type KEYBOARD|num_classes 1|use IsXKeyboard] trace:wintab32:X11DRV_LoadTabletInfo Device 1: [id 1|name WizardPen Tablet|type WizardPen Tablet|num_classes 2|use IsXExtensionDevice] trace:wintab32:X11DRV_LoadTabletInfo Is Extension Device warn:wintab32:X11DRV_LoadTabletInfo Skipping device 1 [name WizardPen Tablet|type WizardPen Tablet]; not apparently a tablet cursor type device trace:wintab32:X11DRV_LoadTabletInfo Device 2: [id 2|name Mouse0|type MOUSE|num_classes 2|use IsXPointer] warn:wintab32:X11DRV_LoadTabletInfo Did not find a valid stylus cursor with >= 5 axes, returning 0 valid devices. -- Configure bugmail: http://bugs.winehq.org/userprefs.cgi?tab=email Do not reply to this email, post in Bugzilla using the above URL to reply. ------- You are receiving this mail because: ------- You are watching all bug changes.
http://bugs.winehq.org/show_bug.cgi?id=12005 --- Comment #2 from Dan Kegel <dank(a)kegel.com> 2008-03-12 11:14:10 --- xorg.conf for this user at http://www.winehq.org/pipermail/wine-users/2008-March/029950.html -- Configure bugmail: http://bugs.winehq.org/userprefs.cgi?tab=email Do not reply to this email, post in Bugzilla using the above URL to reply. ------- You are receiving this mail because: ------- You are watching all bug changes.
http://bugs.winehq.org/show_bug.cgi?id=12005 --- Comment #3 from Timo-Heikki Mäkelä <imaxfun(a)gmail.com> 2008-03-12 11:30:57 --- Howabout adding keyword 'regression' and running a regression test, if things do work correctly on 0.9.33...? (sorry fo bugging) -- Configure bugmail: http://bugs.winehq.org/userprefs.cgi?tab=email Do not reply to this email, post in Bugzilla using the above URL to reply. ------- You are receiving this mail because: ------- You are watching all bug changes.
http://bugs.winehq.org/show_bug.cgi?id=12005 Dan Kegel <dank(a)kegel.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Keywords| |regression -- Configure bugmail: http://bugs.winehq.org/userprefs.cgi?tab=email Do not reply to this email, post in Bugzilla using the above URL to reply. ------- You are receiving this mail because: ------- You are watching all bug changes.
http://bugs.winehq.org/show_bug.cgi?id=12005 Dan Kegel <dank(a)kegel.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|UNCONFIRMED |NEW Ever Confirmed|0 |1 Target Milestone|--- |1.0.0 --- Comment #4 from Dan Kegel <dank(a)kegel.com> 2008-03-12 11:56:43 --- And here's a log from the good old wine-0.9.33: trace:wintab32:LoadTablet Initializing the tablet to hwnd 0x10024 trace:wintab32:X11DRV_LoadTabletInfo Trying device 0(Keyboard0) trace:wintab32:X11DRV_LoadTabletInfo Trying device 1(WizardPen Tablet) trace:wintab32:X11DRV_LoadTabletInfo Is Extension Device trace:wintab32:X11DRV_LoadTabletInfo Trying device 2(Mouse0) It looks like we need to be a bit more liberal in IS_TABLET_CURSOR(). See http://source.winehq.org/source/dlls/winex11.drv/wintab.c#L386 In particular, maybe we need a table of known good tablet types, e.g. static const char *tablet_whitelist[] = {"wacom", "wizardpen", NULL}; and then have IS_TABLET_CURSOR check that whole list, not just wacom. And probably turn IS_TABLET_CURSOR into a real function. -- Configure bugmail: http://bugs.winehq.org/userprefs.cgi?tab=email Do not reply to this email, post in Bugzilla using the above URL to reply. ------- You are receiving this mail because: ------- You are watching all bug changes.
http://bugs.winehq.org/show_bug.cgi?id=12005 --- Comment #5 from Dan Kegel <dank(a)kegel.com> 2008-03-13 10:57:47 --- Try this patch: http://winehq.org/pipermail/wine-patches/2008-March/051454.html See also bug 11699 -- Configure bugmail: http://bugs.winehq.org/userprefs.cgi?tab=email Do not reply to this email, post in Bugzilla using the above URL to reply. ------- You are receiving this mail because: ------- You are watching all bug changes.
http://bugs.winehq.org/show_bug.cgi?id=12005 Keith Brown <spamtrap(a)hellmark.org> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |spamtrap(a)hellmark.org --- Comment #6 from Keith Brown <spamtrap(a)hellmark.org> 2008-03-23 21:44:48 --- Right now, I am on a wacom based tabletpc, using the wacom drivers, and I'm getting the same report of "Did not find a valid stylus cursor with >= 5 axes, returning 0 valid devices." (full log available at http://slexy.org/view/s20wProWdf ) I primarily want to use ArtRage, which kinda needs the pressure sensitivity. -- Configure bugmail: http://bugs.winehq.org/userprefs.cgi?tab=email Do not reply to this email, post in Bugzilla using the above URL to reply. ------- You are receiving this mail because: ------- You are watching all bug changes.
http://bugs.winehq.org/show_bug.cgi?id=12005 --- Comment #7 from Dan Kegel <dank(a)kegel.com> 2008-03-28 00:15:35 --- I have a WP8060 myself now, and can confirm winex11 doesn't like it. It has only 3 axes, for starters... ? -- Configure bugmail: http://bugs.winehq.org/userprefs.cgi?tab=email Do not reply to this email, post in Bugzilla using the above URL to reply. ------- You are receiving this mail because: ------- You are watching all bug changes.
http://bugs.winehq.org/show_bug.cgi?id=12005 --- Comment #8 from John Klehm <xixsimplicityxix(a)gmail.com> 2008-04-16 02:34:04 --- Created an attachment (id=12232) --> (http://bugs.winehq.org/attachment.cgi?id=12232) Patch to allow wintab devices with less than 5 axes This patch should let devices with less than 5 axes be detected. AFAICT JWhite just forgot to remove the hard check for 5 axes when he submitted his wintab patchset. The axes handling code already has guards for devices with less than 5. Please test and let me know if this works or not as I don't have a device with less than 5 axes. -- Configure bugmail: http://bugs.winehq.org/userprefs.cgi?tab=email Do not reply to this email, post in Bugzilla using the above URL to reply. ------- You are receiving this mail because: ------- You are watching all bug changes.
http://bugs.winehq.org/show_bug.cgi?id=12005 Austin English <austinenglish(a)gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Keywords| |patch -- Configure bugmail: http://bugs.winehq.org/userprefs.cgi?tab=email Do not reply to this email, post in Bugzilla using the above URL to reply. ------- You are receiving this mail because: ------- You are watching all bug changes.
http://bugs.winehq.org/show_bug.cgi?id=12005 --- Comment #9 from Dan Kegel <dank(a)kegel.com> 2008-04-16 22:26:11 --- Didn't solve the problem, I'm afraid. I guess you need one of these tablets. -- Configure bugmail: http://bugs.winehq.org/userprefs.cgi?tab=email Do not reply to this email, post in Bugzilla using the above URL to reply. ------- You are receiving this mail because: ------- You are watching all bug changes.
http://bugs.winehq.org/show_bug.cgi?id=12005 John Klehm <xixsimplicityxix(a)gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |xixsimplicityxix(a)gmail.com --- Comment #10 from John Klehm <xixsimplicityxix(a)gmail.com> 2008-04-16 22:37:19 --- Well the patch should at least let the detection code get further. Any chance on getting a +wintab32 log? -- Configure bugmail: http://bugs.winehq.org/userprefs.cgi?tab=email Do not reply to this email, post in Bugzilla using the above URL to reply. ------- You are receiving this mail because: ------- You are watching all bug changes.
http://bugs.winehq.org/show_bug.cgi?id=12005 --- Comment #11 from John Klehm <xixsimplicityxix(a)gmail.com> 2008-04-17 10:15:34 --- Created an attachment (id=12266) --> (http://bugs.winehq.org/attachment.cgi?id=12266) Allow wizardpen to be detected as a stylus Ahh sorry Dan I failed to read the entries before your patch posting #5. The code that guards axes detection is this: if (!axis_read_complete && Val->num_axes >= 5 && cursor->TYPE == CSR_TYPE_PEN) My previous patch allowing devices with any number of axes makes it this: (KeithB you should see more progress in detection with just this patch) if (!axis_read_complete && cursor->TYPE == CSR_TYPE_PEN) axis_read_complete is only set to true inside that if block so we can conclude that cursor-TYPE isn't being set for wizardpens. And of course it wasn't. we see in this block that either our device's name or type has to come up with a match in is_stylus: cursor->PHYSID = target->id; cursor->NPBUTTON = 1; cursor->NPBTNMARKS[0] = 0 ; cursor->NPBTNMARKS[1] = 1 ; cursor->CAPABILITIES = CRC_MULTIMODE; if (is_stylus(target->name, device_type)) cursor->TYPE = CSR_TYPE_PEN; if (is_eraser(target->name, device_type)) cursor->TYPE = CSR_TYPE_ERASER; And having wizardpen match in the is_stylus function is what this patch does. So with allow any num axes patch and this patch, the detection should get further. If things still don't work with wizardpens then but the device detection DOES get further then a new wintab32 log would be good. If device detection DOESNOT get any further with both these patches then I give up for now. =P -- Configure bugmail: http://bugs.winehq.org/userprefs.cgi?tab=email Do not reply to this email, post in Bugzilla using the above URL to reply. ------- You are receiving this mail because: ------- You are watching all bug changes.
http://bugs.winehq.org/show_bug.cgi?id=12005 --- Comment #12 from Dan Kegel <dank(a)kegel.com> 2008-04-17 22:01:27 --- Created an attachment (id=12277) --> (http://bugs.winehq.org/attachment.cgi?id=12277) +wintab log after applying both patches No joy, sorry. -- Configure bugmail: http://bugs.winehq.org/userprefs.cgi?tab=email Do not reply to this email, post in Bugzilla using the above URL to reply. ------- You are receiving this mail because: ------- You are watching all bug changes.
http://bugs.winehq.org/show_bug.cgi?id=12005 --- Comment #13 from Keith Brown <spamtrap(a)hellmark.org> 2008-04-20 23:36:22 --- So far, no change. Still spits the same stuff into the log -- Configure bugmail: http://bugs.winehq.org/userprefs.cgi?tab=email Do not reply to this email, post in Bugzilla using the above URL to reply. ------- You are receiving this mail because: ------- You are watching all bug changes.
http://bugs.winehq.org/show_bug.cgi?id=12005 V.platanias <azathothgr(a)gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |azathothgr(a)gmail.com --- Comment #14 from V.platanias <azathothgr(a)gmail.com> 2008-04-21 07:46:30 --- I had a similar issue with a wacom intuos (5 axes). Same log, same results. However, it worked after I replaced IsXExtensionDevice with IsXExtensionPointer in dlls/winex11.drv/wintab.c xsetpointer -l reports stylus, eraser and cursor devices as "IsXExtensionPointer" too, instead of "..Device". -- Configure bugmail: http://bugs.winehq.org/userprefs.cgi?tab=email Do not reply to this email, post in Bugzilla using the above URL to reply. ------- You are receiving this mail because: ------- You are watching all bug changes.
http://bugs.winehq.org/show_bug.cgi?id=12005 --- Comment #15 from John Klehm <xixsimplicityxix(a)gmail.com> 2008-04-21 16:30:07 --- Yeah I just ran into the ubuntu thread about that =P The #xorg-devel guys were kind enough to tell me that tablets will be XExtensionPointers in >= xserver 1.4. So I guess we have to support both. http://cgit.freedesktop.org/xorg/xserver/commit/?id=0a2068d123520d35818c38a5... -- Configure bugmail: http://bugs.winehq.org/userprefs.cgi?tab=email Do not reply to this email, post in Bugzilla using the above URL to reply. ------- You are receiving this mail because: ------- You are watching all bug changes.
http://bugs.winehq.org/show_bug.cgi?id=12005 --- Comment #16 from Keith Brown <spamtrap(a)hellmark.org> 2008-04-22 08:36:01 --- Changed things around from IsXExtensionDevice to IsXExtensionPointer, since my machine does use the XExtensionPointer, but no change in how things work as of yet. Still trying to fiddle with things to get it working. -- Configure bugmail: http://bugs.winehq.org/userprefs.cgi?tab=email Do not reply to this email, post in Bugzilla using the above URL to reply. ------- You are receiving this mail because: ------- You are watching all bug changes.
http://bugs.winehq.org/show_bug.cgi?id=12005 --- Comment #17 from John Klehm <xixsimplicityxix(a)gmail.com> 2008-04-22 19:18:52 --- Created an attachment (id=12402) --> (http://bugs.winehq.org/attachment.cgi?id=12402) Always check the first 2 system cursor slots Ok possibly a bit more progress. I think the problem now is that gNumCursors is set to 1 for wizard pen as it has just device registered. Wacoms usually have 3 setup (cursor, stylus, eraser). So the bug is brought into play by our hack to support the older versions of photoshop that expect stylus to be in slot 1 in system cursors. Heres the play by play: 1) We detect wizard pens 1 cursor (gNumCursors is 1) and put it in slot 0 of the system cursors (gSysCursor[]). 2) We run our hack for photoshop (Tablet_FixupCursors) and swap cursor.type == stylus into slot 1. 3) our event handlers call cursor_from_device which iterates through the system cursors slots looking for PHYSID == deviceid. However cursor_from_device uses gNumCursors to be the non inclusive upper limit of the device slots. For wizard pens (and other devices with only 1 cursor) this means that: gNumCursors is 1 thus only gSysCursors[0] is checked. This is wrong becuase we swapped gSysCursor[0] to gSysCursor[1] in Tablet_FixupCursors earlier. With this patch we will always check slots 0 and 1 in order to accomodate our earlier accomodation for photoshop. -- Configure bugmail: http://bugs.winehq.org/userprefs.cgi?tab=email Do not reply to this email, post in Bugzilla using the above URL to reply. ------- You are receiving this mail because: ------- You are watching all bug changes.
http://bugs.winehq.org/show_bug.cgi?id=12005 --- Comment #18 from John Klehm <xixsimplicityxix(a)gmail.com> 2008-04-22 20:15:17 --- Created an attachment (id=12403) --> (http://bugs.winehq.org/attachment.cgi?id=12403) Add wintab support for IsXExtensionPointer Hopefully this adds support for IsXExtensionPointer and keeps support in place for IsXExtensionDevice. -- Configure bugmail: http://bugs.winehq.org/userprefs.cgi?tab=email Do not reply to this email, post in Bugzilla using the above URL to reply. ------- You are receiving this mail because: ------- You are watching all bug changes.
http://bugs.winehq.org/show_bug.cgi?id=12005 --- Comment #19 from Keith Brown <spamtrap(a)hellmark.org> 2008-05-06 11:10:23 --- Running 0.9.61 and still no support with my wacom based tabletpc. Still reports the following trace:wintab32:WTInfoT (0, 0, (nil), 0) trace:wintab32:LoadTablet Initializing the tablet to hwnd 0x1002a trace:wintab32:X11DRV_LoadTabletInfo XListInputDevices reports 6 devices trace:wintab32:X11DRV_LoadTabletInfo Device 0: [id 0|name Virtual core keyboard|type |num_classes 1|use IsXKeyboard] trace:wintab32:X11DRV_LoadTabletInfo Device 1: [id 1|name Virtual core pointer|type |num_classes 2|use IsXPointer] trace:wintab32:X11DRV_LoadTabletInfo Device 2: [id 2|name stylus|type Wacom Stylus|num_classes 3|use Unknown] trace:wintab32:X11DRV_LoadTabletInfo Device 3: [id 3|name cursor|type Wacom Cursor|num_classes 3|use Unknown] trace:wintab32:X11DRV_LoadTabletInfo Device 4: [id 4|name PS/2 Generic Mouse 0|type MOUSE|num_classes 2|use Unknown] trace:wintab32:X11DRV_LoadTabletInfo Device 5: [id 5|name Keyboard 0|type KEYBOARD|num_classes 1|use Unknown] warn:wintab32:X11DRV_LoadTabletInfo Did not find a valid stylus cursor with >= 5 axes, returning 0 valid devices. trace:wintab32:X11DRV_WTInfoW (0, 0, (nil)) trace:wintab32:X11DRV_WTInfoW 0 cursors trace:wintab32:WTInfoT returns 0 -- Configure bugmail: http://bugs.winehq.org/userprefs.cgi?tab=email Do not reply to this email, post in Bugzilla using the above URL to reply. ------- You are receiving this mail because: ------- You are watching all bug changes.
http://bugs.winehq.org/show_bug.cgi?id=12005 --- Comment #20 from John Klehm <xixsimplicityxix(a)gmail.com> 2008-05-06 13:53:15 --- (In reply to comment #19)
Running 0.9.61 and still no support with my wacom based tabletpc. Still reports the following
trace:wintab32:X11DRV_LoadTabletInfo Device 2: [id 2|name stylus|type Wacom Stylus|num_classes 3|use Unknown] trace:wintab32:X11DRV_LoadTabletInfo Device 3: [id 3|name cursor|type Wacom Cursor|num_classes 3|use Unknown]
KeithB what distro are you using and what tablet? The curious part of the logs is that the use is "Unknown". This should almost certainly be IsXExtensionDevice or IsXExtensionPointer. This makes me think that its not a wine problem but an x11 one. If you can pastebin the output of the following commands perhaps we can get to the bottom of this. $xsetpointer -l and $xidump -l If I had to guess it almost seems as if you dont have xorg-input-wacom or equivalent package installed. -- Configure bugmail: http://bugs.winehq.org/userprefs.cgi?tab=email Do not reply to this email, post in Bugzilla using the above URL to reply. ------- You are receiving this mail because: ------- You are watching all bug changes.
http://bugs.winehq.org/show_bug.cgi?id=12005 --- Comment #21 from Keith Brown <spamtrap(a)hellmark.org> 2008-05-06 16:00:42 --- Running a Sidux based Debian Sid install on a Fujitsu Lifebook T3010D wacom based tabletpc. The tablet functions work perfectly fine in native apps (use the pressure sensitivity in GIMP and Krita without a problem). The xserver-xorg-input-wacom package is installed. thellmark(a)primeshit:~$ xsetpointer -l 0: "Virtual core keyboard" [XKeyboard] 1: "Virtual core pointer" [XPointer] 2: "stylus" [XExtensionPointer] 3: "cursor" [XExtensionPointer] 4: "PS/2 Generic Mouse 0" [XExtensionPointer] 5: "Keyboard 0" [XExtensionKeyboard] hellmark(a)primeshit:~$ xidump -l Virtual core keyboard keyboard Virtual core pointer disabled stylus unknown cursor unknown PS/2 Generic Mouse 0 unknown Keyboard 0 unknown -- Configure bugmail: http://bugs.winehq.org/userprefs.cgi?tab=email Do not reply to this email, post in Bugzilla using the above URL to reply. ------- You are receiving this mail because: ------- You are watching all bug changes.
http://bugs.winehq.org/show_bug.cgi?id=12005 --- Comment #22 from V.platanias <azathothgr(a)gmail.com> 2008-05-06 18:36:35 --- Is it possible the order of the devices might affect detection ? -- Configure bugmail: http://bugs.winehq.org/userprefs.cgi?tab=email Do not reply to this email, post in Bugzilla using the above URL to reply. ------- You are receiving this mail because: ------- You are watching all bug changes.
http://bugs.winehq.org/show_bug.cgi?id=12005 --- Comment #23 from John Klehm <xixsimplicityxix(a)gmail.com> 2008-05-06 20:24:14 --- (In reply to comment #19)
Running 0.9.61 and still no support with my wacom based tabletpc. Still reports the following
trace:wintab32:WTInfoT (0, 0, (nil), 0) trace:wintab32:LoadTablet Initializing the tablet to hwnd 0x1002a trace:wintab32:X11DRV_LoadTabletInfo XListInputDevices reports 6 devices trace:wintab32:X11DRV_LoadTabletInfo Device 0: [id 0|name Virtual core keyboard|type |num_classes 1|use IsXKeyboard] trace:wintab32:X11DRV_LoadTabletInfo Device 1: [id 1|name Virtual core pointer|type |num_classes 2|use IsXPointer] trace:wintab32:X11DRV_LoadTabletInfo Device 2: [id 2|name stylus|type Wacom Stylus|num_classes 3|use Unknown] trace:wintab32:X11DRV_LoadTabletInfo Device 3: [id 3|name cursor|type Wacom Cursor|num_classes 3|use Unknown] trace:wintab32:X11DRV_LoadTabletInfo Device 4: [id 4|name PS/2 Generic Mouse 0|type MOUSE|num_classes 2|use Unknown] trace:wintab32:X11DRV_LoadTabletInfo Device 5: [id 5|name Keyboard 0|type KEYBOARD|num_classes 1|use Unknown] warn:wintab32:X11DRV_LoadTabletInfo Did not find a valid stylus cursor with >= 5 axes, returning 0 valid devices. trace:wintab32:X11DRV_WTInfoW (0, 0, (nil)) trace:wintab32:X11DRV_WTInfoW 0 cursors trace:wintab32:WTInfoT returns 0
@keithB Thanks for the dumps. Your X11 seems to be setup correctly. However after a little more digging I can only conclude that your wine install is out of sync with winehq 0.9.61. Your logs show a "use Unknown". While my patch attached to this bug kept this value in place above, Alexandre altered the code in mainline in order to accomodate older x servers. If you are using vanilla 9.61 its impossible to get "use Unknown" as all values after "use " will be digits now. Post the short device log like you have been from a vanilla 0.9.61 and I'll see if we can get a bit further. @everyone The only useful patch attached to this bug now is the "always check first 2 system cursor slots" patch. All the others have been committed as of 0.9.61 -- Configure bugmail: http://bugs.winehq.org/userprefs.cgi?tab=email Do not reply to this email, post in Bugzilla using the above URL to reply. ------- You are receiving this mail because: ------- You are watching all bug changes.
http://bugs.winehq.org/show_bug.cgi?id=12005 --- Comment #24 from Keith Brown <spamtrap(a)hellmark.org> 2008-05-06 22:21:40 --- Well, I've been using the default packages from Debian, which 0.9.61 is what they have available at the moment (and what is installed). I'll try and snag some other packages, or compile from source, sans the debian patches. -- Configure bugmail: http://bugs.winehq.org/userprefs.cgi?tab=email Do not reply to this email, post in Bugzilla using the above URL to reply. ------- You are receiving this mail because: ------- You are watching all bug changes.
http://bugs.winehq.org/show_bug.cgi?id=12005 Matt Helsley <mhelsley(a)linux.ucla.edu> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |mhelsley(a)linux.ucla.edu -- Configure bugmail: http://bugs.winehq.org/userprefs.cgi?tab=email Do not reply to this email, post in Bugzilla using the above URL to reply. ------- You are receiving this mail because: ------- You are watching all bug changes.
http://bugs.winehq.org/show_bug.cgi?id=12005 John Klehm <xixsimplicityxix(a)gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #12402|0 |1 is obsolete| | --- Comment #25 from John Klehm <xixsimplicityxix(a)gmail.com> 2008-05-14 04:03:04 --- Created an attachment (id=13046) --> (http://bugs.winehq.org/attachment.cgi?id=13046) Support wintab compatibility mode for less than 3 cursors This is the correct fix for the improper enumeration of cursors that I discovered before. We now avoid copying uninitialized data and will now always properly report the correct amount of cursors needed to make programs work. What we did before in the case of 1 cursor (wizard pen) was this. 1 cursor is detected and placed in system slot 0 and number of system cursors is 1. Older programs expect main cursor to be in system slot 1. So we swap slots 1 and 0. For wacom this is fine but for 1 cursor tablets this is not right as now we have uninitialized data in slot 0 (which is harmless in this case) and the actual data is out of range of the number of system cursors (gNumCursors) which is used to keep track of appropriate indexing of the system cursor slots. What we do now is clone a cursor instead of swap if there arent enough cursors to swap with and then increment gNumCursors to reflect the cloned data. This is a wintab facing modification so X11 behaviour should not be adversly affected. It should allow wintab apps to find single cursor tablets. Let me know how it goes :D -- Configure bugmail: http://bugs.winehq.org/userprefs.cgi?tab=email Do not reply to this email, post in Bugzilla using the above URL to reply. ------- You are receiving this mail because: ------- You are watching all bug changes.
http://bugs.winehq.org/show_bug.cgi?id=12005 --- Comment #26 from Dan Kegel <dank(a)kegel.com> 2008-05-14 17:23:27 --- Bingo. With a wizardpen and Photoshop 6, I see some pressure sensitivity. The sensitivity is off a bit; I have to press harder than on the gimp. But it's a start! -- Configure bugmail: http://bugs.winehq.org/userprefs.cgi?tab=email Do not reply to this email, post in Bugzilla using the above URL to reply. ------- You are receiving this mail because: ------- You are watching all bug changes.
http://bugs.winehq.org/show_bug.cgi?id=12005 --- Comment #27 from Keith Brown <spamtrap(a)hellmark.org> 2008-05-15 18:04:28 --- After taking a look at the patch, I think part of my problem may lie in the fact that my tabletpc, despite being wacom based, does not have an eraser. I'll take a stab at things and report back. -- Configure bugmail: http://bugs.winehq.org/userprefs.cgi?tab=email Do not reply to this email, post in Bugzilla using the above URL to reply. ------- You are receiving this mail because: ------- You are watching all bug changes.
http://bugs.winehq.org/show_bug.cgi?id=12005 --- Comment #28 from John Klehm <xixsimplicityxix(a)gmail.com> 2008-05-16 00:54:33 --- (In reply to comment #27)
After taking a look at the patch, I think part of my problem may lie in the fact that my tabletpc, despite being wacom based, does not have an eraser.
I'll take a stab at things and report back.
Keith since your problem hasn't resolved yet would you mind filing a new bug for it? It'll be easier to close this one(wizard pen pressure) if we are solving your problem in another bug. -- Configure bugmail: http://bugs.winehq.org/userprefs.cgi?tab=email Do not reply to this email, post in Bugzilla using the above URL to reply. ------- You are receiving this mail because: ------- You are watching all bug changes.
http://bugs.winehq.org/show_bug.cgi?id=12005 John Klehm <xixsimplicityxix(a)gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #12232|0 |1 is obsolete| | -- Configure bugmail: http://bugs.winehq.org/userprefs.cgi?tab=email Do not reply to this email, post in Bugzilla using the above URL to reply. ------- You are receiving this mail because: ------- You are watching all bug changes.
http://bugs.winehq.org/show_bug.cgi?id=12005 John Klehm <xixsimplicityxix(a)gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #12266|0 |1 is obsolete| | -- Configure bugmail: http://bugs.winehq.org/userprefs.cgi?tab=email Do not reply to this email, post in Bugzilla using the above URL to reply. ------- You are receiving this mail because: ------- You are watching all bug changes.
http://bugs.winehq.org/show_bug.cgi?id=12005 John Klehm <xixsimplicityxix(a)gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #12403|0 |1 is obsolete| | -- Configure bugmail: http://bugs.winehq.org/userprefs.cgi?tab=email Do not reply to this email, post in Bugzilla using the above URL to reply. ------- You are receiving this mail because: ------- You are watching all bug changes.
http://bugs.winehq.org/show_bug.cgi?id=12005 shakaran <shakaran(a)gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |shakaran(a)gmail.com -- Configure bugmail: http://bugs.winehq.org/userprefs.cgi?tab=email Do not reply to this email, post in Bugzilla using the above URL to reply. ------- You are receiving this mail because: ------- You are watching all bug changes.
http://bugs.winehq.org/show_bug.cgi?id=12005 John Klehm <xixsimplicityxix(a)gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #13046|0 |1 is obsolete| | --- Comment #29 from John Klehm <xixsimplicityxix(a)gmail.com> 2008-05-21 23:35:50 --- Created an attachment (id=13231) --> (http://bugs.winehq.org/attachment.cgi?id=13231) Properly slot the cursors from the get go, no more compat hacks needed This patch appropriately slots the detected tablet cursors as it finds them. It actually simplifies the code overall. I added a ton of comments though so the insertions are still about on par with deletions. Shouldn't really be any difference between this an the support wintab compat mode for less than 3 patch, just that this is a much more clean and maintainable way in the code. That's not to say their wont be though, as this way there isn't any duplicated data. There is one thing left to do regarding cursors in wintab and that is to make the system cursor slots use dynamic memory instead of a static array. After this patch anyone with more than 4 reg tablets/2 multimode(dual-tracking) tablets connected at once may have problems. I thought that it would be rare anyone would have more tablets than that so let me know if I'm wrong. Without this patch 3 reg tablets/1 multimode tablet are fully supported. -- Configure bugmail: http://bugs.winehq.org/userprefs.cgi?tab=email Do not reply to this email, post in Bugzilla using the above URL to reply. ------- You are receiving this mail because: ------- You are watching all bug changes.
http://bugs.winehq.org/show_bug.cgi?id=12005 --- Comment #30 from John Klehm <xixsimplicityxix(a)gmail.com> 2008-05-21 23:41:28 --- (In reply to comment #29)
After this patch anyone with more than 4 reg tablets/2 multimode(dual-tracking) tablets connected at once may have problems. I thought that it would be rare anyone would have more tablets than that so let me know if I'm wrong. Without this patch 3 reg tablets/1 multimode tablet are fully supported.
Erm that is to say support in mainline wine is for 3 reg tablets/1 multimode with this patch support is increased to 4 reg tablets/2 multimode. Cursor detection is better with this patch than mainline as well. -- Configure bugmail: http://bugs.winehq.org/userprefs.cgi?tab=email Do not reply to this email, post in Bugzilla using the above URL to reply. ------- You are receiving this mail because: ------- You are watching all bug changes.
http://bugs.winehq.org/show_bug.cgi?id=12005 John Klehm <xixsimplicityxix(a)gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #13231|0 |1 is obsolete| | --- Comment #31 from John Klehm <xixsimplicityxix(a)gmail.com> 2008-05-26 02:10:27 --- Created an attachment (id=13346) --> (http://bugs.winehq.org/attachment.cgi?id=13346) Place the tablet curosrs in proper slots based on type This is an updated patch which is exactly the same as the previous version except that it will now apply cleanly in git 1.5.4.3 and 1.5.5.1. So if anyone couldn't apply the patch before give this new one a try. -- Configure bugmail: http://bugs.winehq.org/userprefs.cgi?tab=email Do not reply to this email, post in Bugzilla using the above URL to reply. ------- You are receiving this mail because: ------- You are watching all bug changes.
http://bugs.winehq.org/show_bug.cgi?id=12005 Stefan Dösinger <stefandoesinger(a)gmx.at> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |wine-bugs(a)winehq.org AssignedTo|wine-bugs(a)winehq.org |xixsimplicityxix(a)gmail.com --- Comment #32 from Stefan Dösinger <stefandoesinger(a)gmx.at> 2008-05-26 13:48:48 --- xixsimplicityxix(a)gmail.com asked me to assign the bug to him -- Configure bugmail: http://bugs.winehq.org/userprefs.cgi?tab=email Do not reply to this email, post in Bugzilla using the above URL to reply. ------- You are receiving this mail because: ------- You are watching all bug changes.
http://bugs.winehq.org/show_bug.cgi?id=12005 Dan Kegel <dank(a)kegel.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Target Milestone|1.0.0 |1.2.0 --- Comment #33 from Dan Kegel <dank(a)kegel.com> 2008-06-06 09:11:22 --- Wine 1.0 is in deep code freeze. Deferring to 1.2. (Though it'll probably be fixed pretty quickly once the trunk comes out of code freeze.) -- Configure bugmail: http://bugs.winehq.org/userprefs.cgi?tab=email Do not reply to this email, post in Bugzilla using the above URL to reply. ------- You are receiving this mail because: ------- You are watching all bug changes.
http://bugs.winehq.org/show_bug.cgi?id=12005 --- Comment #34 from John Klehm <xixsimplicityxix(a)gmail.com> 2008-06-06 17:18:30 --- It sure will, I spoke with AJ about this series http://winehq.org/pipermail/wine-patches/2008-May/055426.html I sent in which is a more pieced out version of the patch here. He told me it was too big for 1.0. So soon as we're out of freeze I'll drop it in again. -- Configure bugmail: http://bugs.winehq.org/userprefs.cgi?tab=email Do not reply to this email, post in Bugzilla using the above URL to reply. ------- You are receiving this mail because: ------- You are watching all bug changes.
http://bugs.winehq.org/show_bug.cgi?id=12005 John Klehm <xixsimplicityxix(a)gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |RESOLVED Resolution| |FIXED --- Comment #35 from John Klehm <xixsimplicityxix(a)gmail.com> 2008-06-20 11:59:33 --- Committed today: http://source.winehq.org/git/wine.git/?a=commit;h=70cf762d31ac76c2b6b8cdd99e... -- Configure bugmail: http://bugs.winehq.org/userprefs.cgi?tab=email Do not reply to this email, post in Bugzilla using the above URL to reply. ------- You are receiving this mail because: ------- You are watching all bug changes.
http://bugs.winehq.org/show_bug.cgi?id=12005 John Klehm <xixsimplicityxix(a)gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |RESOLVED Resolution| |FIXED Alexandre Julliard <julliard(a)winehq.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Target Milestone|1.2.0 |1.0.1 --- Comment #35 from John Klehm <xixsimplicityxix(a)gmail.com> 2008-06-20 11:59:33 --- Committed today: http://source.winehq.org/git/wine.git/?a=commit;h=70cf762d31ac76c2b6b8cdd99e... --- Comment #36 from Alexandre Julliard <julliard(a)winehq.org> 2008-06-27 09:12:37 --- To consider for 1.0.1. -- Configure bugmail: http://bugs.winehq.org/userprefs.cgi?tab=email Do not reply to this email, post in Bugzilla using the above URL to reply. ------- You are receiving this mail because: ------- You are watching all bug changes.
http://bugs.winehq.org/show_bug.cgi?id=12005 Alexandre Julliard <julliard(a)winehq.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|RESOLVED |CLOSED --- Comment #37 from Alexandre Julliard <julliard(a)winehq.org> 2008-06-27 09:58:48 --- Closing bugs fixed in 1.1.0. -- Configure bugmail: http://bugs.winehq.org/userprefs.cgi?tab=email Do not reply to this email, post in Bugzilla using the above URL to reply. ------- You are receiving this mail because: ------- You are watching all bug changes.
participants (1)
-
wine-bugs＠winehq.org