[Bug 19050] New: PE explorer shows access violations when started
http://bugs.winehq.org/show_bug.cgi?id=19050 Summary: PE explorer shows access violations when started Product: Wine Version: 1.1.24 Platform: PC-x86-64 URL: http://www.heaventools.com/download/pexsetup.exe OS/Version: Linux Status: UNCONFIRMED Severity: normal Priority: P2 Component: -unknown AssignedTo: wine-bugs(a)winehq.org ReportedBy: Paul.Vriens.Wine(a)gmail.com CC: bunglehead(a)gmail.com Installation went fine but running doesn't. Regression testing shows: 34b802caf088e526eadc23d785582e81ea5374cd is first bad commit commit 34b802caf088e526eadc23d785582e81ea5374cd Author: Nikolay Sivov <bunglehead(a)gmail.com> Date: Tue Jun 16 01:46:11 2009 +0400 comctl32/listview: Convert forwarded header notifications to ANSI if NFR_ANSI is current format. :040000 040000 7f9c298690cfa7c63010737878cb6da45dd570b4 a6e1736d290092b6d8c8862160775fd9237cd520 M dlls -- Configure bugmail: http://bugs.winehq.org/userprefs.cgi?tab=email Do not reply to this email, post in Bugzilla using the above URL to reply. ------- You are receiving this mail because: ------- You are watching all bug changes.
http://bugs.winehq.org/show_bug.cgi?id=19050 Paul Vriens <Paul.Vriens.Wine(a)gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Keywords| |regression -- Configure bugmail: http://bugs.winehq.org/userprefs.cgi?tab=email Do not reply to this email, post in Bugzilla using the above URL to reply. ------- You are receiving this mail because: ------- You are watching all bug changes.
http://bugs.winehq.org/show_bug.cgi?id=19050 --- Comment #1 from Nikolay Sivov <bunglehead(a)gmail.com> 2009-06-23 10:05:08 --- Hi, Paul. Does reverting help? -- Configure bugmail: http://bugs.winehq.org/userprefs.cgi?tab=email Do not reply to this email, post in Bugzilla using the above URL to reply. ------- You are receiving this mail because: ------- You are watching all bug changes.
http://bugs.winehq.org/show_bug.cgi?id=19050 --- Comment #2 from Paul Vriens <Paul.Vriens.Wine(a)gmail.com> 2009-06-23 10:32:38 --- Yes, reverting fixes the issue. -- Configure bugmail: http://bugs.winehq.org/userprefs.cgi?tab=email Do not reply to this email, post in Bugzilla using the above URL to reply. ------- You are receiving this mail because: ------- You are watching all bug changes.
http://bugs.winehq.org/show_bug.cgi?id=19050 Ken Sharp <kennybobs(a)o2.co.uk> changed: What |Removed |Added ---------------------------------------------------------------------------- Keywords| |download -- Configure bugmail: http://bugs.winehq.org/userprefs.cgi?tab=email Do not reply to this email, post in Bugzilla using the above URL to reply. ------- You are receiving this mail because: ------- You are watching all bug changes.
http://bugs.winehq.org/show_bug.cgi?id=19050 Austin English <austinenglish(a)gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |austinenglish(a)gmail.com -- Configure bugmail: http://bugs.winehq.org/userprefs.cgi?tab=email Do not reply to this email, post in Bugzilla using the above URL to reply. ------- You are receiving this mail because: ------- You are watching all bug changes.
http://bugs.winehq.org/show_bug.cgi?id=19050 --- Comment #3 from Paul Vriens <Paul.Vriens.Wine(a)gmail.com> 2009-06-23 12:25:14 --- If I change the code in listview.c like this: 780 /* cleanup */ 781 //Free(text); 782 Free(filter); I don't see these access violations anymore. Hope that helps. -- Configure bugmail: http://bugs.winehq.org/userprefs.cgi?tab=email Do not reply to this email, post in Bugzilla using the above URL to reply. ------- You are receiving this mail because: ------- You are watching all bug changes.
http://bugs.winehq.org/show_bug.cgi?id=19050 --- Comment #4 from Paul Vriens <Paul.Vriens.Wine(a)gmail.com> 2009-06-23 12:38:49 --- The Free()'s are suspicious when looking at Str_SetPtrWtoA. -- Configure bugmail: http://bugs.winehq.org/userprefs.cgi?tab=email Do not reply to this email, post in Bugzilla using the above URL to reply. ------- You are receiving this mail because: ------- You are watching all bug changes.
http://bugs.winehq.org/show_bug.cgi?id=19050 --- Comment #5 from Nikolay Sivov <bunglehead(a)gmail.com> 2009-06-23 12:41:48 --- (In reply to comment #4)
The Free()'s are suspicious when looking at Str_SetPtrWtoA.
Yeah, I'm looking at it now. I have to check Str_SetPtrWtoA cause in case of empty string I'll probably got garbage in 'text'. I'll send a patch here to test. -- Configure bugmail: http://bugs.winehq.org/userprefs.cgi?tab=email Do not reply to this email, post in Bugzilla using the above URL to reply. ------- You are receiving this mail because: ------- You are watching all bug changes.
http://bugs.winehq.org/show_bug.cgi?id=19050 --- Comment #6 from Paul Vriens <Paul.Vriens.Wine(a)gmail.com> 2009-06-23 12:43:07 --- I guess we should leave the freeing to the caller. -- Configure bugmail: http://bugs.winehq.org/userprefs.cgi?tab=email Do not reply to this email, post in Bugzilla using the above URL to reply. ------- You are receiving this mail because: ------- You are watching all bug changes.
http://bugs.winehq.org/show_bug.cgi?id=19050 --- Comment #7 from Nikolay Sivov <bunglehead(a)gmail.com> 2009-06-23 12:46:53 --- (In reply to comment #6)
I guess we should leave the freeing to the caller.
What do you mean? Notification means only local pointer to be sent to target window. -- Configure bugmail: http://bugs.winehq.org/userprefs.cgi?tab=email Do not reply to this email, post in Bugzilla using the above URL to reply. ------- You are receiving this mail because: ------- You are watching all bug changes.
http://bugs.winehq.org/show_bug.cgi?id=19050 --- Comment #8 from Paul Vriens <Paul.Vriens.Wine(a)gmail.com> 2009-06-23 12:48:54 --- But who is responsible for allocating that text in lpnmh->pitem->pszText? -- Configure bugmail: http://bugs.winehq.org/userprefs.cgi?tab=email Do not reply to this email, post in Bugzilla using the above URL to reply. ------- You are receiving this mail because: ------- You are watching all bug changes.
http://bugs.winehq.org/show_bug.cgi?id=19050 --- Comment #9 from Nikolay Sivov <bunglehead(a)gmail.com> 2009-06-23 12:53:33 --- (In reply to comment #8)
But who is responsible for allocating that text in lpnmh->pitem->pszText?
Header control when notifying its Listview parent. I don't touch it, just convert to another buffer, for which Free() fails now. -- Configure bugmail: http://bugs.winehq.org/userprefs.cgi?tab=email Do not reply to this email, post in Bugzilla using the above URL to reply. ------- You are receiving this mail because: ------- You are watching all bug changes.
http://bugs.winehq.org/show_bug.cgi?id=19050 --- Comment #10 from Nikolay Sivov <bunglehead(a)gmail.com> 2009-06-23 13:01:09 --- Created an attachment (id=21980) --> (http://bugs.winehq.org/attachment.cgi?id=21980) Init destination pointers Paul, try this please. I hope it'll help. -- Configure bugmail: http://bugs.winehq.org/userprefs.cgi?tab=email Do not reply to this email, post in Bugzilla using the above URL to reply. ------- You are receiving this mail because: ------- You are watching all bug changes.
http://bugs.winehq.org/show_bug.cgi?id=19050 --- Comment #11 from Paul Vriens <Paul.Vriens.Wine(a)gmail.com> 2009-06-23 13:27:07 --- No more access violations and the app works. -- Configure bugmail: http://bugs.winehq.org/userprefs.cgi?tab=email Do not reply to this email, post in Bugzilla using the above URL to reply. ------- You are receiving this mail because: ------- You are watching all bug changes.
http://bugs.winehq.org/show_bug.cgi?id=19050 --- Comment #12 from Nikolay Sivov <bunglehead(a)gmail.com> 2009-06-23 13:29:27 --- (In reply to comment #11)
No more access violations and the app works.
Ok, I just checked another occurrences of Str_SetPtrWtoA in such initialization present here. Will send a patch to list, thanks for testing. -- Configure bugmail: http://bugs.winehq.org/userprefs.cgi?tab=email Do not reply to this email, post in Bugzilla using the above URL to reply. ------- You are receiving this mail because: ------- You are watching all bug changes.
http://bugs.winehq.org/show_bug.cgi?id=19050 --- Comment #13 from Austin English <austinenglish(a)gmail.com> 2009-06-23 21:28:27 --- (In reply to comment #12)
(In reply to comment #11)
No more access violations and the app works.
Ok, I just checked another occurrences of Str_SetPtrWtoA in such initialization present here.
Will send a patch to list, thanks for testing.
I still get an access violation on start and on close, but the app seems to work a bit better. -- Configure bugmail: http://bugs.winehq.org/userprefs.cgi?tab=email Do not reply to this email, post in Bugzilla using the above URL to reply. ------- You are receiving this mail because: ------- You are watching all bug changes.
http://bugs.winehq.org/show_bug.cgi?id=19050 --- Comment #14 from Austin English <austinenglish(a)gmail.com> 2009-06-23 21:56:50 --- (In reply to comment #13)
(In reply to comment #12)
(In reply to comment #11)
No more access violations and the app works.
Ok, I just checked another occurrences of Str_SetPtrWtoA in such initialization present here.
Will send a patch to list, thanks for testing.
I still get an access violation on start and on close, but the app seems to work a bit better.
Hmm, running with +listview makes the problem go away... -- Configure bugmail: http://bugs.winehq.org/userprefs.cgi?tab=email Do not reply to this email, post in Bugzilla using the above URL to reply. ------- You are receiving this mail because: ------- You are watching all bug changes.
http://bugs.winehq.org/show_bug.cgi?id=19050 --- Comment #15 from Paul Vriens <Paul.Vriens.Wine(a)gmail.com> 2009-06-24 00:58:19 --- No access violations here, regardless of +listview or not. -- Configure bugmail: http://bugs.winehq.org/userprefs.cgi?tab=email Do not reply to this email, post in Bugzilla using the above URL to reply. ------- You are receiving this mail because: ------- You are watching all bug changes.
http://bugs.winehq.org/show_bug.cgi?id=19050 --- Comment #16 from Nikolay Sivov <bunglehead(a)gmail.com> 2009-06-24 04:09:42 --- (In reply to comment #13)
(In reply to comment #12)
Will send a patch to list, thanks for testing.
I still get an access violation on start and on close, but the app seems to work a bit better.
I don't have any problems on start even without patch. Only place I used for testing was preferences dialog. (In reply to comment #15)
No access violations here, regardless of +listview or not.
Same here. -- Configure bugmail: http://bugs.winehq.org/userprefs.cgi?tab=email Do not reply to this email, post in Bugzilla using the above URL to reply. ------- You are receiving this mail because: ------- You are watching all bug changes.
http://bugs.winehq.org/show_bug.cgi?id=19050 Nikolay Sivov <bunglehead(a)gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |jose1711(a)gmail.com --- Comment #17 from Nikolay Sivov <bunglehead(a)gmail.com> 2009-06-24 04:12:56 --- *** Bug 19054 has been marked as a duplicate of this bug. *** -- Configure bugmail: http://bugs.winehq.org/userprefs.cgi?tab=email Do not reply to this email, post in Bugzilla using the above URL to reply. ------- You are receiving this mail because: ------- You are watching all bug changes.
http://bugs.winehq.org/show_bug.cgi?id=19050 Nikolay Sivov <bunglehead(a)gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Component|-unknown |comctl32 --- Comment #18 from Nikolay Sivov <bunglehead(a)gmail.com> 2009-06-24 09:36:58 --- Should be fixed by: http://source.winehq.org/git/wine.git/?a=commit;h=2551ea05681ba89acc011f52ef... -- Configure bugmail: http://bugs.winehq.org/userprefs.cgi?tab=email Do not reply to this email, post in Bugzilla using the above URL to reply. ------- You are receiving this mail because: ------- You are watching all bug changes.
http://bugs.winehq.org/show_bug.cgi?id=19050 Austin English <austinenglish(a)gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|UNCONFIRMED |RESOLVED Resolution| |FIXED --- Comment #19 from Austin English <austinenglish(a)gmail.com> 2009-06-24 22:14:26 --- Hmm, I must be crazy. Works fine today with that patch... -- Configure bugmail: http://bugs.winehq.org/userprefs.cgi?tab=email Do not reply to this email, post in Bugzilla using the above URL to reply. ------- You are receiving this mail because: ------- You are watching all bug changes.
http://bugs.winehq.org/show_bug.cgi?id=19050 Austin English <austinenglish(a)gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|RESOLVED |UNCONFIRMED Resolution|FIXED | --- Comment #20 from Austin English <austinenglish(a)gmail.com> 2009-06-25 23:04:12 --- Spoke too soon. There's a race condition of some sort. Exact error: Access violation at address 00000020 in module 'pexplorer.exe'. Write of address 00000020. I was working on an appinstall test for it, sometimes, it would work fine, but while writing/testing other parts of the test it would reappear. I managed to get a +listview trace when it happened (attaching). Nikolay, could you take a look? I can send you the ahk test if you'd like... -- Configure bugmail: http://bugs.winehq.org/userprefs.cgi?tab=email Do not reply to this email, post in Bugzilla using the above URL to reply. ------- You are receiving this mail because: ------- You are watching all bug changes.
http://bugs.winehq.org/show_bug.cgi?id=19050 --- Comment #21 from Austin English <austinenglish(a)gmail.com> 2009-06-25 23:06:07 --- Created an attachment (id=22025) --> (http://bugs.winehq.org/attachment.cgi?id=22025) +listview -- Configure bugmail: http://bugs.winehq.org/userprefs.cgi?tab=email Do not reply to this email, post in Bugzilla using the above URL to reply. ------- You are receiving this mail because: ------- You are watching all bug changes.
http://bugs.winehq.org/show_bug.cgi?id=19050 --- Comment #22 from Nikolay Sivov <bunglehead(a)gmail.com> 2009-06-26 04:25:22 --- (In reply to comment #21)
Created an attachment (id=22025) --> (http://bugs.winehq.org/attachment.cgi?id=22025) [details] +listview
Hi, Austin. I don't see any problems in this log. What make think this is Listview problem? And does native module make problem disappear? -- Configure bugmail: http://bugs.winehq.org/userprefs.cgi?tab=email Do not reply to this email, post in Bugzilla using the above URL to reply. ------- You are receiving this mail because: ------- You are watching all bug changes.
http://bugs.winehq.org/show_bug.cgi?id=19050 --- Comment #23 from Austin English <austinenglish(a)gmail.com> 2009-06-26 19:38:39 --- (In reply to comment #22)
(In reply to comment #21)
Created an attachment (id=22025) --> (http://bugs.winehq.org/attachment.cgi?id=22025) [details] [details] +listview
Hi, Austin.
I don't see any problems in this log. What make think this is Listview problem? And does native module make problem disappear?
Hmm, you're right. Native comctl32 doesn't seem to help....the address has changed today from 00000020 to 00000000 though, fwiw... -- Configure bugmail: http://bugs.winehq.org/userprefs.cgi?tab=email Do not reply to this email, post in Bugzilla using the above URL to reply. ------- You are receiving this mail because: ------- You are watching all bug changes.
http://bugs.winehq.org/show_bug.cgi?id=19050 Austin English <austinenglish(a)gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|UNCONFIRMED |RESOLVED Resolution| |FIXED --- Comment #24 from Austin English <austinenglish(a)gmail.com> 2009-06-26 20:51:56 --- I'm going to file a new bug. Working with Nikolay, we've found this only occurs when running under AutoHotKey (not sure why though...). -- Configure bugmail: http://bugs.winehq.org/userprefs.cgi?tab=email Do not reply to this email, post in Bugzilla using the above URL to reply. ------- You are receiving this mail because: ------- You are watching all bug changes.
http://bugs.winehq.org/show_bug.cgi?id=19050 Nikolay Sivov <bunglehead(a)gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |jdoutt(a)whoi.edu --- Comment #25 from Nikolay Sivov <bunglehead(a)gmail.com> 2009-06-30 10:33:35 --- *** Bug 19130 has been marked as a duplicate of this bug. *** -- Configure bugmail: http://bugs.winehq.org/userprefs.cgi?tab=email Do not reply to this email, post in Bugzilla using the above URL to reply. ------- You are receiving this mail because: ------- You are watching all bug changes.
http://bugs.winehq.org/show_bug.cgi?id=19050 Nikolay Sivov <bunglehead(a)gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |wine(a)tehk.org --- Comment #26 from Nikolay Sivov <bunglehead(a)gmail.com> 2009-06-30 12:44:54 --- *** Bug 19109 has been marked as a duplicate of this bug. *** -- Configure bugmail: http://bugs.winehq.org/userprefs.cgi?tab=email Do not reply to this email, post in Bugzilla using the above URL to reply. ------- You are receiving this mail because: ------- You are watching all bug changes.
http://bugs.winehq.org/show_bug.cgi?id=19050 Alexandre Julliard <julliard(a)winehq.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|RESOLVED |CLOSED --- Comment #27 from Alexandre Julliard <julliard(a)winehq.org> 2009-07-03 12:28:14 --- Closing bugs fixed in 1.1.25. -- Configure bugmail: http://bugs.winehq.org/userprefs.cgi?tab=email Do not reply to this email, post in Bugzilla using the above URL to reply. ------- You are receiving this mail because: ------- You are watching all bug changes.
http://bugs.winehq.org/show_bug.cgi?id=19050 Nikolay Sivov <bunglehead(a)gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Fixed by SHA1| |2551ea05681ba89acc011f52efd | |dd361a25d3d76 Regression SHA1| |34b802caf088e526eadc23d7855 | |82e81ea5374cd -- Configure bugmail: http://bugs.winehq.org/userprefs.cgi?tab=email Do not reply to this email, post in Bugzilla using the above URL to reply. ------- You are receiving this mail because: ------- You are watching all bug changes.
participants (1)
-
wine-bugs＠winehq.org