[Bug 40312] New: Please look for builtin *.fon fonts in fontdir
https://bugs.winehq.org/show_bug.cgi?id=40312 Bug ID: 40312 Summary: Please look for builtin *.fon fonts in fontdir Product: Wine Version: 1.9.4 Hardware: x86 OS: Linux Status: UNCONFIRMED Severity: normal Priority: P2 Component: gdi32 Assignee: wine-bugs(a)winehq.org Reporter: jre.winesim(a)gmail.com Distribution: --- Created attachment 53956 --> https://bugs.winehq.org/attachment.cgi?id=53956 Workaround for dlls/gdi32/freetype.c Hi, in Makefile.in Wine sets fontdir = ${datadir}/wine/fonts. But changing this value seems to have no effect. At least dlls/gdi32/freetype.c looks for the built-in Wine *.fon fonts in ${datadir}/wine/fonts. So it doesn't find them if they are in a changed $fontdir. I suggest to first check fontdir explicitly, before falling back to the default value. Background: In Debian we ship both the stable and the development version of wine (wine and wine-development). These are installed in different subfolders, e.g. /usr/share/wine and /usr/share/wine-development (where wine and wine-development are part of datadir, and "wine/" is stripped from the variable value). So vanilla wine has: datadir=/usr/share fontdir=${datadir}/wine/fonts But Debian has (simplified example): datadir=/usr/share/wine[-development] fontdir=${datadir}/fonts Further we'd like to use the same fonts folder for both wine and wine-development: fontdir=/usr/share/wine/fonts I attached my primitive workaround to get this working (obviously this is not a patch for Wine). -- Do not reply to this email, post in Bugzilla using the above URL to reply. You are receiving this mail because: You are watching all bug changes.
https://bugs.winehq.org/show_bug.cgi?id=40312 Jens Reyer <jre.winesim(a)gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- URL| |https://bugs.debian.org/814 | |844 CC| |jre.winesim(a)gmail.com -- Do not reply to this email, post in Bugzilla using the above URL to reply. You are receiving this mail because: You are watching all bug changes.
https://bugs.winehq.org/show_bug.cgi?id=40312 --- Comment #1 from Alexandre Julliard <julliard(a)winehq.org> --- (In reply to Jens Reyer from comment #0)
Further we'd like to use the same fonts folder for both wine and wine-development: fontdir=/usr/share/wine/fonts
Why do you want that? What happens if the fonts differ between versions? Which one do you use? -- Do not reply to this email, post in Bugzilla using the above URL to reply. You are receiving this mail because: You are watching all bug changes.
https://bugs.winehq.org/show_bug.cgi?id=40312 --- Comment #2 from Jens Reyer <jre.winesim(a)gmail.com> --- (In reply to Alexandre Julliard from comment #1)
(In reply to Jens Reyer from comment #0)
Further we'd like to use the same fonts folder for both wine and wine-development: fontdir=/usr/share/wine/fonts
Why do you want that?
We'd like to avoid a duplicate installation of the Wine fonts.
What happens if the fonts differ between versions? Which one do you use?
Currently we only provide the fonts of wine (stable), and recommend [1] to install them for both wine and wine-development. Currently the fonts don't differ, and between 1.6 and 1.8 there weren't many changes in over 2 years. Given the shorter release cycle now, I currently expect that we can stick with that. Future plans haven't been discussed. But imo if things change noticeably we should revert to separate packages. Smaller changes may be ignored, or backported to stable wine. [1] Recommended packages are installed per default, but aren't mandatory. I'm definitely interested in any feedback about this, thanks! However even without our de-duplication goal, I'd hope for Wine to use existing variables like fontdir directly, instead of relying on their default values. Greets jre -- Do not reply to this email, post in Bugzilla using the above URL to reply. You are receiving this mail because: You are watching all bug changes.
https://bugs.winehq.org/show_bug.cgi?id=40312 --- Comment #3 from Alexandre Julliard <julliard(a)winehq.org> --- (In reply to Jens Reyer from comment #2)
(In reply to Alexandre Julliard from comment #1)
What happens if the fonts differ between versions? Which one do you use?
Currently we only provide the fonts of wine (stable), and recommend [1] to install them for both wine and wine-development.
This seems a little risky. There have been times where we added glyphs to be used for window decorations etc., so wine-development with stable fonts is not guaranteed to work.
I'm definitely interested in any feedback about this, thanks! However even without our de-duplication goal, I'd hope for Wine to use existing variables like fontdir directly, instead of relying on their default values.
Sure. -- Do not reply to this email, post in Bugzilla using the above URL to reply. You are receiving this mail because: You are watching all bug changes.
https://bugs.winehq.org/show_bug.cgi?id=40312 Alexandre Julliard <julliard(a)winehq.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Fixed by SHA1| |1eac54ef7d6d90fcc973c5ea92a | |53be73f61ff12. Status|UNCONFIRMED |RESOLVED Resolution|--- |FIXED --- Comment #4 from Alexandre Julliard <julliard(a)winehq.org> --- It should be fixed by 1eac54ef7d6d90fcc973c5ea92a53be73f61ff12. -- Do not reply to this email, post in Bugzilla using the above URL to reply. You are receiving this mail because: You are watching all bug changes.
https://bugs.winehq.org/show_bug.cgi?id=40312 Alexandre Julliard <julliard(a)winehq.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|RESOLVED |CLOSED --- Comment #5 from Alexandre Julliard <julliard(a)winehq.org> --- Closing bugs fixed in 1.9.6. -- Do not reply to this email, post in Bugzilla using the above URL to reply. You are receiving this mail because: You are watching all bug changes.
https://bugs.winehq.org/show_bug.cgi?id=40312 --- Comment #6 from Jens Reyer <jre.winesim(a)gmail.com> --- (In reply to Alexandre Julliard from comment #4)
It should be fixed by 1eac54ef7d6d90fcc973c5ea92a53be73f61ff12.
Works in Wine 1.9.6, thanks a lot! Cherry-picking that commit to stable (1.8.1) also works. -- Do not reply to this email, post in Bugzilla using the above URL to reply. You are receiving this mail because: You are watching all bug changes.
https://bugs.winehq.org/show_bug.cgi?id=40312 Michael Stefaniuc <mstefani(a)redhat.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Fixed by SHA1|1eac54ef7d6d90fcc973c5ea92a |1eac54ef7d6d90fcc973c5ea92a |53be73f61ff12. |53be73f61ff12 CC| |mstefani(a)redhat.com -- Do not reply to this email, post in Bugzilla using the above URL to reply. You are receiving this mail because: You are watching all bug changes.
participants (1)
-
wine-bugs＠winehq.org