[Bug 35948] New: Starcraft Campaign Editor displays incorrect numeric values when editing triggers
http://bugs.winehq.org/show_bug.cgi?id=35948 Bug ID: 35948 Summary: Starcraft Campaign Editor displays incorrect numeric values when editing triggers Product: Wine Version: 1.7.16 Hardware: x86 OS: Linux Status: UNCONFIRMED Severity: normal Priority: P2 Component: richedit Assignee: wine-bugs(a)winehq.org Reporter: alexhenrie24(a)gmail.com Created attachment 48014 --> http://bugs.winehq.org/attachment.cgi?id=48014 trace+richedit To reproduce, open the Campaign Editor, click Scenario, click Triggers, double-click "Current player commands at most 0 buildings", click Conditions, double-click "Current player commands at most 0 buildings", click "at most 0", change the value 0 to 5, and click OK. The condition will now erroneously read "Current player commands at most 50 buildings" instead of "Current player commands at most 5 buildings". There is actually a second bug here: the "0" in "at most 0" is clickable on Windows, but it is not in Wine. In Wine, only the "at most " is clickable. "winetricks dlls riched20" fixes these problems. -- Do not reply to this email, post in Bugzilla using the above URL to reply. You are receiving this mail because: You are watching all bug changes.
http://bugs.winehq.org/show_bug.cgi?id=35948 --- Comment #1 from Alex Henrie <alexhenrie24(a)gmail.com> --- Created attachment 48015 --> http://bugs.winehq.org/attachment.cgi?id=48015 Hack to make the Campaign Editor work Both aspects of this bug have something to do with RichEdit paragraph wrapping: Without paragraph wrapping, the bug disappears. -- Do not reply to this email, post in Bugzilla using the above URL to reply. You are receiving this mail because: You are watching all bug changes.
http://bugs.winehq.org/show_bug.cgi?id=35948 Alex Henrie <alexhenrie24(a)gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |alexhenrie24(a)gmail.com, | |dylan.ah.smith(a)gmail.com, | |eric.pouech(a)orange.fr, | |huw(a)codeweavers.com, | |wdev(a)foltman.com --- Comment #2 from Alex Henrie <alexhenrie24(a)gmail.com> --- Because dlls/riched20/wrap.c contains the comment "RichEdit - Paragraph wrapping. Don't try to understand it. You've been warned !" I am cc'ing the major contributors to that file. -- Do not reply to this email, post in Bugzilla using the above URL to reply. You are receiving this mail because: You are watching all bug changes.
http://bugs.winehq.org/show_bug.cgi?id=35948 Jactry Zeng <jactry92(a)gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |jactry92(a)gmail.com -- Do not reply to this email, post in Bugzilla using the above URL to reply. You are receiving this mail because: You are watching all bug changes.
http://bugs.winehq.org/show_bug.cgi?id=35948 Alex Henrie <alexhenrie24(a)gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #48015|0 |1 is obsolete| | --- Comment #3 from Alex Henrie <alexhenrie24(a)gmail.com> --- Created attachment 48711 --> http://bugs.winehq.org/attachment.cgi?id=48711 Proposed patch MSDN suggests calling ScriptIsComplex to determine whether or not complex script processing is actually required before calling ScriptItemize.[1] I think that's exactly what we should do here. Forget what I said earlier about paragraph wrapping--this bug is caused by unnecessary Uniscribe processing, not paragraph wrapping per se. [1] http://msdn.microsoft.com/en-us/library/windows/desktop/dd317792%28v=vs.85%2... -- Do not reply to this email, post in Bugzilla using the above URL to reply. You are receiving this mail because: You are watching all bug changes.
http://bugs.winehq.org/show_bug.cgi?id=35948 Alex Henrie <alexhenrie24(a)gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|UNCONFIRMED |NEW Ever confirmed|0 |1 --- Comment #4 from Alex Henrie <alexhenrie24(a)gmail.com> --- Better yet, let's just include contiguous runs in the reported link range: http://source.winehq.org/patches/data/105094 -- Do not reply to this email, post in Bugzilla using the above URL to reply. You are receiving this mail because: You are watching all bug changes.
http://bugs.winehq.org/show_bug.cgi?id=35948 Alex Henrie <alexhenrie24(a)gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Fixed by SHA1| |6b947701a763ba7fe141ffa2a08 | |0d4c04cd6a15a Status|NEW |RESOLVED Resolution|--- |FIXED --- Comment #5 from Alex Henrie <alexhenrie24(a)gmail.com> --- http://source.winehq.org/git/wine.git/commitdiff/6b947701a763ba7fe141ffa2a08... -- Do not reply to this email, post in Bugzilla using the above URL to reply. You are receiving this mail because: You are watching all bug changes.
http://bugs.winehq.org/show_bug.cgi?id=35948 Alex Henrie <alexhenrie24(a)gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #48711|0 |1 is obsolete| | -- Do not reply to this email, post in Bugzilla using the above URL to reply. You are receiving this mail because: You are watching all bug changes.
https://bugs.winehq.org/show_bug.cgi?id=35948 Alexandre Julliard <julliard(a)winehq.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|RESOLVED |CLOSED --- Comment #6 from Alexandre Julliard <julliard(a)winehq.org> --- Closing bugs fixed in 1.7.21. -- Do not reply to this email, post in Bugzilla using the above URL to reply. You are receiving this mail because: You are watching all bug changes.
participants (1)
-
wine-bugs＠winehq.org