[Bug 20253] New: Regression: Change to OLE32 causes page fault (problematic commit attached)
http://bugs.winehq.org/show_bug.cgi?id=20253 Summary: Regression: Change to OLE32 causes page fault (problematic commit attached) Product: Wine Version: 1.1.30 Platform: PC OS/Version: Linux Status: UNCONFIRMED Severity: normal Priority: P2 Component: ole32 AssignedTo: wine-bugs(a)winehq.org ReportedBy: brian(a)brianvuyk.com CC: julliard(a)winehq.org Created an attachment (id=23895) --> (http://bugs.winehq.org/attachment.cgi?id=23895) commit 7b6dd2c9f8339a0bc14aa7f466f5c5a0bb03da06 by Alexandre Julliard <julliard(a)winehq.org> A commit back in March appears to have introduced a bug in which StringFromGUID2() gets provided a null argument, and crashes. I noticed this when trying to get WWII Online: Battleground Europe running. This bug was not present in 1.0.1 (which ships with Ubuntu), but was present in 1.1.30. In short, when you try to start the 'Settings.exe' program that comes with the game, it crashes with a page fault. I did a git bisect, and isolated the commit that introduced this behaviour. I am attaching it, along with a backtrace which resulted from the crash. If there is anything else I can provide, let me know. Regards, Brian -- Configure bugmail: http://bugs.winehq.org/userprefs.cgi?tab=email Do not reply to this email, post in Bugzilla using the above URL to reply. ------- You are receiving this mail because: ------- You are watching all bug changes.
http://bugs.winehq.org/show_bug.cgi?id=20253 --- Comment #1 from Brian Vuyk <brian(a)brianvuyk.com> 2009-10-03 15:46:42 --- Created an attachment (id=23896) --> (http://bugs.winehq.org/attachment.cgi?id=23896) Backtrace from the page fault -- Configure bugmail: http://bugs.winehq.org/userprefs.cgi?tab=email Do not reply to this email, post in Bugzilla using the above URL to reply. ------- You are receiving this mail because: ------- You are watching all bug changes.
http://bugs.winehq.org/show_bug.cgi?id=20253 Nikolay Sivov <bunglehead(a)gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|UNCONFIRMED |NEW Ever Confirmed|0 |1 --- Comment #2 from Nikolay Sivov <bunglehead(a)gmail.com> 2009-10-03 16:08:25 --- Confirming, it's a valid bug. I'll send a patch. -- Configure bugmail: http://bugs.winehq.org/userprefs.cgi?tab=email Do not reply to this email, post in Bugzilla using the above URL to reply. ------- You are receiving this mail because: ------- You are watching all bug changes.
http://bugs.winehq.org/show_bug.cgi?id=20253 --- Comment #3 from Nikolay Sivov <bunglehead(a)gmail.com> 2009-10-03 16:09:44 --- Created an attachment (id=23897) --> (http://bugs.winehq.org/attachment.cgi?id=23897) Check for NULL pointer A fix patch with a test. -- Configure bugmail: http://bugs.winehq.org/userprefs.cgi?tab=email Do not reply to this email, post in Bugzilla using the above URL to reply. ------- You are receiving this mail because: ------- You are watching all bug changes.
http://bugs.winehq.org/show_bug.cgi?id=20253 --- Comment #4 from Brian Vuyk <brian(a)brianvuyk.com> 2009-10-03 16:26:39 --- Wow - that was quick. I'll test the patch, and get back to you tonight. Thanks! -- Configure bugmail: http://bugs.winehq.org/userprefs.cgi?tab=email Do not reply to this email, post in Bugzilla using the above URL to reply. ------- You are receiving this mail because: ------- You are watching all bug changes.
http://bugs.winehq.org/show_bug.cgi?id=20253 Vitaliy Margolen <vitaliy(a)kievinfo.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Keywords| |regression Summary|Regression: Change to OLE32 |WWII Online: Battleground |causes page fault |Europe crashes |(problematic commit | |attached) | --- Comment #5 from Vitaliy Margolen <vitaliy(a)kievinfo.com> 2009-10-03 16:44:18 --- Just pasting commit description is enough. commit 7b6dd2c9f8339a0bc14aa7f466f5c5a0bb03da06 Author: Alexandre Julliard <julliard(a)winehq.org> Date: Wed Mar 11 17:28:21 2009 +0100 ole32: Get rid of WINE_StringFromCLSID and A->W conversions. -- Configure bugmail: http://bugs.winehq.org/userprefs.cgi?tab=email Do not reply to this email, post in Bugzilla using the above URL to reply. ------- You are receiving this mail because: ------- You are watching all bug changes.
http://bugs.winehq.org/show_bug.cgi?id=20253 --- Comment #6 from Brian Vuyk <brian(a)brianvuyk.com> 2009-10-03 16:53:43 --- Tested, this patch (#3) fixes the bug. Thanks for the quick work. That's 1 down out of 4 on my list of bugs to isolate in this game. -- Configure bugmail: http://bugs.winehq.org/userprefs.cgi?tab=email Do not reply to this email, post in Bugzilla using the above URL to reply. ------- You are receiving this mail because: ------- You are watching all bug changes.
http://bugs.winehq.org/show_bug.cgi?id=20253 Nikolay Sivov <bunglehead(a)gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Keywords| |patch --- Comment #7 from Nikolay Sivov <bunglehead(a)gmail.com> 2009-10-04 15:36:24 --- Patch sent: http://www.winehq.org/pipermail/wine-patches/2009-October/079454.html -- Configure bugmail: http://bugs.winehq.org/userprefs.cgi?tab=email Do not reply to this email, post in Bugzilla using the above URL to reply. ------- You are receiving this mail because: ------- You are watching all bug changes.
http://bugs.winehq.org/show_bug.cgi?id=20253 Nikolay Sivov <bunglehead(a)gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |RESOLVED Resolution| |FIXED --- Comment #8 from Nikolay Sivov <bunglehead(a)gmail.com> 2009-10-06 10:47:03 --- Fixed by commit: http://source.winehq.org/git/wine.git/?a=commit;h=5b723235d8302469f86f585a44... -- Configure bugmail: http://bugs.winehq.org/userprefs.cgi?tab=email Do not reply to this email, post in Bugzilla using the above URL to reply. ------- You are receiving this mail because: ------- You are watching all bug changes.
http://bugs.winehq.org/show_bug.cgi?id=20253 Alexandre Julliard <julliard(a)winehq.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|RESOLVED |CLOSED --- Comment #9 from Alexandre Julliard <julliard(a)winehq.org> 2009-10-09 11:14:28 --- Closing bugs fixed in 1.1.31. -- Configure bugmail: http://bugs.winehq.org/userprefs.cgi?tab=email Do not reply to this email, post in Bugzilla using the above URL to reply. ------- You are receiving this mail because: ------- You are watching all bug changes.
participants (1)
-
wine-bugs＠winehq.org