[Bug 47641] New: Treeview Expand using option TVE_COLLAPSE|TVE_COLLAPSERESET causes crash
https://bugs.winehq.org/show_bug.cgi?id=47641 Bug ID: 47641 Summary: Treeview Expand using option TVE_COLLAPSE|TVE_COLLAPSERESET causes crash Product: Wine Version: 4.14 Hardware: x86 OS: Linux Status: NEW Severity: normal Priority: P2 Component: comctl32 Assignee: wine-bugs(a)winehq.org Reporter: leslie_alistair(a)hotmail.com Distribution: --- Created attachment 65082 --> https://bugs.winehq.org/attachment.cgi?id=65082 Testcase When an application call a TreeView Expand function with TVE_COLLAPSE|TVE_COLLAPSERESET options, there is a chance that it will crash the application. See attached patch for the simplest testcase. -- Do not reply to this email, post in Bugzilla using the above URL to reply. You are receiving this mail because: You are watching all bug changes.
https://bugs.winehq.org/show_bug.cgi?id=47641 Alistair Leslie-Hughes <leslie_alistair(a)hotmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Keywords| |patch, testcase CC| |bunglehead(a)gmail.com -- Do not reply to this email, post in Bugzilla using the above URL to reply. You are receiving this mail because: You are watching all bug changes.
https://bugs.winehq.org/show_bug.cgi?id=47641 Nikolay Sivov <bunglehead(a)gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC|bunglehead(a)gmail.com | -- Do not reply to this email, post in Bugzilla using the above URL to reply. You are receiving this mail because: You are watching all bug changes.
https://bugs.winehq.org/show_bug.cgi?id=47641 John Alway <jwalway(a)hotmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |jwalway(a)hotmail.com --- Comment #1 from John Alway <jwalway(a)hotmail.com> --- (In reply to Alistair Leslie-Hughes from comment #0)
Created attachment 65082 [details] Testcase
When an application call a TreeView Expand function with TVE_COLLAPSE|TVE_COLLAPSERESET options, there is a chance that it will crash the application.
See attached patch for the simplest testcase.
Hello, I applied your test patch and studied the problem. I found that in the file dlls/comctl32/treeview.c, and the function TREEVIEW_ComputeItemRect() that infoPtr->firstVisible was equal to null. To fix it I created a patch that changes code in TREEVIEW_Collapse(). I moved the function TREEVIEW_SetFirstVisible() from the end of the function to right before TREEVIEW_RecalculateVisibleOrder(). It's worked for me so far. I posted the patch to the developer's list under the title: "[PATCH] comctl32: Fix Treeview Expand using TVE_COLLAPSE|TVE_COLLAPSERESET" Regards, ...John Alway -- Do not reply to this email, post in Bugzilla using the above URL to reply. You are receiving this mail because: You are watching all bug changes.
https://bugs.winehq.org/show_bug.cgi?id=47641 --- Comment #2 from John Alway <jwalway(a)hotmail.com> --- Created attachment 65920 --> https://bugs.winehq.org/attachment.cgi?id=65920 Patch fix for the problem. Just for the sake of completeness, I've uploaded the patch I wrote to fix the bug. Regards, ...John Alway -- Do not reply to this email, post in Bugzilla using the above URL to reply. You are receiving this mail because: You are watching all bug changes.
http://bugs.winehq.org/show_bug.cgi?id=47641 KRosUser <kyle.kcsoftwares(a)gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |kyle.kcsoftwares(a)gmail.com --- Comment #3 from KRosUser <kyle.kcsoftwares(a)gmail.com> --- Looking at https://github.com/wine-mirror/wine/blob/master/dlls/comctl32/treeview.c#L34... the patch has not been integrated. Do you confirm the problem is still there ? Would you or a Wine Dev do a MR for this patch ? -- Do not reply to this email, post in Bugzilla using the above URL to reply. You are receiving this mail because: You are watching all bug changes.
participants (2)
-
wine-bugs＠winehq.org -
WineHQ Bugzilla