[Bug 17920] New: OleUIAddVerbMenu is not realized
http://bugs.winehq.org/show_bug.cgi?id=17920 Summary: OleUIAddVerbMenu is not realized Product: Wine Version: unspecified Platform: Other URL: http://msdn.microsoft.com/en- us/library/ms686597(VS.85).aspx OS/Version: other Status: UNCONFIRMED Severity: enhancement Priority: P2 Component: ole AssignedTo: wine-bugs(a)winehq.org ReportedBy: lav(a)etersoft.ru OleUIAddVerbMenu is not realized at all in current Wine. My last realization post at January, 16: http://www.winehq.org/pipermail/wine-patches/2009-January/067827.html This realization tested with 1C Accounting program (specified for Russia) and has no reclamation. -- Configure bugmail: http://bugs.winehq.org/userprefs.cgi?tab=email Do not reply to this email, post in Bugzilla using the above URL to reply. ------- You are receiving this mail because: ------- You are watching all bug changes.
http://bugs.winehq.org/show_bug.cgi?id=17920 Vitaliy Margolen <vitaliy(a)kievinfo.com> changed: What |Removed |Added ---------------------------------------------------------------------------- URL|http://msdn.microsoft.com/en| |- | |us/library/ms686597(VS.85).a| |spx | Keywords| |patch Summary|OleUIAddVerbMenu is not |OleUIAddVerbMenu is not |realized |implemented Version|unspecified |1.1.18 -- Configure bugmail: http://bugs.winehq.org/userprefs.cgi?tab=email Do not reply to this email, post in Bugzilla using the above URL to reply. ------- You are receiving this mail because: ------- You are watching all bug changes.
http://bugs.winehq.org/show_bug.cgi?id=17920 --- Comment #1 from Austin English <austinenglish(a)gmail.com> 2009-10-01 15:08:18 --- Still unimplemented. Might try adding some testcases and resending... -- Configure bugmail: http://bugs.winehq.org/userprefs.cgi?tab=email Do not reply to this email, post in Bugzilla using the above URL to reply. ------- You are receiving this mail because: ------- You are watching all bug changes.
http://bugs.winehq.org/show_bug.cgi?id=17920 --- Comment #2 from Vitaly Lipatov <lav(a)etersoft.ru> 2009-10-02 04:05:18 --- I can't image why for NONimplemented function we need any test cases. It is a strange position do not apply patch for completely missed functionality. I have a realization, but have no time for write out tests. Will try done it later... Sorry... -- Configure bugmail: http://bugs.winehq.org/userprefs.cgi?tab=email Do not reply to this email, post in Bugzilla using the above URL to reply. ------- You are receiving this mail because: ------- You are watching all bug changes.
http://bugs.winehq.org/show_bug.cgi?id=17920 --- Comment #3 from Nikolay Sivov <bunglehead(a)gmail.com> 2009-10-02 04:25:59 --- (In reply to comment #2)
I can't image why for NONimplemented function we need any test cases. It is a strange position do not apply patch for completely missed functionality.
It isn't strange at all. For example simply parameter validation tests will help to catch obvious call inconsistencies. The main is that with parameter validation and functionality tests you prove it works, and won't get worse in future if somebody patches is again.
I have a realization, but have no time for write out tests. Will try done it later... Sorry...
Attach your current version here please, and ask wine-devel to help with tests if it's a time problem. -- Configure bugmail: http://bugs.winehq.org/userprefs.cgi?tab=email Do not reply to this email, post in Bugzilla using the above URL to reply. ------- You are receiving this mail because: ------- You are watching all bug changes.
http://bugs.winehq.org/show_bug.cgi?id=17920 --- Comment #4 from Vitaly Lipatov <lav(a)etersoft.ru> 2009-10-02 05:06:17 --- Direct URL to patch (applied correctly to current git tree) with OleUIAddVerbMenu realization: http://www.winehq.org/pipermail/wine-patches/attachments/20090116/041eb4e8/a... -- Configure bugmail: http://bugs.winehq.org/userprefs.cgi?tab=email Do not reply to this email, post in Bugzilla using the above URL to reply. ------- You are receiving this mail because: ------- You are watching all bug changes.
http://bugs.winehq.org/show_bug.cgi?id=17920 --- Comment #5 from Dmitry Timoshkov <dmitry(a)codeweavers.com> 2009-10-05 00:15:21 --- (In reply to comment #2)
I can't image why for NONimplemented function we need any test cases. It is a strange position do not apply patch for completely missed functionality. I have a realization, but have no time for write out tests. Will try done it later... Sorry...
Then the question arizes How did you test that your implementation is correct or at least does work at all? -- Configure bugmail: http://bugs.winehq.org/userprefs.cgi?tab=email Do not reply to this email, post in Bugzilla using the above URL to reply. ------- You are receiving this mail because: ------- You are watching all bug changes.
http://bugs.winehq.org/show_bug.cgi?id=17920 --- Comment #6 from Vitaly Lipatov <lav(a)etersoft.ru> 2009-10-05 06:50:57 --- (In reply to comment #5)
(In reply to comment #2)
I can't image why for NONimplemented function we need any test cases. It is a strange position do not apply patch for completely missed functionality. I have a realization, but have no time for write out tests. Will try done it later... Sorry...
Then the question arizes How did you test that your implementation is correct or at least does work at all? I and my clients uses it realization in 1C Accounting application for years. I do not see better test now. In other words, It works for me. I will try to write a test, but in one month or two...
-- Configure bugmail: http://bugs.winehq.org/userprefs.cgi?tab=email Do not reply to this email, post in Bugzilla using the above URL to reply. ------- You are receiving this mail because: ------- You are watching all bug changes.
http://bugs.winehq.org/show_bug.cgi?id=17920 --- Comment #7 from Dmitry Timoshkov <dmitry(a)codeweavers.com> 2009-10-05 07:58:59 --- (In reply to comment #6)
Then the question arizes How did you test that your implementation is correct or at least does work at all? I and my clients uses it realization in 1C Accounting application for years. I do not see better test now. In other words, It works for me.
The question is how have you developed an implementation in the first place? How do you know what should it do internally and which corner/error cases should you handle and how? The only answer to that questions could be done by test cases written specifically for cases you want to test, or not clear from MSDN, or to prove that your implementation is correct at all. -- Configure bugmail: http://bugs.winehq.org/userprefs.cgi?tab=email Do not reply to this email, post in Bugzilla using the above URL to reply. ------- You are receiving this mail because: ------- You are watching all bug changes.
http://bugs.winehq.org/show_bug.cgi?id=17920 --- Comment #8 from Vitaly Lipatov <lav(a)etersoft.ru> 2009-10-05 08:40:34 --- (In reply to comment #7)
The question is how have you developed an implementation in the first place? How do you know what should it do internally and which corner/error cases should you handle and how? The only answer to that questions could be done by test cases written specifically for cases you want to test, or not clear from MSDN, or to prove that your implementation is correct at all. I agree with all your arguments. But I use 1C Accounting as a test. Only problem is it no test with sources. Is it better to have no implementation then apply some initial implementation?
-- Configure bugmail: http://bugs.winehq.org/userprefs.cgi?tab=email Do not reply to this email, post in Bugzilla using the above URL to reply. ------- You are receiving this mail because: ------- You are watching all bug changes.
http://bugs.winehq.org/show_bug.cgi?id=17920 --- Comment #9 from Dmitry Timoshkov <dmitry(a)codeweavers.com> 2009-10-05 09:14:19 --- (In reply to comment #8)
Is it better to have no implementation then apply some initial implementation?
Any basic implementation that is something more than just a stub requires basic tests. The test serve at least as a measure to prevent any regressions in future modifications, and of course as a measure of correctness of the implementation. -- Configure bugmail: http://bugs.winehq.org/userprefs.cgi?tab=email Do not reply to this email, post in Bugzilla using the above URL to reply. ------- You are receiving this mail because: ------- You are watching all bug changes.
http://bugs.winehq.org/show_bug.cgi?id=17920 --- Comment #10 from Austin English <austinenglish(a)gmail.com> 2010-12-23 18:24:40 CST --- Still unimplemented. -- Configure bugmail: http://bugs.winehq.org/userprefs.cgi?tab=email Do not reply to this email, post in Bugzilla using the above URL to reply. ------- You are receiving this mail because: ------- You are watching all bug changes.
http://bugs.winehq.org/show_bug.cgi?id=17920 --- Comment #11 from butraxz(a)gmail.com 2013-06-15 04:11:00 CDT --- This has not been updated for over 900 days. Is this still an issue in 1.6-rc2 or higher or is this abandoned ? -- Configure bugmail: http://bugs.winehq.org/userprefs.cgi?tab=email Do not reply to this email, post in Bugzilla using the above URL to reply. ------- You are receiving this mail because: ------- You are watching all bug changes.
https://bugs.winehq.org/show_bug.cgi?id=17920 Austin English <austinenglish(a)gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |austinenglish(a)gmail.com -- Do not reply to this email, post in Bugzilla using the above URL to reply. You are receiving this mail because: You are watching all bug changes.
https://bugs.winehq.org/show_bug.cgi?id=17920 Nikolay Sivov <bunglehead(a)gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|UNCONFIRMED |NEW Ever confirmed|0 |1 --- Comment #12 from Nikolay Sivov <bunglehead(a)gmail.com> --- Still present in current wine. I'll take a look when I have time, doesn't look too complicated. -- Do not reply to this email, post in Bugzilla using the above URL to reply. You are receiving this mail because: You are watching all bug changes.
https://bugs.winehq.org/show_bug.cgi?id=17920 Nikolay Sivov <bunglehead(a)gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |bunglehead(a)gmail.com -- Do not reply to this email, post in Bugzilla using the above URL to reply. You are receiving this mail because: You are watching all bug changes.
https://bugs.winehq.org/show_bug.cgi?id=17920 Nikolay Sivov <bunglehead(a)gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Fixed by SHA1| |9fda58362b1ea3019f2bed598c5 | |2d234ea37bd6b Status|NEW |RESOLVED Resolution|--- |FIXED --- Comment #13 from Nikolay Sivov <bunglehead(a)gmail.com> --- This is implement now, commits are: d93781f29bb346f04f8489ae208b1ffe540fe9c6 04ed24fb79b03aa825d684cacaa3c8ef3157552c 66bcad51c0c1f27739ab190bf27e002d20286043 9fda58362b1ea3019f2bed598c52d234ea37bd6b Vitaly, if you find anything about this that's not working right, please open a new report. -- Do not reply to this email, post in Bugzilla using the above URL to reply. You are receiving this mail because: You are watching all bug changes.
https://bugs.winehq.org/show_bug.cgi?id=17920 Nikolay Sivov <bunglehead(a)gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC|bunglehead(a)gmail.com | -- Do not reply to this email, post in Bugzilla using the above URL to reply. You are receiving this mail because: You are watching all bug changes.
https://bugs.winehq.org/show_bug.cgi?id=17920 Alexandre Julliard <julliard(a)winehq.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|RESOLVED |CLOSED --- Comment #14 from Alexandre Julliard <julliard(a)winehq.org> --- Closing bugs fixed in 1.7.44. -- Do not reply to this email, post in Bugzilla using the above URL to reply. You are receiving this mail because: You are watching all bug changes.
https://bugs.winehq.org/show_bug.cgi?id=17920 Nikolay Sivov <bunglehead(a)gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Component|ole |ole32 -- Do not reply to this email, post in Bugzilla using the above URL to reply. You are receiving this mail because: You are watching all bug changes.
participants (1)
-
wine-bugs＠winehq.org