[Bug 19425] New: notepad: running notepad with a non-existent file and choosing yes to create a new file should do so immediately (appinstall)
http://bugs.winehq.org/show_bug.cgi?id=19425 Summary: notepad: running notepad with a non-existent file and choosing yes to create a new file should do so immediately (appinstall) Product: Wine Version: 1.1.26 Platform: PC OS/Version: Linux Status: NEW Keywords: download, source Severity: trivial Priority: P2 Component: programs AssignedTo: wine-bugs(a)winehq.org ReportedBy: austinenglish(a)gmail.com 'notepad foobar.txt' pops up a dialog telling you that the file does not exist, and asking if you'd like to create it. Yes - Opens notepad with foobar.txt, but doesn't create a new file. No - Opens notepad with a blank new document. Cancel - Closes notepad. On windows, choosing yes immediately creates the new (empty) file. -- Configure bugmail: http://bugs.winehq.org/userprefs.cgi?tab=email Do not reply to this email, post in Bugzilla using the above URL to reply. ------- You are receiving this mail because: ------- You are watching all bug changes.
http://bugs.winehq.org/show_bug.cgi?id=19425 --- Comment #1 from André H. <nerv(a)dawncrow.de> 2009-08-02 12:41:35 --- Created an attachment (id=22781) --> (http://bugs.winehq.org/attachment.cgi?id=22781) notepad: create missing file attached a Q&D hack. only thing which should be done better is to handle returnvalue of DoSaveFile -- Configure bugmail: http://bugs.winehq.org/userprefs.cgi?tab=email Do not reply to this email, post in Bugzilla using the above URL to reply. ------- You are receiving this mail because: ------- You are watching all bug changes.
http://bugs.winehq.org/show_bug.cgi?id=19425 André H. <nerv(a)dawncrow.de> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |nerv(a)dawncrow.de --- Comment #2 from André H. <nerv(a)dawncrow.de> 2009-08-04 13:15:22 --- as i think its not that dirty, patch sent: http://www.winehq.org/pipermail/wine-patches/2009-August/076643.html -- Configure bugmail: http://bugs.winehq.org/userprefs.cgi?tab=email Do not reply to this email, post in Bugzilla using the above URL to reply. ------- You are receiving this mail because: ------- You are watching all bug changes.
http://bugs.winehq.org/show_bug.cgi?id=19425 André H. <nerv(a)dawncrow.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Keywords| |patch -- Configure bugmail: http://bugs.winehq.org/userprefs.cgi?tab=email Do not reply to this email, post in Bugzilla using the above URL to reply. ------- You are receiving this mail because: ------- You are watching all bug changes.
http://bugs.winehq.org/show_bug.cgi?id=19425 --- Comment #3 from André H. <nerv(a)dawncrow.de> 2009-08-09 08:36:05 --- Created an attachment (id=22924) --> (http://bugs.winehq.org/attachment.cgi?id=22924) relay-log of Notepad from XP attached a cut out of a relay log from the original xp-notepad running in wine 1.1.27 i started it with "notepadxp.exe bla.txt", bla.txt didnt exist and i clicked yes, when i got asked to create it. the sequence is: 1. the question 2. file creation 3. update window-caption This is what my patch does, so i think it is fine. -- Configure bugmail: http://bugs.winehq.org/userprefs.cgi?tab=email Do not reply to this email, post in Bugzilla using the above URL to reply. ------- You are receiving this mail because: ------- You are watching all bug changes.
http://bugs.winehq.org/show_bug.cgi?id=19425 André H. <nerv(a)dawncrow.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #22924|1 |0 is patch| | -- Configure bugmail: http://bugs.winehq.org/userprefs.cgi?tab=email Do not reply to this email, post in Bugzilla using the above URL to reply. ------- You are receiving this mail because: ------- You are watching all bug changes.
http://bugs.winehq.org/show_bug.cgi?id=19425 André H. <nerv(a)dawncrow.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #22924|text/plain |application/x-bzip mime type| | -- Configure bugmail: http://bugs.winehq.org/userprefs.cgi?tab=email Do not reply to this email, post in Bugzilla using the above URL to reply. ------- You are receiving this mail because: ------- You are watching all bug changes.
http://bugs.winehq.org/show_bug.cgi?id=19425 --- Comment #4 from Vitaliy Margolen <vitaliy(a)kievinfo.com> 2009-08-09 12:25:21 --- (In reply to comment #3)
attached a cut out of a relay log from the original xp-notepad running in wine 1.1.27 You are not allowed to do that. Do not send patches related to this to wine-patches.
-- Configure bugmail: http://bugs.winehq.org/userprefs.cgi?tab=email Do not reply to this email, post in Bugzilla using the above URL to reply. ------- You are receiving this mail because: ------- You are watching all bug changes.
http://bugs.winehq.org/show_bug.cgi?id=19425 --- Comment #5 from Austin English <austinenglish(a)gmail.com> 2009-08-09 14:42:29 --- (In reply to comment #4)
(In reply to comment #3)
attached a cut out of a relay log from the original xp-notepad running in wine 1.1.27 You are not allowed to do that. Do not send patches related to this to wine-patches.
Since when are +relay traces not allowed? -- Configure bugmail: http://bugs.winehq.org/userprefs.cgi?tab=email Do not reply to this email, post in Bugzilla using the above URL to reply. ------- You are receiving this mail because: ------- You are watching all bug changes.
http://bugs.winehq.org/show_bug.cgi?id=19425 --- Comment #6 from Vincent Povirk <madewokherd(a)gmail.com> 2009-08-09 16:23:44 --- Using a relay trace of a native component to implement similar functionality in the corresponding Wine component is not allowed. That's considered reverse-engineering. -- Configure bugmail: http://bugs.winehq.org/userprefs.cgi?tab=email Do not reply to this email, post in Bugzilla using the above URL to reply. ------- You are receiving this mail because: ------- You are watching all bug changes.
http://bugs.winehq.org/show_bug.cgi?id=19425 --- Comment #7 from Austin English <austinenglish(a)gmail.com> 2009-08-09 17:51:07 --- (In reply to comment #6)
Using a relay trace of a native component to implement similar functionality in the corresponding Wine component is not allowed. That's considered reverse-engineering.
The patch (it appears) was written before the +relay trace was done. The +relay only confirmed the suspected behavior. -- Configure bugmail: http://bugs.winehq.org/userprefs.cgi?tab=email Do not reply to this email, post in Bugzilla using the above URL to reply. ------- You are receiving this mail because: ------- You are watching all bug changes.
http://bugs.winehq.org/show_bug.cgi?id=19425 --- Comment #8 from Austin English <austinenglish(a)gmail.com> 2009-08-09 18:19:24 --- (In reply to comment #1)
Created an attachment (id=22781) --> (http://bugs.winehq.org/attachment.cgi?id=22781) [details] notepad: create missing file
attached a Q&D hack. only thing which should be done better is to handle returnvalue of DoSaveFile
I did some manual testing on windows. If creating the file fails, notepad continues without creating a new file. If the directory doesn't exist, you get a file not found error. E.g.,: (In a read only directory):
notepad foo.txt # Notepad runs, choose yes, no file created.
(In any directory):
notepad X:\foo.txt # File not found
-- Configure bugmail: http://bugs.winehq.org/userprefs.cgi?tab=email Do not reply to this email, post in Bugzilla using the above URL to reply. ------- You are receiving this mail because: ------- You are watching all bug changes.
http://bugs.winehq.org/show_bug.cgi?id=19425 --- Comment #9 from André H. <nerv(a)dawncrow.de> 2009-08-10 06:19:57 --- Two possible options left AFAIK: Option 1: my old patch gets in. Thats ok i did my mistake 5 days later Option 2: i write some things different, like the order of creating and captionbarupdate and handle the dosavefile-errors like Austin tells me. I wait until the commit today to see if Option 1 happens. -- Configure bugmail: http://bugs.winehq.org/userprefs.cgi?tab=email Do not reply to this email, post in Bugzilla using the above URL to reply. ------- You are receiving this mail because: ------- You are watching all bug changes.
http://bugs.winehq.org/show_bug.cgi?id=19425 --- Comment #10 from André H. <nerv(a)dawncrow.de> 2009-08-10 12:03:09 --- So now its time for Option 2, but i saw that there is nothing much to reasonable handle on dosavefile. So just change the order? -- Configure bugmail: http://bugs.winehq.org/userprefs.cgi?tab=email Do not reply to this email, post in Bugzilla using the above URL to reply. ------- You are receiving this mail because: ------- You are watching all bug changes.
http://bugs.winehq.org/show_bug.cgi?id=19425 --- Comment #11 from André H. <nerv(a)dawncrow.de> 2009-08-11 13:54:17 --- try2: http://www.winehq.org/pipermail/wine-patches/2009-August/076901.html -- Configure bugmail: http://bugs.winehq.org/userprefs.cgi?tab=email Do not reply to this email, post in Bugzilla using the above URL to reply. ------- You are receiving this mail because: ------- You are watching all bug changes.
http://bugs.winehq.org/show_bug.cgi?id=19425 Alexandre Julliard <julliard(a)winehq.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #22924|0 |1 is obsolete| | --- Comment #12 from Alexandre Julliard <julliard(a)winehq.org> 2009-08-14 05:03:00 --- (From update of attachment 22924) Don't look at native implementation details. -- Configure bugmail: http://bugs.winehq.org/userprefs.cgi?tab=email Do not reply to this email, post in Bugzilla using the above URL to reply. ------- You are receiving this mail because: ------- You are watching all bug changes.
http://bugs.winehq.org/show_bug.cgi?id=19425 Bruno Jesus <00cpxxx(a)gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |00cpxxx(a)gmail.com --- Comment #13 from Bruno Jesus <00cpxxx(a)gmail.com> 2012-03-01 23:42:23 CST --- Still present in 1.4-rc5 as far as I understand what this bug is about. -- Configure bugmail: http://bugs.winehq.org/userprefs.cgi?tab=email Do not reply to this email, post in Bugzilla using the above URL to reply. ------- You are receiving this mail because: ------- You are watching all bug changes.
http://bugs.winehq.org/show_bug.cgi?id=19425 --- Comment #14 from Austin English <austinenglish(a)gmail.com> 2012-03-02 12:51:09 CST --- (In reply to comment #13)
Still present in 1.4-rc5 as far as I understand what this bug is about.
Yes, it is. -- Configure bugmail: http://bugs.winehq.org/userprefs.cgi?tab=email Do not reply to this email, post in Bugzilla using the above URL to reply. ------- You are receiving this mail because: ------- You are watching all bug changes.
http://bugs.winehq.org/show_bug.cgi?id=19425 André H. <nerv(a)dawncrow.de> changed: What |Removed |Added ---------------------------------------------------------------------------- CC|nerv(a)dawncrow.de | -- Configure bugmail: http://bugs.winehq.org/userprefs.cgi?tab=email Do not reply to this email, post in Bugzilla using the above URL to reply. ------- You are receiving this mail because: ------- You are watching all bug changes.
https://bugs.winehq.org/show_bug.cgi?id=19425 --- Comment #15 from Austin English <austinenglish(a)gmail.com> --- The content of attachment 22924 has been deleted for the following reason: deleting native relay log -- Do not reply to this email, post in Bugzilla using the above URL to reply. You are receiving this mail because: You are watching all bug changes.
https://bugs.winehq.org/show_bug.cgi?id=19425 --- Comment #16 from Austin English <austinenglish(a)gmail.com> --- Still in wine-1.7.19-154-g80a29e2 -- Do not reply to this email, post in Bugzilla using the above URL to reply. You are receiving this mail because: You are watching all bug changes.
https://bugs.winehq.org/show_bug.cgi?id=19425 super_man(a)post.com changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |super_man(a)post.com --- Comment #17 from super_man(a)post.com --- still an issue 1.7.49 -- Do not reply to this email, post in Bugzilla using the above URL to reply. You are receiving this mail because: You are watching all bug changes.
https://bugs.winehq.org/show_bug.cgi?id=19425 Sebastian Lackner <sebastian(a)fds-team.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Fixed by SHA1| |8a730168196d45f4364473b93e7 | |3bd74ad4378ce Status|NEW |RESOLVED CC| |sebastian(a)fds-team.de Resolution|--- |FIXED --- Comment #18 from Sebastian Lackner <sebastian(a)fds-team.de> --- Fixed with http://source.winehq.org/git/wine.git/commit/8a730168196d45f4364473b93e73bd7.... -- Do not reply to this email, post in Bugzilla using the above URL to reply. You are receiving this mail because: You are watching all bug changes.
https://bugs.winehq.org/show_bug.cgi?id=19425 Alexandre Julliard <julliard(a)winehq.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|RESOLVED |CLOSED --- Comment #19 from Alexandre Julliard <julliard(a)winehq.org> --- Closing bugs fixed in 1.7.51. -- Do not reply to this email, post in Bugzilla using the above URL to reply. You are receiving this mail because: You are watching all bug changes.
participants (1)
-
wine-bugs@winehq.org