[Bug 15452] New: Freewire aborts due to incorrect handling of COLORRES nIndex in winex11's GetDeviceCaps()
http://bugs.winehq.org/show_bug.cgi?id=15452 Summary: Freewire aborts due to incorrect handling of COLORRES nIndex in winex11's GetDeviceCaps() Product: Wine Version: CVS/GIT Platform: PC URL: http://www.freewiretv.com/downloadTVWin.html OS/Version: Linux Status: UNCONFIRMED Severity: normal Priority: P2 Component: winex11.drv AssignedTo: wine-bugs(a)winehq.org ReportedBy: nodisgod(a)yahoo.com Created an attachment (id=16345) --> (http://bugs.winehq.org/attachment.cgi?id=16345) Freewire relay log (rzipped) With current Git (wine-1.1.5-207-gc425c8a), when attempting to launch Freewire after installation, Freewire aborts with a message box complaining about the currently set bit depth. From relay trace: 0009:Call user32.GetDC(00000000) ret=005808ac 0009:Ret user32.GetDC() retval=0000030c ret=005808ac 0009:Call gdi32.GetDeviceCaps(0000030c,0000006c) ret=005808b5 0009:Ret gdi32.GetDeviceCaps() retval=00000000 ret=005808b5 0009:Call user32.LoadStringA(00000000,00000095,0032f8d4,00000180) ret=005808f3 0009:Ret user32.LoadStringA() retval=0000015d ret=005808f3 0009:Call user32.LoadStringA(00000000,00000097,0032f754,00000180) ret=00580910 0009:Ret user32.LoadStringA() retval=0000001c ret=00580910 0009:Call user32.MessageBoxA(00000000,0032f8d4 "Unfortunately, it has not been possible to start Freewire Television due to your graphics mode.\nPlease set the color depth to 32 bit in the display control panel and restart the application\nIf the problem continues please contact Freewire customer services on 0333 123 0190.\nOr visit the Freewire s"...,0032f754 "We've encountered a problem!",00000030) ret=00580927 The problem seems to lie in: 0009:Call gdi32.GetDeviceCaps(0000030c,0000006c) ret=005808b5 0009:Ret gdi32.GetDeviceCaps() retval=00000000 ret=005808b5 GetDeviceCaps() is being called with the DC handle returned from GetDC(NULL) and the COLORRES value for nIndex. In dlls/winex11.drv/init.c lines 259 and 268: case COLORRES: /* ... */ return 0; Freewire apparently does not like the returned value, and thus aborts with the message box. Modifying the COLORRES case to return screen_bpp allows the application to get past this point, though I am not sure if this is the right thing to do. -- Configure bugmail: http://bugs.winehq.org/userprefs.cgi?tab=email Do not reply to this email, post in Bugzilla using the above URL to reply. ------- You are receiving this mail because: ------- You are watching all bug changes.
http://bugs.winehq.org/show_bug.cgi?id=15452 --- Comment #1 from scguy318 <nodisgod(a)yahoo.com> 2008-09-28 20:48:46 --- Created an attachment (id=16346) --> (http://bugs.winehq.org/attachment.cgi?id=16346) Tentative winex11.drv patch -- Configure bugmail: http://bugs.winehq.org/userprefs.cgi?tab=email Do not reply to this email, post in Bugzilla using the above URL to reply. ------- You are receiving this mail because: ------- You are watching all bug changes.
http://bugs.winehq.org/show_bug.cgi?id=15452 scguy318 <nodisgod(a)yahoo.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Keywords| |download, patch -- Configure bugmail: http://bugs.winehq.org/userprefs.cgi?tab=email Do not reply to this email, post in Bugzilla using the above URL to reply. ------- You are receiving this mail because: ------- You are watching all bug changes.
http://bugs.winehq.org/show_bug.cgi?id=15452 Dmitry Timoshkov <dmitry(a)codeweavers.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Version|CVS/GIT |1.1.5 --- Comment #2 from Dmitry Timoshkov <dmitry(a)codeweavers.com> 2008-09-28 22:36:00 --- Please specify Wine version instead of CVS/GIT. -- Configure bugmail: http://bugs.winehq.org/userprefs.cgi?tab=email Do not reply to this email, post in Bugzilla using the above URL to reply. ------- You are receiving this mail because: ------- You are watching all bug changes.
http://bugs.winehq.org/show_bug.cgi?id=15452 Alexander Nicolaysen Sørnes <alex(a)thehandofagony.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |alex(a)thehandofagony.com --- Comment #3 from Alexander Nicolaysen Sørnes <alex(a)thehandofagony.com> 2008-10-13 14:53:59 --- Could you send your patch to wine-patches? -- Configure bugmail: http://bugs.winehq.org/userprefs.cgi?tab=email Do not reply to this email, post in Bugzilla using the above URL to reply. ------- You are receiving this mail because: ------- You are watching all bug changes.
http://bugs.winehq.org/show_bug.cgi?id=15452 --- Comment #4 from scguy318 <nodisgod(a)yahoo.com> 2008-10-18 21:54:33 --- I've submitted a modified patch: http://www.winehq.org/pipermail/wine-patches/2008-October/063408.html -- Configure bugmail: http://bugs.winehq.org/userprefs.cgi?tab=email Do not reply to this email, post in Bugzilla using the above URL to reply. ------- You are receiving this mail because: ------- You are watching all bug changes.
http://bugs.winehq.org/show_bug.cgi?id=15452 --- Comment #5 from scguy318 <nodisgod(a)yahoo.com> 2008-10-18 22:05:08 --- I made a mistake in the previous submission. The latest resend is at: http://www.winehq.org/pipermail/wine-patches/2008-October/063409.html -- Configure bugmail: http://bugs.winehq.org/userprefs.cgi?tab=email Do not reply to this email, post in Bugzilla using the above URL to reply. ------- You are receiving this mail because: ------- You are watching all bug changes.
http://bugs.winehq.org/show_bug.cgi?id=15452 Dan Kegel <dank(a)kegel.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |dank(a)kegel.com --- Comment #6 from Dan Kegel <dank(a)kegel.com> 2008-10-19 07:36:09 --- Can you write a conformance test to verify your patch is correct? -- Configure bugmail: http://bugs.winehq.org/userprefs.cgi?tab=email Do not reply to this email, post in Bugzilla using the above URL to reply. ------- You are receiving this mail because: ------- You are watching all bug changes.
http://bugs.winehq.org/show_bug.cgi?id=15452 Austin English <austinenglish(a)gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|UNCONFIRMED |RESOLVED Resolution| |FIXED --- Comment #7 from Austin English <austinenglish(a)gmail.com> 2010-06-14 22:49:45 --- In 1.2-rc3, I see: err:d3d_surface:IWineGDISurfaceImpl_UnLoad (0x169608): UnLoad is not supported on X11 surfaces! err:d3d_surface:IWineGDISurfaceImpl_UnLoad (0x169608): Most likely the parent library did something wrong. err:d3d_surface:IWineGDISurfaceImpl_UnLoad (0x169608): Please report to wine-devel err:d3d_surface:IWineGDISurfaceImpl_UnLoad (0x1e6eb8): UnLoad is not supported on X11 surfaces! err:d3d_surface:IWineGDISurfaceImpl_UnLoad (0x1e6eb8): Most likely the parent library did something wrong. err:d3d_surface:IWineGDISurfaceImpl_UnLoad (0x1e6eb8): Please report to wine-devel err:d3d_surface:IWineGDISurfaceImpl_UnLoad (0x157a60): UnLoad is not supported on X11 surfaces! err:d3d_surface:IWineGDISurfaceImpl_UnLoad (0x157a60): Most likely the parent library did something wrong. err:d3d_surface:IWineGDISurfaceImpl_UnLoad (0x157a60): Please report to wine-devel err:d3d:context_release Failed to restore GL context 0x182238 on device context 0x73c, last error 0x7d0. but it runs fine. I don't have a login, so I can't do much, but there's no message box. -- Configure bugmail: http://bugs.winehq.org/userprefs.cgi?tab=email Do not reply to this email, post in Bugzilla using the above URL to reply. ------- You are receiving this mail because: ------- You are watching all bug changes.
http://bugs.winehq.org/show_bug.cgi?id=15452 Andrew Nguyen <arethusa26(a)gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|RESOLVED |UNCONFIRMED Resolution|FIXED | --- Comment #8 from Andrew Nguyen <arethusa26(a)gmail.com> 2010-06-14 22:54:18 --- The original Freewire application I still possess still exhibits the problem. I do have a pending patch that should hopefully be acceptable. -- Configure bugmail: http://bugs.winehq.org/userprefs.cgi?tab=email Do not reply to this email, post in Bugzilla using the above URL to reply. ------- You are receiving this mail because: ------- You are watching all bug changes.
http://bugs.winehq.org/show_bug.cgi?id=15452 Andrew Nguyen <arethusa26(a)gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|UNCONFIRMED |NEW Ever Confirmed|0 |1 --- Comment #9 from Andrew Nguyen <arethusa26(a)gmail.com> 2010-06-14 22:54:49 --- Confirming the bug. -- Configure bugmail: http://bugs.winehq.org/userprefs.cgi?tab=email Do not reply to this email, post in Bugzilla using the above URL to reply. ------- You are receiving this mail because: ------- You are watching all bug changes.
http://bugs.winehq.org/show_bug.cgi?id=15452 --- Comment #10 from Andrew Nguyen <arethusa26(a)gmail.com> 2010-06-15 00:37:44 --- I sent a patch: http://source.winehq.org/patches/data/62620 -- Configure bugmail: http://bugs.winehq.org/userprefs.cgi?tab=email Do not reply to this email, post in Bugzilla using the above URL to reply. ------- You are receiving this mail because: ------- You are watching all bug changes.
http://bugs.winehq.org/show_bug.cgi?id=15452 Austin English <austinenglish(a)gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |RESOLVED Resolution| |FIXED --- Comment #11 from Austin English <austinenglish(a)gmail.com> 2010-06-15 13:52:59 --- Fixed by http://source.winehq.org/git/wine.git/?a=commitdiff;h=b4d58fe58faf960f6914a9.... Thanks Andrew! -- Configure bugmail: http://bugs.winehq.org/userprefs.cgi?tab=email Do not reply to this email, post in Bugzilla using the above URL to reply. ------- You are receiving this mail because: ------- You are watching all bug changes.
http://bugs.winehq.org/show_bug.cgi?id=15452 Alexandre Julliard <julliard(a)winehq.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|RESOLVED |CLOSED --- Comment #12 from Alexandre Julliard <julliard(a)winehq.org> 2010-06-18 12:46:39 --- Closing bugs fixed in 1.2-rc4. -- Configure bugmail: http://bugs.winehq.org/userprefs.cgi?tab=email Do not reply to this email, post in Bugzilla using the above URL to reply. ------- You are receiving this mail because: ------- You are watching all bug changes.
https://bugs.winehq.org/show_bug.cgi?id=15452 André H. <nerv(a)dawncrow.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Fixed by SHA1| |b4d58fe58faf960f6914a91b4f9 | |ca0052f90689a CC| |nerv(a)dawncrow.de -- Do not reply to this email, post in Bugzilla using the above URL to reply. You are receiving this mail because: You are watching all bug changes.
participants (1)
-
wine-bugs＠winehq.org