[Bug 16605] New: riched20 regression: FullTiltPoker client crashes when leaving game window
http://bugs.winehq.org/show_bug.cgi?id=16605 Summary: riched20 regression: FullTiltPoker client crashes when leaving game window Product: Wine Version: 1.1.11 Platform: PC OS/Version: Linux Status: UNCONFIRMED Severity: enhancement Priority: P2 Component: richedit AssignedTo: wine-bugs(a)winehq.org ReportedBy: wtipton(a)hmc.edu Created an attachment (id=18148) --> (http://bugs.winehq.org/attachment.cgi?id=18148) trace FullTiltPoker client crashes when leaving game window. To reproduce, open up any table and then close it. The backtrace is attached, but the crash is happening in riched20:ME_HandleMessage(), a new function in 1.1.11. -- Configure bugmail: http://bugs.winehq.org/userprefs.cgi?tab=email Do not reply to this email, post in Bugzilla using the above URL to reply. ------- You are receiving this mail because: ------- You are watching all bug changes.
http://bugs.winehq.org/show_bug.cgi?id=16605 Austin English <austinenglish(a)gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Keywords| |regression --- Comment #1 from Austin English <austinenglish(a)gmail.com> 2008-12-23 11:28:08 --- Please run a regression test: http://wiki.winehq.org/RegressionTesting -- Configure bugmail: http://bugs.winehq.org/userprefs.cgi?tab=email Do not reply to this email, post in Bugzilla using the above URL to reply. ------- You are receiving this mail because: ------- You are watching all bug changes.
http://bugs.winehq.org/show_bug.cgi?id=16605 --- Comment #2 from Will Tipton <wtipton(a)hmc.edu> 2008-12-24 09:07:21 --- So, around the 4th iteration or so of the regression test, the compilation fails. Not sure why -- I'll attach the output. All bisects were good up until this. -- Configure bugmail: http://bugs.winehq.org/userprefs.cgi?tab=email Do not reply to this email, post in Bugzilla using the above URL to reply. ------- You are receiving this mail because: ------- You are watching all bug changes.
http://bugs.winehq.org/show_bug.cgi?id=16605 --- Comment #3 from Will Tipton <wtipton(a)hmc.edu> 2008-12-24 09:10:51 --- Created an attachment (id=18172) --> (http://bugs.winehq.org/attachment.cgi?id=18172) compilation errors during regression test -- Configure bugmail: http://bugs.winehq.org/userprefs.cgi?tab=email Do not reply to this email, post in Bugzilla using the above URL to reply. ------- You are receiving this mail because: ------- You are watching all bug changes.
http://bugs.winehq.org/show_bug.cgi?id=16605 Will Tipton <wtipton(a)hmc.edu> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #18148|application/octet-stream |text/plain mime type| | -- Configure bugmail: http://bugs.winehq.org/userprefs.cgi?tab=email Do not reply to this email, post in Bugzilla using the above URL to reply. ------- You are receiving this mail because: ------- You are watching all bug changes.
http://bugs.winehq.org/show_bug.cgi?id=16605 --- Comment #4 from Austin English <austinenglish(a)gmail.com> 2008-12-24 09:24:46 --- (In reply to comment #3)
Created an attachment (id=18172) --> (http://bugs.winehq.org/attachment.cgi?id=18172) [details] compilation errors during regression test
Part of a commit was missing for a while, try: $ git show 4cca303be0485ae3a224ff01af68042d6e27e5e3 | patch -p1 and recompile that bisect. You'll need to revert the patch before issuing another bisect: $ git show 4cca303be0485ae3a224ff01af68042d6e27e5e3 | patch -p1 -R -- Configure bugmail: http://bugs.winehq.org/userprefs.cgi?tab=email Do not reply to this email, post in Bugzilla using the above URL to reply. ------- You are receiving this mail because: ------- You are watching all bug changes.
http://bugs.winehq.org/show_bug.cgi?id=16605 --- Comment #5 from Will Tipton <wtipton(a)hmc.edu> 2008-12-24 09:57:01 --- I think git-show just gives a textual diff. In particular, since checks.bmp is binary, it just gives $ git show 4cca303be0485ae3a224ff01af68042d6e27e5e3 commit 4cca303be0485ae3a224ff01af68042d6e27e5e3 Author: Alexandre Julliard <julliard(a)winehq.org> Date: Fri Dec 19 18:31:35 2008 +0100 cryptui: Commit checks.bmp missed in a previous patch. diff --git a/dlls/cryptui/checks.bmp b/dlls/cryptui/checks.bmp new file mode 100644 index 0000000..d3f1b66 Binary files /dev/null and b/dlls/cryptui/checks.bmp differ and the patching fails. Sorry I'm not so great with git, but how do we get the full patch? Thanks -- Configure bugmail: http://bugs.winehq.org/userprefs.cgi?tab=email Do not reply to this email, post in Bugzilla using the above URL to reply. ------- You are receiving this mail because: ------- You are watching all bug changes.
http://bugs.winehq.org/show_bug.cgi?id=16605 --- Comment #6 from Austin English <austinenglish(a)gmail.com> 2008-12-24 11:48:31 --- (In reply to comment #5)
I think git-show just gives a textual diff. In particular, since checks.bmp is binary, it just gives
$ git show 4cca303be0485ae3a224ff01af68042d6e27e5e3
commit 4cca303be0485ae3a224ff01af68042d6e27e5e3 Author: Alexandre Julliard <julliard(a)winehq.org> Date: Fri Dec 19 18:31:35 2008 +0100
cryptui: Commit checks.bmp missed in a previous patch.
diff --git a/dlls/cryptui/checks.bmp b/dlls/cryptui/checks.bmp new file mode 100644 index 0000000..d3f1b66 Binary files /dev/null and b/dlls/cryptui/checks.bmp differ
and the patching fails. Sorry I'm not so great with git, but how do we get the full patch?
Thanks
As a guess, you could try putting a copy of that file in the directory. You can get it online here: http://source.winehq.org/git/wine.git/?a=blob;f=dlls/cryptui/checks.bmp Though that may be a bug in git... -- Configure bugmail: http://bugs.winehq.org/userprefs.cgi?tab=email Do not reply to this email, post in Bugzilla using the above URL to reply. ------- You are receiving this mail because: ------- You are watching all bug changes.
http://bugs.winehq.org/show_bug.cgi?id=16605 Will Tipton <wtipton(a)hmc.edu> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |dylan.ah.smith(a)gmail.com --- Comment #7 from Will Tipton <wtipton(a)hmc.edu> 2008-12-24 19:43:10 --- Ok so manually sticking in the bitmap worked and the regression test gives: 5dc1271ba6af791e2f7475da12ed7fb1b25451ba is first bad commit commit 5dc1271ba6af791e2f7475da12ed7fb1b25451ba Author: Dylan Smith <dylan.ah.smith(a)gmail.com> Date: Fri Dec 19 10:57:28 2008 -0500 richedit: Move message handling to function callable without window. In order to make the message handling available to windowless richedit controls, the message handling must be in a function that can be called from the ITextServices_TxSendMessage method. This method will never have a handle to a window to pass to RichEditWndProc_common in order to get the editor with GetWindowLongPtrW, but passing the editor will work (even if hWnd is NULL). :040000 040000 b56a87544f3da8cafe474b8407ce0df28400cd67 190f0ce5d8876087d2c839127366debd49a20921 M dlls and indeed it shows to be crashing at riched20/editor.c:3824: SetWindowLongPtrW(editor->hWnd, 0, 0); Cheers -- Configure bugmail: http://bugs.winehq.org/userprefs.cgi?tab=email Do not reply to this email, post in Bugzilla using the above URL to reply. ------- You are receiving this mail because: ------- You are watching all bug changes.
http://bugs.winehq.org/show_bug.cgi?id=16605 --- Comment #8 from Austin English <austinenglish(a)gmail.com> 2008-12-25 16:14:30 --- Can you get a +riched log? -- Configure bugmail: http://bugs.winehq.org/userprefs.cgi?tab=email Do not reply to this email, post in Bugzilla using the above URL to reply. ------- You are receiving this mail because: ------- You are watching all bug changes.
http://bugs.winehq.org/show_bug.cgi?id=16605 --- Comment #9 from Will Tipton <wtipton(a)hmc.edu> 2008-12-26 09:47:26 --- Created an attachment (id=18197) --> (http://bugs.winehq.org/attachment.cgi?id=18197) WINEDEBUG=+riched -- Configure bugmail: http://bugs.winehq.org/userprefs.cgi?tab=email Do not reply to this email, post in Bugzilla using the above URL to reply. ------- You are receiving this mail because: ------- You are watching all bug changes.
http://bugs.winehq.org/show_bug.cgi?id=16605 Dylan Smith <dylan.ah.smith(a)gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- AssignedTo|wine-bugs(a)winehq.org |dylan.ah.smith(a)gmail.com Status|UNCONFIRMED |ASSIGNED Ever Confirmed|0 |1 --- Comment #10 from Dylan Smith <dylan.ah.smith(a)gmail.com> 2008-12-26 23:10:37 --- Created an attachment (id=18227) --> (http://bugs.winehq.org/attachment.cgi?id=18227) Prevents the observed crash. This bug was caused by dereferencing the editor pointer after it was freed. It was fixed in my local commits, but this bug must have been created as I was splitting up my patches. You can apply the patch and make sure it fixes the bug. -- Configure bugmail: http://bugs.winehq.org/userprefs.cgi?tab=email Do not reply to this email, post in Bugzilla using the above URL to reply. ------- You are receiving this mail because: ------- You are watching all bug changes.
http://bugs.winehq.org/show_bug.cgi?id=16605 --- Comment #11 from Will Tipton <wtipton(a)hmc.edu> 2008-12-26 23:28:27 --- Yup that did it. Thanks! -- Configure bugmail: http://bugs.winehq.org/userprefs.cgi?tab=email Do not reply to this email, post in Bugzilla using the above URL to reply. ------- You are receiving this mail because: ------- You are watching all bug changes.
http://bugs.winehq.org/show_bug.cgi?id=16605 Austin English <austinenglish(a)gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Keywords| |patch -- Configure bugmail: http://bugs.winehq.org/userprefs.cgi?tab=email Do not reply to this email, post in Bugzilla using the above URL to reply. ------- You are receiving this mail because: ------- You are watching all bug changes.
http://bugs.winehq.org/show_bug.cgi?id=16605 Dylan Smith <dylan.ah.smith(a)gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |RESOLVED Resolution| |FIXED --- Comment #12 from Dylan Smith <dylan.ah.smith(a)gmail.com> 2008-12-28 16:47:58 --- My patch that fixed the bug is now in the main git tree as commit c9977df85306f0403c7eeeee7fd041d9b3ac88f8. -- Configure bugmail: http://bugs.winehq.org/userprefs.cgi?tab=email Do not reply to this email, post in Bugzilla using the above URL to reply. ------- You are receiving this mail because: ------- You are watching all bug changes.
http://bugs.winehq.org/show_bug.cgi?id=16605 Alexandre Julliard <julliard(a)winehq.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|RESOLVED |CLOSED --- Comment #13 from Alexandre Julliard <julliard(a)winehq.org> 2009-01-02 10:34:25 --- Closing bugs fixed in 1.1.12. -- Configure bugmail: http://bugs.winehq.org/userprefs.cgi?tab=email Do not reply to this email, post in Bugzilla using the above URL to reply. ------- You are receiving this mail because: ------- You are watching all bug changes.
participants (1)
-
wine-bugs＠winehq.org