[Bug 39473] New: Some of PropVariantCopy tests results are masked by faulty logic

https://bugs.winehq.org/show_bug.cgi?id=39473

            Bug ID: 39473
           Summary: Some of PropVariantCopy tests results are masked by
                    faulty logic
           Product: Wine
           Version: 1.7.53
          Hardware: x86
                OS: Linux
            Status: NEW
          Severity: normal
          Priority: P2
         Component: ole32
          Assignee: wine-bugs(a)winehq.org
          Reporter: bunglehead(a)gmail.com
      Distribution: ---

After commit
http://source.winehq.org/git/wine.git/commit/d68c13a8941e4e4c298c7dd0d1e26f6...
some test cases are effectively disabled, because of the way operator
precedence works:

---
+        ok(hr == copy ? DISP_E_BADVARTYPE : STG_E_INVALIDPARAMETER, "%s (%s):
got %08x\n", wine_vtypes[idx], modifier, hr);
---

No matter what 'hr == copy' value is ok() condition is never zero. I'm assuming
intention was to do:

---
hr == (copy ? ...)
---

Such simple change brings some tests failures though, but what we have now is
wrong in any case.

P.S. discovered by PVS-Studio guys, present in their recent run log.

-- 
Do not reply to this email, post in Bugzilla using the
above URL to reply.
You are receiving this mail because:
You are watching all bug changes.

[Bug 39473] Some of PropVariantCopy tests results are masked by faulty logic

https://bugs.winehq.org/show_bug.cgi?id=39473

Nikolay Sivov <bunglehead(a)gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
           Keywords|                            |regression
    Regression SHA1|                            |d68c13a8941e4e4c298c7dd0d1e
                   |                            |26f683c083583

-- 
Do not reply to this email, post in Bugzilla using the
above URL to reply.
You are receiving this mail because:
You are watching all bug changes.

[Bug 39473] Some of PropVariantCopy tests results are masked by faulty logic

https://bugs.winehq.org/show_bug.cgi?id=39473

Sebastian Lackner <sebastian(a)fds-team.de> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |dmitry(a)baikal.ru,
                   |                            |sebastian(a)fds-team.de

-- 
Do not reply to this email, post in Bugzilla using the
above URL to reply.
You are receiving this mail because:
You are watching all bug changes.

[Bug 39473] Some of PropVariantCopy tests results are masked by faulty logic

https://bugs.winehq.org/show_bug.cgi?id=39473

Nikolay Sivov <bunglehead(a)gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
      Fixed by SHA1|                            |f9bc636d357221dfc036aacf848
                   |                            |58257f045a1fe
             Status|NEW                         |RESOLVED
         Resolution|---                         |FIXED

--- Comment #1 from Nikolay Sivov <bunglehead(a)gmail.com> ---
Fixed with f9bc636d357221dfc036aacf84858257f045a1fe.

-- 
Do not reply to this email, post in Bugzilla using the
above URL to reply.
You are receiving this mail because:
You are watching all bug changes.

[Bug 39473] Some of PropVariantCopy tests results are masked by faulty logic

https://bugs.winehq.org/show_bug.cgi?id=39473

Alexandre Julliard <julliard(a)winehq.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|RESOLVED                    |CLOSED

--- Comment #2 from Alexandre Julliard <julliard(a)winehq.org> ---
Closing bugs fixed in 1.7.54.

-- 
Do not reply to this email, post in Bugzilla using the
above URL to reply.
You are receiving this mail because:
You are watching all bug changes.