[Bug 11763] New: Bug fix and small improvement of function MSVCRT_fputc in dlls/msvcrt/file .c.

http://bugs.winehq.org/show_bug.cgi?id=11763

           Summary: Bug fix and small improvement of function MSVCRT_fputc
                    in dlls/msvcrt/file.c.
           Product: Wine
           Version: CVS/GIT
          Platform: All
        OS/Version: All
            Status: UNCONFIRMED
          Severity: enhancement
          Priority: P3
         Component: msvcrt
        AssignedTo: wine-bugs(a)winehq.org
        ReportedBy: pawel.ludwiczak(a)gmail.com


Created an attachment (id=11023)
 --> (http://bugs.winehq.org/attachment.cgi?id=11023)
Proposed solution

Bug fix:
In Function MSVCRT_fputc from dlls/msvcrt/file.c, if there are no errors, the
same character that has been written should be returned, but the value should
be converted to an 'unsigned char' before will be returned. Otherwise e.g. if
input character = 0xffffffff, the returned value will not equal to 0xff, we
will 
get EOF instead.

Small improvement:
In my opinion, the function MSVCRT_fputc flushes a buffer when get '\n' and it
is OK, but when the file is opened in binary mode this behaviour is unnecessary
and decrease efficiency.


-- 
Configure bugmail: http://bugs.winehq.org/userprefs.cgi?tab=email
Do not reply to this email, post in Bugzilla using the
above URL to reply.
------- You are receiving this mail because: -------
You are watching all bug changes.

[Bug 11763] Bug fix and small improvement of function MSVCRT_fputc in dlls/ msvcrt/file.c.

http://bugs.winehq.org/show_bug.cgi?id=11763


Pawel <pawel.ludwiczak(a)gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |pawel.ludwiczak(a)gmail.com




-- 
Configure bugmail: http://bugs.winehq.org/userprefs.cgi?tab=email
Do not reply to this email, post in Bugzilla using the
above URL to reply.
------- You are receiving this mail because: -------
You are watching all bug changes.

[Bug 11763] Bug fix and small improvement of function MSVCRT_fputc in dlls/msvcrt/file.c.

http://bugs.winehq.org/show_bug.cgi?id=11763


Austin English <austinenglish(a)gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
           Keywords|                            |patch




--- Comment #1 from Austin English <austinenglish(a)gmail.com>  2008-06-12 11:03:58 ---
Is this still an issue in current (1.0-rc4 or newer) wine? Please submit
patches to wine-patches(a)winehq.org


-- 
Configure bugmail: http://bugs.winehq.org/userprefs.cgi?tab=email
Do not reply to this email, post in Bugzilla using the
above URL to reply.
------- You are receiving this mail because: -------
You are watching all bug changes.

[Bug 11763] Bug fix and small improvement of function MSVCRT_fputc in dlls/msvcrt/file.c.

http://bugs.winehq.org/show_bug.cgi?id=11763


Austin English <austinenglish(a)gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|UNCONFIRMED                 |RESOLVED
         Resolution|                            |ABANDONED




--- Comment #2 from Austin English <austinenglish(a)gmail.com>  2008-12-11 11:14:25 ---
Abandoned.


-- 
Configure bugmail: http://bugs.winehq.org/userprefs.cgi?tab=email
Do not reply to this email, post in Bugzilla using the
above URL to reply.
------- You are receiving this mail because: -------
You are watching all bug changes.

[Bug 11763] Bug fix and small improvement of function MSVCRT_fputc in dlls/msvcrt/file.c.

http://bugs.winehq.org/show_bug.cgi?id=11763


Austin English <austinenglish(a)gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|RESOLVED                    |CLOSED




--- Comment #3 from Austin English <austinenglish(a)gmail.com>  2008-12-11 11:18:04 ---
Closing.


-- 
Configure bugmail: http://bugs.winehq.org/userprefs.cgi?tab=email
Do not reply to this email, post in Bugzilla using the
above URL to reply.
------- You are receiving this mail because: -------
You are watching all bug changes.

[Bug 11763] Bug fix and small improvement of function MSVCRT_fputc in dlls/msvcrt/file.c.

http://bugs.winehq.org/show_bug.cgi?id=11763


Austin English <austinenglish(a)gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
            Version|CVS/GIT                     |unspecified




-- 
Configure bugmail: http://bugs.winehq.org/userprefs.cgi?tab=email
Do not reply to this email, post in Bugzilla using the
above URL to reply.
------- You are receiving this mail because: -------
You are watching all bug changes.

[Bug 11763] Bug fix and small improvement of function MSVCRT_fputc in dlls/msvcrt/file.c.

http://bugs.winehq.org/show_bug.cgi?id=11763

Austin English <austinenglish(a)gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
           Platform|All                         |Other
         OS/Version|All                         |other

--- Comment #4 from Austin English <austinenglish(a)gmail.com> 2012-02-23 15:03:19 CST ---
Removing deprecated 'All' Platform/OS.

-- 
Configure bugmail: http://bugs.winehq.org/userprefs.cgi?tab=email
Do not reply to this email, post in Bugzilla using the
above URL to reply.
------- You are receiving this mail because: -------
You are watching all bug changes.