[Bug 10156] New: "typos" on some include files
http://bugs.winehq.org/show_bug.cgi?id=10156 Summary: "typos" on some include files Product: Wine Version: 0.9.47. Platform: All OS/Version: All Status: UNCONFIRMED Severity: enhancement Priority: P2 Component: wine-winelib AssignedTo: wine-bugs(a)winehq.org ReportedBy: sacrom(a)gmail.com CC: sacrom(a)gmail.com Created an attachment (id=8741) --> (http://bugs.winehq.org/attachment.cgi?id=8741) File that contains diff's of the current header files with the "fixed" header files I'm porting a windows app to Wine (using WineLib) and I found some small problems in some header files in Wine (that contain different values from the corresponding Windows header files). To be able to compile on C++ I did also change some header files.
From my point of view these are small typos problems (see attachment) I hope this to be enough!
-- Configure bugmail: http://bugs.winehq.org/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are watching all bug changes.
http://bugs.winehq.org/show_bug.cgi?id=10156 --- Comment #1 from Dmitry Timoshkov <dmitry(a)codeweavers.com> 2007-10-24 07:19:06 --- Please send the patch in 'diff -up' format to wine-patches. -- Configure bugmail: http://bugs.winehq.org/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are watching all bug changes.
http://bugs.winehq.org/show_bug.cgi?id=10156 James Hawkins <truiken(a)gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Component|_obsolete_winelib |build-env --- Comment #2 from James Hawkins <truiken(a)gmail.com> 2008-01-07 16:30:33 --- I guess headers are a part of the build environment..? -- Configure bugmail: http://bugs.winehq.org/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are watching all bug changes.
http://bugs.winehq.org/show_bug.cgi?id=10156 Austin English <austinenglish(a)gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #8741 is|0 |1 obsolete| | --- Comment #3 from Austin English <austinenglish(a)gmail.com> 2008-06-12 12:01:31 --- Created an attachment (id=13946) --> (http://bugs.winehq.org/attachment.cgi?id=13946) updated patch Updated patch -- Configure bugmail: http://bugs.winehq.org/userprefs.cgi?tab=email Do not reply to this email, post in Bugzilla using the above URL to reply. ------- You are receiving this mail because: ------- You are watching all bug changes.
http://bugs.winehq.org/show_bug.cgi?id=10156 Austin English <austinenglish(a)gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |austinenglish(a)gmail.com Keywords| |patch -- Configure bugmail: http://bugs.winehq.org/userprefs.cgi?tab=email Do not reply to this email, post in Bugzilla using the above URL to reply. ------- You are receiving this mail because: ------- You are watching all bug changes.
http://bugs.winehq.org/show_bug.cgi?id=10156 Jon Griffiths <jon_p_griffiths(a)yahoo.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |jon_p_griffiths(a)yahoo.com --- Comment #4 from Jon Griffiths <jon_p_griffiths(a)yahoo.com> 2008-06-20 07:16:36 --- Hi Marcos, As of commit c3995814d71291c435722ea36f46bcfa12c137c2 the required header changes are now part of Wine. The change you made to oleaut32.def is not valid though - we must implement OleLoadPictureFile in order for your app to link and run correctly. I was going to add a stub for this, but it looks like most of the code is already there to load the file, so I'll have a go at doing it properly. In the meantime we should probably rename this bug to "OleLoadPictureFile not implemented" to prevent duplicates if anyone else needs this function. -- Configure bugmail: http://bugs.winehq.org/userprefs.cgi?tab=email Do not reply to this email, post in Bugzilla using the above URL to reply. ------- You are receiving this mail because: ------- You are watching all bug changes.
http://bugs.winehq.org/show_bug.cgi?id=10156 Jon Griffiths <jon_p_griffiths(a)yahoo.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |jon_p_griffiths(a)yahoo.com Jeremy Drake <wine(a)jdrake.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |wine(a)jdrake.com --- Comment #4 from Jon Griffiths <jon_p_griffiths(a)yahoo.com> 2008-06-20 07:16:36 --- Hi Marcos, As of commit c3995814d71291c435722ea36f46bcfa12c137c2 the required header changes are now part of Wine. The change you made to oleaut32.def is not valid though - we must implement OleLoadPictureFile in order for your app to link and run correctly. I was going to add a stub for this, but it looks like most of the code is already there to load the file, so I'll have a go at doing it properly. In the meantime we should probably rename this bug to "OleLoadPictureFile not implemented" to prevent duplicates if anyone else needs this function. --- Comment #5 from Jeremy Drake <wine(a)jdrake.com> 2008-11-17 00:34:42 --- It turns out I am needing OleLoadPictureFile as well. If this bug was renamed as suggested in comment #4, it would describe my situation perfectly. -- Configure bugmail: http://bugs.winehq.org/userprefs.cgi?tab=email Do not reply to this email, post in Bugzilla using the above URL to reply. ------- You are receiving this mail because: ------- You are watching all bug changes.
http://bugs.winehq.org/show_bug.cgi?id=10156 Austin English <austinenglish(a)gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Summary|"typos" on some include |OleLoadPictureFile is |files |unimplemented -- Configure bugmail: http://bugs.winehq.org/userprefs.cgi?tab=email Do not reply to this email, post in Bugzilla using the above URL to reply. ------- You are receiving this mail because: ------- You are watching all bug changes.
http://bugs.winehq.org/show_bug.cgi?id=10156 Marcos Gutiérrez Batz <sacrom(a)gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|UNCONFIRMED |NEW Ever Confirmed|0 |1 --- Comment #6 from Marcos Gutiérrez Batz <sacrom(a)gmail.com> 2008-11-18 15:36:23 --- *** This bug has been confirmed by popular vote. *** -- Configure bugmail: http://bugs.winehq.org/userprefs.cgi?tab=email Do not reply to this email, post in Bugzilla using the above URL to reply. ------- You are receiving this mail because: ------- You are watching all bug changes.
http://bugs.winehq.org/show_bug.cgi?id=10156 nathan.n <saturn_systems(a)yahoo.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |saturn_systems(a)yahoo.com -- Configure bugmail: http://bugs.winehq.org/userprefs.cgi?tab=email Do not reply to this email, post in Bugzilla using the above URL to reply. ------- You are receiving this mail because: ------- You are watching all bug changes.
http://bugs.winehq.org/show_bug.cgi?id=10156 --- Comment #7 from Austin English <austinenglish(a)gmail.com> 2009-06-02 10:23:24 --- Still unimplemented. -- Configure bugmail: http://bugs.winehq.org/userprefs.cgi?tab=email Do not reply to this email, post in Bugzilla using the above URL to reply. ------- You are receiving this mail because: ------- You are watching all bug changes.
http://bugs.winehq.org/show_bug.cgi?id=10156 --- Comment #8 from Austin English <austinenglish(a)gmail.com> 2009-12-31 11:25:53 --- Still unimplemented. -- Configure bugmail: http://bugs.winehq.org/userprefs.cgi?tab=email Do not reply to this email, post in Bugzilla using the above URL to reply. ------- You are receiving this mail because: ------- You are watching all bug changes.
http://bugs.winehq.org/show_bug.cgi?id=10156 Jeff Zaroyko <jeffz(a)jeffz.name> changed: What |Removed |Added ---------------------------------------------------------------------------- Keywords| |download URL| |http://t4c.eacceleration.co | |m/ --- Comment #9 from Jeff Zaroyko <jeffz(a)jeffz.name> 2010-01-11 04:11:03 --- The 4th guest installer aborts due to this unimplemented function if run in Win98 mode. Adding download keyword and URL. -- Configure bugmail: http://bugs.winehq.org/userprefs.cgi?tab=email Do not reply to this email, post in Bugzilla using the above URL to reply. ------- You are receiving this mail because: ------- You are watching all bug changes.
http://bugs.winehq.org/show_bug.cgi?id=10156 Jeff Zaroyko <jeffz(a)jeffz.name> changed: What |Removed |Added ---------------------------------------------------------------------------- Severity|enhancement |normal -- Configure bugmail: http://bugs.winehq.org/userprefs.cgi?tab=email Do not reply to this email, post in Bugzilla using the above URL to reply. ------- You are receiving this mail because: ------- You are watching all bug changes.
http://bugs.winehq.org/show_bug.cgi?id=10156 Ole Rasmussen <olerass(a)gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |olerass(a)gmail.com --- Comment #10 from Ole Rasmussen <olerass(a)gmail.com> 2010-06-11 09:53:18 --- Still present in Wine1.2-rc2. -- Configure bugmail: http://bugs.winehq.org/userprefs.cgi?tab=email Do not reply to this email, post in Bugzilla using the above URL to reply. ------- You are receiving this mail because: ------- You are watching all bug changes.
http://bugs.winehq.org/show_bug.cgi?id=10156 NSLW <lukasz.wojnilowicz(a)gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |lukasz.wojnilowicz(a)gmail.co | |m --- Comment #11 from NSLW <lukasz.wojnilowicz(a)gmail.com> 2011-04-12 04:30:01 CDT --- Still present in wine-1.3.17-216-gca05ebc with http://www.goodsync.com/download/GoodSync-Setup.exe -- Configure bugmail: http://bugs.winehq.org/userprefs.cgi?tab=email Do not reply to this email, post in Bugzilla using the above URL to reply. ------- You are receiving this mail because: ------- You are watching all bug changes.
http://bugs.winehq.org/show_bug.cgi?id=10156 Austin English <austinenglish(a)gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Platform|All |Other OS/Version|All |other --- Comment #12 from Austin English <austinenglish(a)gmail.com> 2012-02-23 15:19:52 CST --- Removing deprecated 'All' Platform/OS. -- Configure bugmail: http://bugs.winehq.org/userprefs.cgi?tab=email Do not reply to this email, post in Bugzilla using the above URL to reply. ------- You are receiving this mail because: ------- You are watching all bug changes.
http://bugs.winehq.org/show_bug.cgi?id=10156 Carlo Bramini <carlo.bramix(a)libero.it> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |carlo.bramix(a)libero.it --- Comment #13 from Carlo Bramini <carlo.bramix(a)libero.it> 2013-03-09 06:19:46 CST --- The changes in the attached patch are not clear to me: unless I have understood something wrong, MSDN states quite clearly that the interested field in LINEADDRESSSTATUS is dwNumOnHoldPendCalls and not dwNumOnHoldPendingCalls. http://msdn.microsoft.com/en-us/library/windows/desktop/ms734938%28v=vs.85%2... -- Configure bugmail: http://bugs.winehq.org/userprefs.cgi?tab=email Do not reply to this email, post in Bugzilla using the above URL to reply. ------- You are receiving this mail because: ------- You are watching all bug changes.
https://bugs.winehq.org/show_bug.cgi?id=10156 Austin English <austinenglish(a)gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |tbodrey2(a)gmail.com --- Comment #14 from Austin English <austinenglish(a)gmail.com> --- *** Bug 39786 has been marked as a duplicate of this bug. *** -- Do not reply to this email, post in Bugzilla using the above URL to reply. You are receiving this mail because: You are watching all bug changes.
https://bugs.winehq.org/show_bug.cgi?id=10156 tomlohave <tomlohave(a)gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |tomlohave(a)gmail.com --- Comment #15 from tomlohave <tomlohave(a)gmail.com> --- Created attachment 53914 --> https://bugs.winehq.org/attachment.cgi?id=53914 unimplemented function oleaut32.dll.OleLoadPictureFile -- Do not reply to this email, post in Bugzilla using the above URL to reply. You are receiving this mail because: You are watching all bug changes.
https://bugs.winehq.org/show_bug.cgi?id=10156 --- Comment #16 from tomlohave <tomlohave(a)gmail.com> --- It affects XLPro3 400 too. -- Do not reply to this email, post in Bugzilla using the above URL to reply. You are receiving this mail because: You are watching all bug changes.
https://bugs.winehq.org/show_bug.cgi?id=10156 Austin English <austinenglish(a)gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- OS|other |Linux Hardware|Other |x86 --- Comment #17 from Austin English <austinenglish(a)gmail.com> --- (In reply to Carlo Bramini from comment #13)
The changes in the attached patch are not clear to me: unless I have understood something wrong, MSDN states quite clearly that the interested field in LINEADDRESSSTATUS is dwNumOnHoldPendCalls and not dwNumOnHoldPendingCalls.
http://msdn.microsoft.com/en-us/library/windows/desktop/ms734938%28v=vs. 85%29.aspx
From comment #4, it looks like those changes were wrong. The fix was: commit c3995814d71291c435722ea36f46bcfa12c137c2 Author: Jon Griffiths <jon_p_griffiths(a)yahoo.com> Date: Wed Jun 18 18:57:15 2008 -0700
oleidl.h: Fix spelling of OLECONTF_ONLYUSER (reported by Marcos Gutiérrez Batz). diff --git a/include/oleidl.idl b/include/oleidl.idl index 169d83b..5c92cb1 100644 --- a/include/oleidl.idl +++ b/include/oleidl.idl @@ -333,7 +333,7 @@ interface IOleItemContainer : IOleContainer OLECONTF_EMBEDDINGS = 1, OLECONTF_LINKS = 2, OLECONTF_OTHERS = 4, - OLECONTF_OLNYUSER = 8, + OLECONTF_ONLYUSER = 8, OLECONTF_ONLYIFRUNNING = 16 } OLECONTF; -- Do not reply to this email, post in Bugzilla using the above URL to reply. You are receiving this mail because: You are watching all bug changes.
https://bugs.winehq.org/show_bug.cgi?id=10156 Austin English <austinenglish(a)gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Fixed by SHA1| |c3995814d71291c435722ea36f4 | |6bcfa12c137c2 Resolution|--- |FIXED Status|NEW |RESOLVED --- Comment #18 from Austin English <austinenglish(a)gmail.com> --- (In reply to Austin English from comment #17)
(In reply to Carlo Bramini from comment #13)
The changes in the attached patch are not clear to me: unless I have understood something wrong, MSDN states quite clearly that the interested field in LINEADDRESSSTATUS is dwNumOnHoldPendCalls and not dwNumOnHoldPendingCalls.
http://msdn.microsoft.com/en-us/library/windows/desktop/ms734938%28v=vs. 85%29.aspx
From comment #4, it looks like those changes were wrong. The fix was: commit c3995814d71291c435722ea36f46bcfa12c137c2 Author: Jon Griffiths <jon_p_griffiths(a)yahoo.com> Date: Wed Jun 18 18:57:15 2008 -0700
oleidl.h: Fix spelling of OLECONTF_ONLYUSER (reported by Marcos Gutiérrez Batz).
diff --git a/include/oleidl.idl b/include/oleidl.idl index 169d83b..5c92cb1 100644 --- a/include/oleidl.idl +++ b/include/oleidl.idl @@ -333,7 +333,7 @@ interface IOleItemContainer : IOleContainer OLECONTF_EMBEDDINGS = 1, OLECONTF_LINKS = 2, OLECONTF_OTHERS = 4, - OLECONTF_OLNYUSER = 8, + OLECONTF_ONLYUSER = 8, OLECONTF_ONLYIFRUNNING = 16 } OLECONTF;
Actually, it seems there are two bugs here. The original was Marcos' header issue, which is fixed. The other is bug is OleLoadPictureFile being unimplemented, which I reopened. -- Do not reply to this email, post in Bugzilla using the above URL to reply. You are receiving this mail because: You are watching all bug changes.
https://bugs.winehq.org/show_bug.cgi?id=10156 Austin English <austinenglish(a)gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Summary|OleLoadPictureFile is |oleidl.h has |unimplemented |OLECONTF_ONLYUSER | |misspelled -- Do not reply to this email, post in Bugzilla using the above URL to reply. You are receiving this mail because: You are watching all bug changes.
https://bugs.winehq.org/show_bug.cgi?id=10156 Alexandre Julliard <julliard(a)winehq.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|RESOLVED |CLOSED --- Comment #19 from Alexandre Julliard <julliard(a)winehq.org> --- Closing bugs fixed in 1.9.7. -- Do not reply to this email, post in Bugzilla using the above URL to reply. You are receiving this mail because: You are watching all bug changes.
participants (1)
-
wine-bugs＠winehq.org