[Bug 50719] New: The TestBot mishandles renames

[WineHQ Bugzilla]

https://bugs.winehq.org/show_bug.cgi?id=50719

            Bug ID: 50719
           Summary: The TestBot mishandles renames
           Product: Wine-Testbot
           Version: unspecified
          Hardware: x86-64
                OS: Linux
            Status: NEW
          Severity: normal
          Priority: P2
         Component: unknown
          Assignee: wine-bugs(a)winehq.org
          Reporter: fgouget(a)codeweavers.com
      Distribution: ---

The TestBot analyses patches to determine whether they are Wine patches and
which tests are impacted and must be rerun.

But when a patch renames a test unit it still schedules a run for the renamed
test unit. For instance if apphelp:apphelp is renamed to apphelp:renamed, the
TestBot still schedules a run of apphelp:apphelp (in addition to the
apphelp:renamed one).

This means it does not keep track of Wine's current files list correctly, which
also impacts identifying whether a patch is a Wine patch or not, particularly
for patch series.

This can be tested with the following wtbsuite tests:
WTBS Check combined renaming and modifying a file (apphelp:apphelp).
[2/2] WTBS S10.2 - ...before renaming it in the next part (amstream:amstream).
[7/7] WTBS S5.7 - Check for rename+addition+removal conflicts (msi:suminfo).

-- 
Do not reply to this email, post in Bugzilla using the
above URL to reply.
You are receiving this mail because:
You are watching all bug changes.

[Bug 50719] The TestBot mishandles renames

[WineHQ Bugzilla]

https://bugs.winehq.org/show_bug.cgi?id=50719

François Gouget <fgouget(a)codeweavers.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|NEW                         |RESOLVED
         Resolution|---                         |FIXED
      Fixed by SHA1|                            |af6cc2feff12b6cb40d45bb68f8
                   |                            |c29f3485e3639

--- Comment #1 from François Gouget <fgouget(a)codeweavers.com> ---
Now all that remains is bug 50720.

commit af6cc2feff12b6cb40d45bb68f8c29f3485e3639
Author: Francois Gouget <fgouget(a)codeweavers.com>
Date:   Thu Mar 11 14:01:43 2021 +0100

    testbot/PatchUtils: Fix handling of renames.

    Wine-Bug: https://bugs.winehq.org/show_bug.cgi?id=50719
    Signed-off-by: Francois Gouget <fgouget(a)codeweavers.com>
    Signed-off-by: Alexandre Julliard <julliard(a)winehq.org>

-- 
Do not reply to this email, post in Bugzilla using the
above URL to reply.
You are receiving this mail because:
You are watching all bug changes.

[Bug 50719] The TestBot mishandles renames

[WineHQ Bugzilla]

https://bugs.winehq.org/show_bug.cgi?id=50719

François Gouget <fgouget(a)codeweavers.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|RESOLVED                    |CLOSED

--- Comment #2 from François Gouget <fgouget(a)codeweavers.com> ---
Closing.

-- 
Do not reply to this email, post in Bugzilla using the
above URL to reply.
You are receiving this mail because:
You are watching all bug changes.