[Bug 45502] New: No sound in Starcraft II
https://bugs.winehq.org/show_bug.cgi?id=45502 Bug ID: 45502 Summary: No sound in Starcraft II Product: Wine-staging Version: 3.13 Hardware: x86 OS: Linux Status: UNCONFIRMED Severity: normal Priority: P2 Component: -unknown Assignee: wine-bugs(a)winehq.org Reporter: maciej.stanczew+b(a)gmail.com CC: leslie_alistair(a)hotmail.com, z.figura12(a)gmail.com Distribution: --- Using Wine Staging 3.13, there is no sound in Starcraft II. The problem is not present in Wine Staging 3.12 and in plain Wine 3.13. Regression points to commit 18f4be0e03c69d9548a62f5f5048dc6d0d69d8e1: "Updated winepulse-PulseAudio_Support patchset". Reverting just this commit makes the sound work again in SC2. -- Do not reply to this email, post in Bugzilla using the above URL to reply. You are receiving this mail because: You are watching all bug changes.
https://bugs.winehq.org/show_bug.cgi?id=45502 dura <dura(a)duradsl.duckdns.org> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |dura(a)duradsl.duckdns.org --- Comment #1 from dura <dura(a)duradsl.duckdns.org> --- Same thin -- Do not reply to this email, post in Bugzilla using the above URL to reply. You are receiving this mail because: You are watching all bug changes.
https://bugs.winehq.org/show_bug.cgi?id=45502 --- Comment #2 from dura <dura(a)duradsl.duckdns.org> --- Just want to add me to CC List after starting a message. Sorry for the noise. I got the exact same problem. Nothing more to add so not really interesting. Anyone feel free to delete my two messages. -- Do not reply to this email, post in Bugzilla using the above URL to reply. You are receiving this mail because: You are watching all bug changes.
https://bugs.winehq.org/show_bug.cgi?id=45502 Ben Parsons <9parsonsb(a)gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |9parsonsb(a)gmail.com -- Do not reply to this email, post in Bugzilla using the above URL to reply. You are receiving this mail because: You are watching all bug changes.
https://bugs.winehq.org/show_bug.cgi?id=45502 Alistair Leslie-Hughes <leslie_alistair(a)hotmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |aeikum(a)codeweavers.com -- Do not reply to this email, post in Bugzilla using the above URL to reply. You are receiving this mail because: You are watching all bug changes.
https://bugs.winehq.org/show_bug.cgi?id=45502 --- Comment #3 from Maciej Stanczew <maciej.stanczew+b(a)gmail.com> --- Additionally, the game crashes on two occasions after this commit: a) when changing sound device output in the Options menu, and b) when exiting the game. Cause of the problem seems to be modification of usage of pa_stream_peek(): - } else { - pa_stream_peek(This->stream, (const void**)&src, &src_len); + } else if (pa_stream_peek(This->stream, (const void**)&src, &src_len) && src_len) { According to PulseAudio documentation [1], this function returns 0 on success, so the condition here will never be satisfied. Changing the condition to "0 == pa_stream_peek(..." fixes the problem. Also one interesting thing is that other Blizzard games don't seem to go into this area at all -- I added some logs to pulse_rd_loop and they didn't trigger in D3 or HotS, only in SC2 (and sound worked in those other games). [1] https://freedesktop.org/software/pulseaudio/doxygen/stream_8h.html#ac2838c44... -- Do not reply to this email, post in Bugzilla using the above URL to reply. You are receiving this mail because: You are watching all bug changes.
https://bugs.winehq.org/show_bug.cgi?id=45502 --- Comment #4 from dura <dura(a)duradsl.duckdns.org> --- The suggested change in #3 solves the problem here too. -- Do not reply to this email, post in Bugzilla using the above URL to reply. You are receiving this mail because: You are watching all bug changes.
https://bugs.winehq.org/show_bug.cgi?id=45502 Alistair Leslie-Hughes <leslie_alistair(a)hotmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|UNCONFIRMED |RESOLVED Resolution|--- |FIXED --- Comment #5 from Alistair Leslie-Hughes <leslie_alistair(a)hotmail.com> --- (In reply to Maciej Stanczew from comment #3)
Additionally, the game crashes on two occasions after this commit: a) when changing sound device output in the Options menu, and b) when exiting the game.
Cause of the problem seems to be modification of usage of pa_stream_peek(): - } else { - pa_stream_peek(This->stream, (const void**)&src, &src_len); + } else if (pa_stream_peek(This->stream, (const void**)&src, &src_len) && src_len) {
Thanks. Fixed by staging commit f0d3ae8cf201128497ddb5c3d89e1c8778726ac2. -- Do not reply to this email, post in Bugzilla using the above URL to reply. You are receiving this mail because: You are watching all bug changes.
https://bugs.winehq.org/show_bug.cgi?id=45502 --- Comment #6 from Maciej Stanczew <maciej.stanczew+b(a)gmail.com> --- Thanks, can confirm it solves the problem -- sound works and there are no crashes. -- Do not reply to this email, post in Bugzilla using the above URL to reply. You are receiving this mail because: You are watching all bug changes.
https://bugs.winehq.org/show_bug.cgi?id=45502 Stefan <hybrid(a)onlinehome.de> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |hybrid(a)onlinehome.de --- Comment #7 from Stefan <hybrid(a)onlinehome.de> --- Just want to mention this bug is also affecting heroes of the storm. Thank you for the quick resolve! -- Do not reply to this email, post in Bugzilla using the above URL to reply. You are receiving this mail because: You are watching all bug changes.
https://bugs.winehq.org/show_bug.cgi?id=45502 ykui <yumekuineru(a)hotmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |yumekuineru(a)hotmail.com --- Comment #8 from ykui <yumekuineru(a)hotmail.com> --- Sound sometimes drops out for me in the middle of a Starcraft 2 game or replay (or it seems while at main menu also). After sound drops out the same behaviour as reported here occurs where the game freezes if audio device is changed or the exit button is pressed. It might be one of my overrides since it is a prefix I have not modified in a while after I managed to get it working, though the issue started occuring quite recently. It occurs less frequently than all the time as was the case before the fixes staged in this issue though. Versions: WINE_COMMIT="25cc380b8ed41652b135657ef7651beef2f20ae4" #3.13 STAGING_COMMIT="2f3ba1fb462894ad267d72d07ed2114e0ae1f5c2" Patches applied (all seem to mainly pertain to League of Legends): 0003-Pretend-to-have-a-wow64-dll.patch 0006-Refactor-LdrInitializeThunk.patch 0007-Refactor-RtlCreateUserThread-into-NtCreateThreadEx.patch 0009-Refactor-__wine_syscall_dispatcher-for-i386.patch Attachment in https://bugs.winehq.org/show_bug.cgi?id=45550#c8 I can try to get a debug log attached from when it occurs (I can not see anything except 00cd:fixme:d3d_shader:print_glsl_info_log in the default output). -- Do not reply to this email, post in Bugzilla using the above URL to reply. You are receiving this mail because: You are watching all bug changes.
https://bugs.winehq.org/show_bug.cgi?id=45502 --- Comment #9 from dura <dura(a)duradsl.duckdns.org> --- Got same as #8 here a few days ago and I do not use additional patches. I reverted to wine-staging 3.12 since. This bug should be reopened. -- Do not reply to this email, post in Bugzilla using the above URL to reply. You are receiving this mail because: You are watching all bug changes.
https://bugs.winehq.org/show_bug.cgi?id=45502 --- Comment #10 from Andrew Eikum <aeikum(a)codeweavers.com> --- (In reply to dura from comment #9)
Got same as #8 here a few days ago and I do not use additional patches. I reverted to wine-staging 3.12 since. This bug should be reopened.
Please open a new bug, CC me on it, and attach a log with the channels from https://wiki.winehq.org/Sound along with any changes you have made to your PulseAudio configuration, including environment variables or config file changes. -- Do not reply to this email, post in Bugzilla using the above URL to reply. You are receiving this mail because: You are watching all bug changes.
https://bugs.winehq.org/show_bug.cgi?id=45502 --- Comment #11 from ykui <yumekuineru(a)hotmail.com> --- New bug opened at https://bugs.winehq.org/show_bug.cgi?id=45589 -- Do not reply to this email, post in Bugzilla using the above URL to reply. You are receiving this mail because: You are watching all bug changes.
https://bugs.winehq.org/show_bug.cgi?id=45502 Alistair Leslie-Hughes <leslie_alistair(a)hotmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|RESOLVED |CLOSED --- Comment #12 from Alistair Leslie-Hughes <leslie_alistair(a)hotmail.com> --- Closing Fixed Staging 3.14 -- Do not reply to this email, post in Bugzilla using the above URL to reply. You are receiving this mail because: You are watching all bug changes.
participants (1)
-
wine-bugs＠winehq.org