[Bug 9324] New: Mp3Tag: crash when editing the "Year" field in some cases
http://bugs.winehq.org/show_bug.cgi?id=9324 Summary: Mp3Tag: crash when editing the "Year" field in some cases Product: Wine Version: CVS Platform: PC OS/Version: Linux Status: UNCONFIRMED Severity: normal Priority: P2 Component: wine-comctl32 AssignedTo: wine-bugs(a)winehq.org ReportedBy: the_unknown(a)gmx.net Created an attachment (id=7595) --> (http://bugs.winehq.org/attachment.cgi?id=7595) winedbg output and backtrace after crash wine 0.9.43 and last git version gcc (GCC) 4.2.0 (Gentoo 4.2.0 p1.4) Linux k8t800 2.6.22-gentoo-r3 #1 PREEMPT Tue Aug 14 17:33:41 CEST 2007 i686 AMD Athlon(tm) 64 Processor 3500+ AuthenticAMD GNU/Linux How to reproduce: - download Mp3Tag v2.39 from http://www.mp3tag.de/en/download.html - edit the date field of some OGG file with another editor (e.g. via Properties->Meta Info in konqueror) to ensure it has more than 4 symbols in that, e.g. "August 2007" - open it with Mp3Tag - select this file in the list - place the cursor to the beginning of the string "August 2007" in the Year field in tag panel (left panel) - press "Delete" button -> segfault Relevant part of the winedbg output with some additional trace calls added by me attached. The problem is absent on Windows. It seems that the maximal text length in the "year" combo box in Mp3Tag is set to 4, but if a file with more text in the "Year" field is loaded, it is showed in the corresponding combo box tough. This causes a negative string length in a calculation in EDIT_EM_ReplaceSel function in dlls/user32/edit.c:3208 and a buffer overflow later (line 3236). I've made a patch which seems to work fine and do not cause unneeded side effects, but I'm not very familiar with wine internals so better check it :) I'll provide additional info if needed. -- Configure bugmail: http://bugs.winehq.org/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are watching all bug changes.
http://bugs.winehq.org/show_bug.cgi?id=9324 --- Comment #1 from the_unknown(a)gmx.net 2007-08-14 23:44:03 --- Created an attachment (id=7596) --> (http://bugs.winehq.org/attachment.cgi?id=7596) Proposed patch to fix segfault with comboboxes containing a longer text than buffer limit -- Configure bugmail: http://bugs.winehq.org/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are watching all bug changes.
http://bugs.winehq.org/show_bug.cgi?id=9324 Vitaliy Margolen <vitaliy(a)kievinfo.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Component|wine-comctl32 |wine-user --- Comment #2 from Vitaliy Margolen <vitaliy(a)kievinfo.com> 2007-08-15 07:58:49 --- Looks reasonable to me. Please send the patch to wine-patches ML. Patches are not being picked up from the bugzilla. -- Configure bugmail: http://bugs.winehq.org/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are watching all bug changes.
http://bugs.winehq.org/show_bug.cgi?id=9324 --- Comment #3 from the_unknown(a)gmx.net 2007-08-15 14:03:16 ---
Please send the patch to wine-patches ML.
Done. -- Configure bugmail: http://bugs.winehq.org/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are watching all bug changes.
http://bugs.winehq.org/show_bug.cgi?id=9324 Austin English <austinenglish(a)gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|UNCONFIRMED |NEW Ever Confirmed|0 |1 --- Comment #4 from Austin English <austinenglish(a)gmail.com> 2007-10-21 00:48:50 --- Direct Link: http://www.anytag.de/download/mp3tagv239setup.exe Still present in wine 0.9.47, kubuntu gusty. -- Configure bugmail: http://bugs.winehq.org/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are watching all bug changes.
http://bugs.winehq.org/show_bug.cgi?id=9324 Austin English <austinenglish(a)gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Keywords| |download -- Configure bugmail: http://bugs.winehq.org/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are watching all bug changes.
http://bugs.winehq.org/show_bug.cgi?id=9324 scguy318 <nodisgod(a)yahoo.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |nodisgod(a)yahoo.com --- Comment #5 from scguy318 <nodisgod(a)yahoo.com> 2008-05-13 00:19:00 --- I can't reproduce this problem with Wine 1.0-rc1, so this issue seems to be fixed. -- Configure bugmail: http://bugs.winehq.org/userprefs.cgi?tab=email Do not reply to this email, post in Bugzilla using the above URL to reply. ------- You are receiving this mail because: ------- You are watching all bug changes.
http://bugs.winehq.org/show_bug.cgi?id=9324 the_unknown(a)gmx.net changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |RESOLVED Resolution| |FIXED --- Comment #6 from the_unknown(a)gmx.net 2008-05-13 06:26:05 --- The patch was included into wine 0.9.48 and works for me since then -- Configure bugmail: http://bugs.winehq.org/userprefs.cgi?tab=email Do not reply to this email, post in Bugzilla using the above URL to reply. ------- You are receiving this mail because: ------- You are watching all bug changes.
http://bugs.winehq.org/show_bug.cgi?id=9324 Alexandre Julliard <julliard(a)winehq.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|RESOLVED |CLOSED --- Comment #7 from Alexandre Julliard <julliard(a)winehq.org> 2008-05-23 10:37:43 --- Closing bugs fixed in 1.0-rc2. -- Configure bugmail: http://bugs.winehq.org/userprefs.cgi?tab=email Do not reply to this email, post in Bugzilla using the above URL to reply. ------- You are receiving this mail because: ------- You are watching all bug changes.
http://bugs.winehq.org/show_bug.cgi?id=9324 Austin English <austinenglish(a)gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Version|CVS/GIT |unspecified -- Configure bugmail: http://bugs.winehq.org/userprefs.cgi?tab=email Do not reply to this email, post in Bugzilla using the above URL to reply. ------- You are receiving this mail because: ------- You are watching all bug changes.
participants (1)
-
wine-bugs＠winehq.org