[Bug 23453] New: Worms Armageddon cannot send text in WormNET
http://bugs.winehq.org/show_bug.cgi?id=23453 Summary: Worms Armageddon cannot send text in WormNET Product: Wine Version: 1.2-rc5 Platform: x86 OS/Version: Linux Status: NEW Keywords: regression Severity: normal Priority: P2 Component: -unknown AssignedTo: wine-bugs(a)winehq.org ReportedBy: madewokherd(a)gmail.com After logging in to WormNET and joining a channel, one should be able to send a message to the channel by typing some text and pressing enter. Pressing enter has no effect. This used to work. Regression test to follow. -- Configure bugmail: http://bugs.winehq.org/userprefs.cgi?tab=email Do not reply to this email, post in Bugzilla using the above URL to reply. ------- You are receiving this mail because: ------- You are watching all bug changes.
http://bugs.winehq.org/show_bug.cgi?id=23453 Vincent Povirk <madewokherd(a)gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |khodych(a)gmail.com Component|-unknown |user32 --- Comment #1 from Vincent Povirk <madewokherd(a)gmail.com> 2010-06-30 17:15:12 --- f1f1c5053160777d0db89b1891706b0b960d3d48 is first bad commit commit f1f1c5053160777d0db89b1891706b0b960d3d48 Author: Sergey Khodych <khodych(a)gmail.com> Date: Tue Aug 25 17:19:24 2009 +0300 user32: Use IDOK as default identifier in a template. :040000 040000 ec277af366bead5d55f43d7fd8790c90b09a0fef 99d660168abb7fa82689691408113ac39339a863 M dlls -- Configure bugmail: http://bugs.winehq.org/userprefs.cgi?tab=email Do not reply to this email, post in Bugzilla using the above URL to reply. ------- You are receiving this mail because: ------- You are watching all bug changes.
http://bugs.winehq.org/show_bug.cgi?id=23453 --- Comment #2 from Dmitry Timoshkov <dmitry(a)codeweavers.com> 2010-07-01 00:10:10 --- Bug 21295 suffers from the same commit. -- Configure bugmail: http://bugs.winehq.org/userprefs.cgi?tab=email Do not reply to this email, post in Bugzilla using the above URL to reply. ------- You are receiving this mail because: ------- You are watching all bug changes.
http://bugs.winehq.org/show_bug.cgi?id=23453 Murray Colpman <muzerakascooby(a)gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |muzerakascooby(a)gmail.com --- Comment #3 from Murray Colpman <muzerakascooby(a)gmail.com> 2010-09-08 12:43:16 CDT --- Wine 1.3.2 still contains this bug. -- Configure bugmail: http://bugs.winehq.org/userprefs.cgi?tab=email Do not reply to this email, post in Bugzilla using the above URL to reply. ------- You are receiving this mail because: ------- You are watching all bug changes.
http://bugs.winehq.org/show_bug.cgi?id=23453 --- Comment #4 from Vladimir Panteleev <thecybershadow(a)gmail.com> 2010-09-10 06:40:51 CDT --- Created an attachment (id=30675) --> (http://bugs.winehq.org/attachment.cgi?id=30675) Simple MFC test case (executable and source) Here is a very simple MFC application (created using the Visual Studio 2005 application wizard) which demonstrates this problem. To reproduce, make sure that the edit control is focused and press Return. On Windows a message box should pop up. Nothing happens on Wine. -- Configure bugmail: http://bugs.winehq.org/userprefs.cgi?tab=email Do not reply to this email, post in Bugzilla using the above URL to reply. ------- You are receiving this mail because: ------- You are watching all bug changes.
http://bugs.winehq.org/show_bug.cgi?id=23453 Wylda <wylda(a)volny.cz> changed: What |Removed |Added ---------------------------------------------------------------------------- Keywords| |testcase CC| |wylda(a)volny.cz --- Comment #5 from Wylda <wylda(a)volny.cz> 2010-09-10 06:50:10 CDT --- Hmmm... I know that commit ;) Although Sergey Khodych was the first breaker, it was latter removed by Alexandre. This helps in bug 21295: --- orig/dlls/user32/dialog.c 2010-04-30 23:38:53.000000000 +0200 +++ new/dlls/user32/dialog.c 2010-04-30 23:39:44.000000000 +0200 @@ -672,6 +672,7 @@ dlgInfo->hMenu = hMenu; dlgInfo->xBaseUnit = xBaseUnit; dlgInfo->yBaseUnit = yBaseUnit; + dlgInfo->idResult = 0; dlgInfo->flags = flags; -- Configure bugmail: http://bugs.winehq.org/userprefs.cgi?tab=email Do not reply to this email, post in Bugzilla using the above URL to reply. ------- You are receiving this mail because: ------- You are watching all bug changes.
http://bugs.winehq.org/show_bug.cgi?id=23453 Austin English <austinenglish(a)gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Keywords| |download -- Configure bugmail: http://bugs.winehq.org/userprefs.cgi?tab=email Do not reply to this email, post in Bugzilla using the above URL to reply. ------- You are receiving this mail because: ------- You are watching all bug changes.
http://bugs.winehq.org/show_bug.cgi?id=23453 Vladimir Panteleev <thecybershadow(a)gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |thecybershadow(a)gmail.com --- Comment #6 from Vladimir Panteleev <thecybershadow(a)gmail.com> 2010-09-10 11:34:08 CDT --- (In reply to comment #5)
This helps in bug 21295:
Hmm... won't this make the test case attached to f1f1c5053160777d0db89b1891706b0b960d3d48 fail? -- Configure bugmail: http://bugs.winehq.org/userprefs.cgi?tab=email Do not reply to this email, post in Bugzilla using the above URL to reply. ------- You are receiving this mail because: ------- You are watching all bug changes.
http://bugs.winehq.org/show_bug.cgi?id=23453 --- Comment #7 from Vladimir Panteleev <thecybershadow(a)gmail.com> 2010-09-14 03:16:57 CDT --- After a bit of research, I found that Wine's implementation of DM_GETDEFID, and the mentioned commit, seem to be correct as far as this problem is concerned. Windows behaves in the same way as Wine. The fact that DM_GETDEFID returning 0 used to allow MFC applications to function correctly seems to be a coincidence. The problem probably presides in Wine's IsDialogMessage implementation. Windows sends the WM_COMMAND message which triggers MFC's OnOK, while Wine does not. I will continue my research. -- Configure bugmail: http://bugs.winehq.org/userprefs.cgi?tab=email Do not reply to this email, post in Bugzilla using the above URL to reply. ------- You are receiving this mail because: ------- You are watching all bug changes.
http://bugs.winehq.org/show_bug.cgi?id=23453 --- Comment #8 from Vladimir Panteleev <thecybershadow(a)gmail.com> 2010-09-14 04:40:12 CDT --- Actually, if you look at the IsDialogMessage implementation, it's quite clear what's going on: http://source.winehq.org/source/dlls/user32/dialog.c#L1224 DM_GETDEFID returns IDOK, but since there's no IDOK control on the dialog, Wine decides to not do anything (instead of sending the IDOK like on line 1231). I suppose I'll prepare a patch and testcase for the test suite. -- Configure bugmail: http://bugs.winehq.org/userprefs.cgi?tab=email Do not reply to this email, post in Bugzilla using the above URL to reply. ------- You are receiving this mail because: ------- You are watching all bug changes.
http://bugs.winehq.org/show_bug.cgi?id=23453 --- Comment #9 from Vladimir Panteleev <thecybershadow(a)gmail.com> 2010-09-14 09:04:48 CDT --- Created an attachment (id=30751) --> (http://bugs.winehq.org/attachment.cgi?id=30751) Proposed fix and test Here's the patch (and test). Comments are welcome. -- Configure bugmail: http://bugs.winehq.org/userprefs.cgi?tab=email Do not reply to this email, post in Bugzilla using the above URL to reply. ------- You are receiving this mail because: ------- You are watching all bug changes.
http://bugs.winehq.org/show_bug.cgi?id=23453 --- Comment #10 from Juan Lang <juan_lang(a)yahoo.com> 2010-09-14 11:47:41 CDT --- (In reply to comment #9)
Here's the patch (and test). Comments are welcome.
At a quick glance this looks fine. Please send to wine-patches. -- Configure bugmail: http://bugs.winehq.org/userprefs.cgi?tab=email Do not reply to this email, post in Bugzilla using the above URL to reply. ------- You are receiving this mail because: ------- You are watching all bug changes.
http://bugs.winehq.org/show_bug.cgi?id=23453 --- Comment #11 from Vladimir Panteleev <thecybershadow(a)gmail.com> 2010-09-15 20:48:44 CDT --- Thanks. The patch is now in: http://source.winehq.org/git/wine.git/?a=commit;h=592d994f0077c19dc9fa2db988... -- Configure bugmail: http://bugs.winehq.org/userprefs.cgi?tab=email Do not reply to this email, post in Bugzilla using the above URL to reply. ------- You are receiving this mail because: ------- You are watching all bug changes.
http://bugs.winehq.org/show_bug.cgi?id=23453 --- Comment #12 from Dmitry Timoshkov <dmitry(a)codeweavers.com> 2010-09-15 23:05:16 CDT --- Fixed then? -- Configure bugmail: http://bugs.winehq.org/userprefs.cgi?tab=email Do not reply to this email, post in Bugzilla using the above URL to reply. ------- You are receiving this mail because: ------- You are watching all bug changes.
http://bugs.winehq.org/show_bug.cgi?id=23453 --- Comment #13 from Vladimir Panteleev <thecybershadow(a)gmail.com> 2010-09-16 09:18:32 CDT --- Well, as I specified on wine-patches, the patch fixes this bug as well as bug 21295 and bug 23936, at least according to my tests. Is a confirmation from someone other than the patch author required? -- Configure bugmail: http://bugs.winehq.org/userprefs.cgi?tab=email Do not reply to this email, post in Bugzilla using the above URL to reply. ------- You are receiving this mail because: ------- You are watching all bug changes.
http://bugs.winehq.org/show_bug.cgi?id=23453 Dmitry Timoshkov <dmitry(a)codeweavers.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |RESOLVED Resolution| |FIXED --- Comment #14 from Dmitry Timoshkov <dmitry(a)codeweavers.com> 2010-09-16 09:32:00 CDT --- Reported fixed. -- Configure bugmail: http://bugs.winehq.org/userprefs.cgi?tab=email Do not reply to this email, post in Bugzilla using the above URL to reply. ------- You are receiving this mail because: ------- You are watching all bug changes.
http://bugs.winehq.org/show_bug.cgi?id=23453 Alexandre Julliard <julliard(a)winehq.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|RESOLVED |CLOSED --- Comment #15 from Alexandre Julliard <julliard(a)winehq.org> 2010-09-18 13:06:19 CDT --- Closing bugs fixed in 1.3.3. -- Configure bugmail: http://bugs.winehq.org/userprefs.cgi?tab=email Do not reply to this email, post in Bugzilla using the above URL to reply. ------- You are receiving this mail because: ------- You are watching all bug changes.
http://bugs.winehq.org/show_bug.cgi?id=23453 Alexandre Julliard <julliard(a)winehq.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Target Milestone|--- |1.2.x -- Configure bugmail: http://bugs.winehq.org/userprefs.cgi?tab=email Do not reply to this email, post in Bugzilla using the above URL to reply. ------- You are receiving this mail because: ------- You are watching all bug changes.
http://bugs.winehq.org/show_bug.cgi?id=23453 Alexandre Julliard <julliard(a)winehq.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Target Milestone|1.2.x |--- --- Comment #16 from Alexandre Julliard <julliard(a)winehq.org> 2010-10-08 10:40:32 CDT --- Removing 1.2.x milestone from bugs fixed in 1.2.1. -- Configure bugmail: http://bugs.winehq.org/userprefs.cgi?tab=email Do not reply to this email, post in Bugzilla using the above URL to reply. ------- You are receiving this mail because: ------- You are watching all bug changes.
participants (1)
-
wine-bugs＠winehq.org