[Bug 54160] New: REGRESSION : Drive Usage shows empty CDRom drive with free space from the last HDD
https://bugs.winehq.org/show_bug.cgi?id=54160 Bug ID: 54160 Summary: REGRESSION : Drive Usage shows empty CDRom drive with free space from the last HDD Product: Wine Version: unspecified Hardware: x86-64 OS: other Status: UNCONFIRMED Severity: normal Priority: P2 Component: msi Assignee: wine-bugs(a)winehq.org Reporter: contact(a)kcsoftwares.com Created attachment 73684 --> https://bugs.winehq.org/attachment.cgi?id=73684 screenshot Drive Usage shows empty CDRom drive with free space from the last HDD Only if CDRom drive is EMPTY REGRESSION : dlls/msi/dialog.c is faulty because : - change made to msi_dialog_vcl_add_drives now using GetVolumeInformationW and flag compared to FILE_READ_ONLY_VOLUME does not work as previous implementation - GetDiskFreeSpaceExW result is not checked and if failing (eg : empty CDRom drive) the content of "free" is used (containing last valid data, eg last HDD) Detected in https://jira.reactos.org/browse/CORE-18758 -- Do not reply to this email, post in Bugzilla using the above URL to reply. You are receiving this mail because: You are watching all bug changes.
https://bugs.winehq.org/show_bug.cgi?id=54160 Kyle_Katarn <contact(a)kcsoftwares.com> changed: What |Removed |Added ---------------------------------------------------------------------------- URL| |https://jira.reactos.org/br | |owse/CORE-18758 -- Do not reply to this email, post in Bugzilla using the above URL to reply. You are receiving this mail because: You are watching all bug changes.
https://bugs.winehq.org/show_bug.cgi?id=54160 --- Comment #1 from Kyle_Katarn <contact(a)kcsoftwares.com> --- Created attachment 73685 --> https://bugs.winehq.org/attachment.cgi?id=73685 Fix (tested patch) -- Do not reply to this email, post in Bugzilla using the above URL to reply. You are receiving this mail because: You are watching all bug changes.
https://bugs.winehq.org/show_bug.cgi?id=54160 --- Comment #2 from Kyle_Katarn <contact(a)kcsoftwares.com> --- Patch provided and tested in ReactOs -- Do not reply to this email, post in Bugzilla using the above URL to reply. You are receiving this mail because: You are watching all bug changes.
https://bugs.winehq.org/show_bug.cgi?id=54160 --- Comment #3 from Kyle_Katarn <contact(a)kcsoftwares.com> --- Provided patch to be disregarded as ReactOS favors this solution : https://git.reactos.org/?p=reactos.git;a=commit;h=d5265b07bbfb6ac6da190b8213... -- Do not reply to this email, post in Bugzilla using the above URL to reply. You are receiving this mail because: You are watching all bug changes.
http://bugs.winehq.org/show_bug.cgi?id=54160 Alex Henrie <alexhenrie24@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|UNCONFIRMED |NEW Hardware|x86-64 |x86 Ever confirmed|0 |1 CC| |alexhenrie24@gmail.com URL|https://jira.reactos.org/br |https://sourceforge.net/pro |owse/CORE-18758 |jects/pdfsam/files/pdfsam/3 | |.3.5/pdfsam-v3.3.5.msi/down | |load Summary|REGRESSION : Drive Usage |Disk Usage page of PDFsam |shows empty CDRom drive |installer says that empty |with free space from the |CD drive has the same |last HDD |amount of free space as the | |previous drive in the list Keywords| |download, Installer --- Comment #4 from Alex Henrie <alexhenrie24@gmail.com> --- I can reproduce this bug as far back as Wine 3.0, long before the change to msi_dialog_vcl_add_drives that you mentioned: The D drive, which is an empty optical drive on my computer, shows the same amount of free space as the C drive. On Windows on the same hardware, the D drive does not appear in the list at all. Did it ever work correctly in upstream Wine (not ReactOS)? If not, we wouldn't consider it a regression. -- Do not reply to this email, post in Bugzilla using the above URL to reply. You are receiving this mail because: You are watching all bug changes.
http://bugs.winehq.org/show_bug.cgi?id=54160 KRosUser <kyle.kcsoftwares@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |kyle.kcsoftwares@gmail.com --- Comment #5 from KRosUser <kyle.kcsoftwares@gmail.com> --- Was fixed in ReactOS by https://github.com/reactos/reactos/commit/e13c3e856f82faa0d09905b57f17efec73... -- Do not reply to this email, post in Bugzilla using the above URL to reply. You are receiving this mail because: You are watching all bug changes.
http://bugs.winehq.org/show_bug.cgi?id=54160 Hans Leidekker <hans@meelstraat.net> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |RESOLVED Fixed by SHA1| |ab22fef39741128de3221377435 | |745840a12e56f Resolution|--- |FIXED --- Comment #6 from Hans Leidekker <hans@meelstraat.net> --- Should be fixed with ab22fef39741128de3221377435745840a12e56f. -- Do not reply to this email, post in Bugzilla using the above URL to reply. You are receiving this mail because: You are watching all bug changes.
http://bugs.winehq.org/show_bug.cgi?id=54160 Alexandre Julliard <julliard@winehq.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|RESOLVED |CLOSED --- Comment #7 from Alexandre Julliard <julliard@winehq.org> --- Closing bugs fixed in 11.1. -- Do not reply to this email, post in Bugzilla using the above URL to reply. You are receiving this mail because: You are watching all bug changes.
http://bugs.winehq.org/show_bug.cgi?id=54160 --- Comment #8 from Alex Henrie <alexhenrie24@gmail.com> --- Thanks Hans! -- Do not reply to this email, post in Bugzilla using the above URL to reply. You are receiving this mail because: You are watching all bug changes.
participants (2)
-
WineHQ Bugzilla -
WineHQ Bugzilla