[Bug 54160] New: REGRESSION : Drive Usage shows empty CDRom drive with free space from the last HDD
https://bugs.winehq.org/show_bug.cgi?id=54160 Bug ID: 54160 Summary: REGRESSION : Drive Usage shows empty CDRom drive with free space from the last HDD Product: Wine Version: unspecified Hardware: x86-64 OS: other Status: UNCONFIRMED Severity: normal Priority: P2 Component: msi Assignee: wine-bugs(a)winehq.org Reporter: contact(a)kcsoftwares.com Created attachment 73684 --> https://bugs.winehq.org/attachment.cgi?id=73684 screenshot Drive Usage shows empty CDRom drive with free space from the last HDD Only if CDRom drive is EMPTY REGRESSION : dlls/msi/dialog.c is faulty because : - change made to msi_dialog_vcl_add_drives now using GetVolumeInformationW and flag compared to FILE_READ_ONLY_VOLUME does not work as previous implementation - GetDiskFreeSpaceExW result is not checked and if failing (eg : empty CDRom drive) the content of "free" is used (containing last valid data, eg last HDD) Detected in https://jira.reactos.org/browse/CORE-18758 -- Do not reply to this email, post in Bugzilla using the above URL to reply. You are receiving this mail because: You are watching all bug changes.
https://bugs.winehq.org/show_bug.cgi?id=54160 Kyle_Katarn <contact(a)kcsoftwares.com> changed: What |Removed |Added ---------------------------------------------------------------------------- URL| |https://jira.reactos.org/br | |owse/CORE-18758 -- Do not reply to this email, post in Bugzilla using the above URL to reply. You are receiving this mail because: You are watching all bug changes.
https://bugs.winehq.org/show_bug.cgi?id=54160 --- Comment #1 from Kyle_Katarn <contact(a)kcsoftwares.com> --- Created attachment 73685 --> https://bugs.winehq.org/attachment.cgi?id=73685 Fix (tested patch) -- Do not reply to this email, post in Bugzilla using the above URL to reply. You are receiving this mail because: You are watching all bug changes.
https://bugs.winehq.org/show_bug.cgi?id=54160 --- Comment #2 from Kyle_Katarn <contact(a)kcsoftwares.com> --- Patch provided and tested in ReactOs -- Do not reply to this email, post in Bugzilla using the above URL to reply. You are receiving this mail because: You are watching all bug changes.
https://bugs.winehq.org/show_bug.cgi?id=54160 --- Comment #3 from Kyle_Katarn <contact(a)kcsoftwares.com> --- Provided patch to be disregarded as ReactOS favors this solution : https://git.reactos.org/?p=reactos.git;a=commit;h=d5265b07bbfb6ac6da190b8213... -- Do not reply to this email, post in Bugzilla using the above URL to reply. You are receiving this mail because: You are watching all bug changes.
participants (1)
-
WineHQ Bugzilla