[Bug 43577] New: unit test: DBGrid inplace editor dropdown does not work and worked on version 2.0.2
https://bugs.winehq.org/show_bug.cgi?id=43577 Bug ID: 43577 Summary: unit test: DBGrid inplace editor dropdown does not work and worked on version 2.0.2 Product: Wine Version: 2.14 Hardware: x86 OS: Linux Status: UNCONFIRMED Severity: normal Priority: P2 Component: -unknown Assignee: wine-bugs(a)winehq.org Reporter: Brad.Wine1(a)amaitis.com Distribution: --- version 2.0.2 works winehq-devel wine --version wine-2.13 and wine-2.14 If you click the dropdown in the Show column on the grid stable 2.0.2 works and the 2.13 and 2.14 dev version does not let you select from the list shown to change the value of the field. http://www.ateksol.com/dev/unittest/GridDropDown.exe sha1sum cea42ec431f985a802203be10e4cae6abe6afde5 GridDropDown.exe -- Do not reply to this email, post in Bugzilla using the above URL to reply. You are receiving this mail because: You are watching all bug changes.
https://bugs.winehq.org/show_bug.cgi?id=43577 --- Comment #1 from Brad <Brad.Wine1(a)amaitis.com> --- Still working on getting an example of this bug in C++ native API calls. We don't have any C++ projects that use styles to pull from. Added bug to demonstrate the problems I was describing. Hard to explain with an example for you to see. Bug 43576 Bug 43577 http://www.ateksol.com/dev/unittest/GridDropDown.exe sha1sum cea42ec431f985a802203be10e4cae6abe6afde5 GridDropDown.exe http://www.ateksol.com/dev/unittest/MenuStyle.exe sha1sum b08eb7ad7fb0ea9164071b53dcacd117390d0913 MenuStyle.exe -- Do not reply to this email, post in Bugzilla using the above URL to reply. You are receiving this mail because: You are watching all bug changes.
https://bugs.winehq.org/show_bug.cgi?id=43577 Fabian Maurer <dark.shadow4(a)web.de> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |dark.shadow4(a)web.de --- Comment #2 from Fabian Maurer <dark.shadow4(a)web.de> --- Confirming the issue. This is a regression between wine 2.12 and 2.13. I'll add a regression test later. Btw, feel free to add the 'regression' and 'download' keywords. -- Do not reply to this email, post in Bugzilla using the above URL to reply. You are receiving this mail because: You are watching all bug changes.
https://bugs.winehq.org/show_bug.cgi?id=43577 Austin English <austinenglish(a)gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- URL| |http://www.ateksol.com/dev/ | |unittest/GridDropDown.exe Keywords| |download, regression -- Do not reply to this email, post in Bugzilla using the above URL to reply. You are receiving this mail because: You are watching all bug changes.
https://bugs.winehq.org/show_bug.cgi?id=43577 Fabian Maurer <dark.shadow4(a)web.de> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |z.figura12(a)gmail.com --- Comment #3 from Fabian Maurer <dark.shadow4(a)web.de> --- Bisected to commit ae153a5c2c5590d4ea722d38eb4ddf1a7031f34a Author: Zebediah Figura <zfigura(a)codeweavers.com> Date: Fri Jul 7 18:58:12 2017 -0500 user32: Allow activating the desktop window. Signed-off-by: Zebediah Figura <zfigura(a)codeweavers.com> Signed-off-by: Alexandre Julliard <julliard(a)winehq.org> Reverts cleanly and reverting fixes the issue. -- Do not reply to this email, post in Bugzilla using the above URL to reply. You are receiving this mail because: You are watching all bug changes.
https://bugs.winehq.org/show_bug.cgi?id=43577 Nikolay Sivov <bunglehead(a)gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Regression SHA1| |ae153a5c2c5590d4ea722d38eb4 | |ddf1a7031f34a -- Do not reply to this email, post in Bugzilla using the above URL to reply. You are receiving this mail because: You are watching all bug changes.
https://bugs.winehq.org/show_bug.cgi?id=43577 Nikolay Sivov <bunglehead(a)gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Component|-unknown |user32 -- Do not reply to this email, post in Bugzilla using the above URL to reply. You are receiving this mail because: You are watching all bug changes.
https://bugs.winehq.org/show_bug.cgi?id=43577 --- Comment #4 from Zebediah Figura <z.figura12(a)gmail.com> --- Frustrating. Better revert it. -- Do not reply to this email, post in Bugzilla using the above URL to reply. You are receiving this mail because: You are watching all bug changes.
https://bugs.winehq.org/show_bug.cgi?id=43577 --- Comment #5 from Fabian Maurer <dark.shadow4(a)web.de> --- (In reply to Zebediah Figura from comment #4)
Frustrating.
Better revert it.
What did that commit fix? -- Do not reply to this email, post in Bugzilla using the above URL to reply. You are receiving this mail because: You are watching all bug changes.
https://bugs.winehq.org/show_bug.cgi?id=43577 --- Comment #6 from Zebediah Figura <z.figura12(a)gmail.com> --- (In reply to Fabian Maurer from comment #5)
(In reply to Zebediah Figura from comment #4)
Frustrating.
Better revert it.
What did that commit fix?
Virtual desktop—so that clicking on the background defocused the active window. Wouldn't be the first time I've caused a regression for stupid reasons. -- Do not reply to this email, post in Bugzilla using the above URL to reply. You are receiving this mail because: You are watching all bug changes.
https://bugs.winehq.org/show_bug.cgi?id=43577 --- Comment #7 from Fabian Maurer <dark.shadow4(a)web.de> --- Created attachment 59001 --> https://bugs.winehq.org/attachment.cgi?id=59001 Allow activating desktop only when clicked directly It does seem like useful behavior though, can't we get both to work? The issue seems to be that some toplevel windows are are mistakenly labeled child, so the desktop window gets activated when actually no window should be activated. Attached a patch that makes both of them work. How about something like this? -- Do not reply to this email, post in Bugzilla using the above URL to reply. You are receiving this mail because: You are watching all bug changes.
https://bugs.winehq.org/show_bug.cgi?id=43577 --- Comment #8 from Zebediah Figura <z.figura12(a)gmail.com> --- (In reply to Fabian Maurer from comment #7)
Created attachment 59001 [details] Allow activating desktop only when clicked directly
It does seem like useful behavior though, can't we get both to work?
The issue seems to be that some toplevel windows are are mistakenly labeled child, so the desktop window gets activated when actually no window should be activated. I don't think it's a mistake—the application is requesting SetParent(...,NULL), and testing on Windows shows that a child window thus affected retains its WS_CHILD status.
-- Do not reply to this email, post in Bugzilla using the above URL to reply. You are receiving this mail because: You are watching all bug changes.
https://bugs.winehq.org/show_bug.cgi?id=43577 --- Comment #9 from Fabian Maurer <dark.shadow4(a)web.de> --- (In reply to Zebediah Figura from comment #8)
I don't think it's a mistake—the application is requesting SetParent(...,NULL), and testing on Windows shows that a child window thus affected retains its WS_CHILD status.
Makes sense I guess. Anyways, the current code treats such windows wrong, would my way be acceptable? -- Do not reply to this email, post in Bugzilla using the above URL to reply. You are receiving this mail because: You are watching all bug changes.
https://bugs.winehq.org/show_bug.cgi?id=43577 Fabian Maurer <dark.shadow4(a)web.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |43630 -- Do not reply to this email, post in Bugzilla using the above URL to reply. You are receiving this mail because: You are watching all bug changes.
https://bugs.winehq.org/show_bug.cgi?id=43577 alex freudenberg <afb(a)mailbox.org> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |afb(a)mailbox.org --- Comment #10 from alex freudenberg <afb(a)mailbox.org> --- *** Bug 43608 has been marked as a duplicate of this bug. *** -- Do not reply to this email, post in Bugzilla using the above URL to reply. You are receiving this mail because: You are watching all bug changes.
https://bugs.winehq.org/show_bug.cgi?id=43577 Nikolay Sivov <bunglehead(a)gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |winehq(a)der-ingo.de --- Comment #11 from Nikolay Sivov <bunglehead(a)gmail.com> --- *** Bug 43633 has been marked as a duplicate of this bug. *** -- Do not reply to this email, post in Bugzilla using the above URL to reply. You are receiving this mail because: You are watching all bug changes.
https://bugs.winehq.org/show_bug.cgi?id=43577 Fabian Maurer <dark.shadow4(a)web.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Fixed by SHA1| |3ab617499768132df134bab2a7c | |036413a9af50c Resolution|--- |FIXED Status|UNCONFIRMED |RESOLVED --- Comment #12 from Fabian Maurer <dark.shadow4(a)web.de> --- Fixed in 3ab617499768132df134bab2a7c036413a9af50c. -- Do not reply to this email, post in Bugzilla using the above URL to reply. You are receiving this mail because: You are watching all bug changes.
https://bugs.winehq.org/show_bug.cgi?id=43577 Alexandre Julliard <julliard(a)winehq.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|RESOLVED |CLOSED --- Comment #13 from Alexandre Julliard <julliard(a)winehq.org> --- Closing bugs fixed in 2.17. -- Do not reply to this email, post in Bugzilla using the above URL to reply. You are receiving this mail because: You are watching all bug changes.
https://bugs.winehq.org/show_bug.cgi?id=43577 Anastasius Focht <focht(a)gmx.net> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |focht(a)gmx.net URL|http://www.ateksol.com/dev/ |https://web.archive.org/web |unittest/GridDropDown.exe |/20211029090129/http://www. | |ateksol.com/dev/unittest/Gr | |idDropDown.exe -- Do not reply to this email, post in Bugzilla using the above URL to reply. You are receiving this mail because: You are watching all bug changes.
participants (2)
-
wine-bugs＠winehq.org -
WineHQ Bugzilla