[Bug 49244] New: GdipDeleteFontFamily is declared, but does nothing
https://bugs.winehq.org/show_bug.cgi?id=49244 Bug ID: 49244 Summary: GdipDeleteFontFamily is declared, but does nothing Product: Wine Version: 5.9 Hardware: x86 OS: Linux Status: UNCONFIRMED Severity: normal Priority: P2 Component: gdiplus Assignee: wine-bugs(a)winehq.org Reporter: mikrutrafal54(a)gmail.com Distribution: --- Function just check if FontFamily is null and return value without doing anything. https://github.com/wine-mirror/wine/blame/056c9df854817670dc4fb9c095cba29c99... -- Do not reply to this email, post in Bugzilla using the above URL to reply. You are receiving this mail because: You are watching all bug changes.
https://bugs.winehq.org/show_bug.cgi?id=49244 Michael McGuire <spoon0042(a)hotmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |spoon0042(a)hotmail.com --- Comment #1 from Michael McGuire <spoon0042(a)hotmail.com> --- afaik this is normal for wine, presumably 12 years ago someone found an app that calls that function and "do nothing but return ok" made it work. -- Do not reply to this email, post in Bugzilla using the above URL to reply. You are receiving this mail because: You are watching all bug changes.
https://bugs.winehq.org/show_bug.cgi?id=49244 --- Comment #2 from Nikolay Sivov <bunglehead(a)gmail.com> --- It's a recent change, see b9307cfa61e9884b01d34c2310ec1ffbb1868728. If you have discovered any issues with that please outline them, otherwise I don't see a reason for this report. -- Do not reply to this email, post in Bugzilla using the above URL to reply. You are receiving this mail because: You are watching all bug changes.
https://bugs.winehq.org/show_bug.cgi?id=49244 --- Comment #3 from Rafał Mikrut <mikrutrafal54(a)gmail.com> --- I don't have any real world problems caused by this, but Coverity Scan shows "Useless Call" bug, because function doesn't change anything and sometimes even others functions doesn't use return value from this function. https://github.com/wine-mirror/wine/blob/6d801377055911d914226a3c6af8d8637a6... https://github.com/wine-mirror/wine/search?q=GdipDeleteFontFamily&unscoped_q... -- Do not reply to this email, post in Bugzilla using the above URL to reply. You are receiving this mail because: You are watching all bug changes.
https://bugs.winehq.org/show_bug.cgi?id=49244 --- Comment #4 from Esme Povirk <madewokherd(a)gmail.com> --- It's not clear that this function needs to do anything. We know that for every installed font there is exactly one FontFamily object, and in all current tests GdipCloneFontFamily returns the same pointer that was passed in. It wouldn't make sense to ever free the FontFamily for an installed font. For a private font collection, it's less clear, should each font family have its own lifetime or be tied to the collection? If they have an independent lifetime, we need reference counting. But it's also possible that they shouldn't be used after the font collection is destroyed. Until we know for sure, I think we should take the simpler approach. -- Do not reply to this email, post in Bugzilla using the above URL to reply. You are receiving this mail because: You are watching all bug changes.
https://bugs.winehq.org/show_bug.cgi?id=49244 --- Comment #5 from Rafał Mużyło <galtgendo(a)o2.pl> --- Just for reference: bug 50896. -- Do not reply to this email, post in Bugzilla using the above URL to reply. You are receiving this mail because: You are watching all bug changes.
https://bugs.winehq.org/show_bug.cgi?id=49244 Esme Povirk <madewokherd(a)gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |madewokherd(a)gmail.com -- Do not reply to this email, post in Bugzilla using the above URL to reply. You are receiving this mail because: You are watching all bug changes.
https://bugs.winehq.org/show_bug.cgi?id=49244 Bartosz <gang65(a)poczta.onet.pl> changed: What |Removed |Added ---------------------------------------------------------------------------- Resolution|--- |FIXED Status|UNCONFIRMED |RESOLVED CC| |gang65(a)poczta.onet.pl --- Comment #6 from Bartosz <gang65(a)poczta.onet.pl> --- The issue was fixed with commit by Esme: a5540798605b3ef9abcf654bc28d9dd8d8736e53 -- Do not reply to this email, post in Bugzilla using the above URL to reply. You are receiving this mail because: You are watching all bug changes.
https://bugs.winehq.org/show_bug.cgi?id=49244 Alexandre Julliard <julliard(a)winehq.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|RESOLVED |CLOSED --- Comment #7 from Alexandre Julliard <julliard(a)winehq.org> --- Closing bugs fixed in 9.17. -- Do not reply to this email, post in Bugzilla using the above URL to reply. You are receiving this mail because: You are watching all bug changes.
participants (1)
-
WineHQ Bugzilla