[Bug 44953] New: Adobe Premiere Elements 14 (trial) crashes inside winmm.dll
https://bugs.winehq.org/show_bug.cgi?id=44953 Bug ID: 44953 Summary: Adobe Premiere Elements 14 (trial) crashes inside winmm.dll Product: Wine Version: 3.4 Hardware: x86 OS: Linux Status: NEW Severity: normal Priority: P2 Component: winmm&mci Assignee: wine-bugs(a)winehq.org Reporter: xerox.xerox2000x(a)gmail.com Distribution: --- Created attachment 61059 --> https://bugs.winehq.org/attachment.cgi?id=61059 backtrace As the title says. This is after working around bug 44944 for the installer. -- Do not reply to this email, post in Bugzilla using the above URL to reply. You are receiving this mail because: You are watching all bug changes.
https://bugs.winehq.org/show_bug.cgi?id=44953 --- Comment #1 from Louis Lenders <xerox.xerox2000x(a)gmail.com> --- Created attachment 61060 --> https://bugs.winehq.org/attachment.cgi?id=61060 consoleoutput with +winmm debug enabled consoleoutput with +winmm debug enabled -- Do not reply to this email, post in Bugzilla using the above URL to reply. You are receiving this mail because: You are watching all bug changes.
https://bugs.winehq.org/show_bug.cgi?id=44953 --- Comment #2 from Louis Lenders <xerox.xerox2000x(a)gmail.com> --- Created attachment 61061 --> https://bugs.winehq.org/attachment.cgi?id=61061 hack/patch With this hack/patch the crash is gone and the application starts. Haven`t got a clue if it`s correct, haven`t got a clue about winmm anyway ;) Someone who knows winmm could have a look into this bug? -- Do not reply to this email, post in Bugzilla using the above URL to reply. You are receiving this mail because: You are watching all bug changes.
https://bugs.winehq.org/show_bug.cgi?id=44953 Louis Lenders <xerox.xerox2000x(a)gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Keywords| |download URL| |https://helpx.adobe.com/pre | |miere-elements/kb/premiere- | |elements-downloads.html --- Comment #3 from Louis Lenders <xerox.xerox2000x(a)gmail.com> --- filled some fields sha1sum ~/Downloads/PremiereElements_14_LS29_win32.exe 57cdfa1aed3078da5e468eb2380c5c83934dddfd /home/louis/Downloads/PremiereElements_14_LS29_win32.exe sha1sum Adobe\ Premiere\ Elements.exe bdad2f05a0da15c9af844e05c21bccd30525a5d6 Adobe Premiere Elements.exe -- Do not reply to this email, post in Bugzilla using the above URL to reply. You are receiving this mail because: You are watching all bug changes.
https://bugs.winehq.org/show_bug.cgi?id=44953 Robert Munteanu <robert.munteanu(a)gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |robert.munteanu(a)gmail.com -- Do not reply to this email, post in Bugzilla using the above URL to reply. You are receiving this mail because: You are watching all bug changes.
https://bugs.winehq.org/show_bug.cgi?id=44953 Andrew Eikum <aeikum(a)codeweavers.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |aeikum(a)codeweavers.com --- Comment #4 from Andrew Eikum <aeikum(a)codeweavers.com> --- (In reply to Louis Lenders from comment #2)
Created attachment 61061 [details] hack/patch
With this hack/patch the crash is gone and the application starts.
Haven`t got a clue if it`s correct, haven`t got a clue about winmm anyway ;)
Someone who knows winmm could have a look into this bug?
The application seems to be giving us -1 as a DWORD pointer to DRVM_MAPPER_PREFERRED_GET. When we try to write a DWORD to it, it crashes, obviously. How does Windows behave when given -1 to this parameter? -- Do not reply to this email, post in Bugzilla using the above URL to reply. You are receiving this mail because: You are watching all bug changes.
https://bugs.winehq.org/show_bug.cgi?id=44953 --- Comment #5 from Louis Lenders <xerox.xerox2000x(a)gmail.com> --- Created attachment 61092 --> https://bugs.winehq.org/attachment.cgi?id=61092 test (In reply to Andrew Eikum from comment #4)
(In reply to Louis Lenders from comment #2)
The application seems to be giving us -1 as a DWORD pointer to DRVM_MAPPER_PREFERRED_GET. When we try to write a DWORD to it, it crashes, obviously.
How does Windows behave when given -1 to this parameter?
If i did the test in the attachment correct(?), the conclusion is that below win7 it returns MMSYSERR_INVALPARAM (i added it to the test so the test succeeds below win7), but in win7 and above it just crashes. So i guess the bug/error must come from somewhere else -- Do not reply to this email, post in Bugzilla using the above URL to reply. You are receiving this mail because: You are watching all bug changes.
https://bugs.winehq.org/show_bug.cgi?id=44953 --- Comment #6 from Louis Lenders <xerox.xerox2000x(a)gmail.com> --- Created attachment 61110 --> https://bugs.winehq.org/attachment.cgi?id=61110 last 2500 lines of debuglog I attach last 2500 lines of debuglog before the crash Maybe following is relevant 004e:Ret PE DLL (proc=0xffbb064,module=0xffa0000 L"AsioWdm.dll",reason=PROCESS_ATTACH,res=(nil)) retval=1 004e:Ret KERNEL32.LoadLibraryW() retval=0ffa0000 ret=07400262 004e:Call KERNEL32.GetProcAddress(0ffa0000,07426834 "GetDriverInstance") ret=07400272 004e:Ret KERNEL32.GetProcAddress() retval=0ffa2d10 ret=07400272 Maybe it needs asio, but actually i do not even know what exactly asio is, i`m complete noob when it comes to audio, so I`ll stop speculating ;) -- Do not reply to this email, post in Bugzilla using the above URL to reply. You are receiving this mail because: You are watching all bug changes.
https://bugs.winehq.org/show_bug.cgi?id=44953 --- Comment #7 from Louis Lenders <xerox.xerox2000x(a)gmail.com> --- Created attachment 61163 --> https://bugs.winehq.org/attachment.cgi?id=61163 test dwParam1=invalid handle and with dwParam2 = 0 If I adjust test and call exactly what Adobe Elemnts does (dwParam1=-1 en dwParam2=0), it seems like all windowsversions return MMSYSERR_INVALPARAM; it dowsn`t crash at least This test passes on all windowsversions. So maybe we could just a check for this, that would fix this bug -- Do not reply to this email, post in Bugzilla using the above URL to reply. You are receiving this mail because: You are watching all bug changes.
https://bugs.winehq.org/show_bug.cgi?id=44953 --- Comment #8 from Andrew Eikum <aeikum(a)codeweavers.com> --- (In reply to Louis Lenders from comment #7)
Created attachment 61163 [details] test dwParam1=invalid handle and with dwParam2 = 0
If I adjust test and call exactly what Adobe Elemnts does (dwParam1=-1 en dwParam2=0), it seems like all windowsversions return MMSYSERR_INVALPARAM; it dowsn`t crash at least
This test passes on all windowsversions. So maybe we could just a check for this, that would fix this bug
That seems reasonable. Probably Windows returns early with failure if either is NULL, so Windows never writes to the invalid -1 pointer. -- Do not reply to this email, post in Bugzilla using the above URL to reply. You are receiving this mail because: You are watching all bug changes.
https://bugs.winehq.org/show_bug.cgi?id=44953 Louis Lenders <xerox.xerox2000x(a)gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #61061|0 |1 is obsolete| | --- Comment #9 from Louis Lenders <xerox.xerox2000x(a)gmail.com> --- Created attachment 61187 --> https://bugs.winehq.org/attachment.cgi?id=61187 patch
That seems reasonable. Probably Windows returns early with failure if either is NULL, so Windows never writes to the invalid -1 pointer.
Hi thanks for the answer, i guess a patch like here attached should do the trick then -- Do not reply to this email, post in Bugzilla using the above URL to reply. You are receiving this mail because: You are watching all bug changes.
https://bugs.winehq.org/show_bug.cgi?id=44953 --- Comment #10 from Louis Lenders <xerox.xerox2000x(a)gmail.com> --- Created attachment 61189 --> https://bugs.winehq.org/attachment.cgi?id=61189 crash log after waveOutMessage is fixed For completeness of this bug I attach the crashlog after waveOutMessage crash is fixed: 0082:fixme:ntdll:NtQuerySystemInformationEx Relationship filtering not implemented: 0x2 0082:trace:winmm:waveOutMessage (0xffffffff, 8213, ffffffff, 0) 0082:trace:winmm:waveInMessage (0xffffffff, 8213, -1, 0) wine: Unhandled page fault on write access to 0xffffffff at address 0x7da547fb (thread 0082), starting debugger... I sent patches to wine-devel for review -- Do not reply to this email, post in Bugzilla using the above URL to reply. You are receiving this mail because: You are watching all bug changes.
https://bugs.winehq.org/show_bug.cgi?id=44953 tokktokk <fdsfgs(a)krutt.org> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |fdsfgs(a)krutt.org -- Do not reply to this email, post in Bugzilla using the above URL to reply. You are receiving this mail because: You are watching all bug changes.
https://bugs.winehq.org/show_bug.cgi?id=44953 --- Comment #11 from Andrew Eikum <aeikum(a)codeweavers.com> --- Louis's patches are in Wine now. commit d7bd861ae6d3ec24ff69def9ab7115ebb13d554d Author: Louis Lenders <xerox.xerox2000x(a)gmail.com> Date: Tue Apr 24 11:52:18 2018 +0200 winmm: Return error in waveOutMessage if either dwParam1 or dwParam2 is null. commit 8dca6c35e11a104385242ed8346ee05707b78ef7 (origin/master, origin/HEAD) Author: Louis Lenders <xerox.xerox2000x(a)gmail.com> Date: Wed May 2 10:02:15 2018 -0500 winmm: Return error in waveInMessage if either dwParam1 or dwParam2 is null. -- Do not reply to this email, post in Bugzilla using the above URL to reply. You are receiving this mail because: You are watching all bug changes.
https://bugs.winehq.org/show_bug.cgi?id=44953 --- Comment #12 from Louis Lenders <xerox.xerox2000x(a)gmail.com> --- (In reply to Andrew Eikum from comment #11)
winmm: Return error in waveInMessage if either dwParam1 or dwParam2 is null.
Hi Andrew, thanks for the fix of copy/paste error in 2nd patch. The crash is gone and the application starts now. I`ll resolve as fixed -- Do not reply to this email, post in Bugzilla using the above URL to reply. You are receiving this mail because: You are watching all bug changes.
https://bugs.winehq.org/show_bug.cgi?id=44953 Louis Lenders <xerox.xerox2000x(a)gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Resolution|--- |FIXED Status|NEW |RESOLVED Fixed by SHA1| |8dca6c35e11a104385242ed8346 | |ee05707b78ef7 --- Comment #13 from Louis Lenders <xerox.xerox2000x(a)gmail.com> --- fixed with 8dca6c35e11a104385242ed8346ee05707b78ef7 -- Do not reply to this email, post in Bugzilla using the above URL to reply. You are receiving this mail because: You are watching all bug changes.
https://bugs.winehq.org/show_bug.cgi?id=44953 Alexandre Julliard <julliard(a)winehq.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|RESOLVED |CLOSED --- Comment #14 from Alexandre Julliard <julliard(a)winehq.org> --- Closing bugs fixed in 3.8. -- Do not reply to this email, post in Bugzilla using the above URL to reply. You are receiving this mail because: You are watching all bug changes.
https://bugs.winehq.org/show_bug.cgi?id=44953 Michael Stefaniuc <mstefani(a)winehq.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Target Milestone|--- |3.0.x -- Do not reply to this email, post in Bugzilla using the above URL to reply. You are receiving this mail because: You are watching all bug changes.
https://bugs.winehq.org/show_bug.cgi?id=44953 Michael Stefaniuc <mstefani(a)winehq.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Target Milestone|3.0.x |--- --- Comment #15 from Michael Stefaniuc <mstefani(a)winehq.org> --- Removing the 3.0.x milestone from bugs included in 3.0.3. -- Do not reply to this email, post in Bugzilla using the above URL to reply. You are receiving this mail because: You are watching all bug changes.
participants (1)
-
wine-bugs＠winehq.org