[Bug 43848] New: Grand Theft Auto 5 and Tomb Raider 2013 need DepthBiasClamp
https://bugs.winehq.org/show_bug.cgi?id=43848 Bug ID: 43848 Summary: Grand Theft Auto 5 and Tomb Raider 2013 need DepthBiasClamp Product: Wine Version: 2.18 Hardware: x86-64 OS: Linux Status: UNCONFIRMED Severity: normal Priority: P2 Component: -unknown Assignee: wine-bugs(a)winehq.org Reporter: byi5000(a)gmail.com Distribution: --- According to this thread (https://www.gamedev.net/forums/topic/596741-depth-bias-clamping-in-opengl/) the OpenGL function EXT_polygon_offset_clamp is the equivalent to DirectX10/11 depthbiasclamp for d3d11_immediate_context_RSSetState Multiple games need this and it should fix their shadows. https://www.khronos.org/registry/OpenGL/extensions/EXT/EXT_polygon_offset_cl... -- Do not reply to this email, post in Bugzilla using the above URL to reply. You are receiving this mail because: You are watching all bug changes.
https://bugs.winehq.org/show_bug.cgi?id=43848 Michael Müller <michael(a)fds-team.de> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |michael(a)fds-team.de --- Comment #1 from Michael Müller <michael(a)fds-team.de> --- I wrote a patch: https://dev.wine-staging.com/patches/205/ I am not able to see any significant difference in GTA5 though. I guess the remaining problems are caused by something else. -- Do not reply to this email, post in Bugzilla using the above URL to reply. You are receiving this mail because: You are watching all bug changes.
https://bugs.winehq.org/show_bug.cgi?id=43848 --- Comment #2 from BieHDC <byi5000(a)gmail.com> --- Created attachment 59421 --> https://bugs.winehq.org/attachment.cgi?id=59421 My pkgbuild script Your patch somehow won't compile here. I have attached my compile method here. ../../../wine/dlls/d3d11/device.c: In Funktion »d3d11_immediate_context_RSSetState«: ../../../wine/dlls/d3d11/device.c:2301:65: Fehler: »WINED3D_RS_DEPTHBIASCLAMP« nicht deklariert (erstmalige Verwendung in dieser Funktion); meinten Sie »WINED3D_RS_DEPTHBIAS«? wined3d_device_set_render_state(device->wined3d_device, WINED3D_RS_DEPTHBIASCLAMP, tmpfloat.d); ^~~~~~~~~~~~~~~~~~~~~~~~~ WINED3D_RS_DEPTHBIAS ../../../wine/dlls/d3d11/device.c:2301:65: Anmerkung: jeder nicht deklarierte Bezeichner wird nur einmal für jede Funktion, in der er vorkommt, gemeldet make[1]: *** [Makefile:305: device.o] Fehler 1 make: *** [Makefile:7066: dlls/d3d11] Fehler 2 -- Do not reply to this email, post in Bugzilla using the above URL to reply. You are receiving this mail because: You are watching all bug changes.
https://bugs.winehq.org/show_bug.cgi?id=43848 --- Comment #3 from BieHDC <byi5000(a)gmail.com> --- true, but maybe it makes another application happy :D one less thing to worry about. the hunt continues... -- Do not reply to this email, post in Bugzilla using the above URL to reply. You are receiving this mail because: You are watching all bug changes.
https://bugs.winehq.org/show_bug.cgi?id=43848 --- Comment #4 from Gijs Vermeulen <gijsvrm(a)gmail.com> --- This one could be marked STAGED with: https://github.com/wine-staging/wine-staging/tree/master/patches/d3d11-Depth... -- Do not reply to this email, post in Bugzilla using the above URL to reply. You are receiving this mail because: You are watching all bug changes.
https://bugs.winehq.org/show_bug.cgi?id=43848 Zebediah Figura <z.figura12(a)gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |z.figura12(a)gmail.com --- Comment #5 from Zebediah Figura <z.figura12(a)gmail.com> --- (In reply to Gijs Vermeulen from comment #4)
This one could be marked STAGED with: https://github.com/wine-staging/wine-staging/tree/master/patches/d3d11- Depth_Bias
I suspect it has not been because of comment #1. -- Do not reply to this email, post in Bugzilla using the above URL to reply. You are receiving this mail because: You are watching all bug changes.
https://bugs.winehq.org/show_bug.cgi?id=43848 --- Comment #6 from BieHDC <byi5000(a)gmail.com> --- This is implemented now, you can close this. https://source.winehq.org/git/wine.git/commit/42b5d88f2e081d90195bd3cd193192... -- Do not reply to this email, post in Bugzilla using the above URL to reply. You are receiving this mail because: You are watching all bug changes.
https://bugs.winehq.org/show_bug.cgi?id=43848 Józef Kucia <joseph.kucia(a)gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |joseph.kucia(a)gmail.com Status|UNCONFIRMED |RESOLVED Fixed by SHA1| |42b5d88f2e081d90195bd3cd193 | |1929f84b26f45 Component|-unknown |directx-d3d Resolution|--- |FIXED --- Comment #7 from Józef Kucia <joseph.kucia(a)gmail.com> --- https://source.winehq.org/git/wine.git/commit/42b5d88f2e081d90195bd3cd193192... -- Do not reply to this email, post in Bugzilla using the above URL to reply. You are receiving this mail because: You are watching all bug changes.
https://bugs.winehq.org/show_bug.cgi?id=43848 Alexandre Julliard <julliard(a)winehq.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|RESOLVED |CLOSED --- Comment #8 from Alexandre Julliard <julliard(a)winehq.org> --- Closing bugs fixed in 3.19. -- Do not reply to this email, post in Bugzilla using the above URL to reply. You are receiving this mail because: You are watching all bug changes.
participants (1)
-
wine-bugs＠winehq.org