[Bug 52334] New: Vanilla WoW 1.12.1 performance regression between 6.22 and 6.23 (still present 7.0rc4)
https://bugs.winehq.org/show_bug.cgi?id=52334 Bug ID: 52334 Summary: Vanilla WoW 1.12.1 performance regression between 6.22 and 6.23 (still present 7.0rc4) Product: Wine Version: 7.0-rc4 Hardware: x86-64 OS: Linux Status: UNCONFIRMED Severity: normal Priority: P2 Component: -unknown Assignee: wine-bugs(a)winehq.org Reporter: karabaja4(a)gmail.com Distribution: --- There was a regression between Wine 6.22 and 6.23 that caused a FPS performance drop in Vanilla WoW 1.12.1 client (Nostalrius client, played on https://darrowshire.com). This regression is still present in 7.04c4. The FPS is almost double the value in 6.22 compared to 6.23 or 7.0rc4. Pure Wine installation, my OS is Arch Linux 5.10.88 with nvidia 495.46 proprietary drivers with Openbox WM. Here are a few screenshot for comparison: 6.22: https://avacyn.aerium.hr/stuff/wine/wine622.jpg 7.0rc4: https://avacyn.aerium.hr/stuff/wine/wine70rc4.jpg Regards. -- Do not reply to this email, post in Bugzilla using the above URL to reply. You are receiving this mail because: You are watching all bug changes.
https://bugs.winehq.org/show_bug.cgi?id=52334 joaopa <jeremielapuree(a)yahoo.fr> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |jeremielapuree(a)yahoo.fr --- Comment #1 from joaopa <jeremielapuree(a)yahoo.fr> --- To improve the chances to see this bug fixed, you should try to perform a regression test: https://wiki.winehq.org/Regression_Testing -- Do not reply to this email, post in Bugzilla using the above URL to reply. You are receiving this mail because: You are watching all bug changes.
https://bugs.winehq.org/show_bug.cgi?id=52334 --- Comment #2 from Igor <karabaja4(a)gmail.com> --- Hi, I bisected the commits between 6.22 and 6.23. I found the culprit to be this commit: 537e20e041bd3b36553e45fe83671a92fdfd7735 is the first bad commit commit 537e20e041bd3b36553e45fe83671a92fdfd7735 Author: Henri Verbeet <hverbeet(a)codeweavers.com> Date: Wed Dec 1 17:52:16 2021 -0600 wined3d: Map OpenGL adapter BOs persistently on 64-bit architectures. Signed-off-by: Zebediah Figura <zfigura(a)codeweavers.com> Signed-off-by: Alexandre Julliard <julliard(a)winehq.org> dlls/wined3d/context_gl.c | 23 ++++++++++++++++++++++- 1 file changed, 22 insertions(+), 1 deletion(-) -- Do not reply to this email, post in Bugzilla using the above URL to reply. You are receiving this mail because: You are watching all bug changes.
https://bugs.winehq.org/show_bug.cgi?id=52334 --- Comment #3 from Igor <karabaja4(a)gmail.com> --- https://source.winehq.org/git/wine.git/commitdiff/537e20e041bd3b36553e45fe83... -- Do not reply to this email, post in Bugzilla using the above URL to reply. You are receiving this mail because: You are watching all bug changes.
https://bugs.winehq.org/show_bug.cgi?id=52334 Gijs Vermeulen <gijsvrm(a)gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Keywords| |performance, regression Version|7.0-rc4 |6.23 Regression SHA1| |537e20e041bd3b36553e45fe836 | |71a92fdfd7735 CC| |z.figura12(a)gmail.com Component|-unknown |directx-d3d Summary|Vanilla WoW 1.12.1 |WoW 1.12.1 performance has |performance regression |degraded |between 6.22 and 6.23 | |(still present 7.0rc4) | -- Do not reply to this email, post in Bugzilla using the above URL to reply. You are receiving this mail because: You are watching all bug changes.
https://bugs.winehq.org/show_bug.cgi?id=52334 --- Comment #4 from Zebediah Figura <z.figura12(a)gmail.com> --- Created attachment 71594 --> https://bugs.winehq.org/attachment.cgi?id=71594 never map persistently Unfortunately I can't reproduce this on radeonsi. What happens if you always return false from wined3d_map_persistent(), as in the attached patch? -- Do not reply to this email, post in Bugzilla using the above URL to reply. You are receiving this mail because: You are watching all bug changes.
https://bugs.winehq.org/show_bug.cgi?id=52334 --- Comment #5 from Igor <karabaja4(a)gmail.com> --- In latest wine-git, I still get the regression with: static inline bool wined3d_map_persistent(void) { return false; } and the same with: static inline bool wined3d_map_persistent(void) { return true; } which is, a double FPS drop compared to wine 6.22. Changing the function return value seems to be having no effect on this bug. -- Do not reply to this email, post in Bugzilla using the above URL to reply. You are receiving this mail because: You are watching all bug changes.
https://bugs.winehq.org/show_bug.cgi?id=52334 Ker noa <blue-t(a)web.de> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |blue-t(a)web.de -- Do not reply to this email, post in Bugzilla using the above URL to reply. You are receiving this mail because: You are watching all bug changes.
https://bugs.winehq.org/show_bug.cgi?id=52334 poweroverwhelming982(a)gmail.com changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |hverbeet(a)gmail.com, | |poweroverwhelming982(a)gmail. | |com -- Do not reply to this email, post in Bugzilla using the above URL to reply. You are receiving this mail because: You are watching all bug changes.
https://bugs.winehq.org/show_bug.cgi?id=52334 --- Comment #6 from poweroverwhelming982(a)gmail.com --- This also affects Skyrim Legendary Edition, though the performance drop seems more severe on my (low-end) hardware. It drops from around 30 FPS to below 10. Done a regression test, same commit causes the issue, the attached patch also makes no difference. I've also added the commit author to CC. Additional info: OS: Ubuntu Focal 20.04.3 LTS Kernel: 5.13.0-27-generic x86_64 Wine Prefix: 32 bit, clean GPU: NVIDIA Corporation GF108 [GeForce GT 730] (rev a1) Graphics Driver: Proprietary NVIDIA ver. 390.144 -- Do not reply to this email, post in Bugzilla using the above URL to reply. You are receiving this mail because: You are watching all bug changes.
https://bugs.winehq.org/show_bug.cgi?id=52334 Julian Rüger <jr98(a)gmx.net> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |jr98(a)gmx.net -- Do not reply to this email, post in Bugzilla using the above URL to reply. You are receiving this mail because: You are watching all bug changes.
https://bugs.winehq.org/show_bug.cgi?id=52334 Olivier F. R. Dierick <o.dierick(a)piezo-forte.be> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |o.dierick(a)piezo-forte.be --- Comment #7 from Olivier F. R. Dierick <o.dierick(a)piezo-forte.be> --- Hello, Related to bug 50235 and bug 52660. The 3 bugs relates to buffer objects handling. I guess it's a work in progress area. I personally didn't experience a fps drop in World of Warcraft. My game is set to use DirectX11 and the GPU is nvidia RTX 2070 with proprietary driver 510.54. However, on the same hardware, I got a severe FPS drop in Elder Scrolls Online and World of Warships since 6.0-rc3. My estimate was around 4-5 FPS. Although there has been much work on BOs lately, the performance drop has affected each wine version up to 7.3 (I didn't try 7.4). Regards. -- Do not reply to this email, post in Bugzilla using the above URL to reply. You are receiving this mail because: You are watching all bug changes.
https://bugs.winehq.org/show_bug.cgi?id=52334 --- Comment #8 from Igor <karabaja4(a)gmail.com> --- Hi all. Just an update, this bug is still present in 7.7 and the performance drop is still unchanged with the regression introduced in 537e20e041bd3b36553e45fe83671a92fdfd7735, compared to 6.22. -- Do not reply to this email, post in Bugzilla using the above URL to reply. You are receiving this mail because: You are watching all bug changes.
https://bugs.winehq.org/show_bug.cgi?id=52334 Andrey Gusev <andrey.goosev(a)gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|UNCONFIRMED |NEW CC| |andrey.goosev(a)gmail.com Summary|WoW 1.12.1 performance has |Performance has degraded in |degraded |multiple games (WoW 1.12.1, | |Kane & Lynch: Dead Men | |Demo) Ever confirmed|0 |1 --- Comment #9 from Andrey Gusev <andrey.goosev(a)gmail.com> --- Confirming. -- Do not reply to this email, post in Bugzilla using the above URL to reply. You are receiving this mail because: You are watching all bug changes.
https://bugs.winehq.org/show_bug.cgi?id=52334 --- Comment #10 from Igor <karabaja4(a)gmail.com> --- This was fixed for me in Wine 7.20, the FPS is back to the levels of 6.22. -- Do not reply to this email, post in Bugzilla using the above URL to reply. You are receiving this mail because: You are watching all bug changes.
https://bugs.winehq.org/show_bug.cgi?id=52334 Zeb Figura <z.figura12(a)gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |RESOLVED Resolution|--- |FIXED Fixed by SHA1| |ebbcc10b0593948657b8e684c3a | |9be8ace1a5d25 --- Comment #11 from Zeb Figura <z.figura12(a)gmail.com> --- (In reply to Igor from comment #10)
This was fixed for me in Wine 7.20, the FPS is back to the levels of 6.22.
If I had to guess I'd say ebbcc10b05 is the most likely candidate for what fixed it. Marking fixed then; thanks for testing! -- Do not reply to this email, post in Bugzilla using the above URL to reply. You are receiving this mail because: You are watching all bug changes.
https://bugs.winehq.org/show_bug.cgi?id=52334 Alexandre Julliard <julliard(a)winehq.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|RESOLVED |CLOSED --- Comment #12 from Alexandre Julliard <julliard(a)winehq.org> --- Closing bugs fixed in 8.0-rc2. -- Do not reply to this email, post in Bugzilla using the above URL to reply. You are receiving this mail because: You are watching all bug changes.
https://bugs.winehq.org/show_bug.cgi?id=52334 --- Comment #13 from Andrey Gusev <andrey.goosev(a)gmail.com> --- Still reproducible with 8.0-rc2-7-gd059dd1cd07 NVIDIA Driver 525.60.11 -- Do not reply to this email, post in Bugzilla using the above URL to reply. You are receiving this mail because: You are watching all bug changes.
participants (1)
-
WineHQ Bugzilla