[Bug 25752] New: [patch] add support for indexed formats to GdipBitmapSetPixel
http://bugs.winehq.org/show_bug.cgi?id=25752 Summary: [patch] add support for indexed formats to GdipBitmapSetPixel Product: Wine Version: 1.3.11 Platform: x86 OS/Version: Linux Status: UNCONFIRMED Severity: enhancement Priority: P2 Component: gdiplus AssignedTo: wine-bugs(a)winehq.org ReportedBy: singularita(a)gmail.com Created an attachment (id=32806) --> (http://bugs.winehq.org/attachment.cgi?id=32806) Add support for indexed formats (PixelFormat1bppIndexed, PixelFormat4bppIndexed, PixelFormat8bppIndexed) to GdipBitmapSetPixel I run one windows application (unfortunately the application is not publicly available) and I run into some parts of the application being shown in black and lots of "fixme:gdiplus:GdipBitmapSetPixel not implemented for format 0x30803" shown on console. So I added support for indexed formats (PixelFormat1bppIndexed, PixelFormat4bppIndexed, PixelFormat8bppIndexed) to GdipBitmapSetPixel. Seems to fix the problem. Attaching patch to latest 1.3.11 -- Configure bugmail: http://bugs.winehq.org/userprefs.cgi?tab=email Do not reply to this email, post in Bugzilla using the above URL to reply. ------- You are receiving this mail because: ------- You are watching all bug changes.
http://bugs.winehq.org/show_bug.cgi?id=25752 --- Comment #1 from Vincent Povirk <madewokherd(a)gmail.com> 2011-01-10 18:35:32 CST --- Patches are not picked up from bugzilla. See http://wiki.winehq.org/SubmittingPatches -- Configure bugmail: http://bugs.winehq.org/userprefs.cgi?tab=email Do not reply to this email, post in Bugzilla using the above URL to reply. ------- You are receiving this mail because: ------- You are watching all bug changes.
http://bugs.winehq.org/show_bug.cgi?id=25752 Vincent Povirk <madewokherd(a)gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #32806|application/octetstream |text/plain mime type| | Attachment #32806|0 |1 is patch| | -- Configure bugmail: http://bugs.winehq.org/userprefs.cgi?tab=email Do not reply to this email, post in Bugzilla using the above URL to reply. ------- You are receiving this mail because: ------- You are watching all bug changes.
http://bugs.winehq.org/show_bug.cgi?id=25752 Austin English <austinenglish(a)gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Keywords| |patch -- Configure bugmail: http://bugs.winehq.org/userprefs.cgi?tab=email Do not reply to this email, post in Bugzilla using the above URL to reply. ------- You are receiving this mail because: ------- You are watching all bug changes.
http://bugs.winehq.org/show_bug.cgi?id=25752 --- Comment #2 from MP <singularita(a)gmail.com> 2011-01-10 19:36:41 CST --- (In reply to comment #1) I've sent the patch to the wine-patches mailing list. Should this bug be closed? -- Configure bugmail: http://bugs.winehq.org/userprefs.cgi?tab=email Do not reply to this email, post in Bugzilla using the above URL to reply. ------- You are receiving this mail because: ------- You are watching all bug changes.
http://bugs.winehq.org/show_bug.cgi?id=25752 Dan Kegel <dank(a)kegel.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |dank(a)kegel.com --- Comment #3 from Dan Kegel <dank(a)kegel.com> 2011-01-10 20:01:57 CST --- The bug can be left open until the problem is fixed. That warning you mentioned also shows up when the gdiplus image tests are run; did you check whether your patch fixes a todo_wine in cd dlls/gdiplus/tests make test ? Also, did you run your patch through WineTestBot (see http://wiki.winehq.org/WineTestBot )? -- Configure bugmail: http://bugs.winehq.org/userprefs.cgi?tab=email Do not reply to this email, post in Bugzilla using the above URL to reply. ------- You are receiving this mail because: ------- You are watching all bug changes.
http://bugs.winehq.org/show_bug.cgi?id=25752 --- Comment #4 from Austin English <austinenglish(a)gmail.com> 2011-01-11 00:59:57 CST --- (In reply to comment #3)
Also, did you run your patch through WineTestBot (see http://wiki.winehq.org/WineTestBot )?
The tests were not changed, this change won't be tested by WineTestBot (which only tests windows). -- Configure bugmail: http://bugs.winehq.org/userprefs.cgi?tab=email Do not reply to this email, post in Bugzilla using the above URL to reply. ------- You are receiving this mail because: ------- You are watching all bug changes.
http://bugs.winehq.org/show_bug.cgi?id=25752 Austin English <austinenglish(a)gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|UNCONFIRMED |RESOLVED Resolution| |FIXED --- Comment #5 from Austin English <austinenglish(a)gmail.com> 2011-01-12 14:43:57 CST --- Fixed by http://source.winehq.org/git/wine.git/?a=commitdiff;h=ee3c1790265eeb7fc90ef8... Thanks! -- Configure bugmail: http://bugs.winehq.org/userprefs.cgi?tab=email Do not reply to this email, post in Bugzilla using the above URL to reply. ------- You are receiving this mail because: ------- You are watching all bug changes.
http://bugs.winehq.org/show_bug.cgi?id=25752 Alexandre Julliard <julliard(a)winehq.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|RESOLVED |CLOSED --- Comment #6 from Alexandre Julliard <julliard(a)winehq.org> 2011-01-21 13:43:06 CST --- Closing bugs fixed in 1.3.12. -- Configure bugmail: http://bugs.winehq.org/userprefs.cgi?tab=email Do not reply to this email, post in Bugzilla using the above URL to reply. ------- You are receiving this mail because: ------- You are watching all bug changes.
participants (1)
-
wine-bugs＠winehq.org