[Bug 56209] New: winetricks vb5run fails
https://bugs.winehq.org/show_bug.cgi?id=56209 Bug ID: 56209 Summary: winetricks vb5run fails Product: Wine Version: 8.10 Hardware: x86-64 OS: Linux Status: NEW Keywords: download, regression Severity: normal Priority: P2 Component: advpack Assignee: wine-bugs(a)winehq.org Reporter: austinenglish(a)gmail.com CC: alexhenrie24(a)gmail.com Regression SHA1: 29d543d12a2085be8513859369291bbcc35694db Distribution: Debian austin(a)debian:~/wine-rt$ wineserver -k ; rm -rf ~/.wine ; WINE=~/wine-rt/wine WINEDEBUG=advpack winetricks -q vb5run ; echo $? Using winetricks 20240105-next - sha256sum: 7c153235548ab7e2f6f47c3d33c7fa7b27543dd3b603ec97227dc7984647ac32 with wine-8.10-124-g24552295499 and WINEARCH=win32 Executing w_do_call vb5run Executing load_vb5run Executing cd /home/austin/.cache/winetricks/vb5run Executing /home/austin/wine-rt/wine msvbvm50.exe /q 0220:trace:advpack:DoInfInstallW (0031FCDC) ------------------------------------------------------ warning: Note: command /home/austin/wine-rt/wine msvbvm50.exe /q returned status 5. Aborting. ------------------------------------------------------ 1 29d543d12a2085be8513859369291bbcc35694db is the first bad commit commit 29d543d12a2085be8513859369291bbcc35694db Author: Alex Henrie <alexhenrie24(a)gmail.com> Date: Fri Jun 16 21:56:14 2023 -0600 advpack: Check the return value of adv_install in DoInfInstallW (scan-build). dlls/advpack/install.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) -- Do not reply to this email, post in Bugzilla using the above URL to reply. You are receiving this mail because: You are watching all bug changes.
https://bugs.winehq.org/show_bug.cgi?id=56209 Fabian Maurer <dark.shadow4(a)web.de> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |dark.shadow4(a)web.de --- Comment #1 from Fabian Maurer <dark.shadow4(a)web.de> --- Problem is in advpack.dll, register_ocxs_callback. It tries to load dll "@%inat%", which fails. See msvbvm50.inf
[RegisterOCXSection] @%inat% %11%\msvbvm50.dll %11%\olepro32.dll %11%\comcat.dll %11%\oleaut32.dll
-- Do not reply to this email, post in Bugzilla using the above URL to reply. You are receiving this mail because: You are watching all bug changes.
https://bugs.winehq.org/show_bug.cgi?id=56209 --- Comment #2 from Alex Henrie <alexhenrie24(a)gmail.com> --- setupapi seems to ignore lines that start with an at sign, regardless of what section they're in. Seems like something needs to change in the inf file parser. -- Do not reply to this email, post in Bugzilla using the above URL to reply. You are receiving this mail because: You are watching all bug changes.
https://bugs.winehq.org/show_bug.cgi?id=56209 --- Comment #3 from Alex Henrie <alexhenrie24(a)gmail.com> --- No, I was wrong, whether or not arbitrary lines that start with @ are accepted depends very much on what section they are in. Here's what I got after some more testing: At the beginning of the file: Forbidden In the [DefaultInstall] section: Permitted In the [SourceDisksNames] section: Permitted In the [SourceDisksFiles] section: Permitted In a CopyFiles section: Forbidden In a DelFiles section: Permitted In a DelDirs section: Permitted In a RenFiles section: Forbidden In a RunPreSetupCommands section: Forbidden In a RunPostSetupCommands section: Forbidden In a PerUserInstall section: Permitted In a RegisterOCXSection: Permitted -- Do not reply to this email, post in Bugzilla using the above URL to reply. You are receiving this mail because: You are watching all bug changes.
https://bugs.winehq.org/show_bug.cgi?id=56209 --- Comment #4 from Alex Henrie <alexhenrie24(a)gmail.com> --- Typo: That last one should have been "In a RegisterOCXs section" Anyway, I sent a patch: https://gitlab.winehq.org/wine/wine/-/merge_requests/4878/diffs -- Do not reply to this email, post in Bugzilla using the above URL to reply. You are receiving this mail because: You are watching all bug changes.
https://bugs.winehq.org/show_bug.cgi?id=56209 Alex Henrie <alexhenrie24(a)gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |leslie_alistair(a)hotmail.com --- Comment #5 from Alex Henrie <alexhenrie24(a)gmail.com> --- Alistair, could you add the patch from the MR to Wine Staging please? -- Do not reply to this email, post in Bugzilla using the above URL to reply. You are receiving this mail because: You are watching all bug changes.
https://bugs.winehq.org/show_bug.cgi?id=56209 Zeb Figura <z.figura12(a)gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |z.figura12(a)gmail.com --- Comment #6 from Zeb Figura <z.figura12(a)gmail.com> --- (In reply to Alex Henrie from comment #5)
Alistair, could you add the patch from the MR to Wine Staging please?
As far as I've seen, there's been an unaddressed comment on the merge request, any chance you could try to respond to that first? -- Do not reply to this email, post in Bugzilla using the above URL to reply. You are receiving this mail because: You are watching all bug changes.
https://bugs.winehq.org/show_bug.cgi?id=56209 --- Comment #7 from Alex Henrie <alexhenrie24(a)gmail.com> --- (In reply to Zeb Figura from comment #6)
As far as I've seen, there's been an unaddressed comment on the merge request, any chance you could try to respond to that first?
If I knew how to write a more convincing test, I would. Alexandre didn't explicitly say what kind of test would convince him, but since a test where the @ symbol apparently does nothing is not good enough, I'm inferring that he wants a test that shows the @ symbol actually doing something. Unfortunately, since it's undocumented, no one really knows what it's supposed to do. If we add the patch to Wine Staging then maybe someone will find another app that triggers the new FIXME, which might give us the clue we need to write a better test. -- Do not reply to this email, post in Bugzilla using the above URL to reply. You are receiving this mail because: You are watching all bug changes.
https://bugs.winehq.org/show_bug.cgi?id=56209 --- Comment #8 from Zeb Figura <z.figura12(a)gmail.com> --- Is it possible that the @ sign isn't special, but advpack just ignores files that are missing? A successful registration test would probably also be helpful, to at least prove that the tests are meaningful. -- Do not reply to this email, post in Bugzilla using the above URL to reply. You are receiving this mail because: You are watching all bug changes.
https://bugs.winehq.org/show_bug.cgi?id=56209 --- Comment #9 from Alex Henrie <alexhenrie24(a)gmail.com> --- (In reply to Zeb Figura from comment #8)
Is it possible that the @ sign isn't special, but advpack just ignores files that are missing?
A successful registration test would probably also be helpful, to at least prove that the tests are meaningful.
If I omit the @ sign, a modal dialog appears that says "Error registering the OCX foobar", and the program does not continue until I click "OK". Any idea how to prevent that dialog from appearing while running the test suite? -- Do not reply to this email, post in Bugzilla using the above URL to reply. You are receiving this mail because: You are watching all bug changes.
https://bugs.winehq.org/show_bug.cgi?id=56209 --- Comment #10 from Fabian Maurer <dark.shadow4(a)web.de> --- Created attachment 77098 --> https://bugs.winehq.org/attachment.cgi?id=77098 Test patch to ignore dialogs
If I omit the @ sign, a modal dialog appears that says "Error registering the OCX foobar", and the program does not continue until I click "OK". Any idea how to prevent that dialog from appearing while running the test suite?
You can use hooks for that, see my attached patch. -- Do not reply to this email, post in Bugzilla using the above URL to reply. You are receiving this mail because: You are watching all bug changes.
https://bugs.winehq.org/show_bug.cgi?id=56209 --- Comment #11 from Austin English <austinenglish(a)gmail.com> --- Still present in 9.19. -- Do not reply to this email, post in Bugzilla using the above URL to reply. You are receiving this mail because: You are watching all bug changes.
http://bugs.winehq.org/show_bug.cgi?id=56209 Alex Henrie <alexhenrie24(a)gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Fixed by SHA1| |0ef9bf639497eded3addb504762 | |29817b929cc6c Resolution|--- |FIXED Status|NEW |RESOLVED --- Comment #12 from Alex Henrie <alexhenrie24(a)gmail.com> --- Fixed by https://gitlab.winehq.org/wine/wine/-/commit/0ef9bf639497eded3addb5047622981... Thanks to everyone who helped with this. -- Do not reply to this email, post in Bugzilla using the above URL to reply. You are receiving this mail because: You are watching all bug changes.
http://bugs.winehq.org/show_bug.cgi?id=56209 Alexandre Julliard <julliard(a)winehq.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|RESOLVED |CLOSED --- Comment #13 from Alexandre Julliard <julliard(a)winehq.org> --- Closing bugs fixed in 10.18. -- Do not reply to this email, post in Bugzilla using the above URL to reply. You are receiving this mail because: You are watching all bug changes.
participants (1)
-
WineHQ Bugzilla