[Bug 56595] New: Fallout 3: regression causes lots of streamer critical errors, slowdown
https://bugs.winehq.org/show_bug.cgi?id=56595 Bug ID: 56595 Summary: Fallout 3: regression causes lots of streamer critical errors, slowdown Product: Wine Version: unspecified Hardware: x86-64 OS: Linux Status: UNCONFIRMED Severity: normal Priority: P2 Component: -unknown Assignee: wine-bugs(a)winehq.org Reporter: m1m1k4tz(a)protonmail.com CC: bmcgrath(a)codeweavers.com Regression SHA1: 9e1f5f6d11b14b3ee38050a1b45a55f5c71146c6 Distribution: --- Created attachment 76353 --> https://bugs.winehq.org/attachment.cgi?id=76353 gstreamer Critical errors -- Do not reply to this email, post in Bugzilla using the above URL to reply. You are receiving this mail because: You are watching all bug changes.
https://bugs.winehq.org/show_bug.cgi?id=56595 Ken Sharp <imwellcushtymelike(a)gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Ever confirmed|0 |1 Status|UNCONFIRMED |NEEDINFO --- Comment #1 from Ken Sharp <imwellcushtymelike(a)gmail.com> --- You have provided no useful information whatsoever. Read https://wiki.winehq.org/Bugs and provide the required information. --- Comment #2 from m1m1k4tz <m1m1k4tz(a)protonmail.com> --- There is a slowdown in Fallout 3 and lots of critical errors attached in the terminal output after the linked commit. -- Do not reply to this email, post in Bugzilla using the above URL to reply. You are receiving this mail because: You are watching all bug changes.
https://bugs.winehq.org/show_bug.cgi?id=56595 m1m1k4tz <m1m1k4tz(a)protonmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Summary|Fallout 3: regression |Fallout 3: regression |causes lots of streamer |causes lots of gstreamer |critical errors, slowdown |critical errors, slowdown -- Do not reply to this email, post in Bugzilla using the above URL to reply. You are receiving this mail because: You are watching all bug changes.
https://bugs.winehq.org/show_bug.cgi?id=56595 m1m1k4tz <m1m1k4tz(a)protonmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Keywords| |regression -- Do not reply to this email, post in Bugzilla using the above URL to reply. You are receiving this mail because: You are watching all bug changes.
https://bugs.winehq.org/show_bug.cgi?id=56595 Olivier F. R. Dierick <o.dierick(a)piezo-forte.be> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |o.dierick(a)piezo-forte.be --- Comment #3 from Olivier F. R. Dierick <o.dierick(a)piezo-forte.be> --- Hello, Please attach a normal (=without WINEDEBUG) terminal output. Instructions to get a log can be found there: https://wiki.winehq.org/FAQ#get_log Regards. -- Do not reply to this email, post in Bugzilla using the above URL to reply. You are receiving this mail because: You are watching all bug changes.
https://bugs.winehq.org/show_bug.cgi?id=56595 --- Comment #4 from m1m1k4tz <m1m1k4tz(a)protonmail.com> --- Created attachment 76362 --> https://bugs.winehq.org/attachment.cgi?id=76362 gstreamer2 -- Do not reply to this email, post in Bugzilla using the above URL to reply. You are receiving this mail because: You are watching all bug changes.
https://bugs.winehq.org/show_bug.cgi?id=56595 Brendan McGrath <brendan(a)redmandi.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |brendan(a)redmandi.com --- Comment #5 from Brendan McGrath <brendan(a)redmandi.com> --- Are you sure you've listed the right commit? As in, do you see this error when you checkout this commit and compile? Because the errors you've provided come from gstreamer, but this commit doesn't modify Wine's interaction with gstreamer (just a structure used internally by Wine). Also, what's slow? The whole game, or just video playback? -- Do not reply to this email, post in Bugzilla using the above URL to reply. You are receiving this mail because: You are watching all bug changes.
https://bugs.winehq.org/show_bug.cgi?id=56595 --- Comment #6 from m1m1k4tz <m1m1k4tz(a)protonmail.com> --- Well, I did a git bisect and it blames this commit. The mouse in the menu feels slow and it feels like there's less fps in game as well once the gstreamer errors start -- Do not reply to this email, post in Bugzilla using the above URL to reply. You are receiving this mail because: You are watching all bug changes.
https://bugs.winehq.org/show_bug.cgi?id=56595 --- Comment #7 from Brendan McGrath <brendan(a)redmandi.com> --- Can I get you to try reverting commit 752126d60ef8249beee57b6d5f9f7ccde84d0d58? It's the one after 9e1f5f6d11b14b3ee38050a1b45a55f5c71146c6, and is the one which passes the URI to gstreamer. If this fixes the issue, maybe the bisect was off by one. If that doesn't fix it, you can then also revert 9e1f5f6d11b14b3ee38050a1b45a55f5c71146c6 and confirm this fixes it. -- Do not reply to this email, post in Bugzilla using the above URL to reply. You are receiving this mail because: You are watching all bug changes.
https://bugs.winehq.org/show_bug.cgi?id=56595 --- Comment #8 from m1m1k4tz <m1m1k4tz(a)protonmail.com> --- I've just verified that it happens when reverting 9e1f5f6d11b14b3ee38050a1b45a55f5c71146c6 -- Do not reply to this email, post in Bugzilla using the above URL to reply. You are receiving this mail because: You are watching all bug changes.
https://bugs.winehq.org/show_bug.cgi?id=56595 --- Comment #9 from Brendan McGrath <brendan(a)redmandi.com> --- (In reply to m1m1k4tz from comment #8)
I've just verified that it happens when reverting 9e1f5f6d11b14b3ee38050a1b45a55f5c71146c6
OK, so you still see this issue happening after reverting 9e1f5f6d11b14b3ee38050a1b45a55f5c71146c6? Or do you mean you no longer see it happening after reverting? -- Do not reply to this email, post in Bugzilla using the above URL to reply. You are receiving this mail because: You are watching all bug changes.
https://bugs.winehq.org/show_bug.cgi?id=56595 Ken Sharp <imwellcushtymelike(a)gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Summary|Fallout 3: regression |Fallout 3 is slow |causes lots of gstreamer | |critical errors, slowdown | --- Comment #10 from Ken Sharp <imwellcushtymelike(a)gmail.com> ---
experimental wow64 mode
What version of Wine are you using? -- Do not reply to this email, post in Bugzilla using the above URL to reply. You are receiving this mail because: You are watching all bug changes.
https://bugs.winehq.org/show_bug.cgi?id=56595 --- Comment #11 from m1m1k4tz <m1m1k4tz(a)protonmail.com> --- (In reply to Brendan McGrath from comment #9)
(In reply to m1m1k4tz from comment #8)
I've just verified that it happens when reverting 9e1f5f6d11b14b3ee38050a1b45a55f5c71146c6
OK, so you still see this issue happening after reverting 9e1f5f6d11b14b3ee38050a1b45a55f5c71146c6? Or do you mean you no longer see it happening after reverting?
My bad I meant the issue goes away after reverting 9e1f5f6d11b14b3ee38050a1b45a55f5c71146c6 -- Do not reply to this email, post in Bugzilla using the above URL to reply. You are receiving this mail because: You are watching all bug changes.
https://bugs.winehq.org/show_bug.cgi?id=56595 --- Comment #12 from m1m1k4tz <m1m1k4tz(a)protonmail.com> --- (In reply to Ken Sharp from comment #10)
experimental wow64 mode
What version of Wine are you using?
I’m testing the new wow64 mode and the new Wayland driver but it happens on x as well after the gdi stuff got merged the new wow64 mode is pretty usable as far as I can tell -- Do not reply to this email, post in Bugzilla using the above URL to reply. You are receiving this mail because: You are watching all bug changes.
https://bugs.winehq.org/show_bug.cgi?id=56595 --- Comment #13 from Ken Sharp <imwellcushtymelike(a)gmail.com> --- What VERSION of Wine are you using? -- Do not reply to this email, post in Bugzilla using the above URL to reply. You are receiving this mail because: You are watching all bug changes.
https://bugs.winehq.org/show_bug.cgi?id=56595 --- Comment #14 from Ken Sharp <imwellcushtymelike(a)gmail.com> --- $ wine --version -- Do not reply to this email, post in Bugzilla using the above URL to reply. You are receiving this mail because: You are watching all bug changes.
https://bugs.winehq.org/show_bug.cgi?id=56595 --- Comment #15 from Brendan McGrath <brendan(a)redmandi.com> --- (In reply to m1m1k4tz from comment #12)
(In reply to Ken Sharp from comment #10)
experimental wow64 mode
What version of Wine are you using?
I’m testing the new wow64 mode and the new Wayland driver but it happens on x as well after the gdi stuff got merged the new wow64 mode is pretty usable as far as I can tell
Oh, wow64 mode. That better explains how this commit could introduce a problem. Thank-you both for bringing that to my attention, I missed that detail. 9e1f5f6d11b14b3ee38050a1b45a55f5c71146c6 was a cherry-pick from Proton (which doesn't need to support wow64 mode), and it adds an address pointer to one of the APIs (which is a different length for 32-bit vs 64-bit). So this could very well be the problem. Once I confirm, and find the fix, I'll raise a new MR to address this. -- Do not reply to this email, post in Bugzilla using the above URL to reply. You are receiving this mail because: You are watching all bug changes.
https://bugs.winehq.org/show_bug.cgi?id=56595 --- Comment #16 from m1m1k4tz <m1m1k4tz(a)protonmail.com> --- (In reply to Brendan McGrath from comment #15)
(In reply to m1m1k4tz from comment #12)
(In reply to Ken Sharp from comment #10)
experimental wow64 mode
What version of Wine are you using?
I’m testing the new wow64 mode and the new Wayland driver but it happens on x as well after the gdi stuff got merged the new wow64 mode is pretty usable as far as I can tell
Oh, wow64 mode. That better explains how this commit could introduce a problem. Thank-you both for bringing that to my attention, I missed that detail.
9e1f5f6d11b14b3ee38050a1b45a55f5c71146c6 was a cherry-pick from Proton (which doesn't need to support wow64 mode), and it adds an address pointer to one of the APIs (which is a different length for 32-bit vs 64-bit). So this could very well be the problem. Once I confirm, and find the fix, I'll raise a new MR to address this.
No problem, I should've included the whole log from the beginning my bad -- Do not reply to this email, post in Bugzilla using the above URL to reply. You are receiving this mail because: You are watching all bug changes.
https://bugs.winehq.org/show_bug.cgi?id=56595 --- Comment #17 from m1m1k4tz <m1m1k4tz(a)protonmail.com> --- (In reply to Ken Sharp from comment #14)
$ wine --version
wine-9.7-155-g898ab8dab19 with those commits reverted -- Do not reply to this email, post in Bugzilla using the above URL to reply. You are receiving this mail because: You are watching all bug changes.
https://bugs.winehq.org/show_bug.cgi?id=56595 --- Comment #18 from m1m1k4tz <m1m1k4tz(a)protonmail.com> --- (In reply to m1m1k4tz from comment #17)
(In reply to Ken Sharp from comment #14)
$ wine --version
wine-9.7-155-g898ab8dab19 with those commits reverted
I compile it in a toolbox on fedora silverblue with these scripts it keeps everything on my machine clean and fedora automatically uses ccache I'm pretty sure so it speeds stuff up -- Do not reply to this email, post in Bugzilla using the above URL to reply. You are receiving this mail because: You are watching all bug changes.
https://bugs.winehq.org/show_bug.cgi?id=56595 --- Comment #19 from m1m1k4tz <m1m1k4tz(a)protonmail.com> --- Created attachment 76390 --> https://bugs.winehq.org/attachment.cgi?id=76390 compile -- Do not reply to this email, post in Bugzilla using the above URL to reply. You are receiving this mail because: You are watching all bug changes.
https://bugs.winehq.org/show_bug.cgi?id=56595 --- Comment #20 from m1m1k4tz <m1m1k4tz(a)protonmail.com> --- Created attachment 76391 --> https://bugs.winehq.org/attachment.cgi?id=76391 dependencies -- Do not reply to this email, post in Bugzilla using the above URL to reply. You are receiving this mail because: You are watching all bug changes.
https://bugs.winehq.org/show_bug.cgi?id=56595 --- Comment #21 from Brendan McGrath <brendan(a)redmandi.com> --- Created attachment 76392 --> https://bugs.winehq.org/attachment.cgi?id=76392 Hopefully fixes WoW64 Using the latest master (without any of the patches reverted), can you confirm that applying the attached patch fixes this issue for you? -- Do not reply to this email, post in Bugzilla using the above URL to reply. You are receiving this mail because: You are watching all bug changes.
https://bugs.winehq.org/show_bug.cgi?id=56595 Ken Sharp <imwellcushtymelike(a)gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Distribution|--- |Fedora Keywords| |wow64 Version|unspecified |9.7 -- Do not reply to this email, post in Bugzilla using the above URL to reply. You are receiving this mail because: You are watching all bug changes.
https://bugs.winehq.org/show_bug.cgi?id=56595 --- Comment #22 from m1m1k4tz <m1m1k4tz(a)protonmail.com> --- (In reply to Brendan McGrath from comment #21)
Created attachment 76392 [details] Hopefully fixes WoW64
Using the latest master (without any of the patches reverted), can you confirm that applying the attached patch fixes this issue for you?
I can confirm that fixes it, thanks! -- Do not reply to this email, post in Bugzilla using the above URL to reply. You are receiving this mail because: You are watching all bug changes.
https://bugs.winehq.org/show_bug.cgi?id=56595 --- Comment #23 from Brendan McGrath <brendan(a)redmandi.com> --- The fix for this has been merged: 87eaf899551077817106bce62f5a8b980a47635f -- Do not reply to this email, post in Bugzilla using the above URL to reply. You are receiving this mail because: You are watching all bug changes.
https://bugs.winehq.org/show_bug.cgi?id=56595 Ken Sharp <imwellcushtymelike(a)gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Fixed by SHA1| |87eaf899551077817106bce62f5 | |a8b980a47635f Status|NEEDINFO |RESOLVED Resolution|--- |FIXED --- Comment #24 from Ken Sharp <imwellcushtymelike(a)gmail.com> --- As above. Please reopen if the issue persists in the next release of Wine. -- Do not reply to this email, post in Bugzilla using the above URL to reply. You are receiving this mail because: You are watching all bug changes.
https://bugs.winehq.org/show_bug.cgi?id=56595 Alexandre Julliard <julliard(a)winehq.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|RESOLVED |CLOSED --- Comment #25 from Alexandre Julliard <julliard(a)winehq.org> --- Closing bugs fixed in 9.9. -- Do not reply to this email, post in Bugzilla using the above URL to reply. You are receiving this mail because: You are watching all bug changes.
participants (1)
-
WineHQ Bugzilla