[Bug 33190] New: Font display problem using text and dc rotation
http://bugs.winehq.org/show_bug.cgi?id=33190 Bug #: 33190 Summary: Font display problem using text and dc rotation Product: Wine Version: 1.5.25 Platform: x86-64 OS/Version: Linux Status: UNCONFIRMED Severity: normal Priority: P2 Component: gdi32 AssignedTo: wine-bugs(a)winehq.org ReportedBy: ralf.habacker(a)freenet.de Classification: Unclassified We recognized an gdi text display issue using the application Gausz http://appdb.winehq.org/objectManager.php?sClass=application&iId=13649. The problem appears when gdi text is drawn with font rotation *and* display context rotation. The problem do not appear when either font rotation or display context rotation is zero. The application uses CreateIndirectFont to set a fixed size font with optional set rotation and draws the text with TextOut(). The display context rotation has been set with SetWorldTransform(). We tried to find a test case application, but where not able to reproduce the problem outside the application. We also tried to debug into wine's code based, but got lost by the details. -- Configure bugmail: http://bugs.winehq.org/userprefs.cgi?tab=email Do not reply to this email, post in Bugzilla using the above URL to reply. ------- You are receiving this mail because: ------- You are watching all bug changes.
http://bugs.winehq.org/show_bug.cgi?id=33190 --- Comment #1 from Ralf Habacker <ralf.habacker(a)freenet.de> 2013-03-12 08:27:48 CDT --- Created attachment 43905 --> http://bugs.winehq.org/attachment.cgi?id=43905 zero degree - no error -- Configure bugmail: http://bugs.winehq.org/userprefs.cgi?tab=email Do not reply to this email, post in Bugzilla using the above URL to reply. ------- You are receiving this mail because: ------- You are watching all bug changes.
http://bugs.winehq.org/show_bug.cgi?id=33190 --- Comment #2 from Ralf Habacker <ralf.habacker(a)freenet.de> 2013-03-12 08:28:23 CDT --- Created attachment 43906 --> http://bugs.winehq.org/attachment.cgi?id=43906 45 degree dc rotation - showing error -- Configure bugmail: http://bugs.winehq.org/userprefs.cgi?tab=email Do not reply to this email, post in Bugzilla using the above URL to reply. ------- You are receiving this mail because: ------- You are watching all bug changes.
http://bugs.winehq.org/show_bug.cgi?id=33190 --- Comment #3 from Ralf Habacker <ralf.habacker(a)freenet.de> 2013-03-12 08:28:55 CDT --- Created attachment 43907 --> http://bugs.winehq.org/attachment.cgi?id=43907 90 degree rotation - showing error too -- Configure bugmail: http://bugs.winehq.org/userprefs.cgi?tab=email Do not reply to this email, post in Bugzilla using the above URL to reply. ------- You are receiving this mail because: ------- You are watching all bug changes.
http://bugs.winehq.org/show_bug.cgi?id=33190 --- Comment #4 from Ralf Habacker <ralf.habacker(a)freenet.de> 2013-03-12 08:42:00 CDT ---
From my observations I would say that there is something wrong with the advance of the character origin vector, seeable on the '6.0' or 'DN 200' text.
-- Configure bugmail: http://bugs.winehq.org/userprefs.cgi?tab=email Do not reply to this email, post in Bugzilla using the above URL to reply. ------- You are receiving this mail because: ------- You are watching all bug changes.
http://bugs.winehq.org/show_bug.cgi?id=33190 --- Comment #5 from Ralf Habacker <ralf.habacker(a)freenet.de> 2013-03-13 03:28:18 CDT --- (In reply to comment #0)
We tried to find a test case application, but where not able to reproduce the problem outside the application. We also tried to debug into wine's code based, but got lost by the details.
Any hints or inside informations welcome which let us go into the right direction for providing a test case or to find the bug. -- Configure bugmail: http://bugs.winehq.org/userprefs.cgi?tab=email Do not reply to this email, post in Bugzilla using the above URL to reply. ------- You are receiving this mail because: ------- You are watching all bug changes.
http://bugs.winehq.org/show_bug.cgi?id=33190 --- Comment #6 from Alexandre Julliard <julliard(a)winehq.org> 2013-03-13 05:18:41 CDT --- Most gdi functions, including text, don't properly support GM_ADVANCED yet. -- Configure bugmail: http://bugs.winehq.org/userprefs.cgi?tab=email Do not reply to this email, post in Bugzilla using the above URL to reply. ------- You are receiving this mail because: ------- You are watching all bug changes.
http://bugs.winehq.org/show_bug.cgi?id=33190 --- Comment #7 from Ralf Habacker <ralf.habacker(a)freenet.de> 2013-03-13 06:40:22 CDT --- Just for info: We tried crossover linux, which shows the same problem and reported this bug to Jeremy White from codeWeavers. -- Configure bugmail: http://bugs.winehq.org/userprefs.cgi?tab=email Do not reply to this email, post in Bugzilla using the above URL to reply. ------- You are receiving this mail because: ------- You are watching all bug changes.
http://bugs.winehq.org/show_bug.cgi?id=33190 --- Comment #8 from Ralf Habacker <ralf.habacker(a)freenet.de> 2013-03-13 08:14:19 CDT --- Created attachment 43920 --> http://bugs.winehq.org/attachment.cgi?id=43920 testcase Based on the GM_ADVANCED hint I was able to create a test case -- Configure bugmail: http://bugs.winehq.org/userprefs.cgi?tab=email Do not reply to this email, post in Bugzilla using the above URL to reply. ------- You are receiving this mail because: ------- You are watching all bug changes.
http://bugs.winehq.org/show_bug.cgi?id=33190 --- Comment #9 from Ralf Habacker <ralf.habacker(a)freenet.de> 2013-03-13 08:14:39 CDT --- Created attachment 43921 --> http://bugs.winehq.org/attachment.cgi?id=43921 testcase binary -- Configure bugmail: http://bugs.winehq.org/userprefs.cgi?tab=email Do not reply to this email, post in Bugzilla using the above URL to reply. ------- You are receiving this mail because: ------- You are watching all bug changes.
http://bugs.winehq.org/show_bug.cgi?id=33190 Ralf Habacker <ralf.habacker(a)freenet.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #43920|testcase |testcase source description| | -- Configure bugmail: http://bugs.winehq.org/userprefs.cgi?tab=email Do not reply to this email, post in Bugzilla using the above URL to reply. ------- You are receiving this mail because: ------- You are watching all bug changes.
http://bugs.winehq.org/show_bug.cgi?id=33190 --- Comment #10 from Ralf Habacker <ralf.habacker(a)freenet.de> 2013-03-18 04:02:21 CDT --- (In reply to comment #6)
Most gdi functions, including text, don't properly support GM_ADVANCED yet.
Can you explain a bit more what exactly is not working with gdi text display and which part of the implementation is covered ? The screenshot shows that dc rotation works fine at least for lines and rectangles. -- Configure bugmail: http://bugs.winehq.org/userprefs.cgi?tab=email Do not reply to this email, post in Bugzilla using the above URL to reply. ------- You are receiving this mail because: ------- You are watching all bug changes.
http://bugs.winehq.org/show_bug.cgi?id=33190 --- Comment #11 from Ralf Habacker <ralf.habacker(a)freenet.de> 2013-09-30 03:19:35 CDT --- [reply] [-] Description Ralf Habacker 2013-03-12 08:09:10 CDT We recognized an gdi text display issue using the application Gausz http://appdb.winehq.org/objectManager.php?sClass=application&iId=13649. The problem appears when gdi text is drawn with font rotation *and* display context rotation. The problem do not appear when either font rotation or display context rotation is zero. The application uses CreateIndirectFont to set a fixed size font with optional set rotation and draws the text with TextOut(). The display context rotation has been set with SetWorldTransform(). We tried to find a test case application, but where not able to reproduce the problem outside the application. We also tried to debug into wine's code based, but got lost by the details. [reply] [-] Comment 1 Ralf Habacker 2013-03-12 08:27:48 CDT Created attachment 43905 [details] zero degree - no error [reply] [-] Comment 2 Ralf Habacker 2013-03-12 08:28:23 CDT Created attachment 43906 [details] 45 degree dc rotation - showing error [reply] [-] Comment 3 Ralf Habacker 2013-03-12 08:28:55 CDT Created attachment 43907 [details] 90 degree rotation - showing error too [reply] [-] Comment 4 Ralf Habacker 2013-03-12 08:42:00 CDT
From my observations I would say that there is something wrong with the advance of the character origin vector, seeable on the '6.0' or 'DN 200' text.
[reply] [-] Comment 5 Ralf Habacker 2013-03-13 03:28:18 CDT (In reply to comment #0)
We tried to find a test case application, but where not able to reproduce the problem outside the application. We also tried to debug into wine's code based, but got lost by the details.
Any hints or inside informations welcome which let us go into the right direction for providing a test case or to find the bug. [reply] [-] Comment 6 Alexandre Julliard 2013-03-13 05:18:41 CDT Most gdi functions, including text, don't properly support GM_ADVANCED yet. [reply] [-] Comment 7 Ralf Habacker 2013-03-13 06:40:22 CDT Just for info: We tried crossover linux, which shows the same problem and reported this bug to Jeremy White from codeWeavers. [reply] [-] Comment 8 Ralf Habacker 2013-03-13 08:14:19 CDT Created attachment 43920 [details] testcase source Based on the GM_ADVANCED hint I was able to create a test case [reply] [-] Comment 9 Ralf Habacker 2013-03-13 08:14:39 CDT Created attachment 43921 [details] testcase binary [reply] [-] Comment 10 Ralf Habacker 2013-03-18 04:02:21 CDT (In reply to comment #6)
Most gdi functions, including text, don't properly support GM_ADVANCED yet.
One problem with rotated text display seems to be in the implementation of GetTextExtendExPointW(), which output differs between windows and wine (beside the general scaling and rounding differences) Windows 0° 18 34 49 67 85 102 121 138 156 165 182 193 200 218 235 244 262 271 278 295 313 331 349 367 375 393 409 420 437 446 464 482 491 509 526 544 561 579 597 10° 18 34 49 67 85 102 121 138 156 165 182 193 200 218 235 244 262 271 278 295 313 331 349 367 375 393 409 420 437 446 464 482 500 509 526 544 561 579 597 614 45° 18 34 49 67 85 102 121 138 156 165 182 193 200 218 235 244 262 271 278 295 313 331 349 367 375 393 409 420 437 446 464 482 500 509 526 544 561 579 597 614 60° 18 34 49 67 85 102 121 138 156 165 182 193 200 218 235 244 262 271 278 295 313 331 349 367 375 393 409 420 437 446 464 482 500 509 526 544 561 579 597 614 80° 18 34 50 68 86 104 123 141 159 168 186 197 204 222 240 249 267 276 283 301 319 338 356 374 383 401 417 428 446 455 474 492 510 519 537 555 573 591 609 627 Wine 0° 13 26 39 52 65 78 92 105 118 125 138 145 151 164 177 184 197 204 210 223 236 250 263 276 283 296 309 316 329 336 350 363 370 383 396 409 422 435 448 10° 13 26 38 51 64 77 91 103 116 123 136 143 149 162 174 181 194 201 207 220 232 246 259 272 279 292 304 311 324 331 345 357 370 377 390 403 416 428 441 454 45° 6 13 19 25 32 38 45 52 58 62 68 71 74 81 87 91 97 100 103 110 116 123 129 136 139 146 152 156 162 165 173 179 185 189 195 202 208 214 221 227 60° 4 7 11 14 18 21 25 28 32 34 37 39 41 44 48 50 53 55 57 60 64 67 71 74 76 80 83 85 89 91 94 98 101 103 107 110 114 117 121 124 80° 1 1 2 2 3 3 4 4 5 5 6 6 6 7 7 7 8 8 9 9 10 10 11 11 11 12 13 13 13 14 14 15 15 16 16 17 17 18 18 19 Looks like that wine use the rotation from the world transformation matrix, while the windows implementation do not use this rotation. -- Configure bugmail: http://bugs.winehq.org/userprefs.cgi?tab=email Do not reply to this email, post in Bugzilla using the above URL to reply. ------- You are receiving this mail because: ------- You are watching all bug changes.
http://bugs.winehq.org/show_bug.cgi?id=33190 Ralf Habacker <ralf.habacker(a)freenet.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Version|1.5.25 |1.7.10 Summary|Font display problem using |Font display problem text |text and dc rotation |and dc rotation using | |GM_ADVANCED graphics mode -- Do not reply to this email, post in Bugzilla using the above URL to reply. You are receiving this mail because: You are watching all bug changes.
http://bugs.winehq.org/show_bug.cgi?id=33190 --- Comment #12 from Ralf Habacker <ralf.habacker(a)freenet.de> --- Created attachment 47119 --> http://bugs.winehq.org/attachment.cgi?id=47119 add matrix helper functions This patch is used by the following patch -- Do not reply to this email, post in Bugzilla using the above URL to reply. You are receiving this mail because: You are watching all bug changes.
http://bugs.winehq.org/show_bug.cgi?id=33190 --- Comment #13 from Ralf Habacker <ralf.habacker(a)freenet.de> --- Created attachment 47120 --> http://bugs.winehq.org/attachment.cgi?id=47120 Patch which fixes test rotation problem requires patch 47119 -- Do not reply to this email, post in Bugzilla using the above URL to reply. You are receiving this mail because: You are watching all bug changes.
http://bugs.winehq.org/show_bug.cgi?id=33190 Ralf Habacker <ralf.habacker(a)freenet.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |34579 -- Do not reply to this email, post in Bugzilla using the above URL to reply. You are receiving this mail because: You are watching all bug changes.
http://bugs.winehq.org/show_bug.cgi?id=33190 Ralf Habacker <ralf.habacker(a)freenet.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |35331 -- Do not reply to this email, post in Bugzilla using the above URL to reply. You are receiving this mail because: You are watching all bug changes.
http://bugs.winehq.org/show_bug.cgi?id=33190 Bruno Jesus <00cpxxx(a)gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Version|1.7.10 |1.5.25 --- Comment #14 from Bruno Jesus <00cpxxx(a)gmail.com> --- Please don't change the original reported version, it's supposed to be the oldest version where it was tested. -- Do not reply to this email, post in Bugzilla using the above URL to reply. You are receiving this mail because: You are watching all bug changes.
http://bugs.winehq.org/show_bug.cgi?id=33190 Ralf Habacker <ralf.habacker(a)freenet.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |35332 -- Do not reply to this email, post in Bugzilla using the above URL to reply. You are receiving this mail because: You are watching all bug changes.
http://bugs.winehq.org/show_bug.cgi?id=33190 Ralf Habacker <ralf.habacker(a)freenet.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |35333 -- Do not reply to this email, post in Bugzilla using the above URL to reply. You are receiving this mail because: You are watching all bug changes.
http://bugs.winehq.org/show_bug.cgi?id=33190 --- Comment #15 from Ralf Habacker <ralf.habacker(a)freenet.de> --- (In reply to comment #14)
Please don't change the original reported version, it's supposed to be the oldest version where it was tested.
Any chance to add a related tooltip to the version field as available for other fields ? This would make developers live easier. Optional disabling editing of the version field for normal users like me would make more clear that this should not be changed. -- Do not reply to this email, post in Bugzilla using the above URL to reply. You are receiving this mail because: You are watching all bug changes.
http://bugs.winehq.org/show_bug.cgi?id=33190 Ralf Habacker <ralf.habacker(a)freenet.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #47119|0 |1 is obsolete| | Attachment #47120|0 |1 is obsolete| | --- Comment #16 from Ralf Habacker <ralf.habacker(a)freenet.de> --- Created attachment 47159 --> http://bugs.winehq.org/attachment.cgi?id=47159 Fix text rotation problem in GM_ADVANCED mode refactored -- Do not reply to this email, post in Bugzilla using the above URL to reply. You are receiving this mail because: You are watching all bug changes.
http://bugs.winehq.org/show_bug.cgi?id=33190 Ralf Habacker <ralf.habacker(a)freenet.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks|34579, 35331 | -- Do not reply to this email, post in Bugzilla using the above URL to reply. You are receiving this mail because: You are watching all bug changes.
http://bugs.winehq.org/show_bug.cgi?id=33190 Ralf Habacker <ralf.habacker(a)freenet.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Depends on| |34579 -- Do not reply to this email, post in Bugzilla using the above URL to reply. You are receiving this mail because: You are watching all bug changes.
https://bugs.winehq.org/show_bug.cgi?id=33190 Ralf Habacker <ralf.habacker(a)freenet.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #47159|0 |1 is obsolete| | --- Comment #17 from Ralf Habacker <ralf.habacker(a)freenet.de> --- Comment on attachment 47159 --> https://bugs.winehq.org/attachment.cgi?id=47159 Fix text rotation problem in GM_ADVANCED mode Patch has been rejected because it does not fix the issue in a general way. https://www.winehq.org/pipermail/wine-devel/2014-January/102440.html -- Do not reply to this email, post in Bugzilla using the above URL to reply. You are receiving this mail because: You are watching all bug changes.
https://bugs.winehq.org/show_bug.cgi?id=33190 --- Comment #18 from Ralf Habacker <ralf.habacker(a)freenet.de> --- (In reply to Ralf Habacker from comment #17)
Comment on attachment 47159 [details] Fix text rotation problem in GM_ADVANCED mode
Patch has been rejected because it does not fix the issue in a general way. https://www.winehq.org/pipermail/wine-devel/2014-January/102440.html
The patch decomposes the translation and rotation from the transform matrix and supports only the case that the matrix has uniform scale and shear and contains a rotation. It is currently not clear if there is a common usable decomposition algorithm. Published algorithms limits the implementation to uniform scaling for example: http://stackoverflow.com/questions/4361242/extract-rotation-scale-values-fro... ".. This only works if x and y are always scaled the same (uniform scaling). ..." Others depends on a specific order of operations on the original matrix http://research.cs.wisc.edu/graphics/Courses/838-s2002/Papers/polar-decomp.p... ".. QR Decomposition is a much better choice, though it still presents problems. Only when M is constructed by scaling then rotating will QR recover the original factors ..." Polar decomposition is mentioned as a possible way t http://research.cs.wisc.edu/graphics/Courses/838-s2002/Papers/polar-decomp.p... with the drawback, that there is no explicit shear extraction. "... As explained earlier, interaction is to blame; shear will be factored as rotation and stretch. As ... show, the appearance of a factored animation can be quite different from that of a direct animation for shear...." -- Do not reply to this email, post in Bugzilla using the above URL to reply. You are receiving this mail because: You are watching all bug changes.
https://bugs.winehq.org/show_bug.cgi?id=33190 Alistair Leslie-Hughes <leslie_alistair(a)hotmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Keywords| |source, testcase -- Do not reply to this email, post in Bugzilla using the above URL to reply. You are receiving this mail because: You are watching all bug changes.
https://bugs.winehq.org/show_bug.cgi?id=33190 --- Comment #19 from Ralf Habacker <ralf.habacker(a)freenet.de> --- (In reply to Ralf Habacker from comment #17)
Comment on attachment 47159 [details] Fix text rotation problem in GM_ADVANCED mode
Patch has been rejected because it does not fix the issue in a general way. https://www.winehq.org/pipermail/wine-devel/2014-January/102440.html
The mentioned patch fixes the problem from my experience for all type of gis applications because they do not use different axis scales. A generic solution would be a refactoring of the code related to font rotation to not use bounding boxes with two points. Instead the code should use a polygon based bounding box describing each corner, which will be rotation save. -- Do not reply to this email, post in Bugzilla using the above URL to reply. You are receiving this mail because: You are watching all bug changes.
https://bugs.winehq.org/show_bug.cgi?id=33190 joaopa <jeremielapuree(a)yahoo.fr> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |jeremielapuree(a)yahoo.fr --- Comment #20 from joaopa <jeremielapuree(a)yahoo.fr> --- Bug still occur with wine-5.12. -- Do not reply to this email, post in Bugzilla using the above URL to reply. You are receiving this mail because: You are watching all bug changes.
https://bugs.winehq.org/show_bug.cgi?id=33190 --- Comment #21 from Ralf Habacker <ralf.habacker(a)freenet.de> --- See this links - https://www.winehq.org/pipermail/wine-devel/2021-February/180513.html - https://www.winehq.org/pipermail/wine-devel/2021-February/180514.html for associated test cases added to the embedded gdi32 tests. -- Do not reply to this email, post in Bugzilla using the above URL to reply. You are receiving this mail because: You are watching all bug changes.
https://bugs.winehq.org/show_bug.cgi?id=33190 --- Comment #22 from Dmitry Timoshkov <dmitry(a)baikal.ru> --- Created attachment 75445 --> https://bugs.winehq.org/attachment.cgi?id=75445 WIP patch This patch seems to work for the attached test case as well as the application I have here that also uses world transforms to rotate a being displayed text. Ralf, could you please test it in your environment? -- Do not reply to this email, post in Bugzilla using the above URL to reply. You are receiving this mail because: You are watching all bug changes.
https://bugs.winehq.org/show_bug.cgi?id=33190 Dmitry Timoshkov <dmitry(a)baikal.ru> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|UNCONFIRMED |NEW Ever confirmed|0 |1 --- Comment #23 from Dmitry Timoshkov <dmitry(a)baikal.ru> --- Confirming. -- Do not reply to this email, post in Bugzilla using the above URL to reply. You are receiving this mail because: You are watching all bug changes.
https://bugs.winehq.org/show_bug.cgi?id=33190 --- Comment #24 from Dmitry Timoshkov <dmitry(a)baikal.ru> --- Created attachment 75446 --> https://bugs.winehq.org/attachment.cgi?id=75446 A simpler test case I'm attaching a simpler test case for the reference. -- Do not reply to this email, post in Bugzilla using the above URL to reply. You are receiving this mail because: You are watching all bug changes.
https://bugs.winehq.org/show_bug.cgi?id=33190 --- Comment #25 from Ralf Habacker <ralf.habacker(a)freenet.de> --- (In reply to Dmitry Timoshkov from comment #24)
Created attachment 75446 [details] A simpler test case
I'm attaching a simpler test case for the reference.
Thanks for this patch and the updated test case. I will check it and report the result. -- Do not reply to this email, post in Bugzilla using the above URL to reply. You are receiving this mail because: You are watching all bug changes.
https://bugs.winehq.org/show_bug.cgi?id=33190 --- Comment #26 from Ralf Habacker <ralf.habacker(a)freenet.de> --- Created attachment 75448 --> https://bugs.winehq.org/attachment.cgi?id=75448 Screenshot from testcase binary without WIP.patch -- Do not reply to this email, post in Bugzilla using the above URL to reply. You are receiving this mail because: You are watching all bug changes.
https://bugs.winehq.org/show_bug.cgi?id=33190 --- Comment #27 from Ralf Habacker <ralf.habacker(a)freenet.de> --- Created attachment 75449 --> https://bugs.winehq.org/attachment.cgi?id=75449 Screenshot from testcase binary with WIP.patch -- Do not reply to this email, post in Bugzilla using the above URL to reply. You are receiving this mail because: You are watching all bug changes.
https://bugs.winehq.org/show_bug.cgi?id=33190 --- Comment #28 from Ralf Habacker <ralf.habacker(a)freenet.de> --- Created attachment 75450 --> https://bugs.winehq.org/attachment.cgi?id=75450 Screenshot from "a simpler test case" without WIP.patch -- Do not reply to this email, post in Bugzilla using the above URL to reply. You are receiving this mail because: You are watching all bug changes.
https://bugs.winehq.org/show_bug.cgi?id=33190 --- Comment #29 from Ralf Habacker <ralf.habacker(a)freenet.de> --- Created attachment 75451 --> https://bugs.winehq.org/attachment.cgi?id=75451 Screenshot from "a simpler test case" with WIP.patch I can confirm that the patch fixes the reported issue as shown with the "testcase binary" and "a simpler test case". -- Do not reply to this email, post in Bugzilla using the above URL to reply. You are receiving this mail because: You are watching all bug changes.
https://bugs.winehq.org/show_bug.cgi?id=33190 --- Comment #30 from Dmitry Timoshkov <dmitry(a)baikal.ru> --- (In reply to Ralf Habacker from comment #29)
I can confirm that the patch fixes the reported issue as shown with the "testcase binary" and "a simpler test case".
Hello Ralf, many thanks for testing and reporting positive results. In the original comment you mentioned that application Gausz suffers from the font rotation issue, is there a chance to test the patch with it as well? -- Do not reply to this email, post in Bugzilla using the above URL to reply. You are receiving this mail because: You are watching all bug changes.
https://bugs.winehq.org/show_bug.cgi?id=33190 --- Comment #31 from Ralf Habacker <ralf.habacker(a)freenet.de> --- Created attachment 75473 --> https://bugs.winehq.org/attachment.cgi?id=75473 Screenshot from application Gausz without WIP.patch showing the issue -- Do not reply to this email, post in Bugzilla using the above URL to reply. You are receiving this mail because: You are watching all bug changes.
https://bugs.winehq.org/show_bug.cgi?id=33190 --- Comment #32 from Ralf Habacker <ralf.habacker(a)freenet.de> --- Created attachment 75474 --> https://bugs.winehq.org/attachment.cgi?id=75474 Screenshot from application 'Gausz -- Do not reply to this email, post in Bugzilla using the above URL to reply. You are receiving this mail because: You are watching all bug changes.
https://bugs.winehq.org/show_bug.cgi?id=33190 Ralf Habacker <ralf.habacker(a)freenet.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #75474|Screenshot from application |Screenshot from application description|'Gausz |'Gausz' with WIP.patch - | |without issue -- Do not reply to this email, post in Bugzilla using the above URL to reply. You are receiving this mail because: You are watching all bug changes.
https://bugs.winehq.org/show_bug.cgi?id=33190 Ralf Habacker <ralf.habacker(a)freenet.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #75473|Screenshot from application |Screenshot from application description|Gausz without WIP.patch |Gausz without WIP.patch - |showing the issue |showing issue -- Do not reply to this email, post in Bugzilla using the above URL to reply. You are receiving this mail because: You are watching all bug changes.
https://bugs.winehq.org/show_bug.cgi?id=33190 Ralf Habacker <ralf.habacker(a)freenet.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #75473|Screenshot from application |Screenshot from application description|Gausz without WIP.patch - |Gausz with wine 8.20 |showing issue |without WIP.patch - showing | |issue -- Do not reply to this email, post in Bugzilla using the above URL to reply. You are receiving this mail because: You are watching all bug changes.
https://bugs.winehq.org/show_bug.cgi?id=33190 Ralf Habacker <ralf.habacker(a)freenet.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #75474|Screenshot from application |Screenshot from application description|'Gausz' with WIP.patch - |'Gausz' with wine 8.20 with |without issue |WIP.patch - without issue -- Do not reply to this email, post in Bugzilla using the above URL to reply. You are receiving this mail because: You are watching all bug changes.
https://bugs.winehq.org/show_bug.cgi?id=33190 Ralf Habacker <ralf.habacker(a)freenet.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #75473|Screenshot from application |Screenshot from application description|Gausz with wine 8.20 |'Gausz' with wine 8.20 |without WIP.patch - showing |without WIP.patch - showing |issue |issue -- Do not reply to this email, post in Bugzilla using the above URL to reply. You are receiving this mail because: You are watching all bug changes.
https://bugs.winehq.org/show_bug.cgi?id=33190 Ralf Habacker <ralf.habacker(a)freenet.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #75473|Screenshot from application |Screenshot from application description|'Gausz' with wine 8.20 |'Gausz' with wine 8.20 w.o. |without WIP.patch - showing |WIP.patch - 60° rotation - |issue |showing issue -- Do not reply to this email, post in Bugzilla using the above URL to reply. You are receiving this mail because: You are watching all bug changes.
https://bugs.winehq.org/show_bug.cgi?id=33190 Ralf Habacker <ralf.habacker(a)freenet.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #75474|Screenshot from application |Screenshot from application description|'Gausz' with wine 8.20 with |'Gausz' with wine 8.20 with |WIP.patch - without issue |WIP.patch - 60° rotation - | |showing no issue -- Do not reply to this email, post in Bugzilla using the above URL to reply. You are receiving this mail because: You are watching all bug changes.
https://bugs.winehq.org/show_bug.cgi?id=33190 --- Comment #33 from Ralf Habacker <ralf.habacker(a)freenet.de> --- Created attachment 75475 --> https://bugs.winehq.org/attachment.cgi?id=75475 Screenshot from application 'Gausz' with wine 8.20 w.o. WIP.patch - 90° rotation - showing issue -- Do not reply to this email, post in Bugzilla using the above URL to reply. You are receiving this mail because: You are watching all bug changes.
https://bugs.winehq.org/show_bug.cgi?id=33190 --- Comment #34 from Ralf Habacker <ralf.habacker(a)freenet.de> --- Created attachment 75476 --> https://bugs.winehq.org/attachment.cgi?id=75476 Screenshot from application 'Gausz' with wine 8.20 with WIP.patch - 90° rotation - showing no issue -- Do not reply to this email, post in Bugzilla using the above URL to reply. You are receiving this mail because: You are watching all bug changes.
https://bugs.winehq.org/show_bug.cgi?id=33190 --- Comment #35 from Ralf Habacker <ralf.habacker(a)freenet.de> --- (In reply to Dmitry Timoshkov from comment #30)
(In reply to Ralf Habacker from comment #29)
I can confirm that the patch fixes the reported issue as shown with the "testcase binary" and "a simpler test case".
Hello Ralf, many thanks for testing and reporting positive results. In the original comment you mentioned that application Gausz suffers from the font rotation issue, is there a chance to test the patch with it as well?
Hello Dmitry, I applied the patch to wine 8.2.0 and did run the mentioned application. See attachment 75473, attachment 75475 for the result without the patch and attachment 75474, attachment 75476 for the result with your patch applied. -- Do not reply to this email, post in Bugzilla using the above URL to reply. You are receiving this mail because: You are watching all bug changes.
https://bugs.winehq.org/show_bug.cgi?id=33190 --- Comment #36 from Dmitry Timoshkov <dmitry(a)baikal.ru> --- (In reply to Ralf Habacker from comment #35)
Hello Dmitry, I applied the patch to wine 8.2.0 and did run the mentioned application.
See attachment 75473 [details], attachment 75475 [details] for the result without the patch and attachment 75474 [details], attachment 75476 [details] for the result with your patch applied.
Ralf, thank you very much for testing. Let me clarify the results a bit: does that mean that the patch fixes all the problems with rotated text for you? -- Do not reply to this email, post in Bugzilla using the above URL to reply. You are receiving this mail because: You are watching all bug changes.
https://bugs.winehq.org/show_bug.cgi?id=33190 --- Comment #37 from Ralf Habacker <ralf.habacker(a)freenet.de> --- (In reply to Dmitry Timoshkov from comment #36)
Ralf, thank you very much for testing. Let me clarify the results a bit: does that mean that the patch fixes all the problems with rotated text for you?
In the list of open bugs https://appdb.winehq.org/objectManager.php?sClass=version&iId=37429 for the application mentioned, there are other text-related bugs: bug 35332 and bug 35333, which need to be retested to give a complete answer. -- Do not reply to this email, post in Bugzilla using the above URL to reply. You are receiving this mail because: You are watching all bug changes.
https://bugs.winehq.org/show_bug.cgi?id=33190 --- Comment #38 from Ralf Habacker <ralf.habacker(a)freenet.de> --- (In reply to Ralf Habacker from comment #37)
(In reply to Dmitry Timoshkov from comment #36) ... bug 35332
This bug is fixed also after applying your patch, which is great.
bug 35333
This bug is not fixed after applying your patch. -- Do not reply to this email, post in Bugzilla using the above URL to reply. You are receiving this mail because: You are watching all bug changes.
https://bugs.winehq.org/show_bug.cgi?id=33190 --- Comment #39 from Dmitry Timoshkov <dmitry(a)baikal.ru> --- Created attachment 76028 --> https://bugs.winehq.org/attachment.cgi?id=76028 WIP patch (v2) Here is a simpler version of the patches that hopefully fixes the root source of the problem. -- Do not reply to this email, post in Bugzilla using the above URL to reply. You are receiving this mail because: You are watching all bug changes.
https://bugs.winehq.org/show_bug.cgi?id=33190 --- Comment #40 from Dmitry Timoshkov <dmitry(a)baikal.ru> --- Created attachment 76048 --> https://bugs.winehq.org/attachment.cgi?id=76048 A simpler test case (v2 - with scaling world transform) New version of the test which shows that scaling is not handled properly in previous version of the patch. -- Do not reply to this email, post in Bugzilla using the above URL to reply. You are receiving this mail because: You are watching all bug changes.
https://bugs.winehq.org/show_bug.cgi?id=33190 --- Comment #41 from Dmitry Timoshkov <dmitry(a)baikal.ru> --- Submitted https://gitlab.winehq.org/wine/wine/-/merge_requests/5068. This MR fixes rendering of the rotated and scaled text in the attached test app. -- Do not reply to this email, post in Bugzilla using the above URL to reply. You are receiving this mail because: You are watching all bug changes.
https://bugs.winehq.org/show_bug.cgi?id=33190 --- Comment #42 from Rafał Mużyło <galtgendo(a)o2.pl> --- Dmitry, there's one more bug that's a bit related, as it also regards text rotations, but this time the problem is the background - bug 56058. Would you take a look ? -- Do not reply to this email, post in Bugzilla using the above URL to reply. You are receiving this mail because: You are watching all bug changes.
https://bugs.winehq.org/show_bug.cgi?id=33190 --- Comment #43 from Ralf Habacker <ralf.habacker(a)freenet.de> --- (In reply to Rafał Mużyło from comment #42)
Dmitry, there's one more bug that's a bit related, as it also regards text rotations, but this time the problem is the background - bug 56058.
Would you take a look ?
I doubt that Dimitri will take care of it if the previous merge request has not been edited and merged by anyone with appropriate rights. -- Do not reply to this email, post in Bugzilla using the above URL to reply. You are receiving this mail because: You are watching all bug changes.
https://bugs.winehq.org/show_bug.cgi?id=33190 --- Comment #44 from Ralf Habacker <ralf.habacker(a)freenet.de> --- Created attachment 77244 --> https://bugs.winehq.org/attachment.cgi?id=77244 archive with git format-patch generated patches for submission to wine-staging The patches were submitted for inclusion in the Wine git repo and were adapted based on a review. Unfortunately, the reviewer did not respond afterwards. -- Do not reply to this email, post in Bugzilla using the above URL to reply. You are receiving this mail because: You are watching all bug changes.
https://bugs.winehq.org/show_bug.cgi?id=33190 Ralf Habacker <ralf.habacker(a)freenet.de> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |leslie_alistair(a)hotmail.com -- Do not reply to this email, post in Bugzilla using the above URL to reply. You are receiving this mail because: You are watching all bug changes.
https://bugs.winehq.org/show_bug.cgi?id=33190 Ralf Habacker <ralf.habacker(a)freenet.de> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |ralf.habacker(a)freenet.de -- Do not reply to this email, post in Bugzilla using the above URL to reply. You are receiving this mail because: You are watching all bug changes.
https://bugs.winehq.org/show_bug.cgi?id=33190 Ralf Habacker <ralf.habacker(a)freenet.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Component|gdi32 |win32u CC| |z.figura12(a)gmail.com --- Comment #45 from Ralf Habacker <ralf.habacker(a)freenet.de> --- (In reply to Ralf Habacker from comment #44)
Created attachment 77244 [details] archive with git format-patch generated patches for submission to wine-staging
The patches were submitted for inclusion in the Wine git repo and were adapted based on a review. Unfortunately, the reviewer did not respond afterwards.
In accordance with https://gitlab.winehq.org/wine/wine-staging/-/wikis/home#submitting-patches, I request that these patches be included in Staging. -- Do not reply to this email, post in Bugzilla using the above URL to reply. You are receiving this mail because: You are watching all bug changes.
participants (2)
-
wine-bugs＠winehq.org -
WineHQ Bugzilla