[Bug 44902] New: CRASH WHEN INSTALLING BAIDU WIFI HOTSPOT
https://bugs.winehq.org/show_bug.cgi?id=44902 Bug ID: 44902 Summary: CRASH WHEN INSTALLING BAIDU WIFI HOTSPOT Product: Wine Version: 3.5 Hardware: x86 OS: Linux Status: UNCONFIRMED Severity: normal Priority: P2 Component: -unknown Assignee: wine-bugs(a)winehq.org Reporter: noavan.purnama(a)gmail.com Distribution: --- Created attachment 60987 --> https://bugs.winehq.org/attachment.cgi?id=60987 Backtrace error it error when i installing BAIDU WIFI HOTSPOT -- Do not reply to this email, post in Bugzilla using the above URL to reply. You are receiving this mail because: You are watching all bug changes.
https://bugs.winehq.org/show_bug.cgi?id=44902 vandpurnama <noavan.purnama(a)gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Keywords| |Installer, win64 CC| |noavan.purnama(a)gmail.com URL| |http://www.pcfaster.com/id/ | |lp/wifiPopularize.php -- Do not reply to this email, post in Bugzilla using the above URL to reply. You are receiving this mail because: You are watching all bug changes.
https://bugs.winehq.org/show_bug.cgi?id=44902 Louis Lenders <xerox.xerox2000x(a)gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |xerox.xerox2000x(a)gmail.com --- Comment #1 from Louis Lenders <xerox.xerox2000x(a)gmail.com> --- Created attachment 60991 --> https://bugs.winehq.org/attachment.cgi?id=60991 debuglog Confirming. Seems to crash because of this: 03c:trace:shell:IShellLinkW_fnSetIconLocation (0x173680)->(path=(null) iicon=0) Adding a check like below makes the crash dissappear, but after that a window *I guess the main program?) comes up that is completely black. No idea why diff --git a/dlls/shell32/shelllink.c b/dlls/shell32/shelllink.c index 6dca9ac..29e1c78 100644 --- a/dlls/shell32/shelllink.c +++ b/dlls/shell32/shelllink.c @@ -1930,7 +1930,7 @@ static HRESULT WINAPI IShellLinkW_fnGetIconLocation(IShellLinkW * iface, LPWSTR static HRESULT WINAPI IShellLinkW_fnSetIconLocation(IShellLinkW * iface, LPCWSTR pszIconPath,INT iIcon) { IShellLinkImpl *This = impl_from_IShellLinkW(iface); - + if(!pszIconPath) return E_INVALIDARG; TRACE("(%p)->(path=%s iicon=%u)\n",This, debugstr_w(pszIconPath), iIcon); -- Do not reply to this email, post in Bugzilla using the above URL to reply. You are receiving this mail because: You are watching all bug changes.
https://bugs.winehq.org/show_bug.cgi?id=44902 Louis Lenders <xerox.xerox2000x(a)gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Ever confirmed|0 |1 Keywords| |download Status|UNCONFIRMED |NEW --- Comment #2 from Louis Lenders <xerox.xerox2000x(a)gmail.com> --- confirming -- Do not reply to this email, post in Bugzilla using the above URL to reply. You are receiving this mail because: You are watching all bug changes.
https://bugs.winehq.org/show_bug.cgi?id=44902 --- Comment #3 from Gijs Vermeulen <gijsvrm(a)gmail.com> --- Created attachment 60992 --> https://bugs.winehq.org/attachment.cgi?id=60992 test (In reply to Louis Lenders from comment #1) I tried to make a small test for your patch, but passing in NULL and 0 for the second and third argument still returns S_OK on Windows. (My test could be horribly wrong though) -- Do not reply to this email, post in Bugzilla using the above URL to reply. You are receiving this mail because: You are watching all bug changes.
https://bugs.winehq.org/show_bug.cgi?id=44902 --- Comment #4 from Louis Lenders <xerox.xerox2000x(a)gmail.com> --- (In reply to Gijs Vermeulen from comment #3)
Created attachment 60992 [details] test
(In reply to Louis Lenders from comment #1)
I tried to make a small test for your patch, but passing in NULL and 0 for the second and third argument still returns S_OK on Windows. (My test could be horribly wrong though)
I guess that makes sense as from the other tests there i i can see that garbage-values also return S_OK The crash itsself is in lstrlenW*, i guess that is supposed to crash with null-pointer(?). I set component to shell32, needs further investigation BTW, do you also get a black window? * =>0 0x7e734a61 lstrlenW+0x1f() in shell32 (0x00f4f8f8) 1 0x7e73a473 IShellLinkW_fnSetIconLocation+0xa0() in shell32 (0x00f4f938) -- Do not reply to this email, post in Bugzilla using the above URL to reply. You are receiving this mail because: You are watching all bug changes.
https://bugs.winehq.org/show_bug.cgi?id=44902 Louis Lenders <xerox.xerox2000x(a)gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Component|-unknown |shell32 -- Do not reply to this email, post in Bugzilla using the above URL to reply. You are receiving this mail because: You are watching all bug changes.
https://bugs.winehq.org/show_bug.cgi?id=44902 Louis Lenders <xerox.xerox2000x(a)gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Summary|CRASH WHEN INSTALLING BAIDU |Baidu Wifi Hotspot crashes |WIFI HOTSPOT |inside shell32 --- Comment #5 from Louis Lenders <xerox.xerox2000x(a)gmail.com> --- sha1sum ~/Downloads/WiFiHotspot_Setup_GL.exe 1d91a9c9ba1217e0e5b71481b83ad1033829d479 /home/louis/Downloads/WiFiHotspot_Setup_GL.exe -- Do not reply to this email, post in Bugzilla using the above URL to reply. You are receiving this mail because: You are watching all bug changes.
https://bugs.winehq.org/show_bug.cgi?id=44902 --- Comment #6 from Gijs Vermeulen <gijsvrm(a)gmail.com> --- Created attachment 60994 --> https://bugs.winehq.org/attachment.cgi?id=60994 log generated by program (In reply to Louis Lenders from comment #4) I can confirm the black screen. I also attached the crashlog generated by the program itself. -- Do not reply to this email, post in Bugzilla using the above URL to reply. You are receiving this mail because: You are watching all bug changes.
https://bugs.winehq.org/show_bug.cgi?id=44902 --- Comment #7 from Louis Lenders <xerox.xerox2000x(a)gmail.com> --- Still present, tried wine-3.14 (Staging) -- Do not reply to this email, post in Bugzilla using the above URL to reply. You are receiving this mail because: You are watching all bug changes.
https://bugs.winehq.org/show_bug.cgi?id=44902 --- Comment #8 from Nikolay Sivov <bunglehead(a)gmail.com> --- Please try this one, https://www.winehq.org/pipermail/wine-devel/2018-September/133011.html. -- Do not reply to this email, post in Bugzilla using the above URL to reply. You are receiving this mail because: You are watching all bug changes.
https://bugs.winehq.org/show_bug.cgi?id=44902 Louis Lenders <xerox.xerox2000x(a)gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Keywords| |patch --- Comment #9 from Louis Lenders <xerox.xerox2000x(a)gmail.com> --- (In reply to Nikolay Sivov from comment #8)
Please try this one, https://www.winehq.org/pipermail/wine-devel/2018-September/133011.html.
Yes, it fixes the crash (the window coming up is still black, but that is another bug) -- Do not reply to this email, post in Bugzilla using the above URL to reply. You are receiving this mail because: You are watching all bug changes.
https://bugs.winehq.org/show_bug.cgi?id=44902 Anastasius Focht <focht(a)gmx.net> changed: What |Removed |Added ---------------------------------------------------------------------------- Summary|Baidu Wifi Hotspot crashes |Baidu Wifi Hotspot crashes |inside shell32 |in | |IShellLink::SetIconLocation | |method due to missing NULL | |path handling CC| |focht(a)gmx.net -- Do not reply to this email, post in Bugzilla using the above URL to reply. You are receiving this mail because: You are watching all bug changes.
https://bugs.winehq.org/show_bug.cgi?id=44902 Nikolay Sivov <bunglehead(a)gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |RESOLVED Resolution|--- |FIXED --- Comment #10 from Nikolay Sivov <bunglehead(a)gmail.com> --- Marking fixed, c0a1eff706c44fc743021f94ebd7fdd6b331bc93. -- Do not reply to this email, post in Bugzilla using the above URL to reply. You are receiving this mail because: You are watching all bug changes.
https://bugs.winehq.org/show_bug.cgi?id=44902 Gijs Vermeulen <gijsvrm(a)gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Fixed by SHA1| |c0a1eff706c44fc743021f94ebd | |7fdd6b331bc93 -- Do not reply to this email, post in Bugzilla using the above URL to reply. You are receiving this mail because: You are watching all bug changes.
https://bugs.winehq.org/show_bug.cgi?id=44902 Alexandre Julliard <julliard(a)winehq.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|RESOLVED |CLOSED --- Comment #11 from Alexandre Julliard <julliard(a)winehq.org> --- Closing bugs fixed in 3.18. -- Do not reply to this email, post in Bugzilla using the above URL to reply. You are receiving this mail because: You are watching all bug changes.
participants (1)
-
wine-bugs＠winehq.org