[Bug 16550] New: ConnectNamedPort should never return OK in overlapped mode
http://bugs.winehq.org/show_bug.cgi?id=16550 Summary: ConnectNamedPort should never return OK in overlapped mode Product: Wine Version: 1.1.10 Platform: Other URL: http://chromium.org OS/Version: other Status: NEW Keywords: download Severity: normal Priority: P2 Component: kernel32 AssignedTo: wine-bugs(a)winehq.org ReportedBy: dank(a)kegel.com Chromium contains the following code in http://src.chromium.org/viewvc/chrome/trunk/src/chrome/common/ipc_channel_wi... BOOL ok = ConnectNamedPipe(pipe_, &input_state_.context.overlapped); DWORD err = GetLastError(); if (ok) { // Uhm, the API documentation says that this function should never // return success when used in overlapped mode. NOTREACHED(); return false; } switch (err) { case ERROR_IO_PENDING: input_state_.is_pending = true; break; case ERROR_PIPE_CONNECTED: waiting_connect_ = false; break; default: NOTREACHED(); return false; } This triggers, for instance, if you build and run Debug/ui_tests.exe: [1217/155712:FATAL:ipc_channel_win.cc(206)] Check failed: false. The obvious one-line change to our ConnectNamedPipe lets the test get further. I'll post a patch once I have a test case. -- Configure bugmail: http://bugs.winehq.org/userprefs.cgi?tab=email Do not reply to this email, post in Bugzilla using the above URL to reply. ------- You are receiving this mail because: ------- You are watching all bug changes.
http://bugs.winehq.org/show_bug.cgi?id=16550 --- Comment #1 from Dan Kegel <dank(a)kegel.com> 2008-12-17 18:29:32 --- I'm not so sure I can tighten our existing test, so I'm just going to post the patch without a test. -- Configure bugmail: http://bugs.winehq.org/userprefs.cgi?tab=email Do not reply to this email, post in Bugzilla using the above URL to reply. ------- You are receiving this mail because: ------- You are watching all bug changes.
http://bugs.winehq.org/show_bug.cgi?id=16550 Austin English <austinenglish(a)gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Keywords| |patch -- Configure bugmail: http://bugs.winehq.org/userprefs.cgi?tab=email Do not reply to this email, post in Bugzilla using the above URL to reply. ------- You are receiving this mail because: ------- You are watching all bug changes.
http://bugs.winehq.org/show_bug.cgi?id=16550 Dan Kegel <dank(a)kegel.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Summary|ConnectNamedPort should |ConnectNamedPort should |never return OK in |never return OK in |overlapped mode |overlapped mode (affects | |chromium ui_tests.exe) -- Configure bugmail: http://bugs.winehq.org/userprefs.cgi?tab=email Do not reply to this email, post in Bugzilla using the above URL to reply. ------- You are receiving this mail because: ------- You are watching all bug changes.
http://bugs.winehq.org/show_bug.cgi?id=16550 Bruno Jesus <00cpxxx(a)gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |00cpxxx(a)gmail.com --- Comment #2 from Bruno Jesus <00cpxxx(a)gmail.com> 2012-04-26 20:11:20 CDT --- The current tests suggests that this is covered. http://source.winehq.org/source/dlls/kernel32/tests/pipe.c#L609 http://source.winehq.org/source/dlls/kernel32/tests/pipe.c#L731 http://source.winehq.org/source/dlls/kernel32/tests/pipe.c#L1481 Dan, what do you think? I have no idea of how to test this. Also, why the "patch" keyword? -- Configure bugmail: http://bugs.winehq.org/userprefs.cgi?tab=email Do not reply to this email, post in Bugzilla using the above URL to reply. ------- You are receiving this mail because: ------- You are watching all bug changes.
http://bugs.winehq.org/show_bug.cgi?id=16550 --- Comment #3 from Dan Kegel <dank(a)kegel.com> 2012-04-26 21:04:42 CDT --- The patch was http://www.winehq.org/pipermail/wine-patches/2008-December/066314.html, and it doesn't seem to have made it in. I suspect AJ wants to see a real app that complains about this, not just some app's test suite. -- Configure bugmail: http://bugs.winehq.org/userprefs.cgi?tab=email Do not reply to this email, post in Bugzilla using the above URL to reply. ------- You are receiving this mail because: ------- You are watching all bug changes.
https://bugs.winehq.org/show_bug.cgi?id=16550 --- Comment #4 from Ken Sharp <imwellcushtymelike(a)gmail.com> --- Is this still an issue in Wine 1.7.45 or later? -- Do not reply to this email, post in Bugzilla using the above URL to reply. You are receiving this mail because: You are watching all bug changes.
https://bugs.winehq.org/show_bug.cgi?id=16550 Michael Müller <michael(a)fds-team.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |STAGED CC| |michael(a)fds-team.de, | |sebastian(a)fds-team.de Staged patchset| |https://github.com/wine-com | |pholio/wine-staging/tree/ma | |ster/patches/kernel32-Named | |_Pipe -- Do not reply to this email, post in Bugzilla using the above URL to reply. You are receiving this mail because: You are watching all bug changes.
https://bugs.winehq.org/show_bug.cgi?id=16550 Sebastian Lackner <sebastian(a)fds-team.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|STAGED |NEW --- Comment #5 from Sebastian Lackner <sebastian(a)fds-team.de> --- I suspect that this issue is not present anymore (since a while). Has anyone retested recently? -- Do not reply to this email, post in Bugzilla using the above URL to reply. You are receiving this mail because: You are watching all bug changes.
https://bugs.winehq.org/show_bug.cgi?id=16550 super_man(a)post.com changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |super_man(a)post.com --- Comment #6 from super_man(a)post.com --- I havent tested this, but I just found https://github.com/wine-compholio/wine-staging/tree/d3d10 and it has a list of fixed bugs that contain this one too. -- Do not reply to this email, post in Bugzilla using the above URL to reply. You are receiving this mail because: You are watching all bug changes.
participants (1)
-
wine-bugs＠winehq.org