[Bug 59211] New: Too long argument list may cause build failure.
http://bugs.winehq.org/show_bug.cgi?id=59211 Bug ID: 59211 Summary: Too long argument list may cause build failure. Product: Wine Version: unspecified Hardware: x86-64 OS: Windows Status: UNCONFIRMED Severity: normal Priority: P2 Component: tools Assignee: wine-bugs@list.winehq.org Reporter: wushengwuxi-msctinoulk@outlook.com The `spawn` in `tools\winebuild\utils.c` may generate a very long argument list to system. It will be failed on Windows. ```c void spawn( struct strarray args ) { int status; const char *argv0 = find_binary( NULL, args.str[0] ); if (argv0) args.str[0] = argv0; if (verbose) strarray_trace( args ); if ((status = strarray_spawn( args ))) /* <-- Argument list too long (e.g. 1234 arguments) */ { if (status > 0) fatal_error( "%s failed with status %u\n", args.str[0], status ); else fatal_perror( "winebuild" ); exit( 1 ); } } ``` GNU ar supports `@file` to provide arguments. I think it's a better idea. -- Do not reply to this email, post in Bugzilla using the above URL to reply. You are receiving this mail because: You are watching all bug changes.
http://bugs.winehq.org/show_bug.cgi?id=59211 ChenPi11 <wushengwuxi-msctinoulk@outlook.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Severity|normal |minor -- Do not reply to this email, post in Bugzilla using the above URL to reply. You are receiving this mail because: You are watching all bug changes.
http://bugs.winehq.org/show_bug.cgi?id=59211 --- Comment #1 from Alexandre Julliard <julliard@winehq.org> --- Is it actually causing a failure? What's the failed command? -- Do not reply to this email, post in Bugzilla using the above URL to reply. You are receiving this mail because: You are watching all bug changes.
http://bugs.winehq.org/show_bug.cgi?id=59211 --- Comment #2 from ChenPi11 <wushengwuxi-msctinoulk@outlook.com> --- ``` tools/winebuild/winebuild.exe -w --implib -o dlls/msvcr120/msvcr120.a --without-dlltool -m64 --export \ dlls/msvcr120/msvcr120.spec error: winebuild : Invalid argument ``` `winebuild.exe` generates a very long arguments while archiving. For example: ``` ar.exe rc dlls/msvcr120/libmsvcr120.a ...<very long> ``` Which is not accepted on Windows. -- Do not reply to this email, post in Bugzilla using the above URL to reply. You are receiving this mail because: You are watching all bug changes.
http://bugs.winehq.org/show_bug.cgi?id=59211 --- Comment #3 from ChenPi11 <wushengwuxi-msctinoulk@outlook.com> --- Created attachment 80129 --> http://bugs.winehq.org/attachment.cgi?id=80129 The temporary fix code for `spawn` function. I use a temporary fix to solve it. It can works correctly. But it's not a good idea to fix `spawn()` instead of fix archiving functions. -- Do not reply to this email, post in Bugzilla using the above URL to reply. You are receiving this mail because: You are watching all bug changes.
participants (1)
-
WineHQ Bugzilla