[Bug 25056] New: Worms Armageddon's "Fill" and "Random Holes" map editor tools produce interlaced images
http://bugs.winehq.org/show_bug.cgi?id=25056 Summary: Worms Armageddon's "Fill" and "Random Holes" map editor tools produce interlaced images Product: Wine Version: 1.3.6 Platform: x86 OS/Version: Linux Status: UNCONFIRMED Severity: minor Priority: P2 Component: winex11.drv AssignedTo: wine-bugs(a)winehq.org ReportedBy: thecybershadow(a)gmail.com Created an attachment (id=31767) --> (http://bugs.winehq.org/attachment.cgi?id=31767) winex11: Add X11DRV_PALETTE_GetColor function to resolve any COLORREF to an RGB Using the "Fill" (paint bucket) and "Random holes" tools in the map editor (both to erase and fill terrain) will cause the respective areas to be filled with a vertically-interlaced pattern. The pattern is actually a monochrome gray brush. Worms Armageddon passes palette indices for white and black (PALETTEINDEX COLORREF values) to CreateSolidBrush. BRUSH_SelectSolidBrush's check for monochrome surfaces incorrectly compares the passed COLORREF to the RGB values of white and black, and therefore considers the passed COLORREF (0x01000000 or 0x01000001) to be a non-monochrome color. Attached patches fix the problem by adding a function to convert any COLORREF to an RGB COLORREF, and by making BRUSH_SelectSolidBrush use it. -- Configure bugmail: http://bugs.winehq.org/userprefs.cgi?tab=email Do not reply to this email, post in Bugzilla using the above URL to reply. ------- You are receiving this mail because: ------- You are watching all bug changes.
http://bugs.winehq.org/show_bug.cgi?id=25056 --- Comment #1 from Vladimir Panteleev <thecybershadow(a)gmail.com> 2010-11-06 22:53:23 CDT --- Created an attachment (id=31768) --> (http://bugs.winehq.org/attachment.cgi?id=31768) winex11: correctly handle non-RGB COLORREFs in BRUSH_SelectSolidBrush -- Configure bugmail: http://bugs.winehq.org/userprefs.cgi?tab=email Do not reply to this email, post in Bugzilla using the above URL to reply. ------- You are receiving this mail because: ------- You are watching all bug changes.
http://bugs.winehq.org/show_bug.cgi?id=25056 Vladimir Panteleev <thecybershadow(a)gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #31767|0 |1 is patch| | -- Configure bugmail: http://bugs.winehq.org/userprefs.cgi?tab=email Do not reply to this email, post in Bugzilla using the above URL to reply. ------- You are receiving this mail because: ------- You are watching all bug changes.
http://bugs.winehq.org/show_bug.cgi?id=25056 Austin English <austinenglish(a)gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Keywords| |patch --- Comment #2 from Austin English <austinenglish(a)gmail.com> 2010-11-06 23:09:59 CDT --- Patches should be sent to wine-patches(a)winehq.org -- Configure bugmail: http://bugs.winehq.org/userprefs.cgi?tab=email Do not reply to this email, post in Bugzilla using the above URL to reply. ------- You are receiving this mail because: ------- You are watching all bug changes.
http://bugs.winehq.org/show_bug.cgi?id=25056 --- Comment #3 from Vladimir Panteleev <thecybershadow(a)gmail.com> 2010-11-07 08:28:18 CST --- I know, I put them here first in case anyone has any comments before I send them there. -- Configure bugmail: http://bugs.winehq.org/userprefs.cgi?tab=email Do not reply to this email, post in Bugzilla using the above URL to reply. ------- You are receiving this mail because: ------- You are watching all bug changes.
http://bugs.winehq.org/show_bug.cgi?id=25056 Vladimir Panteleev <thecybershadow(a)gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|UNCONFIRMED |RESOLVED Resolution| |FIXED --- Comment #4 from Vladimir Panteleev <thecybershadow(a)gmail.com> 2010-11-13 09:28:05 CST --- Patch was accepted, the issue is fixed in 1.3.7. -- Configure bugmail: http://bugs.winehq.org/userprefs.cgi?tab=email Do not reply to this email, post in Bugzilla using the above URL to reply. ------- You are receiving this mail because: ------- You are watching all bug changes.
http://bugs.winehq.org/show_bug.cgi?id=25056 Alexandre Julliard <julliard(a)winehq.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|RESOLVED |CLOSED --- Comment #5 from Alexandre Julliard <julliard(a)winehq.org> 2010-11-26 13:13:38 CST --- Closing bugs fixed in 1.3.8. -- Configure bugmail: http://bugs.winehq.org/userprefs.cgi?tab=email Do not reply to this email, post in Bugzilla using the above URL to reply. ------- You are receiving this mail because: ------- You are watching all bug changes.
http://bugs.winehq.org/show_bug.cgi?id=25056 --- Comment #6 from Vladimir Panteleev <thecybershadow(a)gmail.com> 2010-11-26 13:15:15 CST --- Alexandre, this bug was fixed in Wine 1.3.7. -- Configure bugmail: http://bugs.winehq.org/userprefs.cgi?tab=email Do not reply to this email, post in Bugzilla using the above URL to reply. ------- You are receiving this mail because: ------- You are watching all bug changes.
participants (1)
-
wine-bugs＠winehq.org