[Bug 20699] New: Something wrong with WH_GETMESSAGE hook (TeamViewer)
http://bugs.winehq.org/show_bug.cgi?id=20699 Summary: Something wrong with WH_GETMESSAGE hook (TeamViewer) Product: Wine Version: 1.1.33 Platform: PC OS/Version: Linux Status: UNCONFIRMED Severity: minor Priority: P2 Component: user32 AssignedTo: wine-bugs(a)winehq.org ReportedBy: gabmoa(a)yahoo.it TeamViewer 3 with OS=NT4.0 to workaround bug 12067 All seems to work (except for the unrelated bug 11727) but the chat the other windows seems to loop (when a connection is active) when many input messages are sent on this windows (for example when you press 2 or more keys on the chat). Obviously in windows there aren't problems. To workaround this in then dlls/user32/message.c ... break; case MSG_HARDWARE: if (size >= sizeof(msg_data->hardware)) { ... HOOK_CallHooks( WH_GETMESSAGE, HC_ACTION, flags & PM_REMOVE, (LPARAM)msg, TRUE ); return TRUE; } ... I add this check (or you can remove the whole call...) ... if (flags & PM_REMOVE) <- HOOK_CallHooks( WH_GETMESSAGE, HC_ACTION, flags & PM_REMOVE, (LPARAM)msg, TRUE ... and now there aren't problems and it works very well. I know the patch isn't right, since the WH_GETMESSAGE should return also the not removed peeked messages but I think there is something wrong with the hooking system! Note: To understand what Teamviewer do I have followed the source code VNCHooks.dll 'cause it's very similar (also with the name and meanings of the registerd messages). -- Configure bugmail: http://bugs.winehq.org/userprefs.cgi?tab=email Do not reply to this email, post in Bugzilla using the above URL to reply. ------- You are receiving this mail because: ------- You are watching all bug changes.
http://bugs.winehq.org/show_bug.cgi?id=20699 Austin English <austinenglish(a)gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Keywords| |patch -- Configure bugmail: http://bugs.winehq.org/userprefs.cgi?tab=email Do not reply to this email, post in Bugzilla using the above URL to reply. ------- You are receiving this mail because: ------- You are watching all bug changes.
http://bugs.winehq.org/show_bug.cgi?id=20699 --- Comment #1 from Vitaliy Margolen <vitaliy(a)kievinfo.com> 2009-11-14 15:03:53 ---
All seems to work (except for the unrelated bug 11727) but the chat the other windows seems to loop (when a connection is active) when many input messages are sent on this windows (for example when you press 2 or more keys on the chat). Obviously in windows there aren't problems. This makes absolutely no sense. What exactly is happening? What supposed to be happening? What is the difference?
-- Configure bugmail: http://bugs.winehq.org/userprefs.cgi?tab=email Do not reply to this email, post in Bugzilla using the above URL to reply. ------- You are receiving this mail because: ------- You are watching all bug changes.
http://bugs.winehq.org/show_bug.cgi?id=20699 Vitaliy Margolen <vitaliy(a)kievinfo.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Keywords|patch | Component|user32 |-unknown -- Configure bugmail: http://bugs.winehq.org/userprefs.cgi?tab=email Do not reply to this email, post in Bugzilla using the above URL to reply. ------- You are receiving this mail because: ------- You are watching all bug changes.
http://bugs.winehq.org/show_bug.cgi?id=20699 --- Comment #2 from Gabriele Moabiti <gabmoa(a)yahoo.it> 2009-11-14 17:26:24 ---
All seems to work (except for the unrelated bug 11727) but the chat the other windows seems to loop (when a connection is active) when many input messages are sent on this windows (for example when you press 2 or more keys on the chat). Obviously in windows there aren't problems. This makes absolutely no sense. What exactly is happening? What supposed to be happening? What is the difference?
Ok, I have written in a an horrible english, I hope this will help: Open the chat and try to press two letter (or more) together like 'A' an 'S' some times on the edit box of the chat windows and the chat will loop. Sometime you can stop looping changing focus to another windows. (While looping due to keyboard with WINEDEBUG=+msg we can see two repeated messages "TeamViewer DeferredUpdateRect" and WM_KEYDOWN) This behavoiour can be seen (with more difficulties to replicate) also with mousewheel or quickly presssing mouse buttons and it's not keyboard-only related. The problem happens only in wine. I think the component is user32 'cause with the patch Teamviewer works fine. -- Configure bugmail: http://bugs.winehq.org/userprefs.cgi?tab=email Do not reply to this email, post in Bugzilla using the above URL to reply. ------- You are receiving this mail because: ------- You are watching all bug changes.
http://bugs.winehq.org/show_bug.cgi?id=20699 Vitaliy Margolen <vitaliy(a)kievinfo.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Summary|Something wrong with |TeamViewer - characters |WH_GETMESSAGE hook |repeat in the chat window |(TeamViewer) | -- Configure bugmail: http://bugs.winehq.org/userprefs.cgi?tab=email Do not reply to this email, post in Bugzilla using the above URL to reply. ------- You are receiving this mail because: ------- You are watching all bug changes.
http://bugs.winehq.org/show_bug.cgi?id=20699 --- Comment #3 from Austin English <austinenglish(a)gmail.com> 2011-10-02 11:45:38 CDT --- This is your friendly reminder that there has been no bug activity for 1 year. Is this still an issue in current (1.3.29 or newer) wine? -- Configure bugmail: http://bugs.winehq.org/userprefs.cgi?tab=email Do not reply to this email, post in Bugzilla using the above URL to reply. ------- You are receiving this mail because: ------- You are watching all bug changes.
http://bugs.winehq.org/show_bug.cgi?id=20699 Bruno Jesus <00cpxxx(a)gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|UNCONFIRMED |RESOLVED URL| |http://www.teamviewer.com/e | |n/download/dyngate.aspx Keywords| |download CC| |00cpxxx(a)gmail.com Resolution| |FIXED Summary|TeamViewer - characters |TeamViewer 3 - characters |repeat in the chat window |repeat in the chat window --- Comment #4 from Bruno Jesus <00cpxxx(a)gmail.com> 2013-01-05 09:09:45 CST --- After several attempts I could not reproduce this issue in wine 1.5.21 so I'm assuming this fixed. -- Configure bugmail: http://bugs.winehq.org/userprefs.cgi?tab=email Do not reply to this email, post in Bugzilla using the above URL to reply. ------- You are receiving this mail because: ------- You are watching all bug changes.
http://bugs.winehq.org/show_bug.cgi?id=20699 Alexandre Julliard <julliard(a)winehq.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|RESOLVED |CLOSED --- Comment #5 from Alexandre Julliard <julliard(a)winehq.org> 2013-01-18 14:56:58 CST --- Closing bugs fixed in 1.5.22. -- Configure bugmail: http://bugs.winehq.org/userprefs.cgi?tab=email Do not reply to this email, post in Bugzilla using the above URL to reply. ------- You are receiving this mail because: ------- You are watching all bug changes.
participants (1)
-
wine-bugs＠winehq.org