[Bug 17908] New: TCSCP fails to install
http://bugs.winehq.org/show_bug.cgi?id=17908 Summary: TCSCP fails to install Product: Wine Version: 1.1.18 Platform: All OS/Version: All Status: UNCONFIRMED Severity: normal Priority: P2 Component: msi AssignedTo: wine-bugs(a)winehq.org ReportedBy: wine(a)mkarcher.dialup.fu-berlin.de CC: truiken(a)gmail.com The TCSCP installer fails to accept valid license numbers. This has been tracked down to be caused by commit 8321276cd34486bc6bf1e07c0e99c73423288854 Author: James Hawkins <truiken(a)gmail.com> Date: Wed Oct 18 11:25:14 2006 -0700 msi: Run SetProperty events before all other events no matter what the order is. The reason is, that there is an action table for the next button of the dialog where you enter user name / company name / license code along these lines: "UserInfoDlg" "Next" "[numtocheck]" "[keyentered]" "FEATURE_A = 1 OR "FEATURE_B = 1" 1 "UserInfoDlg" "Next" "[checkpassed]" "0" "1" 15 "UserInfoDlg" "Next" "DoAction" "CheckLicenseString" "FEATURE_A = 1 OR FEATURE_B = 1" 20 "UserInfoDlg" "Next" "[donotinstall]" "1" "NOT checkpassed" 100 Because that patch executes the PropertySet Actions before all other actions, donotinstall always gets set to 1, even if the entered license number is correct (in that case, the custom action "CheckLicenseSting" will set checkpassed to one, if the number in numtocheck is valid). Having donotinstall set to one makes the installer re-request a valid license number. Reverting the patch (and thus executing the custom action at the right point in time fixes the behaviour. The correct fix for Americas Army that needed this out-of-order execution thus must be different. The installer has been verified to work fine in Windows XP. -- Configure bugmail: http://bugs.winehq.org/userprefs.cgi?tab=email Do not reply to this email, post in Bugzilla using the above URL to reply. ------- You are receiving this mail because: ------- You are watching all bug changes.
http://bugs.winehq.org/show_bug.cgi?id=17908 Vitaliy Margolen <vitaliy(a)kievinfo.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Keywords| |regression OS/Version|All |other Platform|All |Other -- Configure bugmail: http://bugs.winehq.org/userprefs.cgi?tab=email Do not reply to this email, post in Bugzilla using the above URL to reply. ------- You are receiving this mail because: ------- You are watching all bug changes.
http://bugs.winehq.org/show_bug.cgi?id=17908 Austin English <austinenglish(a)gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Keywords| |Installer -- Configure bugmail: http://bugs.winehq.org/userprefs.cgi?tab=email Do not reply to this email, post in Bugzilla using the above URL to reply. ------- You are receiving this mail because: ------- You are watching all bug changes.
http://bugs.winehq.org/show_bug.cgi?id=17908 James Hawkins <truiken(a)gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- AssignedTo|wine-bugs(a)winehq.org |truiken(a)gmail.com --- Comment #1 from James Hawkins <truiken(a)gmail.com> 2009-04-05 23:09:17 --- Assigning to me. -- Configure bugmail: http://bugs.winehq.org/userprefs.cgi?tab=email Do not reply to this email, post in Bugzilla using the above URL to reply. ------- You are receiving this mail because: ------- You are watching all bug changes.
http://bugs.winehq.org/show_bug.cgi?id=17908 --- Comment #2 from Austin English <austinenglish(a)gmail.com> 2009-10-12 14:55:55 --- Is this still an issue in current (1.1.31 or newer) wine? -- Configure bugmail: http://bugs.winehq.org/userprefs.cgi?tab=email Do not reply to this email, post in Bugzilla using the above URL to reply. ------- You are receiving this mail because: ------- You are watching all bug changes.
http://bugs.winehq.org/show_bug.cgi?id=17908 Xavier Vachon <xvachon(a)gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |xvachon(a)gmail.com --- Comment #3 from Xavier Vachon <xvachon(a)gmail.com> 2010-07-25 00:12:33 --- What is TCSCP? Is there a download somewhere so that we can test? -- Configure bugmail: http://bugs.winehq.org/userprefs.cgi?tab=email Do not reply to this email, post in Bugzilla using the above URL to reply. ------- You are receiving this mail because: ------- You are watching all bug changes.
http://bugs.winehq.org/show_bug.cgi?id=17908 snejjj <jensm1(a)bbjh.de> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |jensm1(a)bbjh.de --- Comment #4 from snejjj <jensm1(a)bbjh.de> 2011-05-18 06:31:23 CDT --- no real activity since April 2009 (>2years) and reporter hasn't answered once here. Should probably marked as ABANDONED. -- Configure bugmail: http://bugs.winehq.org/userprefs.cgi?tab=email Do not reply to this email, post in Bugzilla using the above URL to reply. ------- You are receiving this mail because: ------- You are watching all bug changes.
http://bugs.winehq.org/show_bug.cgi?id=17908 Austin English <austinenglish(a)gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|UNCONFIRMED |RESOLVED Resolution| |ABANDONED --- Comment #5 from Austin English <austinenglish(a)gmail.com> 2011-05-18 13:16:26 CDT --- Agreed. -- Configure bugmail: http://bugs.winehq.org/userprefs.cgi?tab=email Do not reply to this email, post in Bugzilla using the above URL to reply. ------- You are receiving this mail because: ------- You are watching all bug changes.
http://bugs.winehq.org/show_bug.cgi?id=17908 Jeff Zaroyko <jeffz(a)jeffz.name> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|RESOLVED |CLOSED --- Comment #6 from Jeff Zaroyko <jeffz(a)jeffz.name> 2011-05-21 17:54:47 CDT --- Closing abandoned. -- Configure bugmail: http://bugs.winehq.org/userprefs.cgi?tab=email Do not reply to this email, post in Bugzilla using the above URL to reply. ------- You are receiving this mail because: ------- You are watching all bug changes.
http://bugs.winehq.org/show_bug.cgi?id=17908 --- Comment #7 from Michael Karcher <wine(a)mkarcher.dialup.fu-berlin.de> 2011-05-27 12:49:31 CDT --- Created an attachment (id=34919) --> (http://bugs.winehq.org/attachment.cgi?id=34919) MSI file as test case -- Configure bugmail: http://bugs.winehq.org/userprefs.cgi?tab=email Do not reply to this email, post in Bugzilla using the above URL to reply. ------- You are receiving this mail because: ------- You are watching all bug changes.
http://bugs.winehq.org/show_bug.cgi?id=17908 --- Comment #8 from Michael Karcher <wine(a)mkarcher.dialup.fu-berlin.de> 2011-05-27 12:56:23 CDT --- Created an attachment (id=34920) --> (http://bugs.winehq.org/attachment.cgi?id=34920) Sources for winetest.msi -- Configure bugmail: http://bugs.winehq.org/userprefs.cgi?tab=email Do not reply to this email, post in Bugzilla using the above URL to reply. ------- You are receiving this mail because: ------- You are watching all bug changes.
http://bugs.winehq.org/show_bug.cgi?id=17908 --- Comment #9 from Michael Karcher <wine(a)mkarcher.dialup.fu-berlin.de> 2011-05-27 13:09:58 CDT --- First, sorry for not being responsive on this bug earlier. Second, sorry for misspelling the tool name - it's not TCSCP, but TCSPC, a commercial data acquisition and evaluation tool for "time-correlated single-photon counting", made by Becker & Hickl. The installer I referred to is stored at http://www.becker-hickl.de/download/tcspcpackage/tcspc_setup_32.exe. I don't have any valid license code at hands anymore (and also didn't anymore at October 2009 when Austin English asked), so I can't test whether wine will still pass with a valid license code. The offending MSI is extracted by that exe installer, and can be easily located using "ps x" when the installer is running (look for a msiexec process having the path to the file as parameter). In that MSI file, check the User_Information_Dialog, especially the event handling for the "Next" control. On the other hand, I am slightly disappointed by my analysis of the problem going down the drain by abondoning the bug. So I made a minimal example (using a JScript instead of a native code action) exposing the same problem. The attached MSI file works fine in Windows (i.e. keeps re-asking for the license code until you enter "VALID", in which case the dialog sequence ends), while in Wine the loop can not be exited with any license code (I also attached the sources that can be put into "wine winemsibuilder -i winetest.msi *.idt"). The question "does the bug still exist" annoyed me a bit, as the code doing the invalid reordering (processing the property events before all other events despite of what the Ordering column says) is not changed since the 2006 commit I pointed out (according to git blame). OTOH the Installer for America's Army most likely should be retested, whether it still needs the cited patch that caused the regression, because scheduling of action has indeed changed since 2006, which might cause the action that was executed too early to run at the right time through the scheduling mechanism. -- Configure bugmail: http://bugs.winehq.org/userprefs.cgi?tab=email Do not reply to this email, post in Bugzilla using the above URL to reply. ------- You are receiving this mail because: ------- You are watching all bug changes.
http://bugs.winehq.org/show_bug.cgi?id=17908 Michael Karcher <wine(a)mkarcher.dialup.fu-berlin.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|CLOSED |UNCONFIRMED Version|1.1.18 |1.3.20 Resolution|ABANDONED | --- Comment #10 from Michael Karcher <wine(a)mkarcher.dialup.fu-berlin.de> 2011-05-27 13:11:34 CDT --- reopening due to added info. -- Configure bugmail: http://bugs.winehq.org/userprefs.cgi?tab=email Do not reply to this email, post in Bugzilla using the above URL to reply. ------- You are receiving this mail because: ------- You are watching all bug changes.
http://bugs.winehq.org/show_bug.cgi?id=17908 Hans Leidekker <hans(a)meelstraat.net> changed: What |Removed |Added ---------------------------------------------------------------------------- Version|1.3.20 |1.1.18 --- Comment #11 from Hans Leidekker <hans(a)meelstraat.net> 2011-05-30 02:19:00 CDT --- Test case doesn't work here unless I use native jscript. Could someone please confirm that the installer for America's Army still works after reverting 8321276cd34486bc6bf1e07c0e99c73423288854? -- Configure bugmail: http://bugs.winehq.org/userprefs.cgi?tab=email Do not reply to this email, post in Bugzilla using the above URL to reply. ------- You are receiving this mail because: ------- You are watching all bug changes.
http://bugs.winehq.org/show_bug.cgi?id=17908 --- Comment #12 from Michael Karcher <wine(a)mkarcher.dialup.fu-berlin.de> 2011-05-30 10:59:46 CDT --- What do you mean by "doesn't work unless I use native jscript"? I tried "msiexec /i winetest.msi" on a clean prefix, and the license code "VALID" will be rejected, as well as after installing wsh56js via some (outdated) winetricks version and setting jscript to (native,builtin). Did you manage to get "VALID" accepted (i.e. the installer exiting) with builtin msi and native jscript? -- Configure bugmail: http://bugs.winehq.org/userprefs.cgi?tab=email Do not reply to this email, post in Bugzilla using the above URL to reply. ------- You are receiving this mail because: ------- You are watching all bug changes.
http://bugs.winehq.org/show_bug.cgi?id=17908 --- Comment #13 from Hans Leidekker <hans(a)meelstraat.net> 2011-05-30 11:38:06 CDT --- (In reply to comment #12)
Did you manage to get "VALID" accepted (i.e. the installer exiting) with builtin msi and native jscript?
Yes. -- Configure bugmail: http://bugs.winehq.org/userprefs.cgi?tab=email Do not reply to this email, post in Bugzilla using the above URL to reply. ------- You are receiving this mail because: ------- You are watching all bug changes.
http://bugs.winehq.org/show_bug.cgi?id=17908 --- Comment #14 from Hans Leidekker <hans(a)meelstraat.net> 2011-06-07 02:58:08 CDT --- I found an old version of America's Army that appears to have been current in 2006, when that patch was committed. It does install after reverting 8321276cd34486bc6bf1e07c0e99c73423288854. $ sha1sum americasarmy250_download.exe 40add16ba4184d70c8fcc2c43405f2214dd476af americasarmy250_download.exe -- Configure bugmail: http://bugs.winehq.org/userprefs.cgi?tab=email Do not reply to this email, post in Bugzilla using the above URL to reply. ------- You are receiving this mail because: ------- You are watching all bug changes.
http://bugs.winehq.org/show_bug.cgi?id=17908 Juan Lang <juan_lang(a)yahoo.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|UNCONFIRMED |NEW Summary|TCSCP fails to install |TCSPC fails to install Ever Confirmed|0 |1 --- Comment #15 from Juan Lang <juan_lang(a)yahoo.com> 2011-06-07 11:58:33 CDT --- Renaming due to comment 9, and confirming due to comment 14. -- Configure bugmail: http://bugs.winehq.org/userprefs.cgi?tab=email Do not reply to this email, post in Bugzilla using the above URL to reply. ------- You are receiving this mail because: ------- You are watching all bug changes.
http://bugs.winehq.org/show_bug.cgi?id=17908 Austin English <austinenglish(a)gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |RESOLVED Resolution| |FIXED --- Comment #16 from Austin English <austinenglish(a)gmail.com> 2011-06-07 12:05:11 CDT --- Fixed by http://source.winehq.org/git/wine.git/commitdiff/5e37c1a2b77cc40a1b7f896da65... -- Configure bugmail: http://bugs.winehq.org/userprefs.cgi?tab=email Do not reply to this email, post in Bugzilla using the above URL to reply. ------- You are receiving this mail because: ------- You are watching all bug changes.
http://bugs.winehq.org/show_bug.cgi?id=17908 Alexandre Julliard <julliard(a)winehq.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|RESOLVED |CLOSED --- Comment #17 from Alexandre Julliard <julliard(a)winehq.org> 2011-06-10 13:17:57 CDT --- Closing bugs fixed in 1.3.22. -- Configure bugmail: http://bugs.winehq.org/userprefs.cgi?tab=email Do not reply to this email, post in Bugzilla using the above URL to reply. ------- You are receiving this mail because: ------- You are watching all bug changes.
http://bugs.winehq.org/show_bug.cgi?id=17908 Hans Leidekker <hans(a)meelstraat.net> changed: What |Removed |Added ---------------------------------------------------------------------------- Fixed by SHA1| |5e37c1a2b77cc40a1b7f896da65 | |b57b4baa13390 -- Configure bugmail: http://bugs.winehq.org/userprefs.cgi?tab=email Do not reply to this email, post in Bugzilla using the above URL to reply. ------- You are receiving this mail because: ------- You are watching all bug changes.
http://bugs.winehq.org/show_bug.cgi?id=17908 Hans Leidekker <hans(a)meelstraat.net> changed: What |Removed |Added ---------------------------------------------------------------------------- Regression SHA1| |8321276cd34486bc6bf1e07c0e9 | |9c73423288854 -- Configure bugmail: http://bugs.winehq.org/userprefs.cgi?tab=email Do not reply to this email, post in Bugzilla using the above URL to reply. ------- You are receiving this mail because: ------- You are watching all bug changes.
participants (1)
-
wine-bugs＠winehq.org