[Bug 7150] Implement Arabic shaping

http://bugs.winehq.org/show_bug.cgi?id=7150


Alexander Scott-Johns <alexander.scott.johns+winebug(a)googlemail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |alexander.scott.johns+wineb
                   |                            |ug(a)googlemail.com




--- Comment #11 from Alexander Scott-Johns <alexander.scott.johns+winebug(a)googlemail.com>  2009-10-25 16:43:39 ---
(In reply to comment #10)
> (In reply to comment #9)
> > Created an attachment (id=23239)
> >  --> (http://bugs.winehq.org/attachment.cgi?id=23239)
> > faster as it skips shaping if there is nothing to shape
>
> Muayyad, wine developers don't grab patches from bugzilla, see
> http://wiki.winehq.org/SubmittingPatches on how to submit a patch.

A few comments about your patch (the maintainer is quite picky about the
patches that get into Wine, and it might get silently dropped):

* Please keep the spacing of your code consistent with the rest of the file (4
space indentation, spaces around binary operators, etc).
* You don't need to include your email address in the code itself (as the Wine
Git repository tracks authorship information).
* Can you please use slightly more descriptive variable names than p, c, cn,
ch, jx, jcn, jpc, j, i and ix?
* Is it possible to write conformance tests for this? (If so, please include
some, as the patch will be much more likely to get in.)
* You may find it easier to manage and generate your patches with Git.

-- 
Configure bugmail: http://bugs.winehq.org/userprefs.cgi?tab=email
Do not reply to this email, post in Bugzilla using the
above URL to reply.
------- You are receiving this mail because: -------
You are watching all bug changes.