[Bug 18606] New: Open/save file dialog "New Folder" button does not behave as expected for non-unixfs/My Documents working directory shell items
http://bugs.winehq.org/show_bug.cgi?id=18606 Summary: Open/save file dialog "New Folder" button does not behave as expected for non-unixfs/My Documents working directory shell items Product: Wine Version: 1.1.22 Platform: PC OS/Version: Linux Status: UNCONFIRMED Severity: minor Priority: P2 Component: -unknown AssignedTo: wine-bugs(a)winehq.org ReportedBy: arethusa26(a)gmail.com When a file dialog is opened, and a shell item that is not under the unixfs hierarchy or is not the My Documents item is selected as the working directory, pressing the "New Folder" button does not show a new "New Folder" icon in the file listing and does not offer the choice of renaming the folder item, whereas doing so under a shell item under the "/" hierarchy works properly. To reproduce: 1. Start up Notepad and open the file open dialog. 2. Change the "Look in:" combo box selector to My Computer. 3. Select the "C:\" shell item. 4. Press the New Folder icon. The expected behavior does not occur. -- Configure bugmail: http://bugs.winehq.org/userprefs.cgi?tab=email Do not reply to this email, post in Bugzilla using the above URL to reply. ------- You are receiving this mail because: ------- You are watching all bug changes.
http://bugs.winehq.org/show_bug.cgi?id=18606 Austin English <austinenglish(a)gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Keywords| |download CC| |austinenglish(a)gmail.com -- Configure bugmail: http://bugs.winehq.org/userprefs.cgi?tab=email Do not reply to this email, post in Bugzilla using the above URL to reply. ------- You are receiving this mail because: ------- You are watching all bug changes.
http://bugs.winehq.org/show_bug.cgi?id=18606 --- Comment #1 from Andrew Eikum <aeikum(a)codeweavers.com> 2010-06-17 11:00:28 --- Created an attachment (id=28916) --> (http://bugs.winehq.org/attachment.cgi?id=28916) Patch tarball to fix Here is a patch series which fixes this. The problem and my solution are described in patch 3. The patches still need tests. Unfortunately, there are no existing tests for the SHChangeNotify family yet, so I suspect a slew of failures will pop up when tests are made. If someone wants to write tests for these, then great. Otherwise I'll try to put something together for after 1.2. -- Configure bugmail: http://bugs.winehq.org/userprefs.cgi?tab=email Do not reply to this email, post in Bugzilla using the above URL to reply. ------- You are receiving this mail because: ------- You are watching all bug changes.
http://bugs.winehq.org/show_bug.cgi?id=18606 Andrew Eikum <aeikum(a)codeweavers.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Keywords| |patch CC| |aeikum(a)codeweavers.com -- Configure bugmail: http://bugs.winehq.org/userprefs.cgi?tab=email Do not reply to this email, post in Bugzilla using the above URL to reply. ------- You are receiving this mail because: ------- You are watching all bug changes.
http://bugs.winehq.org/show_bug.cgi?id=18606 Andrew Eikum <aeikum(a)codeweavers.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #28916|0 |1 is obsolete| | --- Comment #2 from Andrew Eikum <aeikum(a)codeweavers.com> 2010-08-04 09:49:51 --- (From update of attachment 28916) Patches are wrong. Different solution is needed. -- Configure bugmail: http://bugs.winehq.org/userprefs.cgi?tab=email Do not reply to this email, post in Bugzilla using the above URL to reply. ------- You are receiving this mail because: ------- You are watching all bug changes.
http://bugs.winehq.org/show_bug.cgi?id=18606 --- Comment #3 from Andrew Eikum <aeikum(a)codeweavers.com> 2010-11-24 10:19:24 CST --- Created an attachment (id=32112) --> (http://bugs.winehq.org/attachment.cgi?id=32112) Correctly construct the PIDL given to SHChangeNotify in AddFolder Here's a better approach. This also fixes the bug. I'm still working on tests. -- Configure bugmail: http://bugs.winehq.org/userprefs.cgi?tab=email Do not reply to this email, post in Bugzilla using the above URL to reply. ------- You are receiving this mail because: ------- You are watching all bug changes.
http://bugs.winehq.org/show_bug.cgi?id=18606 Andrew Eikum <aeikum(a)codeweavers.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|UNCONFIRMED |RESOLVED Resolution| |FIXED --- Comment #4 from Andrew Eikum <aeikum(a)codeweavers.com> 2010-12-07 09:47:05 CST --- This is fixed by 0a55ec2c9e1dc5fd0b99ad1202fd7849b0187808 in latest git. -- Configure bugmail: http://bugs.winehq.org/userprefs.cgi?tab=email Do not reply to this email, post in Bugzilla using the above URL to reply. ------- You are receiving this mail because: ------- You are watching all bug changes.
http://bugs.winehq.org/show_bug.cgi?id=18606 Alexandre Julliard <julliard(a)winehq.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|RESOLVED |CLOSED --- Comment #5 from Alexandre Julliard <julliard(a)winehq.org> 2010-12-10 13:46:37 CST --- Closing bugs fixed in 1.3.9. -- Configure bugmail: http://bugs.winehq.org/userprefs.cgi?tab=email Do not reply to this email, post in Bugzilla using the above URL to reply. ------- You are receiving this mail because: ------- You are watching all bug changes.
participants (1)
-
wine-bugs＠winehq.org