[Bug 18347] New: GdipImageRotateFlip and GdipImageSetAbort aren't implemented
http://bugs.winehq.org/show_bug.cgi?id=18347 Summary: GdipImageRotateFlip and GdipImageSetAbort aren't implemented Product: Wine Version: 1.1.20 Platform: PC OS/Version: Linux Status: UNCONFIRMED Severity: normal Priority: P2 Component: -unknown AssignedTo: wine-bugs(a)winehq.org ReportedBy: dima(a)gmail.com GdipImageRotateFlip and GdipImageSetAbort are marked "stub" in gdiplus.spec. Cooliris tries to call them and crashes because of that. When I added stub implementations, similar to other functions in image.c, it fixed that particular crash. (Cooliris still dereferences a NULL pointer later, though - possibly because the GDI+ functions aren't actually implemented. I'm looking into that.) If you want to test this, you'll have to set HOMEDRIVE and HOMEPATH first (see bug 18336). Btw, what does "@ stub" do? Is there any point in adding that, as opposed to a dummy implementation of the function? -- Configure bugmail: http://bugs.winehq.org/userprefs.cgi?tab=email Do not reply to this email, post in Bugzilla using the above URL to reply. ------- You are receiving this mail because: ------- You are watching all bug changes.
http://bugs.winehq.org/show_bug.cgi?id=18347 Vincent Povirk <madewokherd(a)gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |madewokherd(a)gmail.com Component|-unknown |gdiplus Keywords| |download -- Configure bugmail: http://bugs.winehq.org/userprefs.cgi?tab=email Do not reply to this email, post in Bugzilla using the above URL to reply. ------- You are receiving this mail because: ------- You are watching all bug changes.
http://bugs.winehq.org/show_bug.cgi?id=18347 --- Comment #1 from Austin English <austinenglish(a)gmail.com> 2009-05-03 23:20:57 --- You should send those stubs to wine-patches(a)winehq.org. (In reply to comment #0)
Btw, what does "@ stub" do? Is there any point in adding that, as opposed to a dummy implementation of the function?
Marks it as unimplemented. -- Configure bugmail: http://bugs.winehq.org/userprefs.cgi?tab=email Do not reply to this email, post in Bugzilla using the above URL to reply. ------- You are receiving this mail because: ------- You are watching all bug changes.
http://bugs.winehq.org/show_bug.cgi?id=18347 --- Comment #2 from Nikolay Sivov <bunglehead(a)gmail.com> 2009-07-07 08:57:14 --- Currently: GdipImageRotateFlip - has a stub. GdipImageSetAbort - missed -- Configure bugmail: http://bugs.winehq.org/userprefs.cgi?tab=email Do not reply to this email, post in Bugzilla using the above URL to reply. ------- You are receiving this mail because: ------- You are watching all bug changes.
http://bugs.winehq.org/show_bug.cgi?id=18347 Ken Sharp <kennybobs(a)o2.co.uk> changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |18876 -- Configure bugmail: http://bugs.winehq.org/userprefs.cgi?tab=email Do not reply to this email, post in Bugzilla using the above URL to reply. ------- You are receiving this mail because: ------- You are watching all bug changes.
http://bugs.winehq.org/show_bug.cgi?id=18347 --- Comment #3 from Vincent Povirk <madewokherd(a)gmail.com> 2009-08-27 17:31:31 --- There's a bit of additional difficulty in stubbing GdipImageSetAbort. The GdiplusAbort type is defined as a struct containing a single virtual method. Someone will have to translate that into C before we can use the type. -- Configure bugmail: http://bugs.winehq.org/userprefs.cgi?tab=email Do not reply to this email, post in Bugzilla using the above URL to reply. ------- You are receiving this mail because: ------- You are watching all bug changes.
http://bugs.winehq.org/show_bug.cgi?id=18347 Dan Kegel <dank(a)kegel.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |dank(a)kegel.com --- Comment #4 from Dan Kegel <dank(a)kegel.com> 2009-11-04 16:10:20 --- btw, 'sh winetricks gdiplus' should get you past this problem, though it's not a real fix. -- Configure bugmail: http://bugs.winehq.org/userprefs.cgi?tab=email Do not reply to this email, post in Bugzilla using the above URL to reply. ------- You are receiving this mail because: ------- You are watching all bug changes.
http://bugs.winehq.org/show_bug.cgi?id=18347 Ken Sharp <kennybobs(a)o2.co.uk> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|UNCONFIRMED |NEW Blocks|18876 | Ever Confirmed|0 |1 --- Comment #5 from Ken Sharp <kennybobs(a)o2.co.uk> 2011-10-08 12:05:44 CDT --- May as well confirm it. http://source.winehq.org/source/dlls/gdiplus/gdiplus.spec#L624 -- Configure bugmail: http://bugs.winehq.org/userprefs.cgi?tab=email Do not reply to this email, post in Bugzilla using the above URL to reply. ------- You are receiving this mail because: ------- You are watching all bug changes.
http://bugs.winehq.org/show_bug.cgi?id=18347 Austin English <austinenglish(a)gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Summary|GdipImageRotateFlip and |GdipImageSetAbort isn't |GdipImageSetAbort aren't |implemented |implemented | -- Do not reply to this email, post in Bugzilla using the above URL to reply. You are receiving this mail because: You are watching all bug changes.
https://bugs.winehq.org/show_bug.cgi?id=18347 Anastasius Focht <focht(a)gmx.net> changed: What |Removed |Added ---------------------------------------------------------------------------- URL| |http://www.idg.pl/ftp/pobie | |rz/pc/18735.html CC| |focht(a)gmx.net Summary|GdipImageSetAbort isn't |Multiple applications crash |implemented |on unimplemented function | |gdiplus.dll.GdipImageSetAbo | |rt (Cooliris, IPLA 0.9) --- Comment #6 from Anastasius Focht <focht(a)gmx.net> --- Hello folks, is this about 'Cooliris' browser plugin? I can't find a download for this, please add one. MSDN: http://msdn.microsoft.com/en-us/library/windows/desktop/ms534041%28v=vs.85%2... Another app reported for this: IPLA 0.9 https://appdb.winehq.org/objectManager.php?sClass=version&iId=13853 Download: http://www.idg.pl/ftp/pobierz/pc/18735.html $ sha1sum iplasetup.exe cbd5578e1c8a3439ecc126d246fcb271825c2e37 iplasetup.exe $ du -sh iplasetup.exe 8.2M iplasetup.exe $ wine --version wine-1.7.13-100-gfcae016 Regards -- Do not reply to this email, post in Bugzilla using the above URL to reply. You are receiving this mail because: You are watching all bug changes.
https://bugs.winehq.org/show_bug.cgi?id=18347 --- Comment #7 from Nikolay Sivov <bunglehead(a)gmail.com> --- (In reply to Vincent Povirk from comment #3)
There's a bit of additional difficulty in stubbing GdipImageSetAbort. The GdiplusAbort type is defined as a struct containing a single virtual method. Someone will have to translate that into C before we can use the type.
Doesn't matter for now as I added it as generic structure pointer. Can someone please test if a5ab896abd27fcd367948b4716523c607997ff87 is enough? -- Do not reply to this email, post in Bugzilla using the above URL to reply. You are receiving this mail because: You are watching all bug changes.
https://bugs.winehq.org/show_bug.cgi?id=18347 Austin English <austinenglish(a)gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Fixed by SHA1| |a5ab896abd27fcd367948b47165 | |23c607997ff87 Status|NEW |RESOLVED Resolution|--- |FIXED --- Comment #8 from Austin English <austinenglish(a)gmail.com> --- (In reply to Nikolay Sivov from comment #7)
(In reply to Vincent Povirk from comment #3)
There's a bit of additional difficulty in stubbing GdipImageSetAbort. The GdiplusAbort type is defined as a struct containing a single virtual method. Someone will have to translate that into C before we can use the type.
Doesn't matter for now as I added it as generic structure pointer. Can someone please test if a5ab896abd27fcd367948b4716523c607997ff87 is enough?
It's been 6 months and there's no download, I think it's safe to assume fixed. -- Do not reply to this email, post in Bugzilla using the above URL to reply. You are receiving this mail because: You are watching all bug changes.
https://bugs.winehq.org/show_bug.cgi?id=18347 Alexandre Julliard <julliard(a)winehq.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|RESOLVED |CLOSED --- Comment #9 from Alexandre Julliard <julliard(a)winehq.org> --- Closing bugs fixed in 1.9.0. -- Do not reply to this email, post in Bugzilla using the above URL to reply. You are receiving this mail because: You are watching all bug changes.
participants (1)
-
wine-bugs＠winehq.org