[Bug 29180] New: WS_CHILD dialog might want WM_CAPTION
http://bugs.winehq.org/show_bug.cgi?id=29180 Bug #: 29180 Summary: WS_CHILD dialog might want WM_CAPTION Product: Wine Version: 1.3.33 Platform: x86 OS/Version: Linux Status: UNCONFIRMED Severity: normal Priority: P2 Component: user32 AssignedTo: wine-bugs(a)winehq.org ReportedBy: toni.spets(a)iki.fi Classification: Unclassified Created attachment 37645 --> http://bugs.winehq.org/attachment.cgi?id=37645 Missing title bar in editable dialog A child dialog (WS_CHILD) window can request WM_CAPTION and WS_SYSMENU. The very obscure case of this is a free resource editor like ResEdit. With ResEdit the WM_CAPTION style is ignored when the window is first created leaving the editable window without a title bar, this is incorrect and also causes height calculation problems when the program expect the title bar to exist. The incorrect rendering is shown in the attachment. Toggling some style options which triggers SetWindowLong() will make the title bar appear and everything continue working correctly. I'm not 100% sure about WM_SYSMENU showing up on Windows, I'd expect it to be shown if requested altough not working as the dialog is in disabled state to prevent using them. Patch attached to show the incorrect handling of WM_CAPTION. Fixing this should be trivial by loosening the restrictions posed on WM_CHILD windows. -- Configure bugmail: http://bugs.winehq.org/userprefs.cgi?tab=email Do not reply to this email, post in Bugzilla using the above URL to reply. ------- You are receiving this mail because: ------- You are watching all bug changes.
http://bugs.winehq.org/show_bug.cgi?id=29180 --- Comment #1 from Toni Spets <toni.spets(a)iki.fi> 2011-11-26 15:07:56 CST --- Created attachment 37646 --> http://bugs.winehq.org/attachment.cgi?id=37646 Probably not the correct fix Added patch. -- Configure bugmail: http://bugs.winehq.org/userprefs.cgi?tab=email Do not reply to this email, post in Bugzilla using the above URL to reply. ------- You are receiving this mail because: ------- You are watching all bug changes.
http://bugs.winehq.org/show_bug.cgi?id=29180 --- Comment #2 from Toni Spets <toni.spets(a)iki.fi> 2011-11-26 15:41:46 CST --- Example rendering of the dialog editor with the title bar is at the program's homepage: http://www.resedit.net/images/dialog_editor.png -- Configure bugmail: http://bugs.winehq.org/userprefs.cgi?tab=email Do not reply to this email, post in Bugzilla using the above URL to reply. ------- You are receiving this mail because: ------- You are watching all bug changes.
http://bugs.winehq.org/show_bug.cgi?id=29180 Vitaliy Margolen <vitaliy-bugzilla(a)kievinfo.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Keywords| |download, patch URL| |http://www.resedit.net/ Severity|normal |minor -- Configure bugmail: http://bugs.winehq.org/userprefs.cgi?tab=email Do not reply to this email, post in Bugzilla using the above URL to reply. ------- You are receiving this mail because: ------- You are watching all bug changes.
http://bugs.winehq.org/show_bug.cgi?id=29180 --- Comment #3 from Dmitry Timoshkov <dmitry(a)baikal.ru> 2011-11-26 21:40:43 CST --- It shouldn't be too hard to write a test case for this. -- Configure bugmail: http://bugs.winehq.org/userprefs.cgi?tab=email Do not reply to this email, post in Bugzilla using the above URL to reply. ------- You are receiving this mail because: ------- You are watching all bug changes.
http://bugs.winehq.org/show_bug.cgi?id=29180 Toni Spets <toni.spets(a)iki.fi> changed: What |Removed |Added ---------------------------------------------------------------------------- Summary|WS_CHILD dialog might want |WS_CHILD dialog might want |WM_CAPTION |WS_CAPTION -- Configure bugmail: http://bugs.winehq.org/userprefs.cgi?tab=email Do not reply to this email, post in Bugzilla using the above URL to reply. ------- You are receiving this mail because: ------- You are watching all bug changes.
http://bugs.winehq.org/show_bug.cgi?id=29180 --- Comment #4 from Toni Spets <toni.spets(a)iki.fi> 2011-11-27 04:01:20 CST --- I was of course talking about WS_CAPTION. Silly me. -- Configure bugmail: http://bugs.winehq.org/userprefs.cgi?tab=email Do not reply to this email, post in Bugzilla using the above URL to reply. ------- You are receiving this mail because: ------- You are watching all bug changes.
http://bugs.winehq.org/show_bug.cgi?id=29180 --- Comment #5 from Toni Spets <toni.spets(a)iki.fi> 2011-11-27 06:54:37 CST --- Confirming that on Windows toggling WS_SYSMENU off (by using ResEdit Properties panel) removes the dialog icon and close button leaving only title with WS_CAPTION. The demo window also doesn't have an icon or any buttons, just the title like in preview. Attaching a screenshot on win7 with WS_SYSMENU disabled and preview window launched. -- Configure bugmail: http://bugs.winehq.org/userprefs.cgi?tab=email Do not reply to this email, post in Bugzilla using the above URL to reply. ------- You are receiving this mail because: ------- You are watching all bug changes.
http://bugs.winehq.org/show_bug.cgi?id=29180 --- Comment #6 from Toni Spets <toni.spets(a)iki.fi> 2011-11-27 06:55:45 CST --- Created attachment 37662 --> http://bugs.winehq.org/attachment.cgi?id=37662 ResEdit WS_SYSMENU disabled with WS_CAPTION -- Configure bugmail: http://bugs.winehq.org/userprefs.cgi?tab=email Do not reply to this email, post in Bugzilla using the above URL to reply. ------- You are receiving this mail because: ------- You are watching all bug changes.
http://bugs.winehq.org/show_bug.cgi?id=29180 Dmitry Timoshkov <dmitry(a)baikal.ru> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|UNCONFIRMED |NEW Ever Confirmed|0 |1 --- Comment #7 from Dmitry Timoshkov <dmitry(a)baikal.ru> 2011-12-07 01:09:30 CST --- Part 2 of http://www.winehq.org/pipermail/wine-patches/2011-December/109533.html http://www.winehq.org/pipermail/wine-patches/2011-December/109534.html should fix this bug. -- Configure bugmail: http://bugs.winehq.org/userprefs.cgi?tab=email Do not reply to this email, post in Bugzilla using the above URL to reply. ------- You are receiving this mail because: ------- You are watching all bug changes.
http://bugs.winehq.org/show_bug.cgi?id=29180 --- Comment #8 from Toni Spets <toni.spets(a)iki.fi> 2011-12-07 10:32:02 CST --- Confirming the second patch fixes this bug. -- Configure bugmail: http://bugs.winehq.org/userprefs.cgi?tab=email Do not reply to this email, post in Bugzilla using the above URL to reply. ------- You are receiving this mail because: ------- You are watching all bug changes.
http://bugs.winehq.org/show_bug.cgi?id=29180 Austin English <austinenglish(a)gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Fixed by SHA1| |18576b36e4f5759cef7fe04474d | |9e968748251fe Status|NEW |RESOLVED Resolution| |FIXED --- Comment #9 from Austin English <austinenglish(a)gmail.com> 2011-12-07 14:23:54 CST --- (In reply to comment #8)
Confirming the second patch fixes this bug.
http://source.winehq.org/git/wine.git/commitdiff/18576b36e4f5759cef7fe04474d... -- Configure bugmail: http://bugs.winehq.org/userprefs.cgi?tab=email Do not reply to this email, post in Bugzilla using the above URL to reply. ------- You are receiving this mail because: ------- You are watching all bug changes.
http://bugs.winehq.org/show_bug.cgi?id=29180 Alexandre Julliard <julliard(a)winehq.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|RESOLVED |CLOSED --- Comment #10 from Alexandre Julliard <julliard(a)winehq.org> 2011-12-16 13:30:39 CST --- Closing bugs fixed in 1.3.35. -- Configure bugmail: http://bugs.winehq.org/userprefs.cgi?tab=email Do not reply to this email, post in Bugzilla using the above URL to reply. ------- You are receiving this mail because: ------- You are watching all bug changes.
participants (1)
-
wine-bugs＠winehq.org