[Bug 28664] New: qedit/mediadet test crashes on FreeBSD9
http://bugs.winehq.org/show_bug.cgi?id=28664 Bug #: 28664 Summary: qedit/mediadet test crashes on FreeBSD9 Product: Wine Version: 1.3.30 Platform: x86 OS/Version: Linux Status: NEW Keywords: download, source, testcase Severity: normal Priority: P2 Component: winegstreamer AssignedTo: wine-bugs(a)winehq.org ReportedBy: austinenglish(a)gmail.com Classification: Unclassified Created attachment 36837 --> http://bugs.winehq.org/attachment.cgi?id=36837 backtrace The test was running without $DISPLAY set, but that passes fine for me on gentoo/debian. Backtrace attached. -- Configure bugmail: http://bugs.winehq.org/userprefs.cgi?tab=email Do not reply to this email, post in Bugzilla using the above URL to reply. ------- You are receiving this mail because: ------- You are watching all bug changes.
http://bugs.winehq.org/show_bug.cgi?id=28664 Charles Davis <cdavis(a)mymail.mines.edu> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |cdavis(a)mymail.mines.edu --- Comment #1 from Charles Davis <cdavis(a)mymail.mines.edu> 2011-10-17 21:13:11 CDT --- It also crashes on Mac with the same stack trace. -- Configure bugmail: http://bugs.winehq.org/userprefs.cgi?tab=email Do not reply to this email, post in Bugzilla using the above URL to reply. ------- You are receiving this mail because: ------- You are watching all bug changes.
http://bugs.winehq.org/show_bug.cgi?id=28664 --- Comment #2 from Austin English <austinenglish(a)gmail.com> 2013-07-09 14:40:47 CDT --- This is okay for me in PC-BSD9 (i386) and 1.6-rc4. It also passes in wine-1.2. I tested both versions with/without DISPLAY set. @Charles, is it broken on OSX? -- Configure bugmail: http://bugs.winehq.org/userprefs.cgi?tab=email Do not reply to this email, post in Bugzilla using the above URL to reply. ------- You are receiving this mail because: ------- You are watching all bug changes.
http://bugs.winehq.org/show_bug.cgi?id=28664 Charles Davis <cdavis5x(a)gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |aric(a)codeweavers.com --- Comment #3 from Charles Davis <cdavis5x(a)gmail.com> 2013-07-09 20:41:16 CDT --- (In reply to comment #2)
This is okay for me in PC-BSD9 (i386) and 1.6-rc4. It also passes in wine-1.2. I tested both versions with/without DISPLAY set.
@Charles, is it broken on OSX? Well, it doesn't crash anymore, but it fails with:
mediadet.c:281: Test failed: IMediaDet_get_FrameRate: fps is inf I haven't really looked at this. It might take me a while to come up with a fix. From the looks of this, we're dividing by zero on Mac--probably because the QuickTime component isn't even returning a valid AM_MEDIA_TYPE to begin with (cf. dlls/qedit/mediadet.c:605, the division in question). From what I've seen, it *should* be returning one, but it's not, and I can't figure out why at the moment. I've CC'd Aric, and I'll attach a file containing the complete output from the test, including +relay output. (Or should I file a new bug?) In any case, maybe he can help me figure this out. -- Configure bugmail: http://bugs.winehq.org/userprefs.cgi?tab=email Do not reply to this email, post in Bugzilla using the above URL to reply. ------- You are receiving this mail because: ------- You are watching all bug changes.
http://bugs.winehq.org/show_bug.cgi?id=28664 --- Comment #4 from Charles Davis <cdavis5x(a)gmail.com> 2013-07-09 20:46:40 CDT --- Created attachment 45178 --> http://bugs.winehq.org/attachment.cgi?id=45178 Output from failed qedit:mediadet test on Mac OS (+relay) -- Configure bugmail: http://bugs.winehq.org/userprefs.cgi?tab=email Do not reply to this email, post in Bugzilla using the above URL to reply. ------- You are receiving this mail because: ------- You are watching all bug changes.
http://bugs.winehq.org/show_bug.cgi?id=28664 --- Comment #5 from Aric Stewart <aric(a)codeweavers.com> 2013-07-12 08:34:16 CDT --- Could you generate a +strmbase,+quartz,+qtsplitter log? On my mac I am seeing a crash in FilterGraph2_AddFilter -- Configure bugmail: http://bugs.winehq.org/userprefs.cgi?tab=email Do not reply to this email, post in Bugzilla using the above URL to reply. ------- You are receiving this mail because: ------- You are watching all bug changes.
http://bugs.winehq.org/show_bug.cgi?id=28664 --- Comment #6 from Charles Davis <cdavis5x(a)gmail.com> 2013-07-13 19:43:13 CDT --- Created attachment 45257 --> http://bugs.winehq.org/attachment.cgi?id=45257 Output from failed qedit:mediadet test on Mac OS (+strmbase,+quartz,+qtsplitter) Done. You're seeing a crash? Something must be different about my setup. I have Flip4Mac installed, which lets QT understand Windows Media formats. Could that account for the test not crashing (though still failing) on my system? -- Configure bugmail: http://bugs.winehq.org/userprefs.cgi?tab=email Do not reply to this email, post in Bugzilla using the above URL to reply. ------- You are receiving this mail because: ------- You are watching all bug changes.
http://bugs.winehq.org/show_bug.cgi?id=28664 --- Comment #7 from Aric Stewart <aric(a)codeweavers.com> 2013-07-15 10:01:47 CDT --- (In reply to comment #6)
Created attachment 45257 [details] Output from failed qedit:mediadet test on Mac OS (+strmbase,+quartz,+qtsplitter)
Done.
You're seeing a crash? Something must be different about my setup. I have Flip4Mac installed, which lets QT understand Windows Media formats. Could that account for the test not crashing (though still failing) on my system?
Ok that is likely. My qtdecoder reports that it cannot handle the format and so I fall back to "ffdshow Video Decoder" which crashes when adding the filter. Looking at the qtdecoder you are correct: AvgTimePerFrame is unset. I can develop a patch to correct that for the qtdecoder without too much problem. The trick is is having a AvgTimePerFrame of 0 an error or is the way that qedit does that test incorrect? -aric -- Configure bugmail: http://bugs.winehq.org/userprefs.cgi?tab=email Do not reply to this email, post in Bugzilla using the above URL to reply. ------- You are receiving this mail because: ------- You are watching all bug changes.
http://bugs.winehq.org/show_bug.cgi?id=28664 --- Comment #8 from Aric Stewart <aric(a)codeweavers.com> 2013-07-15 10:10:49 CDT --- Created attachment 45276 --> http://bugs.winehq.org/attachment.cgi?id=45276 possible fix Could you try this patch. It should properly set the AvgTimePerFrame for video streams using the qtdecoder. -- Configure bugmail: http://bugs.winehq.org/userprefs.cgi?tab=email Do not reply to this email, post in Bugzilla using the above URL to reply. ------- You are receiving this mail because: ------- You are watching all bug changes.
http://bugs.winehq.org/show_bug.cgi?id=28664 Aric Stewart <aric(a)codeweavers.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #45276|0 |1 is obsolete| | --- Comment #9 from Aric Stewart <aric(a)codeweavers.com> 2013-07-15 10:23:12 CDT --- Created attachment 45277 --> http://bugs.winehq.org/attachment.cgi?id=45277 Corrected fix I found if i ran in a clean wine prefix I could get proper test behavior. I found problems with the old fix. This one appears to be correct. -- Configure bugmail: http://bugs.winehq.org/userprefs.cgi?tab=email Do not reply to this email, post in Bugzilla using the above URL to reply. ------- You are receiving this mail because: ------- You are watching all bug changes.
http://bugs.winehq.org/show_bug.cgi?id=28664 --- Comment #10 from Charles Davis <cdavis5x(a)gmail.com> 2013-07-15 13:30:28 CDT --- (In reply to comment #8)
Created attachment 45276 [details] possible fix
Could you try this patch. It should properly set the AvgTimePerFrame for video streams using the qtdecoder. That fixes it, alright. Now there are no test failures.
-- Configure bugmail: http://bugs.winehq.org/userprefs.cgi?tab=email Do not reply to this email, post in Bugzilla using the above URL to reply. ------- You are receiving this mail because: ------- You are watching all bug changes.
http://bugs.winehq.org/show_bug.cgi?id=28664 Bruno Jesus <00cpxxx(a)gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Keywords| |patch -- Configure bugmail: http://bugs.winehq.org/userprefs.cgi?tab=email Do not reply to this email, post in Bugzilla using the above URL to reply. ------- You are receiving this mail because: ------- You are watching all bug changes.
http://bugs.winehq.org/show_bug.cgi?id=28664 --- Comment #11 from Bruno Jesus <00cpxxx(a)gmail.com> 2013-07-22 14:27:50 CDT --- Patch commited: http://source.winehq.org/git/wine.git/commitdiff/deff27e23ee9dca1791501c3ba3... -- Configure bugmail: http://bugs.winehq.org/userprefs.cgi?tab=email Do not reply to this email, post in Bugzilla using the above URL to reply. ------- You are receiving this mail because: ------- You are watching all bug changes.
http://bugs.winehq.org/show_bug.cgi?id=28664 Austin English <austinenglish(a)gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Fixed by SHA1| |deff27e23ee9dca1791501c3ba3 | |1a0e6cf042c64 Status|NEW |RESOLVED Resolution| |FIXED --- Comment #12 from Austin English <austinenglish(a)gmail.com> 2013-07-29 18:45:18 CDT --- Fixed for Mac and FreeBSD. -- Configure bugmail: http://bugs.winehq.org/userprefs.cgi?tab=email Do not reply to this email, post in Bugzilla using the above URL to reply. ------- You are receiving this mail because: ------- You are watching all bug changes.
http://bugs.winehq.org/show_bug.cgi?id=28664 Alexandre Julliard <julliard(a)winehq.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|RESOLVED |CLOSED --- Comment #13 from Alexandre Julliard <julliard(a)winehq.org> 2013-08-02 13:19:12 CDT --- Closing bugs fixed in 1.7.0. -- Configure bugmail: http://bugs.winehq.org/userprefs.cgi?tab=email Do not reply to this email, post in Bugzilla using the above URL to reply. ------- You are receiving this mail because: ------- You are watching all bug changes.
http://bugs.winehq.org/show_bug.cgi?id=28664 Alexandre Julliard <julliard(a)winehq.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Target Milestone|--- |1.6.x -- Configure bugmail: http://bugs.winehq.org/userprefs.cgi?tab=email Do not reply to this email, post in Bugzilla using the above URL to reply. ------- You are receiving this mail because: ------- You are watching all bug changes.
http://bugs.winehq.org/show_bug.cgi?id=28664 Alexandre Julliard <julliard(a)winehq.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Target Milestone|1.6.x |--- --- Comment #14 from Alexandre Julliard <julliard(a)winehq.org> 2013-11-15 13:40:43 CST --- Removing 1.6.x milestone from bugs included in 1.6.1. -- Configure bugmail: http://bugs.winehq.org/userprefs.cgi?tab=email Do not reply to this email, post in Bugzilla using the above URL to reply. ------- You are receiving this mail because: ------- You are watching all bug changes.
participants (1)
-
wine-bugs＠winehq.org