[Bug 39092] New: Regression introduced with xaudio2_8
https://bugs.winehq.org/show_bug.cgi?id=39092 Bug ID: 39092 Summary: Regression introduced with xaudio2_8 Product: Wine Version: 1.7.49 Hardware: x86-64 OS: Linux Status: UNCONFIRMED Severity: normal Priority: P2 Component: -unknown Assignee: wine-bugs(a)winehq.org Reporter: xzvnjp(a)gmail.com Distribution: --- Created attachment 52084 --> https://bugs.winehq.org/attachment.cgi?id=52084 Log of game crashing on git master Game ラクエンイセキのリムリリム fails to start after commit 929ab3e527b25bcfea375e4373230748868d8714. Reverting commit in git master fixes issue. -- Do not reply to this email, post in Bugzilla using the above URL to reply. You are receiving this mail because: You are watching all bug changes.
https://bugs.winehq.org/show_bug.cgi?id=39092 --- Comment #1 from Andrew Kudryashov <xzvnjp(a)gmail.com> --- Created attachment 52085 --> https://bugs.winehq.org/attachment.cgi?id=52085 Game working with commit reverted -- Do not reply to this email, post in Bugzilla using the above URL to reply. You are receiving this mail because: You are watching all bug changes.
https://bugs.winehq.org/show_bug.cgi?id=39092 Andrew Kudryashov <xzvnjp(a)gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Distribution|--- |ArchLinux Regression SHA1| |929ab3e527b25bcfea375e43732 | |30748868d8714 -- Do not reply to this email, post in Bugzilla using the above URL to reply. You are receiving this mail because: You are watching all bug changes.
https://bugs.winehq.org/show_bug.cgi?id=39092 Andrew Kudryashov <xzvnjp(a)gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |aeikum(a)codeweavers.com -- Do not reply to this email, post in Bugzilla using the above URL to reply. You are receiving this mail because: You are watching all bug changes.
https://bugs.winehq.org/show_bug.cgi?id=39092 Sebastian Lackner <sebastian(a)fds-team.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Keywords| |regression CC| |sebastian(a)fds-team.de -- Do not reply to this email, post in Bugzilla using the above URL to reply. You are receiving this mail because: You are watching all bug changes.
https://bugs.winehq.org/show_bug.cgi?id=39092 --- Comment #2 from Andrew Eikum <aeikum(a)codeweavers.com> --- That's not too surprising. It's trying to use the stub xaudio2 object, which didn't exist before. You should be able to work around in the meantime by using native xaudio2 with "winetricks xact". -- Do not reply to this email, post in Bugzilla using the above URL to reply. You are receiving this mail because: You are watching all bug changes.
https://bugs.winehq.org/show_bug.cgi?id=39092 --- Comment #3 from Andrew Kudryashov <xzvnjp(a)gmail.com> --- Unfortunately, I get identical results with xact. -- Do not reply to this email, post in Bugzilla using the above URL to reply. You are receiving this mail because: You are watching all bug changes.
https://bugs.winehq.org/show_bug.cgi?id=39092 --- Comment #4 from Andrew Eikum <aeikum(a)codeweavers.com> --- What about if you set both xaudio2_7 and xaudio2_8 to "native" in winecfg's Libraries tab? -- Do not reply to this email, post in Bugzilla using the above URL to reply. You are receiving this mail because: You are watching all bug changes.
https://bugs.winehq.org/show_bug.cgi?id=39092 --- Comment #5 from Andrew Kudryashov <xzvnjp(a)gmail.com> --- That's interesting. I did override those two libs in previous tests, but used wine's default "native then builtin" load order. After reading your reply, I changed order to native only and game works perfectly. Thanks! -- Do not reply to this email, post in Bugzilla using the above URL to reply. You are receiving this mail because: You are watching all bug changes.
https://bugs.winehq.org/show_bug.cgi?id=39092 --- Comment #6 from Andrew Eikum <aeikum(a)codeweavers.com> --- Could you retest this with Wine 1.7.53 or later and built-in xaudio2 DLLs (i.e. no "winetricks xact")? If it is still not working, please attach another log with the channels from <http://wiki.winehq.org/Sound>. Thanks! -- Do not reply to this email, post in Bugzilla using the above URL to reply. You are receiving this mail because: You are watching all bug changes.
https://bugs.winehq.org/show_bug.cgi?id=39092 --- Comment #7 from Andrew Kudryashov <xzvnjp(a)gmail.com> --- Still crashes on startup with clean prefix. -- Do not reply to this email, post in Bugzilla using the above URL to reply. You are receiving this mail because: You are watching all bug changes.
https://bugs.winehq.org/show_bug.cgi?id=39092 --- Comment #8 from Andrew Kudryashov <xzvnjp(a)gmail.com> --- Created attachment 52584 --> https://bugs.winehq.org/attachment.cgi?id=52584 wine-1.7.53 -- Do not reply to this email, post in Bugzilla using the above URL to reply. You are receiving this mail because: You are watching all bug changes.
https://bugs.winehq.org/show_bug.cgi?id=39092 --- Comment #9 from Andrew Eikum <aeikum(a)codeweavers.com> --- Thanks Andrew. I've submitted a patch to fix one function that your game is calling. Could you apply it or wait for it to be accepted, and then retest? http://source.winehq.org/patches/data/115467 -- Do not reply to this email, post in Bugzilla using the above URL to reply. You are receiving this mail because: You are watching all bug changes.
https://bugs.winehq.org/show_bug.cgi?id=39092 --- Comment #10 from Andrew Kudryashov <xzvnjp(a)gmail.com> --- Created attachment 52613 --> https://bugs.winehq.org/attachment.cgi?id=52613 wine-1.7.53-35-g26094c5 Got patch in git together with "xaudio2: Explicitly trace the xaudio object version", but unfortunately, it didn't help. Attached log doesn't differ much from previous one, but I'm pretty sure, I'm missing important details. -- Do not reply to this email, post in Bugzilla using the above URL to reply. You are receiving this mail because: You are watching all bug changes.
https://bugs.winehq.org/show_bug.cgi?id=39092 --- Comment #11 from Andrew Eikum <aeikum(a)codeweavers.com> --- I've implemented a few more things that could result in NULL function pointers. Please retest. -- Do not reply to this email, post in Bugzilla using the above URL to reply. You are receiving this mail because: You are watching all bug changes.
https://bugs.winehq.org/show_bug.cgi?id=39092 --- Comment #12 from Andrew Kudryashov <xzvnjp(a)gmail.com> --- Created attachment 52672 --> https://bugs.winehq.org/attachment.cgi?id=52672 wine-54633e39 It works after commit f9860002f45e159f704af3dd41b6b24e1879c796, albeit with no sound at all. -- Do not reply to this email, post in Bugzilla using the above URL to reply. You are receiving this mail because: You are watching all bug changes.
https://bugs.winehq.org/show_bug.cgi?id=39092 kakurasan(a)gmail.com changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |kakurasan(a)gmail.com --- Comment #13 from kakurasan(a)gmail.com --- PlaySoundFile() in DX Library (a DirectX wrapper library, used in many Japanese games) version 3.11 doesn't play audio file if builtin version of xaudio2_8.dll is used (as of Wine 1.8-rc4). Games created with WOLF RPG Editor 2.10 also have the same problem (no sound effects, no background music except for MIDI files). DX Library (Japanese): http://homepage2.nifty.com/natupaji/DxLib/ DX Library 3.11 Source (7z archive): http://dxlib.o.oo7.jp/DxLib/DxLibMake3_11.exe -- Do not reply to this email, post in Bugzilla using the above URL to reply. You are receiving this mail because: You are watching all bug changes.
https://bugs.winehq.org/show_bug.cgi?id=39092 --- Comment #14 from kakurasan(a)gmail.com --- Created attachment 53093 --> https://bugs.winehq.org/attachment.cgi?id=53093 Test program (Source) -- Do not reply to this email, post in Bugzilla using the above URL to reply. You are receiving this mail because: You are watching all bug changes.
https://bugs.winehq.org/show_bug.cgi?id=39092 --- Comment #15 from kakurasan(a)gmail.com --- Created attachment 53094 --> https://bugs.winehq.org/attachment.cgi?id=53094 Test program (Binary) -- Do not reply to this email, post in Bugzilla using the above URL to reply. You are receiving this mail because: You are watching all bug changes.
https://bugs.winehq.org/show_bug.cgi?id=39092 Sagawa <sagawa.aki+winebugs(a)gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |sagawa.aki+winebugs(a)gmail.c | |om --- Comment #16 from Sagawa <sagawa.aki+winebugs(a)gmail.com> --- I can reproduce no sound issue with attachment 53094.
From my point of view, this is due to incomplete Wine's implementation.
In detail, DXLib code expects a valid required bytes argument in OnVoiceProcessingPassStart callback. Then, it fills audio buffer by SubmitSourceBuffer() as seen in DxSound.cpp SOUNDBUFFER_CALLBACK::OnVoiceProcessingPassStart function. However, wine always passes zero. So, the buffer is never updated. Andrew, could you take a look? -- Do not reply to this email, post in Bugzilla using the above URL to reply. You are receiving this mail because: You are watching all bug changes.
https://bugs.winehq.org/show_bug.cgi?id=39092 --- Comment #17 from Sagawa <sagawa.aki+winebugs(a)gmail.com> --- Thanks Andrew. Attachment 53094 works perfectly by 3934253513c277e0a0163a923af7c4d92f911881. I can also confirm with demo version of ラクエンイセキのリムリリム[1]. But, I'm not sure about the full version of the game. [1] ... http://trial.dlsite.com/doujin/RJ150000/RJ149669_trial.zip sha1sum(RJ149669_trial.zip) = 4f357eab13f6aa94127f2254bd518801064f41df -- Do not reply to this email, post in Bugzilla using the above URL to reply. You are receiving this mail because: You are watching all bug changes.
https://bugs.winehq.org/show_bug.cgi?id=39092 --- Comment #18 from Andrew Kudryashov <xzvnjp(a)gmail.com> --- I confirm 3934253513c277e0a0163a923af7c4d92f911881 fixing full game as well, which now works, including sound, in empty wine prefix without overrides. Huge thanks everyone. -- Do not reply to this email, post in Bugzilla using the above URL to reply. You are receiving this mail because: You are watching all bug changes.
https://bugs.winehq.org/show_bug.cgi?id=39092 Nikolay Sivov <bunglehead(a)gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Component|-unknown |xaudio2 -- Do not reply to this email, post in Bugzilla using the above URL to reply. You are receiving this mail because: You are watching all bug changes.
https://bugs.winehq.org/show_bug.cgi?id=39092 Nikolay Sivov <bunglehead(a)gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Fixed by SHA1| |3934253513c277e0a0163a923af | |7c4d92f911881 Status|UNCONFIRMED |RESOLVED Resolution|--- |FIXED --- Comment #19 from Nikolay Sivov <bunglehead(a)gmail.com> --- Reported fixed. -- Do not reply to this email, post in Bugzilla using the above URL to reply. You are receiving this mail because: You are watching all bug changes.
https://bugs.winehq.org/show_bug.cgi?id=39092 Michael Stefaniuc <mstefani(a)redhat.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |mstefani(a)redhat.com Target Milestone|--- |1.8.x -- Do not reply to this email, post in Bugzilla using the above URL to reply. You are receiving this mail because: You are watching all bug changes.
https://bugs.winehq.org/show_bug.cgi?id=39092 --- Comment #20 from Andrew Eikum <aeikum(a)codeweavers.com> --- Thanks kakurasan for finding the problem and providing a simple test case! -- Do not reply to this email, post in Bugzilla using the above URL to reply. You are receiving this mail because: You are watching all bug changes.
https://bugs.winehq.org/show_bug.cgi?id=39092 Alexandre Julliard <julliard(a)winehq.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|RESOLVED |CLOSED --- Comment #21 from Alexandre Julliard <julliard(a)winehq.org> --- Closing bugs fixed in 1.9.3. -- Do not reply to this email, post in Bugzilla using the above URL to reply. You are receiving this mail because: You are watching all bug changes.
https://bugs.winehq.org/show_bug.cgi?id=39092 Michael Stefaniuc <mstefani(a)redhat.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Target Milestone|1.8.x |--- --- Comment #22 from Michael Stefaniuc <mstefani(a)redhat.com> --- Removing 1.8.x milestone from bugs included in 1.8.3. -- Do not reply to this email, post in Bugzilla using the above URL to reply. You are receiving this mail because: You are watching all bug changes.
participants (1)
-
wine-bugs@winehq.org