[Bug 40380] New: Wine should take dosbox's configuration instead of creating a new one
https://bugs.winehq.org/show_bug.cgi?id=40380 Bug ID: 40380 Summary: Wine should take dosbox's configuration instead of creating a new one Product: Wine Version: unspecified Hardware: Other OS: Linux Status: UNCONFIRMED Severity: enhancement Priority: P2 Component: dos Assignee: wine-bugs(a)winehq.org Reporter: shankao(a)gmail.com Distribution: --- The start_dosbox() function at programs/winevdm/winevdm.c should not start with an empty configuration file for dosbox, but take the currently used by the user. In a linux system, this is at ./dosbox/dosbox.conf With this, DOS programs loaded via wine will respect the options that the user has set up for dosbox, or allow him a way to indicate them. In my personal case, I like to set up the aspect option by default. It works if I load the program directly with dosbox, but not when done via wine. -- Do not reply to this email, post in Bugzilla using the above URL to reply. You are receiving this mail because: You are watching all bug changes.
https://bugs.winehq.org/show_bug.cgi?id=40380 Austin English <austinenglish(a)gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |austinenglish(a)gmail.com Keywords| |download, integration -- Do not reply to this email, post in Bugzilla using the above URL to reply. You are receiving this mail because: You are watching all bug changes.
https://bugs.winehq.org/show_bug.cgi?id=40380 shankao <shankao(a)gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |shankao(a)gmail.com -- Do not reply to this email, post in Bugzilla using the above URL to reply. You are receiving this mail because: You are watching all bug changes.
https://bugs.winehq.org/show_bug.cgi?id=40380 --- Comment #1 from shankao <shankao(a)gmail.com> --- There can be an easy way to accomplish this by passing the option -userconf when launching dosbox. From dosbox's README: -userconf Start DOSBox with the users specific configuration file. Can be used together with multiple -conf parameters, but -userconf will always be loaded before them. This option has been added in dosbox 0.74, released more than 6 years ago. Patch for it: diff --git a/programs/winevdm/winevdm.c b/programs/winevdm/winevdm.c index 290ad25..1662008 100644 --- a/programs/winevdm/winevdm.c +++ b/programs/winevdm/winevdm.c @@ -195,7 +195,7 @@ static void start_dosbox( const char *appname, const char *args ) const char *args[4]; char *config_file = wine_get_unix_file_name( config ); args[0] = dosbox; - args[1] = "-conf"; + args[1] = "-userconf -conf"; args[2] = config_file; args[3] = NULL; ret = _spawnvp( _P_WAIT, args[0], args ); -- Do not reply to this email, post in Bugzilla using the above URL to reply. You are receiving this mail because: You are watching all bug changes.
https://bugs.winehq.org/show_bug.cgi?id=40380 Austin English <austinenglish(a)gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|UNCONFIRMED |NEW Ever confirmed|0 |1 Keywords| |patch --- Comment #2 from Austin English <austinenglish(a)gmail.com> --- Hi shankao, Thanks for the patch. You should submit it to wine-patches(a)winehq.org, as patches are not picked up from bugzilla. -- Do not reply to this email, post in Bugzilla using the above URL to reply. You are receiving this mail because: You are watching all bug changes.
https://bugs.winehq.org/show_bug.cgi?id=40380 --- Comment #3 from shankao <shankao(a)gmail.com> --- (In reply to Austin English from comment #2)
Hi shankao,
Thanks for the patch. You should submit it to wine-patches(a)winehq.org, as patches are not picked up from bugzilla.
Ok, I will. Thanks for the hint :) -- Do not reply to this email, post in Bugzilla using the above URL to reply. You are receiving this mail because: You are watching all bug changes.
https://bugs.winehq.org/show_bug.cgi?id=40380 super_man(a)post.com changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |super_man(a)post.com --- Comment #4 from super_man(a)post.com --- The patch needs real author full name. -- Do not reply to this email, post in Bugzilla using the above URL to reply. You are receiving this mail because: You are watching all bug changes.
https://bugs.winehq.org/show_bug.cgi?id=40380 Bruno Jesus <00cpxxx(a)gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Fixed by SHA1| |6a05abed484cdfbb75956508a58 | |37dbf58424f88 Resolution|--- |FIXED Status|NEW |RESOLVED --- Comment #5 from Bruno Jesus <00cpxxx(a)gmail.com> --- Patch commited, thanks for working on this. http://source.winehq.org/git/wine.git/?a=commit;h=6a05abed484cdfbb75956508a5... -- Do not reply to this email, post in Bugzilla using the above URL to reply. You are receiving this mail because: You are watching all bug changes.
https://bugs.winehq.org/show_bug.cgi?id=40380 Alexandre Julliard <julliard(a)winehq.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|RESOLVED |CLOSED --- Comment #6 from Alexandre Julliard <julliard(a)winehq.org> --- Closing bugs fixed in 1.9.12. -- Do not reply to this email, post in Bugzilla using the above URL to reply. You are receiving this mail because: You are watching all bug changes.
https://bugs.winehq.org/show_bug.cgi?id=40380 Michael Stefaniuc <mstefani(a)redhat.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Target Milestone|--- |1.8.x CC| |mstefani(a)redhat.com -- Do not reply to this email, post in Bugzilla using the above URL to reply. You are receiving this mail because: You are watching all bug changes.
https://bugs.winehq.org/show_bug.cgi?id=40380 Michael Stefaniuc <mstefani(a)redhat.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Target Milestone|1.8.x |--- --- Comment #7 from Michael Stefaniuc <mstefani(a)redhat.com> --- Removing 1.8.x milestone from bugs included in 1.8.4. -- Do not reply to this email, post in Bugzilla using the above URL to reply. You are receiving this mail because: You are watching all bug changes.
participants (1)
-
wine-bugs＠winehq.org