[Bug 35310] New: Destination directories are not created causing make install to fail
http://bugs.winehq.org/show_bug.cgi?id=35310 Bug ID: 35310 Summary: Destination directories are not created causing make install to fail Product: Wine Version: 1.7.10 Hardware: x86-64 OS: Mac OS X Status: UNCONFIRMED Severity: normal Priority: P2 Component: build-env Assignee: wine-bugs(a)winehq.org Reporter: wine-2013(a)ryandesign.com Classification: Unclassified Created attachment 47095 --> http://bugs.winehq.org/attachment.cgi?id=47095 MacPorts log trying to build wine 1.7.10 Destination directories are not getting created during make install, causing it to fail e.g.: install: /opt/local/var/macports/build/_Users_rschmidt_macports_dports_x11_wine-devel/wine-devel/work/destroot/opt/local/lib/wine/acledit.dll.so: No such file or directory 1.7.9 did not have this problem. It presumably relates to the change by Alexandre Julliard mentioned in the ANNOUNCE file: "makefiles: Leave it to install-sh to create destination directories." Apparently install-sh is not creating the directories. -- Do not reply to this email, post in Bugzilla using the above URL to reply. You are receiving this mail because: You are watching all bug changes.
http://bugs.winehq.org/show_bug.cgi?id=35310 Alexandre Julliard <julliard(a)winehq.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|UNCONFIRMED |RESOLVED Resolution|--- |INVALID --- Comment #1 from Alexandre Julliard <julliard(a)winehq.org> --- That's because you redefined INSTALL: INSTALL='/usr/bin/install -c' Don't do that if your /usr/bin/install doesn't create directories. -- Do not reply to this email, post in Bugzilla using the above URL to reply. You are receiving this mail because: You are watching all bug changes.
http://bugs.winehq.org/show_bug.cgi?id=35310 --- Comment #2 from Ryan Schmidt <wine-2013(a)ryandesign.com> --- MacPorts sets INSTALL='/usr/bin/install -c' automatically, for all ports, and has done so since as long as I can remember, and this apparently works fine for wine 1.7.9 and earlier and all other ports. So why is this wrong? What should we be doing instead? What solution do you suggest? -- Do not reply to this email, post in Bugzilla using the above URL to reply. You are receiving this mail because: You are watching all bug changes.
http://bugs.winehq.org/show_bug.cgi?id=35310 --- Comment #3 from Ryan Schmidt <wine-2013(a)ryandesign.com> --- Looks like it was 6 years ago that we started setting INSTALL, to avoid problems in cases where coreutils was installed: https://trac.macports.org/changeset/30216 Also, /usr/bin/install does of course create directories, if you supply the -d flag. -- Do not reply to this email, post in Bugzilla using the above URL to reply. You are receiving this mail because: You are watching all bug changes.
http://bugs.winehq.org/show_bug.cgi?id=35310 --- Comment #4 from Alexandre Julliard <julliard(a)winehq.org> --- Well, I can just disallow overriding it, but I still think it would be a better idea to let configure detect it instead of forcing it. -- Do not reply to this email, post in Bugzilla using the above URL to reply. You are receiving this mail because: You are watching all bug changes.
http://bugs.winehq.org/show_bug.cgi?id=35310 --- Comment #5 from Ryan Schmidt <wine-2013(a)ryandesign.com> --- The reason why we force INSTALL='/usr/bin/install -c' may no longer be applicable so I could look into changing MacPorts base to no longer do that. However, I don't understand why setting INSTALL to a valid install program causes a problem for wine. -- Do not reply to this email, post in Bugzilla using the above URL to reply. You are receiving this mail because: You are watching all bug changes.
http://bugs.winehq.org/show_bug.cgi?id=35310 --- Comment #6 from Ryan Schmidt <wine-2013(a)ryandesign.com> --- I see: install-sh creates intermediate directories but /usr/bin/install does not. -- Do not reply to this email, post in Bugzilla using the above URL to reply. You are receiving this mail because: You are watching all bug changes.
http://bugs.winehq.org/show_bug.cgi?id=35310 Austin English <austinenglish(a)gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|RESOLVED |CLOSED --- Comment #7 from Austin English <austinenglish(a)gmail.com> --- Closing. -- Do not reply to this email, post in Bugzilla using the above URL to reply. You are receiving this mail because: You are watching all bug changes.
participants (1)
-
wine-bugs@winehq.org