[Bug 58673] New: Kinco Dtools fails to start: err:msxml:doparse Unsupported encoding: gb2312
http://bugs.winehq.org/show_bug.cgi?id=58673 Bug ID: 58673 Summary: Kinco Dtools fails to start: err:msxml:doparse Unsupported encoding: gb2312 Product: Wine Version: 10.14 Hardware: x86-64 URL: https://en.kinco.cn/download/download.html OS: Linux Status: NEW Keywords: download Severity: normal Priority: P2 Component: msxml3 Assignee: wine-bugs(a)winehq.org Reporter: xerox.xerox2000x(a)gmail.com Distribution: Debian This was program reported on the forum: https://forum.winehq.org/viewtopic.php?t=41565 It needs mfc42.dll and mfc140u.dll (via winetricks vcrun2019) but even after that installed, it fails to start with a vague error messagebox. After multiple "Unsupported encoding: gb2312" in the console The hack below allows it to start; might be easy to solve (???) for someone familiar with msxml? diff --git a/dlls/msxml3/main.c b/dlls/msxml3/main.c index 16e0b38b185..733a707cd31 100644 --- a/dlls/msxml3/main.c +++ b/dlls/msxml3/main.c @@ -322,6 +322,7 @@ static void init_char_encoders(void) } encoder[] = { { "gbk", gbk_to_utf8, utf8_to_gbk }, + { "gb2312", gbk_to_utf8, utf8_to_gbk }, { "iso8859-1", iso8859_1_to_utf8, utf8_to_iso8859_1 }, { "windows-1250", win1250_to_utf8, utf8_to_win1250 }, { "windows-1251", win1251_to_utf8, utf8_to_win1251 }, -- Do not reply to this email, post in Bugzilla using the above URL to reply. You are receiving this mail because: You are watching all bug changes.
http://bugs.winehq.org/show_bug.cgi?id=58673 --- Comment #1 from Dmitry Timoshkov <dmitry(a)baikal.ru> --- According to https://en.wikipedia.org/wiki/GBK_(character_encoding) "GBK is an extension of the GB 2312 character set", so your patch looks reasonable. -- Do not reply to this email, post in Bugzilla using the above URL to reply. You are receiving this mail because: You are watching all bug changes.
http://bugs.winehq.org/show_bug.cgi?id=58673 --- Comment #2 from Louis Lenders <xerox.xerox2000x(a)gmail.com> --- Dmitry, thank for the reply,
"GBK is an extension of the GB 2312 character set", so your patch looks reasonable.
Ok, but as I'm really unfamiliar with msxml and I gues this needs a test (?), could someone else pick this up? -- Do not reply to this email, post in Bugzilla using the above URL to reply. You are receiving this mail because: You are watching all bug changes.
http://bugs.winehq.org/show_bug.cgi?id=58673 --- Comment #3 from Dmitry Timoshkov <dmitry(a)baikal.ru> --- (In reply to Louis Lenders from comment #2)
Dmitry, thank for the reply,
"GBK is an extension of the GB 2312 character set", so your patch looks reasonable.
Ok, but as I'm really unfamiliar with msxml and I gues this needs a test (?), could someone else pick this up?
It's OK to send this patch without a test. The patch looks good to me. -- Do not reply to this email, post in Bugzilla using the above URL to reply. You are receiving this mail because: You are watching all bug changes.
http://bugs.winehq.org/show_bug.cgi?id=58673 Louis Lenders <xerox.xerox2000x(a)gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Keywords| |patch CC| |leslie_alistair(a)hotmail.com | |, z.figura12(a)gmail.com --- Comment #4 from Louis Lenders <xerox.xerox2000x(a)gmail.com> --- So it appeared there was already a merge request for this here: https://gitlab.winehq.org/wine/wine/-/merge_requests/3928 As this merge request has been hanging there for almost 2 years, and it seems quite ok, here's a request to include this in Staging: @Staging-guys: Could you please include the patch in Staging? (https://gitlab.winehq.org/wine/wine/-/merge_requests/3928) -- Do not reply to this email, post in Bugzilla using the above URL to reply. You are receiving this mail because: You are watching all bug changes.
http://bugs.winehq.org/show_bug.cgi?id=58673 Louis Lenders <xerox.xerox2000x(a)gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |STAGED Staged patchset| |https://github.com/wine-sta | |ging/wine-staging/tree/mast | |er/patches/msxml3_encode_gb | |2312 --- Comment #5 from Louis Lenders <xerox.xerox2000x(a)gmail.com> --- Staged now, thanks Alistair. -- Do not reply to this email, post in Bugzilla using the above URL to reply. You are receiving this mail because: You are watching all bug changes.
participants (1)
-
WineHQ Bugzilla