[Bug 51784] New: The dinput8:hid output is too big in Wine
https://bugs.winehq.org/show_bug.cgi?id=51784 Bug ID: 51784 Summary: The dinput8:hid output is too big in Wine Product: Wine Version: unspecified Hardware: x86-64 OS: Linux Status: NEW Severity: normal Priority: P2 Component: directx-dinput Assignee: wine-bugs(a)winehq.org Reporter: fgouget(a)codeweavers.com Distribution: --- dinput8:hid outputs ~26kB of data. This is too much and contributes in pushing the WineTest reports above the 1.5MB limit. The traces break down as follows: 0kB failures 25kB todos 0kB traces 0kB test framework (summary lines, etc.) Time to fix Wine to reduce the number of todos! -- Do not reply to this email, post in Bugzilla using the above URL to reply. You are receiving this mail because: You are watching all bug changes.
https://bugs.winehq.org/show_bug.cgi?id=51784 François Gouget <fgouget(a)codeweavers.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Keywords| |source, testcase -- Do not reply to this email, post in Bugzilla using the above URL to reply. You are receiving this mail because: You are watching all bug changes.
https://bugs.winehq.org/show_bug.cgi?id=51784 Rémi Bernon <rbernon(a)codeweavers.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |rbernon(a)codeweavers.com --- Comment #1 from Rémi Bernon <rbernon(a)codeweavers.com> --- And it's not going to get better ;) Well, I definitely intend to reduce it but it'll still take quite a bit of time and I'm probably going to struggle with the 32k limit already as I've got a lot of additional tests to send. To be honest, what's taking the most is the "Test succeeded inside todo block" prefix on all these lines! -- Do not reply to this email, post in Bugzilla using the above URL to reply. You are receiving this mail because: You are watching all bug changes.
https://bugs.winehq.org/show_bug.cgi?id=51784 --- Comment #2 from François Gouget <fgouget(a)codeweavers.com> --- I guess you mean ": Test marked todo: ". Otherwise you're almost there ;-) The breakdown on the report I have here (job 98459-win32) is: $ grep "Test marked todo: " dinput8-hid.txt | wc -c 25358 $ grep "Test marked todo: " dinput8-hid.txt | wc -l 331 $ echo -n "Test marked todo: " | wc -c 18 $ expr 331 \* 18 5958 $ sed -e 's/Test marked todo: .*$/Test marked todo: /' -e t -e d dinput8-hid.txt | wc -c 10433 So 4475 bytes (18%) for the filename + line number, 5958 bytes (23%) for "Test marked todo", 10433 bytes combined (41%) and 14925 bytes (59%) for the remainder of the line. Short of using abbreviations or just "Todo: " (*) I don't think we can gain much. (*) But that's not as clear, inconsistent with the other messages and increases the risk of false positives when parsing the report. -- Do not reply to this email, post in Bugzilla using the above URL to reply. You are receiving this mail because: You are watching all bug changes.
https://bugs.winehq.org/show_bug.cgi?id=51784 --- Comment #3 from Rémi Bernon <rbernon(a)codeweavers.com> --- Is this still the case? I think it's been shrinked a lot. -- Do not reply to this email, post in Bugzilla using the above URL to reply. You are receiving this mail because: You are watching all bug changes.
https://bugs.winehq.org/show_bug.cgi?id=51784 François Gouget <fgouget(a)codeweavers.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |RESOLVED Resolution|--- |FIXED --- Comment #4 from François Gouget <fgouget(a)codeweavers.com> --- Yes it looks good nowadays. Marking resolved. -- Do not reply to this email, post in Bugzilla using the above URL to reply. You are receiving this mail because: You are watching all bug changes.
https://bugs.winehq.org/show_bug.cgi?id=51784 Alexandre Julliard <julliard(a)winehq.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|RESOLVED |CLOSED --- Comment #5 from Alexandre Julliard <julliard(a)winehq.org> --- Closing bugs fixed in 8.1. -- Do not reply to this email, post in Bugzilla using the above URL to reply. You are receiving this mail because: You are watching all bug changes.
participants (1)
-
WineHQ Bugzilla